Re: [PATCH v4 1/2] staging: iio: ad7780: update voltage on read

2018-11-06 Thread Ardelean, Alexandru
On Mon, 2018-11-05 at 17:14 -0200, Renato Lui Geh wrote: > The ad7780 driver previously did not read the correct device output, as > it read an outdated value set at initialization. It now updates its > voltage on read. > Looks good from my side. Alex > Signed-off-by: Renato Lui Geh > --- > Ch

[PATCH] davinci_vpfe: add a missing break

2018-11-06 Thread Mauro Carvalho Chehab
As warned by gcc: drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: In function 'ipipeif_hw_setup': drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:298:3: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (isif_port_if) { ^~ drivers/staging/media/davinci_vp

Re: [PATCH] davinci_vpfe: add a missing break

2018-11-06 Thread Hans Verkuil
On 11/06/18 11:15, Mauro Carvalho Chehab wrote: > As warned by gcc: > > drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: In function > 'ipipeif_hw_setup': > drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:298:3: warning: this > statement may fall through [-Wimplicit-fallthrough=] >swit

[PATCH] media: dm365_ipipeif: better annotate a fall though

2018-11-06 Thread Mauro Carvalho Chehab
Shut up this warning: drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: In function 'ipipeif_hw_setup': drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:298:3: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (isif_port_if) { ^~~

Re: [PATCH v4 2/2] staging: iio: ad7780: remove unnecessary stashed voltage value

2018-11-06 Thread Ardelean, Alexandru
On Mon, 2018-11-05 at 17:16 -0200, Renato Lui Geh wrote: > This patch removes the unnecessary field int_vref_mv in ad7780_state > referring to the device's voltage. > Looks good from my side. Alex > Signed-off-by: Renato Lui Geh > --- > Changes in v3: > - removed unnecessary int_vref_mv

[PATCH] cedrus: check if kzalloc() fails

2018-11-06 Thread Mauro Carvalho Chehab
As warned by static code analizer checkers: drivers/staging/media/sunxi/cedrus/cedrus.c: drivers/staging/media/sunxi/cedrus/cedrus.c:93 cedrus_init_ctrls() error: potential null dereference 'ctx->ctrls'. (kzalloc returns null) The problem is that it assumes that kzalloc() will always su

[PATCH] media: platform: fix platform_no_drv_owner.cocci warnings

2018-11-06 Thread kbuild test robot
From: kbuild test robot drivers/staging/media/sunxi/cedrus/cedrus.c:421:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Fixes: 50e761516f2b ("media: platfor

Re: [PATCH] media: dm365_ipipeif: better annotate a fall though

2018-11-06 Thread Hans Verkuil
On 11/06/18 11:55, Mauro Carvalho Chehab wrote: > Shut up this warning: > > drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: In function > 'ipipeif_hw_setup': > drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:298:3: warning: this > statement may fall through [-Wimplicit-fallthr

Re: [PATCH] cedrus: check if kzalloc() fails

2018-11-06 Thread Maxime Ripard
On Tue, Nov 06, 2018 at 06:21:29AM -0500, Mauro Carvalho Chehab wrote: > As warned by static code analizer checkers: > drivers/staging/media/sunxi/cedrus/cedrus.c: > drivers/staging/media/sunxi/cedrus/cedrus.c:93 cedrus_init_ctrls() error: > potential null dereference 'ctx->ctrls'. (kzallo

Re: [PATCH] media: platform: fix platform_no_drv_owner.cocci warnings

2018-11-06 Thread Maxime Ripard
On Tue, Nov 06, 2018 at 07:33:19PM +0800, kbuild test robot wrote: > From: kbuild test robot > > drivers/staging/media/sunxi/cedrus/cedrus.c:421:3-8: No need to set .owner > here. The core will do it. > > Remove .owner field if calls are used which set it automatically > > Generated by: scrip

Re: [PATCH] staging: Remove the mt29f_spinand driver

2018-11-06 Thread Miquel Raynal
Hi Greg, Greg Kroah-Hartman wrote on Mon, 5 Nov 2018 15:34:33 +0100: > On Mon, Nov 05, 2018 at 03:27:34PM +0100, Miquel Raynal wrote: > > Hi Greg, > > > > Greg Kroah-Hartman wrote on Mon, 5 Nov > > 2018 14:29:49 +0100: > > > > > On Mon, Nov 05, 2018 at 11:12:27AM +0100, Miquel Raynal wrote:

[PATCH] x86/hyper-v: fix a commit description style in the comments

2018-11-06 Thread Peng Hao
From: Peng Hao Use commit description style 'commit <12+ chars of sha1> ("")'. Signed-off-by: Peng Hao --- arch/x86/include/asm/mshyperv.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h index f377044..b5

Re: [PATCH RFC 09/18] staging: vchiq_core: do not initialize semaphores twice

2018-11-06 Thread Nicolas Saenz Julienne
Hi Stefan, thanks for spending the time reviewing the code. I took note of the rest of comments. On Sun, 2018-10-28 at 21:45 +0100, Stefan Wahren wrote: > Hi Nicolas, > > > Nicolas Saenz Julienne hat am 26. Oktober > > 2018 um 15:48 geschrieben: > > > > > > vchiq_init_state() initialises a ser

Re: [PATCH RFC 09/18] staging: vchiq_core: do not initialize semaphores twice

2018-11-06 Thread Stefan Wahren
Am 06.11.18 um 16:41 schrieb Nicolas Saenz Julienne: > Hi Stefan, > thanks for spending the time reviewing the code. I took note of the > rest of comments. > > On Sun, 2018-10-28 at 21:45 +0100, Stefan Wahren wrote: >> Hi Nicolas, >> >>> Nicolas Saenz Julienne hat am 26. Oktober >>> 2018 um 15:48

Re: [PATCH v3 0/4] Improve VCHIQ cache line size handling

2018-11-06 Thread Stefan Wahren
> Phil Elwell hat am 17. September 2018 um 20:01 > geschrieben: > > > On 17/09/2018 18:51, Florian Fainelli wrote: > > On 09/17/2018 04:47 AM, Phil Elwell wrote: > >> Hi Stefan, > >> > >> On 17/09/2018 12:39, Stefan Wahren wrote: > >>> Hi Phil, > >>> > >>> Am 17.09.2018 um 10:22 schrieb Phil El

Re: [PATCH RFC 09/18] staging: vchiq_core: do not initialize semaphores twice

2018-11-06 Thread Nicolas Saenz Julienne
On Tue, 2018-11-06 at 17:06 +0100, Stefan Wahren wrote: > Am 06.11.18 um 16:41 schrieb Nicolas Saenz Julienne: > > Hi Stefan, > > thanks for spending the time reviewing the code. I took note of the > > rest of comments. > > > > On Sun, 2018-10-28 at 21:45 +0100, Stefan Wahren wrote: > > > Hi Nicol

PERSONAL FROM AFGHANISTAN

2018-11-06 Thread Mr. X
Dear Friend I am sorry to encroach into your privacy in this manner.My name is Scott Metz an American soldier serving in the Military with the 25th Brigade Support Battalion, 1st Stryker Brigade Combat Team, 25th Infantry Division in Afghanistan.My reason for contacting you is that we mana

Re: [alsa-devel] [PATCH v2] staging: bcm2835-audio: interpolate audio delay

2018-11-06 Thread Mike Brady
> On 5 Nov 2018, at 16:11, Takashi Iwai wrote: > > On Mon, 05 Nov 2018 16:57:07 +0100, > Mike Brady wrote: >> >>> One another thing I'd like to point out is that the value given in the >>> patch is nothing but an estimated position, optimistically calculated >>> via the system timer. Mike and

Re: [RFC PATCH v2] android: ion: How to properly clean caches for uncached allocations

2018-11-06 Thread Liam Mark
On Fri, 2 Nov 2018, John Stultz wrote: > On Thu, Nov 1, 2018 at 3:15 PM, Liam Mark wrote: > > Based on the suggestions from Laura I created a first draft for a change > > which will attempt to ensure that uncached mappings are only applied to > > ION memory who's cache lines have been cleaned. >

Re: [alsa-devel] [PATCH v2] staging: bcm2835-audio: interpolate audio delay

2018-11-06 Thread Takashi Iwai
On Tue, 06 Nov 2018 22:05:11 +0100, Mike Brady wrote: > > > > On 5 Nov 2018, at 16:11, Takashi Iwai wrote: > > > > On Mon, 05 Nov 2018 16:57:07 +0100, > > Mike Brady wrote: > >> > >>> One another thing I'd like to point out is that the value given in the > >>> patch is nothing but an estimated

[PATCH] staging: rtl8723bs: Correct errors from checkpatch

2018-11-06 Thread Josenivaldo Benito Jr
Correct following errors reported by checkpath.pl: ERROR: space required before the open parenthesis '(' #265: FILE: drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c:265: +   if(!precvframe) ')' Also similar errors on line 274 and 283. Signed-off-by: Josenivaldo Benito Jr ---

[PATCH] binder: fix race that allows malicious free of live buffer

2018-11-06 Thread Todd Kjos
Malicious code can attempt to free buffers using the BC_FREE_BUFFER ioctl to binder. There are protections against a user freeing a buffer while in use by the kernel, however there was a window where BC_FREE_BUFFER could be used to free a recently allocated buffer that was not completely initialize

Re: [PATCH V2] binder: ipc namespace support for android binder

2018-11-06 Thread Andrew Morton
On Mon, 29 Oct 2018 06:18:11 + chouryzhou(周威) wrote: > We are working for running android in container, but we found that binder is > not isolated by ipc namespace. Since binder is a form of IPC and therefore > should > be tied to ipc namespace. With this patch, we can run more than one a

[PATCH] Staging: vchi: Add license id and change int type

2018-11-06 Thread andrealmeid
From: André Almeida Fix the following checkpatch issues: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 CHECK: Prefer kernel type 's32' over 'int32_t' Signed-off-by: André Almeida --- Hello! This is my first patch to Linux Kernel. Let me know any feedback --- drivers/st

[PATCH] binder: fix sparse warnings on locking context

2018-11-06 Thread Todd Kjos
Add __acquire()/__release() annnotations to fix warnings in sparse context checking There is one case where the warning was due to a lack of a "default:" case in a switch statement where a lock was being released in each of the cases, so the default case was added. Signed-off-by: Todd Kjos ---

[PATCH] staging: sm750fb: Add spaces around '+'

2018-11-06 Thread Laís Pessine do Carmo
Add spaces around '+' to correct the following checkpath.pl warnings: WARNING: line over 80 characters + write_dpPort(accel, *(unsigned int *)(pSrcbuf + (j * 4))); WARNING: line over 80 characters + memcpy(ajRemain, pSrcbuf+ul4BytesPerScan, ulBytesRemai

[PATCH] staging: mt7621-mmc: Add blank line after declaration

2018-11-06 Thread nicolas
From: Nícolas F. R. A. Prado Correct the following warning from checkpatch.pl: WARNING: Missing a blank line after declarations + struct msdc_host *host = mmc_priv(mmc); + msdc_pm(state, (void *)host); Signed-off-by: Nícolas F. R. A. Prado --- Hi, this is my first

RE: [PATCH V2] binder: ipc namespace support for android binder

2018-11-06 Thread 周威
> -Original Message- > From: Andrew Morton > Sent: Wednesday, November 7, 2018 8:07 AM > To: chouryzhou(周威) > Cc: gre...@linuxfoundation.org; a...@android.com; tk...@android.com; > d...@stgolabs.net; de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH V2] binder

[PATCH] media: staging: tegra-vde: Change from __attribute to __packed.

2018-11-06 Thread rafaelgoncalves
From: Rafael Goncalves Correct the following warnings from checkpatch.pl: WARNING: __packed is preferred over __attribute__((packed)) +} __attribute__((packed)); WARNING: __packed is preferred over __attribute__((packed)) +} __attribute__((packed)); Signed-off-by: Rafael Goncalves --- Hi. I

[PATCH v3] driver-staging: vsoc.c: Add sysfs support for examining the permissions of regions.

2018-11-06 Thread Jerry Lin
Add a attribute called permissions under vsoc device node for examining current granted permissions in vsoc_device. This file will display permissions in following format: begin_offset end_offset owner_offset owned_value %x %x%x %x Signed-off-by: Je

[PATCH] staging: rtl8723bs: Fix incorrect sense of ether_addr_equal

2018-11-06 Thread Larry Finger
In commit b37f9e1c3801 ("staging: rtl8723bs: Fix lines too long in update_recvframe_attrib()."), the refactoring involved replacing two memcmp() calls with ether_addr_equal() calls. What the author missed is that memcmp() returns false when the two strings are equal, whereas ether_addr_equal() retu

[PATCH v2] staging: wilc1000: update wilc1000 driver maintainer ids

2018-11-06 Thread Ajay.Kathat
From: Ajay Singh We would like to update the maintainer email id's for wilc1000 driver. Signed-off-by: Aditya Shankar Signed-off-by: Ganesh Krishna Signed-off-by: Adham Abozaeid Signed-off-by: Ajay Singh --- Changes in v2: - added sob of current wilc1000 maintainers --- MAINTAINERS