Re: [PATCH v2 2/3] media: imx7-media-csi: add i.MX6UL support

Hi Rui, thanks for the review! On 6/10/19 12:28 PM, Rui Miguel Silva wrote: > Hi Sebastien, > Thanks for the patch. > > On Thu 06 Jun 2019 at 16:38, Sébastien Szymanski wrote: >> i.MX7 and i.MX6UL/L have the same CSI controller. So add i.MX6UL/L support >> to imx7-media-csi driver. >> >> Signed-

Re: [GIT PULL net-next, resend] isdn: deprecate non-mISDN drivers

Hi Arnd, I'm a long time ISDN user and I cannot fully agree to the assessment of current ISDN usage. It is of course true that ISDN is no longer a main protocol for telephone connections and therefore the number of users has dropped. But still there are people with public ISDN telephone links,

Re: [PATCH v2 2/3] media: imx7-media-csi: add i.MX6UL support

Hi Sebastien, On Tue 11 Jun 2019 at 09:16, Sébastien Szymanski wrote: > Hi Rui, > > thanks for the review! > > On 6/10/19 12:28 PM, Rui Miguel Silva wrote: >> Hi Sebastien, >> Thanks for the patch. >> >> On Thu 06 Jun 2019 at 16:38, Sébastien Szymanski wrote: >>> i.MX7 and i.MX6UL/L have the same C

Re: [PATCH v2 2/3] media: imx7-media-csi: add i.MX6UL support

On 6/11/19 11:40 AM, Rui Miguel Silva wrote: > Hi Sebastien, > On Tue 11 Jun 2019 at 09:16, Sébastien Szymanski wrote: >> Hi Rui, >> >> thanks for the review! >> >> On 6/10/19 12:28 PM, Rui Miguel Silva wrote: >>> Hi Sebastien, >>> Thanks for the patch. >>> >>> On Thu 06 Jun 2019 at 16:38, Sébastie

Re: [PATCH v2 2/3] media: imx7-media-csi: add i.MX6UL support

Hi Sebastien, On Tue 11 Jun 2019 at 11:03, Sébastien Szymanski wrote: > On 6/11/19 11:40 AM, Rui Miguel Silva wrote: >> Hi Sebastien, >> On Tue 11 Jun 2019 at 09:16, Sébastien Szymanski wrote: >>> Hi Rui, >>> >>> thanks for the review! >>> >>> On 6/10/19 12:28 PM, Rui Miguel Silva wrote: Hi Se

[PATCH -next] Staging: kpc2000: kpc_dma: Make some symbols static

Fix sparse warnings: drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c:46:6: warning: symbol 'kpc_dma_del_device' was not declared. Should it be static? drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c:84:1: warning: symbol 'dev_attr_engine_regs' was not declared. Should it be static? drivers/sta

RE: [PATCH v2] staging: kpc2000: kpc_i2c: remove the macros inb_p and outb_p

>-Original Message- >From: devel On Behalf Of >Geordan Neukum > >This inb() call looks like a bug. We perform a 64-bit operation when >talking to this hardware register everywhere else in this driver. Anyone >have more insight into the hardware with which this driver interacts >such that t

[PATCH] media: imx7-media-csi: get csi upstream endpoint

When the upstream endpoint is neither a mux nor a CSI2 module, just get the source pad directly upstream from the CSI. Fixes: 05f634040c0d ("media: staging/imx7: add imx7 CSI subdev driver") Reported-by: Sebastien Szymanski Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/imx7-medi

[PATCH 1/3] staging: rtl8723bs: hal: sdio_ops: fix Comparison to NULL

this patch fixes below warning reported by checkpatch CHECK: Comparison to NULL could be written "c2h_evt" Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b

[PATCH 2/3] staging: rtl8723bs: hal: sdio_ops: fix spaces preferred around unary operator

CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 12 ++--

[PATCH 3/3] staging: rtl8723bs: hal: sdio_ops: fix braces {} are not necessary for single statement blocks

This patch fixes below issue reported by checkpatch WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/staging

[PATCH] staging: rtl8723bs: hal: Change return type to void from u8

The function HalQueryTxOQTBufferStatus8723BSdio always returns true and caller functions are not bother about return status. Change return type to void. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 3 +-- drivers/staging/rtl8723bs/include/sdio_ops.h | 2 +-

[PATCH 6/6] staging: kpc2000: updated TODO in light of DMA AIO fixes.

The DMA AIO file-ops now work, so remove that item from the to-do list. Cc: Matt Sickler Signed-off-by: Jeremy Sowden --- drivers/staging/kpc2000/TODO | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/kpc2000/TODO b/drivers/staging/kpc2000/TODO index 47530e2

[PATCH 3/6] staging: kpc2000_dma: formatting fixes for AIO functions.

Fixed some lines which were more than 80-characters long. Cc: Matt Sickler Signed-off-by: Jeremy Sowden --- drivers/staging/kpc2000/kpc_dma/fileops.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c b/drivers/s

[PATCH 0/6] staging: kpc2000_dma: fixes for AIO file-ops.

I've had a go at getting the DMA AIO working. It compiles, but I don't have access to the hardware, so I have done no more testing than that. The fifth patch removes the cancel call-back because it is empty and so doesn't serve any purpose (AFAICS). However, it doesn't appear to be too tricky to

[PATCH 5/6] staging: kpc2000_dma: removed aio cancel call-back.

The AIO cancel call-back doesn't do anything. Removed it. Cc: Matt Sickler Signed-off-by: Jeremy Sowden --- drivers/staging/kpc2000/kpc_dma/fileops.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c b/drivers/staging/kpc2000/kpc_dma/

[PATCH 2/6] staging: kpc2000_dma: removed casts of void pointers.

The AIO call-backs assigned void pointers to local variables and used superfluous casts in the process. Removed the casts. Cc: Matt Sickler Signed-off-by: Jeremy Sowden --- drivers/staging/kpc2000/kpc_dma/fileops.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drive

[PATCH 4/6] staging: kpc2000_dma: replaced aio_(read|write) file-ops with (read|write)_iter ones.

The AIO API was implemented in terms of obsolete file-ops. Replaced the ->aio_read and ->aio_write call-backs with ->read_iter and ->write_iter ones. Replaced the call to aio_complete with a call to the ki_complete call-back of the kiocb object. Cc: Matt Sickler Signed-off-by: Jeremy Sowden --

[PATCH 1/6] staging: kpc2000_dma: added Kconfig to enable asynchronous I/O.

The DMA driver has call-backs for doing asynchronous I/O which are protected by a CONFIG_ macro which is not defined. Added a Kconfig stanza to define it. Cc: Matt Sickler Signed-off-by: Jeremy Sowden --- drivers/staging/kpc2000/Kconfig | 8 drivers/staging/kpc2000/kpc_dma/f

[PATCH] x86/hyperv: Disable preemption while setting reenlightenment vector

KVM support may be compiled as dynamic module, which triggers the following splat on modprobe: KVM: vmx: using Hyper-V Enlightened VMCS BUG: using smp_processor_id() in preemptible [] code: modprobe/466 caller is debug_smp_processor_id+0x17/0x19 CPU: 0 PID: 466 Comm: modprobe Kdump: lo

RE: [PATCH 4/6] staging: kpc2000_dma: replaced aio_(read|write) file-ops with (read|write)_iter ones.

>-Original Message- >From: Jeremy Sowden > >The AIO API was implemented in terms of obsolete file-ops. Replaced the >->aio_read and ->aio_write call-backs with ->read_iter and ->write_iter >ones. Replaced the call to aio_complete with a call to the ki_complete >call-back of the kiocb ob

RE: [PATCH 0/6] staging: kpc2000_dma: fixes for AIO file-ops.

>-Original Message- >From: Jeremy Sowden >I've had a go at getting the DMA AIO working. It compiles, but I don't >have access to the hardware, so I have done no more testing than that. Honestly, it'd probably be better to just remove the AIO support entirely. The one use case we had tha

[PATCH 2/2] staging: rtl8723bs: hal: sdio_halinit: fix spaces preferred around that unary operator

CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '<<' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 92 ++-- 1 file changed, 46 insertions

[PATCH 1/2] staging: rtl8723bs: hal: sdio_halinit: fix comparison to true/false is error prone

CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_

[PATCH] staging: rtl8188eu: Change type of rtw_get_sec_ie()

Change return type of function rtw_get_sec_ie from int to void and remove its return statement as the return value is never stored, checked or otherwise used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 +--- drivers/staging/rtl8188eu/include/ieee80211.h