Hi Rui,
thanks for the review!
On 6/10/19 12:28 PM, Rui Miguel Silva wrote:
> Hi Sebastien,
> Thanks for the patch.
>
> On Thu 06 Jun 2019 at 16:38, Sébastien Szymanski wrote:
>> i.MX7 and i.MX6UL/L have the same CSI controller. So add i.MX6UL/L support
>> to imx7-media-csi driver.
>>
>> Signed-
Hi Arnd,
I'm a long time ISDN user and I cannot fully agree to the assessment of current
ISDN usage. It is of course true that ISDN is no longer a main protocol for
telephone connections and therefore the number of users has dropped. But still
there are people with public ISDN telephone links,
Hi Sebastien,
On Tue 11 Jun 2019 at 09:16, Sébastien Szymanski wrote:
> Hi Rui,
>
> thanks for the review!
>
> On 6/10/19 12:28 PM, Rui Miguel Silva wrote:
>> Hi Sebastien,
>> Thanks for the patch.
>>
>> On Thu 06 Jun 2019 at 16:38, Sébastien Szymanski wrote:
>>> i.MX7 and i.MX6UL/L have the same C
On 6/11/19 11:40 AM, Rui Miguel Silva wrote:
> Hi Sebastien,
> On Tue 11 Jun 2019 at 09:16, Sébastien Szymanski wrote:
>> Hi Rui,
>>
>> thanks for the review!
>>
>> On 6/10/19 12:28 PM, Rui Miguel Silva wrote:
>>> Hi Sebastien,
>>> Thanks for the patch.
>>>
>>> On Thu 06 Jun 2019 at 16:38, Sébastie
Hi Sebastien,
On Tue 11 Jun 2019 at 11:03, Sébastien Szymanski wrote:
> On 6/11/19 11:40 AM, Rui Miguel Silva wrote:
>> Hi Sebastien,
>> On Tue 11 Jun 2019 at 09:16, Sébastien Szymanski wrote:
>>> Hi Rui,
>>>
>>> thanks for the review!
>>>
>>> On 6/10/19 12:28 PM, Rui Miguel Silva wrote:
Hi Se
Fix sparse warnings:
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c:46:6: warning: symbol
'kpc_dma_del_device' was not declared. Should it be static?
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c:84:1: warning: symbol
'dev_attr_engine_regs' was not declared. Should it be static?
drivers/sta
>-Original Message-
>From: devel On Behalf Of
>Geordan Neukum
>
>This inb() call looks like a bug. We perform a 64-bit operation when
>talking to this hardware register everywhere else in this driver. Anyone
>have more insight into the hardware with which this driver interacts
>such that t
When the upstream endpoint is neither a mux nor a CSI2 module, just get
the source pad directly upstream from the CSI.
Fixes: 05f634040c0d ("media: staging/imx7: add imx7 CSI subdev driver")
Reported-by: Sebastien Szymanski
Signed-off-by: Rui Miguel Silva
---
drivers/staging/media/imx/imx7-medi
this patch fixes below warning reported by checkpatch
CHECK: Comparison to NULL could be written "c2h_evt"
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c
b
CHECK: spaces preferred around that '+' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 12 ++--
This patch fixes below issue reported by checkpatch
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/staging
The function HalQueryTxOQTBufferStatus8723BSdio always returns true and
caller functions are not bother about return status.
Change return type to void.
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 3 +--
drivers/staging/rtl8723bs/include/sdio_ops.h | 2 +-
The DMA AIO file-ops now work, so remove that item from the to-do list.
Cc: Matt Sickler
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/TODO | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/kpc2000/TODO b/drivers/staging/kpc2000/TODO
index 47530e2
Fixed some lines which were more than 80-characters long.
Cc: Matt Sickler
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/kpc_dma/fileops.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c
b/drivers/s
I've had a go at getting the DMA AIO working. It compiles, but I don't
have access to the hardware, so I have done no more testing than that.
The fifth patch removes the cancel call-back because it is empty and so
doesn't serve any purpose (AFAICS). However, it doesn't appear to be
too tricky to
The AIO cancel call-back doesn't do anything. Removed it.
Cc: Matt Sickler
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/kpc_dma/fileops.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c
b/drivers/staging/kpc2000/kpc_dma/
The AIO call-backs assigned void pointers to local variables and used
superfluous casts in the process. Removed the casts.
Cc: Matt Sickler
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/kpc_dma/fileops.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drive
The AIO API was implemented in terms of obsolete file-ops. Replaced the
->aio_read and ->aio_write call-backs with ->read_iter and ->write_iter
ones. Replaced the call to aio_complete with a call to the ki_complete
call-back of the kiocb object.
Cc: Matt Sickler
Signed-off-by: Jeremy Sowden
--
The DMA driver has call-backs for doing asynchronous I/O which are
protected by a CONFIG_ macro which is not defined. Added a Kconfig
stanza to define it.
Cc: Matt Sickler
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/Kconfig | 8
drivers/staging/kpc2000/kpc_dma/f
KVM support may be compiled as dynamic module, which triggers the
following splat on modprobe:
KVM: vmx: using Hyper-V Enlightened VMCS
BUG: using smp_processor_id() in preemptible [] code: modprobe/466
caller is debug_smp_processor_id+0x17/0x19
CPU: 0 PID: 466 Comm: modprobe Kdump: lo
>-Original Message-
>From: Jeremy Sowden
>
>The AIO API was implemented in terms of obsolete file-ops. Replaced the
>->aio_read and ->aio_write call-backs with ->read_iter and ->write_iter
>ones. Replaced the call to aio_complete with a call to the ki_complete
>call-back of the kiocb ob
>-Original Message-
>From: Jeremy Sowden
>I've had a go at getting the DMA AIO working. It compiles, but I don't
>have access to the hardware, so I have done no more testing than that.
Honestly, it'd probably be better to just remove the AIO support entirely. The
one use case we had tha
CHECK: spaces preferred around that '+' (ctx:VxV)
CHECK: spaces preferred around that '<<' (ctx:VxV)
CHECK: spaces preferred around that '|' (ctx:VxV)
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 92 ++--
1 file changed, 46 insertions
CHECK: Using comparison to false is error prone
CHECK: Using comparison to true is error prone
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_
Change return type of function rtw_get_sec_ie from int to void and
remove its return statement as the return value is never stored, checked
or otherwise used.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 +---
drivers/staging/rtl8188eu/include/ieee80211.h
25 matches
Mail list logo