[PATCH 1/3] [PATCH] staging: greybus: fix warnings about endianness detected by sparse

This patch fix the following warnings from sparse, $ make C=2 drivers/staging/greybus/ drivers/staging/greybus/audio_module.c:222:25: warning: incorrect type in assignment (different base types) drivers/staging/greybus/audio_module.c:222:25:expected restricted __le16 [usertype] data_cport dr

[PATCH 3/3] [PATCH] staging: greybus: __u8 is sufficient for snd_ctl_elem_type_t and snd_ctl_elem_iface_t

Use __8 to replace int and remove the unnecessary __bitwise type attribute. Found by sparse, $ make C=2 drivers/staging/greybus/ drivers/staging/greybus/audio_topology.c:185:24: warning: cast to restricted snd_ctl_elem_type_t drivers/staging/greybus/audio_topology.c:679:14: warning: restricted

[PATCH 2/3] staging: greybus: codecs: use SNDRV_PCM_FMTBIT_S16_LE for format bitmask

snd_soc_pcm_stream.formats should use the bitmask SNDRV_PCM_FMTBIT_* instead of the sequential integers SNDRV_PCM_FORMAT_* as explained by commit e712bfca1ac1f63f622f87c2f33b57608f2a4d19 ("ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask"). Found by sparse, $ make C=2 drivers/staging/greyb

RE: [PATCH 3/3] [PATCH] staging: greybus: __u8 is sufficient for snd_ctl_elem_type_t and snd_ctl_elem_iface_t

From: Coiby Xu > Sent: 24 September 2020 11:21 > Use __8 to replace int and remove the unnecessary __bitwise type attribute. > > Found by sparse, ... > diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h > index 535a7229e1d9..8e71a95644ab 100644 > --- a/include/uapi/sound/asound

Re: [PATCH 3/3] [PATCH] staging: greybus: __u8 is sufficient for snd_ctl_elem_type_t and snd_ctl_elem_iface_t

On Thu, Sep 24, 2020 at 06:20:39PM +0800, Coiby Xu wrote: > Use __8 to replace int and remove the unnecessary __bitwise type attribute. > > Found by sparse, > > $ make C=2 drivers/staging/greybus/ > drivers/staging/greybus/audio_topology.c:185:24: warning: cast to restricted > snd_ctl_elem_type_

Re: [greybus-dev] [PATCH 1/3] [PATCH] staging: greybus: fix warnings about endianness detected by sparse

On 9/24/20 5:20 AM, Coiby Xu wrote: > This patch fix the following warnings from sparse, You need to address Greg's comment. But in general this looks good. I have one comment below, which you can address in v2. If you (or others) disagree with it, I'm fine with your code as-is. Either way, yo

Re: [greybus-dev] [PATCH 2/3] staging: greybus: codecs: use SNDRV_PCM_FMTBIT_S16_LE for format bitmask

On 9/24/20 5:20 AM, Coiby Xu wrote: > snd_soc_pcm_stream.formats should use the bitmask SNDRV_PCM_FMTBIT_* > instead of the sequential integers SNDRV_PCM_FORMAT_* as explained by > commit e712bfca1ac1f63f622f87c2f33b57608f2a4d19 > ("ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask"). > > Fo

Re: [greybus-dev] [PATCH 3/3] [PATCH] staging: greybus: __u8 is sufficient for snd_ctl_elem_type_t and snd_ctl_elem_iface_t

On 9/24/20 5:20 AM, Coiby Xu wrote: > Use __8 to replace int and remove the unnecessary __bitwise type attribute. > > Found by sparse, Greg's right, don't change the public header. You could try this in the Greybus code to eliminate the warning, but I haven't tried it (and for all I know it's no

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

On Thu, Sep 24, 2020 at 08:48:51PM +0530, Srinivasan Raju wrote: > +PUREILIFI USB DRIVER > +M: pureLiFi Ltd I need a real person here, having aliases as maintainers results in a lack of accountability :( > --- /dev/null > +++ b/drivers/staging/purelifi/TODO > @@ -0,0 +1,5 @@ > +TODO: > + -

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

On Thu, Sep 24, 2020 at 08:48:51PM +0530, Srinivasan Raju wrote: > +++ b/drivers/staging/purelifi/chip.c > @@ -0,0 +1,184 @@ > +// SPDX-License-Identifier: GNU General Public License v2.0 or later That's not a valid SPDX identifier :) > +/* Copyright (c) 2015-2020 pureLiFi Ltd > + * All rights

[PATCH] staging: Initial driver submission for pureLiFi devices

From: Srini This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC and LiFi-XL USB devices, which provide lightweight, highspeed secure and fully networked wireless communications via light. This driver implementation has been based on the zd1211rw driver Driver is based on 802.11 softMAC

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

>> --- /dev/null >> +++ b/drivers/staging/purelifi/TODO >> @@ -0,0 +1,5 @@ >> +TODO: >> + - checkpatch.pl cleanups >> + >> +Please send any patches or complaints about this driver to pureLiFi Ltd >> + >Why not just do these fixups on your own right now and submit it to the >"real" part of th

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

On Thu, Sep 24, 2020 at 05:24:14PM +, Srinivasan Raju wrote: > > >> --- /dev/null > >> +++ b/drivers/staging/purelifi/TODO > >> @@ -0,0 +1,5 @@ > >> +TODO: > >> + - checkpatch.pl cleanups > >> + > >> +Please send any patches or complaints about this driver to pureLiFi Ltd > >> + > > >Why

Re: [PATCH RFT/RFC 37/49] staging: media: zoran: add fallthrough keyword

On Mon, Sep 21, 2020 at 01:59:45PM +0300, Dan Carpenter wrote: > On Mon, Sep 21, 2020 at 10:20:12AM +, Corentin Labbe wrote: > > This patch adds fallthrough keyword where appropriate. > > > > Signed-off-by: Corentin Labbe > > --- > > drivers/staging/media/zoran/zoran_device.c | 6 ++ > >

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

Hi, On 9/24/20 8:18 AM, Srinivasan Raju wrote: > diff --git a/drivers/staging/purelifi/Kconfig > b/drivers/staging/purelifi/Kconfig > new file mode 100644 > index ..db24bdf884a3 > --- /dev/null > +++ b/drivers/staging/purelifi/Kconfig > @@ -0,0 +1,42 @@ > +config WLAN_VENDOR_PURELIFI

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

On Thu, Sep 24, 2020 at 08:48:51PM +0530, Srinivasan Raju wrote: > + > +#include > +#include > + > +#include "def.h" > +#include "chip.h" > +#include "mac.h" > +#include "usb.h" > +#include "log.h" > + > +void purelifi_chip_init(struct purelifi_chip *chip, > + struct ieee80211