On Sunday 31 May 2015 08:58:13 Greg KH wrote:
> On Sat, May 30, 2015 at 12:09:23PM +0530, Sudip Mukherjee wrote:
> > On Fri, May 29, 2015 at 10:52:16PM +0200, Arnd Bergmann wrote:
> > > The abstraction for time in this driver is completely
> > > unused, so remove it.
hangs after
receiving a signal, as the original code did by looping around
down_interruptible.
The semaphores still need to be turned into mutexes as a
follow-up step.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Makefile | 2 +-
drivers/staging/wilc1000
I have crossed off one item on the list, but found a few others that should
not get lost, so here is an update of the wilc1000 list
Signed-off-by: Arnd Bergmann
diff --git a/drivers/staging/wilc1000/TODO b/drivers/staging/wilc1000/TODO
index 5dfeb3eda599..95199d80a3e4 100644
--- a/drivers
-off-by: Arnd Bergmann
---
Documentation/isdn/interface_capi.rst | 71
drivers/isdn/Makefile | 2 +-
drivers/isdn/capi/Kconfig | 32 +-
drivers/isdn/capi/Makefile| 18 +-
drivers/isdn/capi/capi.c | 14 +-
drivers/isdn/capi/capilib.c
%8B%D1%85_%D0%BB%D0%B8%D0%BD%D0%B8%D0%B9_Granch_SBNI12-10
Signed-off-by: Arnd Bergmann
---
.../admin-guide/kernel-parameters.txt |2 -
drivers/net/Space.c |4 -
drivers/net/wan/Kconfig | 28 -
drivers/net/wan/Makef
packages ten years earlier when they no longer built
correctly.
Signed-off-by: Arnd Bergmann
---
Documentation/networking/framerelay.txt | 39 -
MAINTAINERS |6 -
drivers/net/wan/Kconfig | 45 -
drivers/net/wan/Makefile|2 -
drivers
The dscc4 driver was recently removed, but these
Kconfig entries remain, so remove them as well.
Fixes: 28c9eb9042a9 ("net/wan: dscc4: remove broken dscc4 driver")
Signed-off-by: Arnd Bergmann
---
drivers/net/wan/Kconfig | 24
1 file changed, 24 deletions(-)
e...@syzkaller.appspotmail.com
Reported-by: syzbot+eec0c87f31a7c3b66...@syzkaller.appspotmail.com
Link:
https://syzkaller.appspot.com/bug?id=5b0ecf0386f56be7fe7210a14d0f62df765c0c39
Signed-off-by: Arnd Bergmann
If anyone has different views or additional information, let us know.
If you ag
On Mon, Dec 9, 2019 at 7:29 PM David Miller wrote:
>
> From: Arnd Bergmann
> Date: Mon, 9 Dec 2019 16:12:56 +0100
>
> > syzbot keeps finding issues in the X.25 implementation that nobody is
> > interested in fixing. Given that all the x25 patches of the past years
On Tue, Dec 10, 2019 at 9:59 AM Martin Schiller wrote:
> On 2019-12-09 20:26, Arnd Bergmann wrote:
> > On Mon, Dec 9, 2019 at 7:29 PM David Miller
> > wrote:
> >>
> >> From: Arnd Bergmann
> >> Date: Mon, 9 Dec 2019 16:12:56 +0100
> >
uot; [drivers/staging/hp/hp100.ko] undefined!
ERROR: "__netdev_alloc_skb" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "free_netdev" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "unregister_netdev" [drivers/staging/hp/hp100.ko] undefined!
Add it back explicitly.
Fixes:
On Tue, Dec 10, 2019 at 10:19 AM Greg Kroah-Hartman
wrote:
>
> On Mon, Dec 09, 2019 at 04:11:13PM +0100, Arnd Bergmann wrote:
> > As described in drivers/staging/isdn/TODO, the drivers are all
> > assumed to be unmaintained and unused now, with gigaset being the
> >
/lkml/20191108213257.3097633-1-a...@arndb.de/
Arnd Bergmann (24):
Input: input_event: fix struct padding on sparc64
fat: use prandom_u32() for i_generation
dlm: use SO_SNDTIMEO_NEW instead of SO_SNDTIMEO_OLD
xtensa: ISS: avoid struct timeval
um: ubd: use 64-bit time_t where possible
acct: stop
e of
1560 bytes is larger than 1400 bytes [-Werror=frame-larger-than=]
Use the same trick as in the rtl8723bs copy of the same function, and
allocate it dynamically.
Signed-off-by: Arnd Bergmann
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 9 ++---
1 file changed, 6 insertions(+), 3
ther variable on the stack.
Reduce the amount of inlining to get back to the previous state,
with no function using more than 200 bytes each.
Fixes: mmtom ("init/Kconfig: enable -O3 for all arches")
Signed-off-by: Arnd Bergmann
---
drivers/vme/bridges/vme_fake.c | 30 ++--
the pointer dereference in the only place
the variable is used avoids the warning in all configurations,
so we can allow compile-testing as well.
Fixes: d65dd85281fb ("media: staging: rkisp1: add Rockchip ISP1 base driver")
Signed-off-by: Arnd Bergmann
---
drivers/staging/media/phy-
On Wed, Apr 8, 2020 at 7:56 PM Ezequiel Garcia wrote:
>
> On Wed, 2020-04-08 at 17:52 +0200, Arnd Bergmann wrote:
> > When compile-testing with CONFIG_OF disabled, we get a warning
> > about an unused variable, and about inconsistent Kconfig dependencies:
> >
&
_device_id wfx_sdio_of_match[];
| ^
Move the proper declaration up and out of the #ifdef instead.
Fixes: a7a91ca5a23d ("staging: wfx: add infrastructure for new driver")
Signed-off-by: Arnd Bergmann
---
drivers/staging/wfx/bus_sdio.c | 19 +++
newline.flow_control |= GB_SERIAL_AUTO_RTSCTS_EN;
Instead of using |= and &= on the uninitialized variable, use a
direct assignment.
Fixes: e55c25206d5c ("greybus: uart: Handle CRTSCTS flag in termios")
Signed-off-by: Arnd Bergmann
---
drivers/staging/greybus/uart.c | 4 ++--
1 file changed, 2 i
On Wed, Apr 29, 2020 at 6:04 PM Jerome Pouiller
wrote:
> On Wednesday 29 April 2020 16:21:09 CEST Arnd Bergmann wrote:
> >
> > -static const struct of_device_id wfx_sdio_of_match[];
> > +static const struct of_device_id wfx_sdio_of_match[] = {
> > + { .co
On Thu, Apr 30, 2020 at 10:42 AM Jerome Pouiller
wrote:
> On Wednesday 29 April 2020 22:34:56 CEST Arnd Bergmann wrote:
> > On Wed, Apr 29, 2020 at 6:04 PM Jerome Pouiller
> > wrote:
> > > On Wednesday 29 April 2020 16:21:09 CEST Arnd Bergmann wrote:
> > &g
On Sat, Apr 8, 2017 at 5:58 PM, Deepa Dinamani wrote:
>> I have no problem merging this patch into audit/next for v4.12, would
>> you prefer me to do that so at least this patch is merged?
>
> This would be fine.
> But, I think whoever takes the last 2 deletion patches should also take them.
> I'm
tc is defined as a non-empty macro, we get the intended
behavior and no warning. Using no_printk() for printing helper functions
as the added advantage of compile-time checking format strings
Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
Signed-off-by: Arnd Bergmann
4f8e0981ef ("atomisp: remove satm kernel")
Signed-off-by: Arnd Bergmann
---
drivers/staging/media/atomisp/pci/atomisp2/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/Makefile
b/drivers/staging/media/atomisp/pci/atomisp2/Makefil
ing/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Arnd Bergmann
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c
b/drivers/stagi
annotations
for the stub handlers, and moving some variables around.
Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
Signed-off-by: Arnd Bergmann
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 ++
drivers/staging/rtl8723bs/core/rtw_debug.c| 11 +++-
wn field ‘update’
> specified in initializer
> drivers/staging/ccree/ssi_hash.c:1992: warning: excess elements in union
> initializer
> ...
>
> Add missing braces to fix this.
> After this it compiles without warnings with gcc 4.1.2 and 4.9.0.
Acked-by: Arnd Bergmann
Fo
can simply drop that argument here and in its callers.
Fixes: 302ef8ebb4b2 ("staging: ccree: add skcipher support")
Signed-off-by: Arnd Bergmann
---
drivers/staging/ccree/ssi_cipher.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ccr
ROR: "netif_carrier_on" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko]
undefined!
This adds a dependency on NETDEVICES and ETHERNET.
Fixes: 0352d1d85201 ("staging: fsl-dpaa2/eth: Add APIs for DPNI objects")
Signed-off-by: Arnd Bergmann
---
drivers/staging/fsl-dpaa2/Kconf
On Thu, May 18, 2017 at 10:45 AM, Mauro Carvalho Chehab
wrote:
> Several atomisp files use:
> ccflags-y += -Werror
>
> As, on media, our usual procedure is to use W=1, and atomisp
> has *a lot* of warnings with such flag enabled,like:
>
> ./drivers/staging/media/atomisp/pci/atomisp2/css24
:12: error:
'arche_platform_suspend' defined but not used [-Werror=unused-function]
This marks the functions as __maybe_unused to shut up the warnings.
Fixes: 2eccd4aa19fc ("staging: greybus: enable compile testing of arche driver")
Signed-off-by: Arnd Bergmann
---
drivers/staging/greybus/arc
On Thu, May 18, 2017 at 4:18 PM, Viresh Kumar wrote:
> On 18-05-17, 15:28, Arnd Bergmann wrote:
>> Enabling the arche platform for compile testing showed a harmless
>> warning with CONFIG_PM=n:
>>
>> drivers/staging/greybus/arche-platform.c:632:12: error:
>> &#
On Fri, May 19, 2017 at 5:40 AM, Viresh Kumar wrote:
> On 18-05-17, 16:51, Arnd Bergmann wrote:
>> I find that a lot of users get the #ifdef wrong, either using the wrong
>> macro (CONFIG_PM vs CONFIG_PM_SLEEP) or not using the right
>> set of functions (e.g. calling a f
avoid the
problem, since CRYPTO_HW is a bool symbol and by itself that does not
force CCREE to be a loadable module when the core cryto support is modular.
Fixes: 50cfbbb7e627 ("staging: ccree: add ahash support")
Signed-off-by: Arnd Bergmann
---
drivers/staging/ccree/Kconfig | 2 +-
1
On Thu, May 25, 2017 at 7:03 PM, kbuild test robot wrote:
>>> cc1: warning: unrecognized command line option
>>> "-Wno-suggest-attribute=format"
>>> cc1: warning: unrecognized command line option
>>> "-Wno-unused-but-set-variable"
>>> cc1: warning: unrecognized command line option "-Wno-unused-
On Thu, Jun 1, 2017 at 11:56 AM, Yan, Zheng wrote:
> On Sat, Apr 8, 2017 at 8:57 AM, Deepa Dinamani wrote:
>> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
>> index 517838b..77204da 100644
>> --- a/drivers/block/rbd.c
>> +++ b/drivers/block/rbd.c
>> @@ -1922,7 +1922,7 @@ static void rbd
On Fri, Jun 2, 2017 at 4:09 AM, Yan, Zheng wrote:
> On Fri, Jun 2, 2017 at 8:57 AM, Deepa Dinamani wrote:
>> On Thu, Jun 1, 2017 at 5:36 PM, John Stultz wrote:
>>> On Thu, Jun 1, 2017 at 5:26 PM, Yan, Zheng wrote:
>>>> On Thu, Jun 1, 2017 at 6:22 PM, Arnd Bergma
On Fri, Jun 2, 2017 at 12:10 PM, Yan, Zheng wrote:
> On Fri, Jun 2, 2017 at 5:45 PM, Arnd Bergmann wrote:
>> On Fri, Jun 2, 2017 at 4:09 AM, Yan, Zheng wrote:
>>> On Fri, Jun 2, 2017 at 8:57 AM, Deepa Dinamani
>>> wrote:
>>>> On Thu, Jun 1, 2017 at 5:
On Fri, Jun 2, 2017 at 1:18 PM, Yan, Zheng wrote:
> On Fri, Jun 2, 2017 at 6:51 PM, Arnd Bergmann wrote:
>> On Fri, Jun 2, 2017 at 12:10 PM, Yan, Zheng wrote:
>>> On Fri, Jun 2, 2017 at 5:45 PM, Arnd Bergmann wrote:
>>>> On Fri, Jun 2, 2017 at 4:09 AM, Yan, Zhe
On Fri, Jun 2, 2017 at 2:18 PM, Yan, Zheng wrote:
> On Fri, Jun 2, 2017 at 7:33 PM, Arnd Bergmann wrote:
>> On Fri, Jun 2, 2017 at 1:18 PM, Yan, Zheng wrote:
>> What I meant is another related problem in ceph_mkdir() where the
>> i_ctime field of the parent inode is
ue is only set once to the argument of alloc_netdev_mq(),
we can compare against that constant directly.
Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table")
Fixes: 2b01888d1b45 ("netvsc: allow more flexible setting of number of
channels")
Signed-off-by: Arnd B
; declared inside
parameter list
s32 wilc_init(struct net_device *dev, struct host_if_drv **phWFIDrv);
This adds a forward-declaration for the structure name to avoid
that error.
Signed-off-by: Arnd Bergmann
Fixes: d5382219138d ("staging: wilc1000: host_int_init: add argument
net_device
A number of symbols in the wilc1000 driver are completely unused
and can be removed.
This includes two variables that are only written but not read.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/host_interface.c | 295 --
drivers/staging/wilc1000
first changes over the only other user.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
b/drivers/staging/wilc1000/linux_wlan.c
index f1e70b225deb..040caa0d0d0b 100644
are also not needed here.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 84 +++
drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 83 --
2 files changed, 84 insertions(+), 83 deletions(-)
diff --git a/drivers/staging
I have rebased the patches once more on top of a lot of renames,
and would prefer not to rebase them again. This is the series of
fixups that I've posted before, now for today's staging-testing
branch.
Please apply.
Arnd Bergmann (20):
staging/wilc1000: add struct net_device d
'extern' declarations belong into a header file rather than
a .c file, to ensure that the definition matches the declaration.
This moves all declarations into a header file that seems
most appropriate for it.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/host_i
wilc_wlan_inp_t is an unnecessary indirection and requires linux_wlan.c
to have knowledge of the specific sdio and spi front-ends. This
removes the structure and places io_type directly inside the struct wilc.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 21
All symbols that are only referenced in the file that defines
them can be declared 'static' to avoid namespace pollution,
to produce better object code, and to make the source more
readable.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Makefile | 3 +
cribe the respective
hardware specifics using device tree or platform data and make
the driver handle this is a more general way.
This removes the empty stubs.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 40 ---
1 file changed, 40 dele
The driver interfaces are in linux_wlan_sdio.c and linux_wlan_spi.c, so
this is where the init and exit functions should be. Splitting this up
enables further cleanups, including eventually allowing both modules
to be built together.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000
.
All other locations that check for the interrupt method are turned
into runtime checks based on the gpio number (>=0) or the interrupt
number (>0).
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Makefile | 1 -
drivers/staging/wilc1000/linux_wlan.c
In order to avoid some of the #ifdefs, this passes the io_type
and device pointer as an argument to wilc_netdev_init.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 18 --
drivers/staging/wilc1000/linux_wlan_sdio.c| 4 ++--
drivers/staging
i_dev
variables in favor of retrieving them from the wilc_dev
variable that will eventually get passed through all functions
instead of using a global.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c| 6 +-
drivers/staging/wilc1000/linux_wlan_common.h | 12 ---
dr
wilc_create_wiphy tries to get a pointer to a device from the
global wilc_sdio_func variable. This is a layering violation
and we can use the wilc_dev->dev pointer instead.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
drivers/staging/wilc1
struct wilc has two pointers to store the device, one for sdio_func
and one for spi_device. By changing the pointer to a 'struct device',
we can simplify the logic and avoid a few #ifdefs.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c
The last remaining user of WILC_SDIO macro checks for the correct
time to wait in an interrupt for the PLL to settle. We can
replace this with a runtime check and remove both WILC_SDIO and
WILC_SPI, as we no longer need conditional compilation based on
the hardware type.
Signed-off-by: Arnd
The SPI and SDIO specific code is now separate enough that
we just need to restructure the Makefile and Kconfig logic
a bit and export a couple of symbols from the common module
to have separate bus glue drivers.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Kconfig| 66
modules.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 4 ++-
drivers/staging/wilc1000/linux_wlan_sdio.c| 3 ++-
drivers/staging/wilc1000/linux_wlan_spi.c | 2 +-
drivers/staging/wilc1000/wilc_sdio.c | 35 +--
drivers
also change arguments slightly to pass the device,
as we are already touching those lines and the change will be needed
later to remove the global variables.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 22 +-
drivers/staging/wilc1000
driver
that does not have an instance pointer at hand. Changing those
would be a follow-up step.
There are a few other globals that will have to get moved
into struct wilc at a later point.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging
y start with
wilc or a variation of that to start with wilc_ and to follow
the usual naming conventions.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/coreconfigurator.c | 10 +-
drivers/staging/wilc1000/coreconfigurator.h | 16 +-
drivers/staging/wilc1000/host_inter
On Tuesday 10 November 2015 15:47:02 Joe Perches wrote:
> On Wed, 2015-11-11 at 00:42 +0100, Arnd Bergmann wrote:
> > A recent cleanup added a reference to struct net_device, but
> > that structure is not always visible in the context of the
> > declaration, so we may get
On Tuesday 10 November 2015 16:02:48 Greg Kroah-Hartman wrote:
> On Wed, Nov 11, 2015 at 12:42:21AM +0100, Arnd Bergmann wrote:
> I think this is already fixed in my staging-testing branch, right?
Ah right. I only got it with some rare randconfig builds, and assumed
the problem was still
On Wednesday 11 November 2015 09:54:57 Andy Shevchenko wrote:
> > diff --git a/drivers/staging/wilc1000/linux_wlan_common.h
> > b/drivers/staging/wilc1000/linux_wlan_common.h
> > index f2ea8280b8f8..72b524a98cba 100644
> > --- a/drivers/staging/wilc1000/linux_wlan_common.h
> > +++ b/drivers/stagin
On Wednesday 11 November 2015 15:14:48 Mauro Carvalho Chehab wrote:
> rename include/media/{ => platform}/exynos-fimc.h (100%)
> rename include/media/{ => platform}/mmp-camera.h (100%)
> rename include/media/{ => platform}/omap1_camera.h (100%)
> rename include/media/{ => platform}/omap4iss.h (
On Thursday 12 November 2015 19:05:41 glen lee wrote:
> Hi arnd,
>
> I appreciate the patches.
> I did test this patch series on h/w which is arm based MCU.
> From this patch wilc is not working properly. After downloading firmware,
> the firmware cannot start and it fails.
> I double check this
On Friday 13 November 2015 16:49:22 glen lee wrote:
>
> Hi arnd,
>
> I found this. These should be like this. It works fine.
> + .hif_block_tx_ext = sdio_write,
> + .hif_block_rx_ext = sdio_read,
>
> also, wilc_hif_spi need to be fixed together like this.
> + .hif_block_tx_ext
On Friday 13 November 2015 17:13:41 Mauro Carvalho Chehab wrote:
> Em Wed, 11 Nov 2015 21:26:31 +0100
> Arnd Bergmann escreveu:
>
> include/media/{ => drv-intf}/cx2341x.h | 0
> include/media/{ => drv-intf}/cx25840.h | 0
> inc
On Monday 16 November 2015 09:00:45 Mauro Carvalho Chehab wrote:
> Let's not mix platform_data headers with the core headers. Instead, let's
> create a subdir at linux/platform_data and move the headers to that
> common place, adding it to MAINTAINERS.
>
Acked-by: Arnd Ber
All symbols that are only referenced in the file that defines
them can be declared 'static' to avoid namespace pollution,
to produce better object code, and to make the source more
readable.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Makefile | 3 +
first changes over the only other user.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
b/drivers/staging/wilc1000/linux_wlan.c
index f1e70b225deb..040caa0d0d0b 100644
'extern' declarations belong into a header file rather than
a .c file, to ensure that the definition matches the declaration.
This moves all declarations into a header file that seems
most appropriate for it.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/host_i
wilc_wlan_inp_t is an unnecessary indirection and requires linux_wlan.c
to have knowledge of the specific sdio and spi front-ends. This
removes the structure and places io_type directly inside the struct wilc.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 21
The SPI and SDIO specific code is now separate enough that
we just need to restructure the Makefile and Kconfig logic
a bit and export a couple of symbols from the common module
to have separate bus glue drivers.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Kconfig| 66
wilc_create_wiphy tries to get a pointer to a device from the
global wilc_sdio_func variable. This is a layering violation
and we can use the wilc_dev->dev pointer instead.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
drivers/staging/wilc1
A number of symbols in the wilc1000 driver are completely unused
and can be removed.
This includes two variables that are only written but not read.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/host_interface.c | 295 --
drivers/staging/wilc1000
are also not needed here.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 84 +++
drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 83 --
2 files changed, 84 insertions(+), 83 deletions(-)
diff --git a/drivers/staging
y start with
wilc or a variation of that to start with wilc_ and to follow
the usual naming conventions.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/coreconfigurator.c | 10 +-
drivers/staging/wilc1000/coreconfigurator.h | 16 +-
drivers/staging/wilc1000/host_inter
On Monday 16 November 2015 10:36:47 glen lee wrote:
> On 2015년 11월 13일 18:17, Arnd Bergmann wrote:
> > On Friday 13 November 2015 16:49:22 glen lee wrote:
> >> Hi arnd,
> >>
> >> I found this. These should be like this. It works fine.
> &g
cribe the respective
hardware specifics using device tree or platform data and make
the driver handle this is a more general way.
This removes the empty stubs.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 40 ---
1 file changed, 40 dele
he version that
Glen has successfully tested.
Please disregard the earlier version and apply this one.
Arnd
Arnd Bergmann (19):
staging/wilc1000: remove unused functions
staging/wilc1000: make symbols static if possible
staging/wilc1000: use proper naming for global symbols
st
The last remaining user of WILC_SDIO macro checks for the correct
time to wait in an interrupt for the PLL to settle. We can
replace this with a runtime check and remove both WILC_SDIO and
WILC_SPI, as we no longer need conditional compilation based on
the hardware type.
Signed-off-by: Arnd
The driver interfaces are in linux_wlan_sdio.c and linux_wlan_spi.c, so
this is where the init and exit functions should be. Splitting this up
enables further cleanups, including eventually allowing both modules
to be built together.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000
In order to avoid some of the #ifdefs, this passes the io_type
and device pointer as an argument to wilc_netdev_init.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 18 --
drivers/staging/wilc1000/linux_wlan_sdio.c| 4 ++--
drivers/staging
modules.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 4 ++-
drivers/staging/wilc1000/linux_wlan_sdio.c| 3 ++-
drivers/staging/wilc1000/linux_wlan_spi.c | 2 +-
drivers/staging/wilc1000/wilc_sdio.c | 35 +--
drivers
driver
that does not have an instance pointer at hand. Changing those
would be a follow-up step.
There are a few other globals that will have to get moved
into struct wilc at a later point.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging
.
All other locations that check for the interrupt method are turned
into runtime checks based on the gpio number (>=0) or the interrupt
number (>0).
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Makefile | 1 -
drivers/staging/wilc1000/linux_wlan.c
i_dev
variables in favor of retrieving them from the wilc_dev
variable that will eventually get passed through all functions
instead of using a global.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c| 6 +-
drivers/staging/wilc1000/linux_wlan_common.h | 12 ---
dr
also change arguments slightly to pass the device,
as we are already touching those lines and the change will be needed
later to remove the global variables.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 22 +-
drivers/staging/wilc1000
struct wilc has two pointers to store the device, one for sdio_func
and one for spi_device. By changing the pointer to a 'struct device',
we can simplify the logic and avoid a few #ifdefs.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c
On Monday 16 November 2015 16:57:32 Laura Abbott wrote:
> Hi,
>
> This is another attempt at devicetree bindings for Ion. The big complaint from
> v1 was that too much unnecessary data was being pushed into devicetree.
> v2 takes a different approach of using just compatbile strings for the heaps.
intptr_t, not int.
Signed-off-by: Arnd Bergmann
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.c
index 4e6c16af40fc..c168845cbb91 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -823,7 +823,7 @@ static int _nbu2ss_out
all the code in all configurations
and is harder to get wrong.
Signed-off-by: Arnd Bergmann
diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
index 824d460911ec..58ccafb97344 100644
--- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
+++ b/driv
river to use ktime_t.
ktime_get() is better than using do_gettimeofday(),
because it uses the monotonic clock. ktime_sub
are used to subtract two ktime variables.
Build tested this by saying Y to WIMAX_GDM72XX.
Signed-off-by: Tapasweni Pathak
Reviewed-by: Arnd Bergmann
Signed-off-by: Arnd Bergmann
intptr_t, not int.
Signed-off-by: Arnd Bergmann
---
I sent this a month ago, here is the same patch again in case it got lost.
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.c
index 4e6c16af40fc..c168845cbb91 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++
ode is correct as far as I
can tell.
This disambiguates the operation by making the constant expressions
we pass here explicitly 'unsigned', which helps to avoid the warning.
Signed-off-by: Arnd Bergmann
---
drivers/staging/comedi/drivers/dt282x.c | 62 -
defined!
This adds the one-line change that was evidently missing from the
commit, doing what was intended there to have a correct set of dependencies.
Signed-off-by: Arnd Bergmann
Fixes: b08bb6bb5af5 ("staging: lustre: make lustre dependent on LNet")
---
drivers/staging/lustre/lustre
On Tuesday 15 March 2016 21:35:40 Hartley Sweeten wrote:
> On Monday, March 14, 2016 3:48 PM, Arnd Bergmann wrote:
> > gcc-6 warns about passing negative signed integer into swab16()
> > in the dt282x driver:
>
>
>
> > The warning makes sense, though the code is co
ble, though the suggested BIT()
macro wouldn't work either. I'm changing it to a hexadecimal notation,
which hopefully improves readability. I'm leaving the DT2821_CHANCSR_PRESLA
alone because it seems wrong.
Signed-off-by: Arnd Bergmann
---
v2: also reformat to make checkpatch.pl happy
dri
201 - 300 of 643 matches
Mail list logo
