Joe Perches writes:
> On Thu, 2015-05-07 at 10:08 -0400, Jes Sorensen wrote:
>> Dan Carpenter writes:
>> > On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
>> >> NACK!
>> > SHOUTING!
>> It's normal to write NACK in upper case
>
&g
t; 1 file changed, 1 insertion(+), 1 deletion(-)
Looks fine to me
Acked-by: Jes Sorensen
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
"Gujulan Elango, Hari Prasath (H.)" writes:
> On Thu, May 07, 2015 at 10:09:59AM -0400, Jes Sorensen wrote:
>> "Gujulan Elango, Hari Prasath (H.)" writes:
>> > On Thu, May 07, 2015 at 03:19:34PM +0300, Dan Carpenter wrote:
>> >> On Thu, Ma
Wim de With writes:
> This is a patch that fixes the function declarations in
> visorbus/visorchipset.c by removing newlines after the function return
> type
This patch doesn't fix things, it makes things worse!
If you want to post patches to this, do it properly and check the output
first.
NAC
tolga ceylan writes:
> On 05/15/2015 09:22 PM, Tolga Ceylan wrote:
>> visorchipset_file_init() and visorchipset_file_cleanup() functions
>> do not seem to be used from anywhere else and now are declared
>> as static. Sparse emitted "not declared" warnings for these two
>> functions.
>>
>> Signed-o
Juston Li writes:
> change cast to __le16 to fix the following warning:
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1488:20: warning: cast to
> restricted __le16
>
> Signed-off-by: Juston Li
> ---
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +-
> 1 file changed, 1 insertion(
Sudip Mukherjee writes:
> On Thu, Jun 04, 2015 at 09:22:45AM -0400, Benjamin Romer wrote:
>> From: David Kershner
>>
>> Diagchannel.h is used primarily for the diagnostics channel. The
>> diagnostics channel is not being used by linux guests currently, so
>> the majority of the file is not neede
Sudip Mukherjee writes:
> On Thu, Jun 04, 2015 at 09:22:36AM -0400, Benjamin Romer wrote:
>> This patch set contains the remaining changes from our driver cleanup
>> efforts. No functional changes have been made, only a rebase so that the
>> patches would apply.
> Hi,
> its not related to your thi
Larry Finger writes:
> On 03/28/2014 10:26 PM, Joe Perches wrote:
>> On Fri, 2014-03-28 at 21:37 -0500, Larry Finger wrote:
>>> The Realtek USB device RTL8723AU is found in Lenovo Yoga 13 tablets.
>>> A driver for it has been available in a GitHub repo for several months.
>> []
>>> 133 files cha
Paul Bolle writes:
> Larry,
>
> 0) I stumbled on two minor Kconfig related issues in the r8723au driver
> in staging-next.
>
> 1) drivers/staging/rtl8723au/include/drv_types.h
> Why is CONFIG_BR_EXT used? I couldn't find a Kconfig symbol BR_EXT nor a
> preprocessor define for CONFIG_BR_EXT.
Hi Pa
Paul Bolle writes:
> Jes,
>
> On Mon, 2014-04-07 at 11:25 +0200, Jes Sorensen wrote:
>> If it's not used, it should be ripped out.
>
> That's a rule I can grasp!
>
>> We've been going through this code for a while ripping things out that
>> a
From: Jes Sorensen
Converting the driver from the original RTL provided version, by error
converted the code to use four, which caused all sorts of issues. The
confusion was caused by the RTL driver having support for both two and
four paths, and in some places had RF_PATH_MAX = 3. At the same
From: Jes Sorensen
Greg,
This one is a major bug in the version of the driver we submitted for
staging. It correct a problem where we ended up trying to configure
more RF paths than are on the chip. The result was for transmission
to hang randomly.
I really would like this to go in with the
Paul Bolle writes:
> Larry,
>
> 0) I stumbled on two minor Kconfig related issues in the r8723au driver
> in staging-next.
>
> 1) drivers/staging/rtl8723au/include/drv_types.h
> Why is CONFIG_BR_EXT used? I couldn't find a Kconfig symbol BR_EXT nor a
> preprocessor define for CONFIG_BR_EXT.
>
> 2)
Dan Carpenter writes:
> Hi Larry and Jes,
>
> The patch 5e93f3520957: "staging: r8723au: Add source files for new
> driver - part 1" from Mar 28, 2014, leads to the following static
> checker warning:
>
> drivers/staging/rtl8723au/core/rtw_ieee80211.c:1515 rtw_get_wfd_ie()
> error: mem
to limited range of data type
>
> The first two warnings are fixed by making the two prototypes be "inline" to
> match
> the actual routine. The third warning comes from testing that a u8 quantity
> is positive.
>
> Reported-by: kbuild test robot
> Signed-off-
Dan Carpenter writes:
> Hello Larry, Jes,
>
> The rtw_report_sec_ie23a() is very buggy.
>
> 1) It uses GFP_KERNEL but the callers are holding a spinlock.
>
> rtw_select_and_join_from_scanned_queue23a() <- takes lock
> -> rtw_joinbss_cmd23a()
>-> rtw_restruct_sec_ie23a()
>
Dan Carpenter writes:
> Hello Larry, Jes,
>
> The rtw_report_sec_ie23a() is very buggy.
>
> 1) It uses GFP_KERNEL but the callers are holding a spinlock.
>
> rtw_select_and_join_from_scanned_queue23a() <- takes lock
> -> rtw_joinbss_cmd23a()
>-> rtw_restruct_sec_ie23a()
>
Dan Carpenter writes:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> staging-next
> head: dff222670ebebf1a7f147a23ccb5fc0312f2ae7e
> commit: da290c54610f49ef475f7f88668259216b08fc36 [133/193] staging:
> rtl8723au: OnAssocReq23a(): Clean up and use more ieee80211.h
>
>
Dan Carpenter writes:
> On Thu, Apr 17, 2014 at 11:50:13AM +0200, Jes Sorensen wrote:
>> > Old smatch warnings:
>> > drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4362
>> > collect_bss_info23a() error: __builtin_memcpy() 'bssid->IEs' too small
>>
Sven Dziadek writes:
> Remove byte order conversions.
> Conversion is already done in usb_ops_linux.c when accessing usb port.
> The deleted lines convert to little-endian and then call FillH2CCmd to
> convert back. Additionally, they are applied to wrong types and
> process wrong parts of variabl
> .../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 24
> drivers/staging/rtl8723au/hal/usb_halinit.c| 6 ++--
> 3 files changed, 15 insertions(+), 47 deletions(-)
Looks fine to me.
Acked-by: Jes Sorensen
_
Julian Calaby writes:
> Hi Sven,
>
> On Tue, Jan 5, 2016 at 2:29 AM, Sven Dziadek wrote:
>> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
>> b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
>> index 1662c03c..57f5941 100644
>> --- a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
>> +++ b
Joe Perches writes:
> On Fri, 2016-03-18 at 13:42 -0400, Jes Sorensen wrote:
>> Xose Vazquez Perez writes:
>> > People should not waste time and energy working on this staging driver.
>> > A replacement(rtl8xxxu) using the kernel wireless stack already was me
Julian Calaby writes:
> Hi Jandy,
>
> On Thu, Mar 17, 2016 at 7:03 PM, Jandy Gou
> wrote:
>> make C=1 M=drivers/staging/rtl8723au/
>>
>> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to
>> restricted __le16
>> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast
Xose Vazquez Perez writes:
> People should not waste time and energy working on this staging driver.
> A replacement(rtl8xxxu) using the kernel wireless stack already was merged
> in the 4.3 kernel.
>
> Cc: Jes Sorensen
> Cc: Larry Finger
> Cc: Kalle Valo
> Cc: Greg Kr
Jandy Gou writes:
> make C=1 M=drivers/staging/rtl8723au/
>
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to
> restricted __le16
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to
> restricted __le32
>
> Signed-off-by: Jandy Gou
> ---
> drivers/staging/
tl8723au/core/rtw_recv.c| 25 -
> drivers/staging/rtl8723au/include/rtw_recv.h | 2 --
> 2 files changed, 27 deletions(-)
Looks reasonable to me.
Acked-by: Jes Sorensen
Jes
> diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c
> b/drivers/stagi
tw_wlan_util.c | 10 --
> drivers/staging/rtl8723au/include/rtw_mlme_ext.h | 2 --
> 2 files changed, 12 deletions(-)
Acked-by: Jes Sorensen
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
From: Jes Sorensen
Hi,
I think it is time to get rid of the vendor rtl8723au driver. I
haven't heard any complaints about rtl8xxxu not being able to support
the rtl8723au as well as the old driver.
To give users a little time to migrate and raise their voices, lets
start by marki
From: Jes Sorensen
This driver is deprecated and superseded by rtl8xxxu. It will be
removed in a future kernel release.
Add a warning to Kconfig and at device init time to notify users and
allow them time to switch over.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/Kconfig
Jandy Gou writes:
> make C=1 M=drivers/staging/rtl8723au/
>
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to
> restricted __le16
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to
> restricted __le32
>
> Signed-off-by: Jandy Gou
> ---
> drivers/sta
Greg KH writes:
> On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote:
>> This patchset moves the visorbus driver (fromdrivers/staging/unisys/visorbus)
>> and its dependent headers files (from drivers/staging/unisys/include)
>> out of staging into the main kernel tree.
>>
>> The visorb
Greg KH writes:
> On Tue, May 17, 2016 at 10:01:55AM -0400, Jes Sorensen wrote:
>> Greg KH writes:
>> > On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote:
>> >> This patchset moves the visorbus driver
>> >> (fromdrivers/staging/unisys/visor
Greg KH writes:
> On Tue, May 17, 2016 at 07:49:53PM -0400, Jes Sorensen wrote:
>> > Ok, but still no need to put it under arch/ anything, it should go in
>> > drivers/ like all other drivers and busses are, no matter what the arch
>> > it happens to run on is.
>
Bhaktipriya Shridhar writes:
> This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file.
> WARNING: void function return statements are not generally useful
>
> Signed-off-by: Bhaktipriya Shridhar
> ---
> drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 10 --
> 1 file changed, 10 de
Julian Calaby writes:
> Hi Bhaktipriya,
>
> On Sat, Jan 30, 2016 at 5:00 AM, Jes Sorensen wrote:
>> Bhaktipriya Shridhar writes:
>> If you insist on pushing this rather unncessary change, please do it
>> properly, and remove the blank line before the return stateme
Bhaktipriya Shridhar writes:
> This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file.
> WARNING: void function return statements are not generally useful
>
> Signed-off-by: Bhaktipriya Shridhar
> ---
> Changes in v2:
>- Removed the unnecessary blank lines.
> drivers/staging/rtl8723a
Rakhi Sharma writes:
> Fixed the space and brace coding style error.
> ERROR: space required before that '='
> ERROR: that open brace { should be on the previous line.
>
> Signed-off-by: Rakhi Sharma
> ---
> drivers/staging/rtl8723au/core/rtw_ieee80211.c | 4 ++--
> 1 file changed, 2 insertions(
Geliang Tang writes:
> Use list_for_each_entry*() instead of list_for_each*() to simplify
> the code. Fix coding style by the way.
>
> Signed-off-by: Geliang Tang
> ---
> drivers/staging/rtl8723au/core/rtw_ap.c | 166
> --
> drivers/staging/rtl8723au/core/rtw_mlme.
Joe Perches writes:
> On Sun, 2016-01-31 at 09:36 -0500, Jes Sorensen wrote:
>> Rakhi Sharma writes:
>> > Fixed the space and brace coding style error.
>> > ERROR: space required before that '='
>> > ERROR: that open brace { should be on the previou
Joe Perches writes:
> On Mon, 2016-02-01 at 07:29 -0500, Jes Sorensen wrote:
>> Joe Perches writes:
> []
>> > so this could be transformed into something like:
>> >
>> > int rtw_get_bit_value_from_ieee_value23a(u8 val)
>> > {
>>
Geliang Tang writes:
> Use list_for_each_entry*() instead of list_for_each*() to simplify
> the code.
>
> Signed-off-by: Geliang Tang
> ---
> Changes in v2:
> - drop the coding style fixing in v1.
> ---
> drivers/staging/rtl8723au/core/rtw_ap.c | 92
> ++-
> drive
Geliang Tang writes:
> Use list_for_each_entry*() instead of list_for_each*() to simplify
> the code.
>
> Signed-off-by: Geliang Tang
> ---
> Changes in v3:
> - split it into three patches.
> Changes in v2:
> - drop the coding style fixing in v1.
> ---
> drivers/staging/rtl8723au/core/rtw_ap.c
ing in v1.
> ---
> drivers/staging/rtl8723au/core/rtw_recv.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
I assume this requires patch 1/3 applied first?
Acked-by: Jes Sorensen
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c
> b/drivers/staging/rtl87
Julian Calaby writes:
> Hi Geliang,
>
> On Sun, Feb 7, 2016 at 2:30 PM, Geliang Tang wrote:
>> This patch cleans whitespaces and blank lines surrounding
>> list_for_each_entry*().
>
> It does a lot more than this, including:
> - Removing some unnecessary brackets
> - Whitespace changes well awa
kbuild test robot writes:
> Hi Geliang,
>
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on v4.5-rc4 next-20160217]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improving the system]
>
> url:
> https://github.com/0day-ci/lin
Geliang Tang writes:
> On Wed, Feb 17, 2016 at 12:28:33PM -0500, Jes Sorensen wrote:
>> kbuild test robot writes:
>> > All errors (new ones prefixed by >>):
>> >
>> >drivers/staging/rtl8723au/core/rtw_recv.c: In function
>> > 'rtw_fr
--
> 2 files changed, 22 insertions(+), 53 deletions(-)
This looks fine to me. When these changes gets large, it may be better
to break them down into multiple patches as it's easier to debug if
there is a bug somewhere.
Acked-by: Jes Sorensen
>
> diff --git a/drivers/sta
ariable bound on line 1620 cannot be NULL
>
> Signed-off-by: Cihangir Akturk
> ---
> drivers/staging/rtl8723au/core/rtw_mlme.c | 13 ++---
> 1 file changed, 2 insertions(+), 11 deletions(-)
Looks fine to me
Acked-by: Jes Sorensen
_
David Kershner writes:
> Visordriver_probe_device gotos were messy, clean them up.
>
> Signed-off-by: David Kershner
> Signed-off-by: Timothy Sell
> ---
> drivers/staging/unisys/visorbus/visorbus_main.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drive
Fabian Frederick writes:
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick
> ---
> drivers/staging/rtl8723au/core/rtw_wlan_util.c | 12 +++-
> 1 file changed, 3 insertions(+), 9 deletions(-)
Please make sure
Luca Ceresoli writes:
> The is_valid_p2p_probereq is never referenced in the function body.
>
> Signed-off-by: Luca Ceresoli
> Cc: Greg Kroah-Hartman
> Cc: Jes Sorensen
> Cc: Larry Finger
> ---
> drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 8 +++-
> 1 file
Nicholas Mc Guire writes:
> scanning for trivial bug-patters with coccinelle spatches returned:
> ./drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1395
> WARNING: condition with no effect (if branch == else)
>
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c - line numbers from 4.1-rc7
Nicholas Mc Guire writes:
> On Sat, 13 Jun 2015, Jes Sorensen wrote:
>
>> Nicholas Mc Guire writes:
>> > scanning for trivial bug-patters with coccinelle spatches returned:
>> > ./drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1395
>> >WARNING: cond
itions */
> u16 Version;/* FW Version */
> u8 Subversion; /* FW Subversion, default 0x00 */
> - u16 Rsvd1;
> + u8 Rsvd1;
I had to look through this one a bit
Sudip Mukherjee writes:
> On Mon, Jun 15, 2015 at 11:30:41AM +0200, Daniele Alessandrelli wrote:
>> On June 15, 2015 7:47:41 AM GMT+02:00, Sudip Mukherjee
>> wrote:
>> >On Sun, Jun 14, 2015 at 11:26:35PM +0200, Daniele Alessandrelli wrote:
>>
>> >> - u16 Signature; /* 92C0: test chip; 92C, 88C0:
"Kershner, David A" writes:
>> -Original Message-
>> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
>> Sent: Friday, June 19, 2015 8:55 AM
>> To: Kershner, David A
>> Cc: gre...@linuxfoundation.org; jes.soren...@redhat.com; *S-Par-
>> Maintainer; driverdev-devel@linuxdriverproject.o
1 deletion(-)
Looks straight forward.
Acked-by: Jes Sorensen
Jes
> diff --git a/drivers/staging/rtl8723au/hal/odm.c
> b/drivers/staging/rtl8723au/hal/odm.c
> index f354f5e..6b9dbef 100644
> --- a/drivers/staging/rtl8723au/hal/odm.c
> +++ b/drivers/staging/rtl8723au/hal/odm.c
> @@
David Decotigny writes:
> The code shows a couple inconsistencies (described in commit
> descriptions) which would not be an issue on little-endian cpus, but
> could cause breakage on non-LE cpus. Note: I could not test on real
> hardware, these patches created based on sparse reports.
>
> Hostory
Michel von Czettritz writes:
> Writing the output of cpu_to_le32 to an u32 or *(u32*) is an implicit
> cast and results in an sparse warning.
>
> Since param and mask won't be changed, the implicit cast can be avoided
> by creating local variables.
>
> Signed-off-by: Michel von Czettritz
> ---
>
Dan Carpenter writes:
> On Tue, Jun 30, 2015 at 11:54:02PM +0200, Michel von Czettritz wrote:
>> Writing the output of cpu_to_le32 to an u32 or *(u32*) is an implicit
>> cast and results in an sparse warning.
>>
>> Since param and mask won't be changed, the implicit cast can be avoided
>> by crea
Michel von Czettritz writes:
> On 07/01/2015 10:31 PM, Jes Sorensen wrote:
>> Michel von Czettritz writes:
>>> Writing the output of cpu_to_le32 to an u32 or *(u32*) is an implicit
>>> cast and results in an sparse warning.
>>>
>>> Since param and ma
"Kershner, David A" writes:
>> -Original Message-
>> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
>> Sent: Wednesday, July 15, 2015 8:16 AM
>> To: Romer, Benjamin M
>> Cc: gre...@linuxfoundation.org; driverdev-devel@linuxdriverproject.org;
>> jes.soren...@redhat.com; *S-Par-Mainta
Steve Pennington writes:
> Repaced call to htons with call to cpu_to_be16s to fix the
> following sparse warning:
> drivers/staging/rtl8723au/core/rtw_recv.c:1557:21: warning: incorrect type in
> assignment (different base types)
> drivers/staging/rtl8723au/core/rtw_recv.c:1557:21:expected un
Steve Pennington writes:
> Repaced calls to htons and memcpy with a single call to put_unaligned_be16
You may want an 'l' in replaced, but not a biggie to me.
> to fix the following sparse warning:
> drivers/staging/rtl8723au/core/rtw_recv.c:1557:21: warning: incorrect type in
> assignment (dif
"Joglekar, Tejas (T.)" writes:
> From: Joglekar Tejas
>
> This patch fixes the error given by checkpatch.pl
>
> Signed-off-by: Joglekar Tejas
> ---
> drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723au/co
Ting-Chih Hsiao writes:
> remove spaces at the start of a line
> align enum variable with other parameters
>
> Signed-off-by: Ting-Chih Hsiao
Acked-by: Jes Sorensen
> ---
> drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 2 +-
> 1 file changed, 1 insertion(+), 1
Johannes Postma writes:
> usPtr is used as __le16 *, but was defined as u16 *.
> This was reported by sparse as:
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1850:29: warning: cast to
> restricted __le16
>
> This patch fixes the type of usPtr.
>
> Signed-off-by: Johannes Postma
> ---
> dr
Johannes Postma writes:
> On 06/08/15 at 08:21am, Jes Sorensen wrote:
>>
>> Looks OK to me. Probably worth changing the *(usPtr + index) to be
>> usPtr[index] as well to make the code easier to read.
>>
>> Jes
>>
>
> Thank you for reviewing. I
it.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Jes Sorensen
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Rickard Strandqvist writes:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/staging/rtl8723au/cor
Rickard Strandqvist writes:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/staging/rtl8723au/hal
Rickard Strandqvist writes:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/staging/rtl8723au/hal
Rickard Strandqvist writes:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/staging/rtl8723au/cor
Julian Calaby writes:
> Hi Rickard,
>
> On Mon, Feb 2, 2015 at 10:17 AM, Rickard Strandqvist
> wrote:
>> 2015-02-02 0:01 GMT+01:00 Jes Sorensen :
>>> Rickard Strandqvist writes:
>>>> Variable was assigned a value that was never used.
>>>> I ha
ertions(+), 52 deletions(-)
Why make it simple if you can make it complicated :)
I presume it's against 3.19-rc7 since a 3.0.19 would be rather obsolete.
Signed-off-by: Jes Sorensen
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
From: Jes Sorensen
Hi,
A couple more cleanups for the rtl8723au driver.
Cheers,
Jes
Jes Sorensen (6):
staging: rtl8723au: Use RF_AC instead of hardcoded value for RF
register write
staging: rtl8723au: rates are always set via the firmware interface
staging: rtl8723au
From: Jes Sorensen
No point shifting raid right, just to shift it left again before
re-adding it.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/hal_com.h | 30 -
1 file changed, 30 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/hal_com.h
b/drivers/staging/rtl8723au/include/hal_com.h
index 7c31865..e946c4b
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/ieee80211.h | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/ieee80211.h
b/drivers/staging/rtl8723au/include/ieee80211.h
index cb23cd0..3caf4f5 100644
--- a
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/usb_halinit.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c
b/drivers/staging/rtl8723au/hal/usb_halinit.c
index adbf1c2..319170d 100644
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/odm.c | 12
drivers/staging/rtl8723au/include/odm.h | 3 ---
2 files changed, 15 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/odm.c
b/drivers/staging/rtl8723au/hal/odm.c
index
From: Jes Sorensen
The only case where fw_ractrl = false was when the firmware failed to
load, and in that case we are dead in the water anyway.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/odm.c| 3 +--
.../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 28
gt; 1 file changed, 14 insertions(+), 26 deletions(-)
Looks good to me.
Acked-by: Jes Sorensen
>
> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> index a5eadd4..e88d851 100644
> --- a/drivers/staging/rtl8723a
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/ieee80211.h | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/ieee80211.h
b/drivers/staging/rtl8723au/include/ieee80211.h
index cb23cd0..3caf4f5 100644
--- a
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/hal_com.h | 30 -
1 file changed, 30 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/hal_com.h
b/drivers/staging/rtl8723au/include/hal_com.h
index 7c31865..e946c4b
From: Jes Sorensen
The only case where fw_ractrl = false was when the firmware failed to
load, and in that case we are dead in the water anyway.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/odm.c| 3 +--
.../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 28
From: Jes Sorensen
No point shifting raid right, just to shift it left again before
re-adding it.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/odm.c | 12
drivers/staging/rtl8723au/include/odm.h | 3 ---
2 files changed, 15 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/odm.c
b/drivers/staging/rtl8723au/hal/odm.c
index
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/usb_halinit.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c
b/drivers/staging/rtl8723au/hal/usb_halinit.c
index adbf1c2..319170d 100644
From: Jes Sorensen
Hi,
A few more fixes for the rtl8723au driver for staging-next.
Cheers,
Jes
Jes Sorensen (6):
staging: rtl8723au: Use RF_AC instead of hardcoded value for RF
register write
staging: rtl8723au: rates are always set via the firmware interface
staging: rtl8723au
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/odm.c | 12 +++-
drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 7 ---
drivers/staging/rtl8723au/include/odm.h | 16
3 files changed, 3 insertions(+), 32 deletions(-)
diff
From: Jes Sorensen
This gets rid of yet another duplicated copy of the RF type
Signed-off-by: Jes Sorensen
---
.../staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c| 19 +-
drivers/staging/rtl8723au/hal/hal_com.c| 40 --
drivers/staging/rtl8723au/hal
From: Jes Sorensen
Hi,
Here is another 5 cleanups for the rtl8723au driver, to go on top of
the set I posted yesterday.
Cheers,
Jes
Jes Sorensen (5):
staging: rtl8723au: No need for two copies of rf_type
staging: rtl8723au: Be more consistent in checking for 2 TX paths
staging
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c| 1 -
drivers/staging/rtl8723au/include/Hal8723APhyCfg.h | 3 ---
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c
b/drivers/staging/rtl8723au
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c
b/drivers/staging/rtl8723au/hal
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c| 34 +-
drivers/staging/rtl8723au/hal/usb_halinit.c| 12
drivers/staging/rtl8723au/include/Hal8723APhyCfg.h | 9 --
drivers/staging/rtl8723au/include
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/odm.c | 17 ++---
drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 1 -
drivers/staging/rtl8723au/include/odm.h | 1 -
3 files changed, 2 insertions(+), 17 deletions(-)
diff --git a/drivers
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/odm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/odm.c
b/drivers/staging/rtl8723au/hal/odm.c
index 2c604da..a77d151 100644
--- a/drivers/staging
101 - 200 of 745 matches
Mail list logo
