[PATCH 39/43] staging: rtl8723au: Eliminate set_wep_key() and call set_group_key() directly

From: Jes Sorensen This also eliminates another round of determine algorithm based on key length, followed by determine key length based on algorithm. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 45 +++ 1 file changed, 6 insertions

[PATCH 27/43] staging: rtl8723au: rtw_cfg80211_set_encryption(): Use key_params->cipher

From: Jes Sorensen Use key_params->cipher to determine WEP/TKIP Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/stag

[PATCH 40/43] staging: rtl8723au: rtw_restruct_wmm_ie23a(): Use cfg80211_find_vendor_ie()

From: Jes Sorensen Rewrite rtw_restruct_wmm_ie23a() using cfg80211_find_vendor_ie() Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 34 --- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/drivers/staging/rtl8723au/core

[PATCH 06/43] staging: rtl8723au: rtw_check_beacon_data23a(): Capability is already uptodate in cur_network

From: Jes Sorensen Beacon capability was already added to mlme_priv->cur_network before calling this function, so no need to retrieve it from the IE array again. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ap.c | 7 ++- 1 file changed, 2 insertions(+), 5 deleti

[PATCH 14/43] staging: rtl8723au: Stop carrying half the beacon frame header in the stored IE array

From: Jes Sorensen This gets rid of the odd carrying of half the beacon frame in the IE array stored for the network. Instead we rely on the relevant fields (timestamp, beacon_interval, and capability) stored in struct wlan_bssid_ex. Carrying only half the ieee80211_mgmt header led to a number

[PATCH 30/43] staging: rtl8723au: rtw_cfg80211_ap_set_encryption(): Pass key_index argument

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 62 ++- 1 file changed, 26 insertions(+), 36 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep

[PATCH 41/43] staging: rtl8723au: rtw_append_pmkid(): Adjust for IEs array not arrying fixed elements

From: Jes Sorensen Another case using hard coded offsets counting on the presence of fixed beacon elements in the IEs array. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH 42/43] staging: rtl8723au: Only validate vendor specific ies, when they it is vendor specific

From: Jes Sorensen Don't run rtw_validate_vendor_specific_ies() on anything but WLAN_EID_VENDOR_SPECIFIC. In addition use the proper WLAN_OUI_TYPE_MICROSOFT_* definitions. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 7 --- 1 file changed, 4 inser

[PATCH 33/43] staging: rtl8723au: Stop setting ieee_parm arguments that aren't used

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 37 --- 1 file changed, 37 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c index 624966e

[PATCH 31/43] staging: rtl8723au: rtw_cfg80211_ap_set_encryption(): obtain key from key_params

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep

Re: [PATCH] staging: rtl8723au: fix sparse warning

Clement Calmels writes: > From: Clément Calmels > > Found running sparse on the rtl8723au driver. > > CHECK drivers/staging/rtl8723au/core/rtw_cmd.c > drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54: warning: incorrect type in > argument 2 (different base types) > drivers/staging/rtl8723au/

Re: [jes:rtl8723au-devel 206/499] WARNING: __func__ should be used instead of gcc specific __FUNCTION__

Fengguang Wu writes: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git > rtl8723au-devel > head: 07068767ab5cc9eb549dc85cb858e00c384ade4c > commit: 068bf12cd5cc11f85a5b4d5423e629b640e12df7 [206/499] staging: > rtl8723au: hal/usb_ops_linux.c: Various cleanups > > scripts/che

[PATCH 03/10] staging: rtl8723au: rtw_sta_mgt.c: Use ether_addr_{copy, equal}()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_sta_mgt.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_sta_mgt.c b/drivers/staging/rtl8723au/core/rtw_sta_mgt.c index 14a82be..62e35dd

[PATCH 00/10] staging: rtl8723au: sparse fixes and some cleanups

From: Jes Sorensen Greg, A couple of sparse fixes (a fix from Clement Calmels and one reported by Fengguang Wu) as well as some cleanups removing dead code. Cheers, Jes Clément Calmels (1): staging: rtl8723au: fix sparse warning Jes Sorensen (9): staging: rtl8723au: usb_ops_linux.c: Add

[PATCH 09/10] staging: rtl8723au: Remove no-op rtl8723a_sreset_linked_status_check()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 -- drivers/staging/rtl8723au/hal/rtl8723a_sreset.c | 4 drivers/staging/rtl8723au/include/rtl8723a_sreset.h | 1 - 3 files changed, 7 deletions(-) diff --git a/drivers/staging

[PATCH 01/10] staging: rtl8723au: fix sparse warning

int [signed] gfp drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54:got restricted gfp_t Signed-off-by: Clement Calmels Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c| 2 +- drivers/staging/rtl8723au/include/rtw_mlme.h | 2 +- 2 files changed, 2 insertions(+), 2

[PATCH 02/10] staging: rtl8723au: usb_ops_linux.c: Add blank line between declaration and usage

From: Jes Sorensen This fixes a minor sparse warning. Reported-by: Fengguang Wu Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_ops_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/hal/usb_ops_linux.c b/drivers/staging

[PATCH 08/10] staging: rtl8723au: sreset_priv->dbg_trigger_point is never set

From: Jes Sorensen No point carrying a bunch of code around that is never going to get called. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_sreset.c | 7 --- drivers/staging/rtl8723au/hal/rtl8723a_sreset.c | 14 -- drivers/staging/rtl8723au/include

[PATCH 04/10] staging: rtl8723au: rtw_sta_mgt.c: One copy of the broadcast address should suffice

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_sta_mgt.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_sta_mgt.c b/drivers/staging/rtl8723au/core/rtw_sta_mgt.c index 62e35dd..f13a470

[PATCH 05/10] staging: rtl8723au: rtw_allow_stainfo23a(): Make hwaddr argument const

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_sta_mgt.c | 4 ++-- drivers/staging/rtl8723au/include/sta_info.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_sta_mgt.c b/drivers/staging

[PATCH 06/10] staging: rtl8723au: Remove unused rtw_sreset_get_wifi_status()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_sreset.c| 29 -- drivers/staging/rtl8723au/include/rtw_sreset.h | 1 - 2 files changed, 30 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_sreset.c b/drivers

[PATCH 10/10] staging: rtl8723au: Remove unused rtw_pwr_wakeup_ex()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/rtw_pwrctrl.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/include/rtw_pwrctrl.h b/drivers/staging/rtl8723au/include/rtw_pwrctrl.h index a458af9..577914d 100644 --- a/drivers

[PATCH 07/10] staging: rtl8723au: Wifi_Error_Status isn't used for anything

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_sreset.c | 11 --- drivers/staging/rtl8723au/hal/rtl8723a_sreset.c | 1 - drivers/staging/rtl8723au/hal/usb_ops_linux.c| 11 --- drivers/staging/rtl8723au/include/rtw_sreset.h

[PATCH 04/10] staging: rtl8723au: Remove unused variables from struct pwrctrl_priv

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/rtw_pwrctrl.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723au/include/rtw_pwrctrl.h b/drivers/staging/rtl8723au/include/rtw_pwrctrl.h index 110bad9..2142255 100644 --- a

[PATCH 02/10] staging: rtl8723au: Fold power_saving_wk_hdl() into rtw_drvextra_cmd_hdl23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_cmd.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c b/drivers/staging/rtl8723au/core/rtw_cmd.c index 35f879e..f44f941 100644 --- a

[PATCH 03/10] staging: rtl8723au: Remove unused pwrctrl_priv->brfoffbyhw

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_pwrctrl.c| 1 - drivers/staging/rtl8723au/include/rtw_pwrctrl.h | 1 - drivers/staging/rtl8723au/os_dep/usb_intf.c | 1 - 3 files changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723au/core

[PATCH 00/10] staging: rtl8723au: Remove more dead code and clean up USB functions

From: Jes Sorensen Greg, Please find attached a number of fixes for the rtl8723au driver for the staging-next tree. In particular this includes a cleanup simplifying the USB read/write functions as we don't need all the retry hacks that they had in there for other operating. In addition re

[PATCH 06/10] staging: rtl8723au: pwrctrl_priv->ps_flag is never set

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/rtw_pwrctrl.h | 2 -- drivers/staging/rtl8723au/os_dep/os_intfs.c | 5 - 2 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723au/include/rtw_pwrctrl.h b/drivers/staging/rtl8723au

[PATCH 08/10] staging: rtl8723au: Sanitize USB read/write functions

From: Jes Sorensen The original Realtek provided functions suffered badly from clutter to accommodate broken operating systems. Lets try this lean and clean version instead. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_ops_linux.c | 289 ++ drivers

[PATCH 07/10] staging: rtl8723au: Remove never set struct rtw_adapter->bNotifyChannelChange

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 4 drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 3 --- drivers/staging/rtl8723au/include/drv_types.h | 2 -- drivers/staging/rtl8723au/os_dep/os_intfs.c | 1 - 4 files changed

[PATCH 01/10] staging: rtl8723au: Clean up rtw_pm_set_ips23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_pwrctrl.c| 15 ++- drivers/staging/rtl8723au/include/rtw_pwrctrl.h | 6 -- 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_pwrctrl.c b

[PATCH 09/10] staging: rtl8723au: Simplify _BlockWrite() based on saner rtl8723au_writeN()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 89 ++- 1 file changed, 5 insertions(+), 84 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal

[PATCH 10/10] staging: rtl8723au: Remove unnecessary null test before kfree

From: Fabian Frederick Fix checkpatch warning: WARNING: kfree(NULL) is safe this check is probably not required Cc: Larry Finger Cc: Jes Sorensen Cc: linux-wirel...@vger.kernel.org Signed-off-by: Fabian Frederick Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_cmd.c | 4

[PATCH 05/10] staging: rtl8723au: pnp_bstop_trx is never set

From: Jes Sorensen In addition remove unused pnp_current_pwr_state Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_ops_linux.c| 11 --- drivers/staging/rtl8723au/include/rtw_pwrctrl.h | 2 -- drivers/staging/rtl8723au/os_dep/usb_ops_linux.c | 8 +++- 3

Re: [PATCH 08/10] staging: rtl8723au: Sanitize USB read/write functions

jes.soren...@redhat.com writes: > From: Jes Sorensen > > The original Realtek provided functions suffered badly from clutter to > accommodate broken operating systems. Lets try this lean and clean > version instead. > > Signed-off-by: Jes Sorensen > --- > dr

[PATCH v2 00/10] staging: rtl8723au: Fix USB macro functions

From: Jes Sorensen Greg, Here is v2 of patch 08/10 "Sanitize USB read/write functions" it should fix the 'do not do DMA on the stack' issue with the original version. With this patch 09/10 is valid again. I didn't want to resend the full set again to reduce list nois

[PATCH v2 08/10] staging: rtl8723au: Sanitize USB read/write functions

From: Jes Sorensen The original Realtek provided functions suffered badly from clutter to accommodate broken operating systems. Lets try this lean and clean version instead. v2: Do not use the stack for data passed to usb_control_msg(). This requires reintroducing the mutex used in the old

Re: [PATCH] staging: rtl8723au: type casting corrections

Greg KH writes: > On Sun, Aug 17, 2014 at 10:19:28AM -0300, Raphael Silva wrote: >> Type casting corrections in order to solve warnings of the sparce static >> analyser. >> >> Signed-off-by: Raphael Silva >> --- >> drivers/staging/rtl8723au/hal/usb_halinit.c | 4 ++-- >> drivers/staging

[PATCH] staging: rtl8723au: Remove write-only variables hal_data_8723a.EEPROM[VP]ID

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 22 -- drivers/staging/rtl8723au/include/rtl8723a_hal.h | 4 2 files changed, 26 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers

Re: [patch] staging: rtl8723au: incorrect use of ether_addr_copy()

Dan Carpenter writes: > The return from myid() isn't aligned correctly for ether_addr_copy(). > > Signed-off-by: Dan Carpenter Sorry, this makes no sense, just fix it properly! drivers/staging/rtl8723au/include/rtw_eeprom.h: struct eeprom_priv { u8 bautoload_fail_flag;

Re: [patch] staging: rtl8723au: incorrect use of ether_addr_copy()

Dan Carpenter writes: > On Wed, Oct 08, 2014 at 03:59:33PM +0200, Jes Sorensen wrote: >> Dan Carpenter writes: >> > The return from myid() isn't aligned correctly for ether_addr_copy(). >> > >> > Signed-off-by: Dan Carpenter >> >

Re: [patch] staging: rtl8723au: incorrect use of ether_addr_copy()

Joe Perches writes: > On Wed, 2014-10-08 at 15:46 +0300, Dan Carpenter wrote: >> On Wed, Oct 08, 2014 at 05:26:11AM -0700, Joe Perches wrote: >> > On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote: >> > > The return from myid() isn't aligned correctly for ether_addr_copy(). >> > >> > Hey Dan

Re: [patch] staging: rtl8723au: incorrect use of ether_addr_copy()

Joe Perches writes: > On Wed, 2014-10-08 at 16:33 +0200, Jes Sorensen wrote: >> Joe Perches writes: >> > On Wed, 2014-10-08 at 15:46 +0300, Dan Carpenter wrote: >> >> On Wed, Oct 08, 2014 at 05:26:11AM -0700, Joe Perches wrote: >> >> > On Wed, 2

[PATCH 09/15] staging: rtl8723au: Don't read REQ_NQOS_SEQ 16 bits and write back 8 bits

From: Jes Sorensen This fixes a potential endian bug Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/hal_com.c | 2 +- drivers/staging/rtl8723au/include/rtw_xmit.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/hal_com.c

[PATCH 12/15] staging: rtl8723au: Remove unused struct zero_bulkout_content

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/usb_ops_linux.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/usb_ops_linux.c b/drivers/staging/rtl8723au/os_dep/usb_ops_linux.c index 4c94264..3e19b3b 100644 --- a

[PATCH 04/15] staging: rtl8723au: Remove write-only struct xmit_priv->vcs_type

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/rtw_xmit.h | 1 - drivers/staging/rtl8723au/os_dep/os_intfs.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/include/rtw_xmit.h b/drivers/staging/rtl8723au/include/rtw_xmit.h

[PATCH 00/15] staging: rtl8723au: Fixes and cleanups

From: Jes Sorensen Hi, Please find attached a couple of fixes and cleanups for the rtl8723au driver. This includes a fix for the mac_addr alignment reported by Dan Carpenter and two patches from Greg Donald. Cheers, Jes Greg Donald (2): drivers: staging: rtl8723au: core: Fix "'

[PATCH 08/15] staging: rtl8723au: Use register define REQ_NQOS_SEQ instead of hardcoded value

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/core/rtw_sreset.c b/drivers/staging/rtl8723au/core/rtw_sreset.c index 58ed980..29a29d9 100644 --- a

[PATCH 06/15] staging: rtl8723au: Eliminate write-once variable xmit_priv->vcs_setting

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_xmit.c| 2 +- drivers/staging/rtl8723au/include/rtw_xmit.h | 1 - drivers/staging/rtl8723au/os_dep/os_intfs.c | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH 11/15] staging: rtl8723au: Remove a stack of write only counters

From: Jes Sorensen We don't do anything with these, so get rid of them Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_xmit.c| 6 -- drivers/staging/rtl8723au/include/rtw_xmit.h | 5 - drivers/staging/rtl8723au/os_dep/usb_ops_linux.c

[PATCH 05/15] staging: rtl8723au: Use enum values for vcs_type

From: Jes Sorensen Be consistent in the use of enum VCS_TYPE Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c b/drivers/staging/rtl8723au/core

[PATCH 15/15] staging: rtl8723au: Eliminate write-only struct wlan_network->aid

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 3 --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8723au/include/wlan_bssdef.h | 1 - 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers

[PATCH 14/15] staging: rtl8723au: Remove unused struct ndis_802_11_key

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/wlan_bssdef.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8723au/include/wlan_bssdef.h b/drivers/staging/rtl8723au/include/wlan_bssdef.h index 037942c..8acc418 100644

[PATCH 10/15] staging: rtl8723au: Re-organize struct xmit_priv for better packing

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/rtw_xmit.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/include/rtw_xmit.h b/drivers/staging/rtl8723au/include/rtw_xmit.h index c26d944..b170ee2 100644

[PATCH 07/15] stating: rtl8723au: Eliminate write-only struct xmit_priv->txirp_cnt

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_xmit.c| 2 -- drivers/staging/rtl8723au/include/rtw_xmit.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c index

[PATCH 01/15] staging: rtl8723au: Fix alignment of mac_addr for ether_addr_copy() usage

From: Jes Sorensen Make sure struct eeprom_priv->mac_addr is 2 byte aligned to work with ether_addr_copy() Reported-by: Dan Carpenter Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/rtw_eeprom.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

[PATCH 13/15] staging: rtl8723au: Fold struct wlan_phy_info into struct wlan_bssid_ex

From: Jes Sorensen Half the entries of struct wlan_phy_info weren't used and this makes the code a little cleaner Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 40 +++ drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 02/15] drivers: staging: rtl8723au: core: Fix "'foo * bar' should be 'foo *bar'" errors

From: Greg Donald Fix checkpatch.pl "'foo * bar' should be 'foo *bar'" errors Signed-off-by: Greg Donald Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ap.c| 2 +- drivers/staging/rtl8723au/core/rtw_led.c | 3 ++- drivers/sta

[PATCH 03/15] drivers: staging: rtl8723au: Fix "open brace '{' following struct go on the same line" errors

From: Greg Donald Fix checkpatch.pl "open brace '{' following struct go on the same line" errors Signed-off-by: Greg Donald Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_security.c | 3 +-- drivers/staging/rtl8723au/include/rtl8723a_dm.h | 3

Re: [PATCH 00/15] staging: rtl8723au: Fixes and cleanups

Greg KH writes: > On Fri, Oct 10, 2014 at 09:41:23PM +0200, jes.soren...@redhat.com wrote: >> From: Jes Sorensen >> >> Hi, >> >> Please find attached a couple of fixes and cleanups for the rtl8723au >> driver. This includes a fix for the mac_addr alignme

Re: [PATCH 11/15] staging: rtl8723au: Remove a stack of write only counters

Greg KH writes: > On Sat, Oct 11, 2014 at 05:32:49AM -0700, Greg KH wrote: >> On Fri, Oct 10, 2014 at 09:41:34PM +0200, jes.soren...@redhat.com wrote: >> > From: Jes Sorensen >> > >> > We don't do anything with these, so get rid of th

Re: [PATCH 2/2] staging: rtl8723au:core

Joe Perches writes: > On Sun, 2014-10-26 at 16:18 +, Paul McQuade wrote: >> ERROR: spaces required around that ':' (ctx:VxE) >> >> Signed-off-by: Paul McQuade >> --- >> drivers/staging/rtl8723au/core/rtw_ieee80211.c | 16 >> 1 file changed, 8 insertions(+), 8 deletions(-) >

Re: [PATCH] staging: rtl8723au: create macro get_max_rate

Paul McQuade writes: > create marco for max_rate values > > Signed-off-by: Paul McQuade > --- > drivers/staging/rtl8723au/core/rtw_ieee80211.c | 58 > -- > 1 file changed, 26 insertions(+), 32 deletions(-) > > diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c

Re: [PATCH 2/2] staging: rtl8723au:core

Joe Perches writes: > On Mon, 2014-10-27 at 06:45 +0100, Jes Sorensen wrote: >> Joe Perches writes: >> > On Sun, 2014-10-26 at 16:18 +, Paul McQuade wrote: >> >> ERROR: spaces required around that ':' (ctx:VxE) > [] >> >> diff --git a

Re: [PATCH 2/2] staging: rtl8723au:core

Joe Perches writes: > On Mon, 2014-10-27 at 07:16 +0100, Jes Sorensen wrote: >> Joe Perches writes: >> > On Mon, 2014-10-27 at 06:45 +0100, Jes Sorensen wrote: >> >> Joe Perches writes: >> >> > On Sun, 2014-10-26 at 16:18 +, Paul McQuade wrote

Re: [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch.

Sanjeev Sharma writes: > This is a patch to the rtw_cmd.c file that fixes > Error reported by checkpatch. > > Signed-off-by: Sanjeev Sharma > --- > drivers/staging/rtl8723au/core/rtw_cmd.c | 83 > +++- > 1 file changed, 40 insertions(+), 43 deletions(-) > > diff --gi

Re: [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch.

Joe Perches writes: > On Mon, 2014-10-27 at 09:43 +0100, Jes Sorensen wrote: >> Sanjeev Sharma writes: >> > This is a patch to the rtw_cmd.c file that fixes >> > Error reported by checkpatch. > [] >> > diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.

Re: [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch.

"Sharma, Sanjeev" writes: > -Original Message----- > From: Jes Sorensen [mailto:jes.soren...@redhat.com] > Sent: Monday, October 27, 2014 2:13 PM > To: Sharma, Sanjeev > Cc: larry.fin...@lwfinger.net; gre...@linuxfoundation.org; > linux-wirel...@vger.kernel.org

Re: [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch.

"Sharma, Sanjeev" writes: > -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Monday, October 27, 2014 8:23 PM > To: Jes Sorensen > Cc: Sharma, Sanjeev; larry.fin...@lwfinger.net; > gre...@linuxfoundation.org; linux-wi

Re: [PATCH 7/8] staging: unisys: stop device registration before visorbus registration

Sudip Mukherjee writes: > On Tue, Aug 18, 2015 at 03:14:02PM -0400, Benjamin Romer wrote: >> In cases where visorbus is compiled directly into the kernel, if >> visorbus registration fails for any reason, it is still possible for >> other drivers to call visorbus_register_visor_driver(), which cou

Re: [PATCH 7/8] staging: unisys: stop device registration before visorbus registration

Sudip Mukherjee writes: > On Tue, Aug 25, 2015 at 08:33:55AM -0400, Jes Sorensen wrote: >> Sudip Mukherjee writes: >> > On Tue, Aug 18, 2015 at 03:14:02PM -0400, Benjamin Romer wrote: >> >> In cases where visorbus is compiled directly into the kernel, if >> &g

Re: [PATCH 2/3] staging/rtl8723au: Use %pM format specifier to print mac address

- > 1 file changed, 2 insertions(+), 5 deletions(-) Works for me Acked-by: Jes Sorensen ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 11/16] staging: rtl8723au: remove unimplemented function declarations

Luca Ceresoli writes: > Signed-off-by: Luca Ceresoli > Cc: Greg Kroah-Hartman > Cc: Jes Sorensen > Cc: Larry Finger > --- > drivers/staging/rtl8723au/include/rtw_cmd.h | 2 -- > 1 file changed, 2 deletions(-) Acked-by: Jes Sorensen

Re: [PATCH] staging: rtl8723au: remove unnecessary le32_to_cpu

Michał Bartoszkiewicz writes: > The values passed to le32_to_cpu are already in the correct byte order. > This fixes four "cast to restricted __le32" sparse warnings. > > Signed-off-by: Michał Bartoszkiewicz > --- > drivers/staging/rtl8723au/core/rtw_security.c | 8 > 1 file changed, 4

[PATCH 5/6] staging: rtl8723au: TurboScanOff is always true

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c | 32 + 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c b/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c

[PATCH 2/6] staging: rtl8723au: Eliminate dummy ccxPowerIndexCheck()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c b/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c index 7fa9780..8764538 100644 --- a

[PATCH 4/6] staging: rtl8723au: Tidy up SetTxPowerLevel8723A()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 27 +++-- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c b/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c

[PATCH 0/6] staging: rtl8723au: Clean ups

From: Jes Sorensen Hi, Reading through some of the rate setup code, I was forced to clean up some of the components to be able to read it properly. Cheers, Jes Jes Sorensen (6): staging: rtl8723au: Simplify eeprom content checking staging: rtl8723au: Eliminate dummy ccxPowerIndexCheck

[PATCH 6/6] staging: rtl8723au: Clean up getPowerBase()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c b/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c index

[PATCH 1/6] staging: rtl8723au: Simplify eeprom content checking

From: Jes Sorensen This eliminates the ugly Hal_EEValueCheck() function Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 42 ++- 1 file changed, 11 insertions(+), 31 deletions(-) diff --git a/drivers/staging/rtl8723au/hal

[PATCH 3/6] staging: rtl8723au: Fold getTxPowerIndex() into PHY_SetTxPowerLevel8723A()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 46 ++--- 1 file changed, 19 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c b/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c

Re: [PATCH] Removed extra spaces, and error from checkpatch.pl

Pinkesh Badjatiya writes: > Removed trailing spaces. > Fixed some errors from checkpatch.pl verification. > No changes made to actual functional code. > > Signed-off-by: Pinkesh Badjatiya > --- > drivers/staging/rtl8723au/include/rtw_cmd.h | 162 > ++-- > 1 file changed,

Re: [PATCH v2 00/10] staging: rtl8723au: Fix USB macro functions

Greg KH writes: > On Tue, Jul 01, 2014 at 12:06:59PM +0200, jes.soren...@redhat.com wrote: >> From: Jes Sorensen >> >> Greg, >> >> Here is v2 of patch 08/10 "Sanitize USB read/write functions" it >> should fix the 'do not do DMA on the stac

[PATCH 09/10] staging: rtl8723au: Remove obfuscating wrapper ODM_ConfigMACWithHeaderFile23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_HWConfig.c | 7 --- drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 3 +-- drivers/staging/rtl8723au/include/odm_HWConfig.h | 2 -- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a

[PATCH 08/10] staging: rtl8723au: Remove unused ODM_MacStatusQuery23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_HWConfig.c | 9 - drivers/staging/rtl8723au/include/odm_HWConfig.h | 8 2 files changed, 17 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm_HWConfig.c b/drivers/staging

[PATCH 03/10] staging: rtl8723au: Eliminate wrapper ODM_ConfigRFWithHeaderFile23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_HWConfig.c | 15 --- drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 6 ++ drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c| 8 ++-- drivers/staging/rtl8723au/include

[PATCH 01/10] staging: rtl8723au: Remove horrendous code obfuscation READ_AND_CONFIG*()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_HWConfig.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm_HWConfig.c b/drivers/staging/rtl8723au/hal/odm_HWConfig.c index 82b1b83

[PATCH 05/10] staging: rtl8723au: Remove pointless wrappers for calling odm_ConfigRFReg_8723A()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/HalHWImg8723A_RF.c | 5 +++-- drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 14 -- drivers/staging/rtl8723au/include/odm_RegConfig8723A.h | 4 3 files changed, 3 insertions

[PATCH 10/10] staging: rtl8723au: Remove unncessary wrapper PHY_RFConfig8723A()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c| 12 drivers/staging/rtl8723au/hal/usb_halinit.c| 4 ++-- drivers/staging/rtl8723au/include/Hal8723APhyCfg.h | 1 - 3 files changed, 2 insertions(+), 15 deletions

[PATCH 04/10] staging: rtl8723au: Remove zero value calculation added to address

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c b/drivers/staging/rtl8723au/hal

[PATCH 02/10] staging: rtl8723au: Call to ODM_ConfigRFWithHeaderFile23a path is identical for RF_PATH_[AB]

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c b/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c index c30bd23..6686a29 100644 --- a

[PATCH 06/10] staging: rtl8723au: Remove unused ODM_ReadAndConfig_PHY_REG_PG_8723A() and related code+data

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/HalHWImg8723A_BB.c | 160 - drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 28 .../staging/rtl8723au/include/HalHWImg8723A_BB.h | 6 - .../staging/rtl8723au/include

[PATCH 00/10] staging-next: rtl8723au: Reducing code obfuscation

From: Jes Sorensen Greg, Please find attached another smaller set of changes for the rtl8723au driver. IT's mainly removing code obfuscation in the hal layer. Cheers, Jes Jes Sorensen (10): staging: rtl8723au: Remove horrendous code obfuscation READ_AND_CONFIG*() staging: rtl8

[PATCH 07/10] staging: rtl8723au: Remove ugly wrapper ODM_ConfigBBWithHeaderFile23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_HWConfig.c | 16 drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 10 ++ drivers/staging/rtl8723au/include/odm.h | 8 drivers/staging/rtl8723au/include

[PATCH 10/13] staging: rtl8723au: rtl8723a_InitBeaconParameters(): Remove unused variable

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c index 5c4751c..8523908 100644 --- a

[PATCH 11/13] staging: rtl8723au: ODM_IC_11N_SERIES is always true for SupportICType

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 142 +++--- drivers/staging/rtl8723au/include/odm.h | 4 - drivers/staging/rtl8723au/include/odm_interface.h | 11 +- 3 files changed, 75 insertions(+), 82

[PATCH 00/13] staging: rtl8723au: Remove more code obfuscation

From: Jes Sorensen Greg, Another round of code obfuscation removal, mostly getting rid of no-op and unncessary wrappers. Cheers, Jes Jes Sorensen (12): staging: rtl8723au: Eliminate Set_MSR() wrapper call staging: rtl8723au: Reduce number of duplicate defines for link state staging

[PATCH 06/13] staging: rtl8723au: Remove no-op usb_AggSetting*()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 50 - 1 file changed, 50 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index 227a363..4161409

[PATCH 01/13] staging: rtl8723au: Eliminate Set_MSR() wrapper call

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ap.c | 2 +- drivers/staging/rtl8723au/core/rtw_mlme_ext.c| 18 +- drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 5

[PATCH 05/13] staging: rtl8723au: Remove write-only variable UsbRxHighSpeedMode

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 3 --- drivers/staging/rtl8723au/include/rtl8723a_hal.h | 3 --- 2 files changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal

<    2   3   4   5   6   7   8   >