From: Ajay Singh
This series contains pending patches from #9 till #15 from previous
series[1].
Also added 5 new patches to avoid the use of unnecessary static
variables for few leftovers.
[1]. https://patchwork.kernel.org/cover/10794463/
https://patchwork.kernel.org/patch/10794479/
Ajay S
From: Ajay Singh
Make use of cookie information to pass to wpa_s and handle cookie value
received in the cfg80211_ops callbacks.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 72 +++
drivers/staging/wilc1000/host_interface.h | 13
From: Ajay Singh
Avoid use of interface name i.e 'wlan0' & 'p2p0' to check the interface
type in dev_state_ev_handler(). Now making use of netdev_ops and iface
type to know interface. Reorder the functions to avoid the forward
declaration after the above changes
Signed-off-by: Ajay Singh
---
d
From: Ajay Singh
Use random number to assign to cookie value.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers/staging/wilc1000/wilc_w
From: Ajay Singh
Refactor linux_wlan_init_test_config() to use correct endianness for wid
values and remove unnecessary code.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 200 +---
drivers/staging/wilc1000/wilc_wlan_if.h | 1 -
2 files c
From: Ajay Singh
Avoid the use of static variable and move it as part of wilc structure.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 22 --
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 +
2 files changed, 13 insertions(+), 10
From: Ajay Singh
Avoid use of static variable 'wlan_channel' by moving it inside the wilc
structure.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 36 ---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 +
2 files changed, 20 inser
From: Ajay Singh
Remove 'add_sta_param' structure as its not used now.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.h
b/drivers/staging/wilc1000/host_interface.h
From: Ajay Singh
This series contains the following changes:
- fix to set 'vif_num' value correctly. The previous Fixes patch
for vif count had not fixed the issue completely, so reverted it
and added a new patch to fix the issue.
- use 'wilc_' prefix for variables and function names.
-
From: Ajay Singh
Cleanup patch to rename data structure and function name to have 'wilc_'
prefix.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 54 +++
drivers/staging/wilc1000/host_interface.h | 12 ++---
drivers/staging/wilc1000
From: Ajay Singh
Set correct interface count value in '->vif_num'.
'vif_num' was incorrectly set one less than total number of interfaces
because 'i' is used to set its value, which starts from 0.
Fixes: 735bb39ca3be ("staging: wilc1000: simplify vif[i]->ndev accesses")
Cc: # v4.10
Signed-off-b
From: Ajay Singh
Cleanup patch to avoid function forward declaration by reordering the
function.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_sdio.c | 91 +---
1 file changed, 43 insertions(+), 48 deletions(-)
diff --git a/drivers/staging/wilc100
From: Ajay Singh
This patch reverts 0e490657c721 ("staging: wilc1000: Fix problem with
wrong vif index") commit.
The issue was not completely fixed with the above commit.
After 'for' loop completion, '->idx' value is correct but '->vif_num'
still contains incorrect interface count.
Fixes: 0e490
From: Ajay Singh
Move data structure and function prototype from 'wilc_wlan_if.h file.
Now, this file contains constant specific to the firmware.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 1 +
drivers/staging/wilc1000/host_interface.h | 11 ++
drivers/s
From: Ajay Singh
Rename wilc_frmw_to_linux() to wilc_frmw_to_host() to be remove the _linux
suffix.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 3 ++-
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +-
drivers/staging/wilc1000/wilc_wlan.c | 5 ++---
From: Ajay Singh
Cleanup patch to have proper follow clear namespace in wilc_sdio.c file.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_sdio.c | 92 ++--
1 file changed, 46 insertions(+), 46 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_
From: Ajay Singh
Rename linux_wlan.c and linux_mon.c to wilc_netdev.c and wilc_mon.c to
include 'wilc_' prefix.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/Makefile| 2 +-
drivers/staging/wilc1000/{linux_mon.c => wilc_mon.c} | 0
drivers/staging/wilc1000/
From: Ajay Singh
Remove 'linux_' prefix and replace it with 'wilc_' namespace.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 17 -
drivers/staging/wilc1000/wilc_sdio.c | 10 +-
2 files changed, 13 insertions(+), 14 deletions(-)
diff --git a/dri
Hi Dan,
On 2/7/2019 1:42 PM, Dan Carpenter wrote:
> This patch was very confusing to review...
Apologies for the confusion.
> From a process perspective, you really should fold patches 1 and 2
> together. Otherwise we're re-introducing a bug.
Patch 1 and Patch 2 both are required if commit 0e4
From: Ajay Singh
Rename linux_wlan.c and linux_mon.c to wilc_netdev.c and wilc_mon.c to
include 'wilc_' prefix.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/Makefile| 2 +-
drivers/staging/wilc1000/{linux_mon.c => wilc_mon.c} | 0
drivers/staging/wilc1000/
From: Ajay Singh
Rename wilc_frmw_to_linux() to wilc_frmw_to_host() to be remove the _linux
suffix.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 3 ++-
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +-
drivers/staging/wilc1000/wilc_wlan.c | 5 ++---
From: Ajay Singh
Remove 'linux_' prefix and replace it with 'wilc_' namespace.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 17 -
drivers/staging/wilc1000/wilc_sdio.c | 10 +-
2 files changed, 13 insertions(+), 14 deletions(-)
diff --git a/dri
From: Ajay Singh
Cleanup patch to have proper follow clear namespace in wilc_sdio.c file.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_sdio.c | 92 ++--
1 file changed, 46 insertions(+), 46 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_
From: Ajay Singh
Move data structure and function prototype from 'wilc_wlan_if.h file.
Now, this file contains constant specific to the firmware.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 1 +
drivers/staging/wilc1000/host_interface.h | 11 ++
drivers/s
From: Ajay Singh
Set correct value in '->vif_num' for the total number of interfaces and
set '->idx' value using 'i'.
Fixes: 735bb39ca3be ("staging: wilc1000: simplify vif[i]->ndev accesses")
Fixes: 0e490657c721 ("staging: wilc1000: Fix problem with wrong vif index")
Cc:
Suggested-by: Dan Carpe
From: Ajay Singh
This series contains the following changes:
- fix to set 'vif_num' value correctly.
- use 'wilc_' prefix for variables and function names.
- avoid use of unnecessary 'linux_' prefix from file names.
Changes since v1:
- merged patch 1 & 2 and added modification as suggeste
From: Ajay Singh
Cleanup patch to avoid function forward declaration by reordering the
function.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_sdio.c | 91 +---
1 file changed, 43 insertions(+), 48 deletions(-)
diff --git a/drivers/staging/wilc100
From: Ajay Singh
Cleanup patch to rename data structure and function name to have 'wilc_'
prefix.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 54 +++
drivers/staging/wilc1000/host_interface.h | 12 ++---
drivers/staging/wilc1000
On 2/7/2019 6:21 PM, Claudiu Beznea - M18063 wrote:
>
>
> On 07.02.2019 13:29, ajay.kat...@microchip.com wrote:
>> From: Ajay Singh
>>
>> Move data structure and function prototype from 'wilc_wlan_if.h file.
>> Now, this file contains constant specific to the firmware.
>>
>> Signed-off-by: Ajay
On 2/26/2019 8:58 AM, Bo YU wrote:
> The patch fixes following sparse warning:
>
> drivers/staging/wilc1000/host_interface.c:450:30: warning: incorrect type in
> assignment (different base types)
> drivers/staging/wilc1000/host_interface.c:450:30:expected restricted
> __le16 [usertype] be
Thanks.
On 2/26/2019 12:55 PM, Bo YU wrote:
> Fix sparse warning:
>
> drivers/staging/wilc1000/host_interface.c:450:30: warning: incorrect type in
> assignment (different base types)
> drivers/staging/wilc1000/host_interface.c:450:30:expected restricted
> __le16 [usertype] beacon_period
> d
From: Ajay Singh
As discussed in [1] use put_unaligned_le16() & put_unaligned_le32()
helper to pack the data before sending to firmware.
[1].
https://lore.kernel.org/linux-wireless/86bc79ccd379497d56bade79ec8f717603110ef7.ca...@sipsolutions.net/
Signed-off-by: Ajay Singh
---
drivers/staging/
Hi Dan,
On 8/8/2019 4:18 PM, Dan Carpenter wrote:
>
> Hello Ajay Singh,
>
> The patch 9bc061e88054: "staging: wilc1000: added support to
> dynamically add/remove interfaces" from Jun 26, 2019, leads to the
> following static checker warning:
>
> drivers/staging/wilc1000/wilc_wlan.c:497 wi
Hi Eugen,
On 04-Sep-19 7:03 PM, Eugen Hristev - M18282 wrote:
> From: Eugen Hristev
>
> Add bindings for optional rtc clock pin.
>
> Signed-off-by: Eugen Hristev
Thanks for sending the patch series. The changes in this series looks
good to me.
Acked-by: Ajay Singh
Regards,
Ajay
> ---
>
Hi Greg,
On 05-Sep-19 1:07 PM, Greg KH wrote:
> On Thu, Sep 05, 2019 at 06:09:43AM +, ajay.kat...@microchip.com wrote:
>> Hi Eugen,
>>
>> On 04-Sep-19 7:03 PM, Eugen Hristev - M18282 wrote:
>>> From: Eugen Hristev
>>>
>>> Add bindings for optional rtc clock pin.
>>>
>>> Signed-off-by: Eugen H
From: Ajay Singh
The IRQ handler(isr_bh_routine()) was called twice for each interrupt
from firmware. The data was read completely during the first call and
the second call was doing nothing.
Now changed the IRQ flag from ‘level’ to ‘edge’ trigger i.e
IRQF_TRIGGER_LOW to IRQF_TRIGGER_FALLING to a
From: Ajay Singh
Remove interrupt handling for unused interrupt status(PLL update and
Sleep). The firmware only initiates the interrupt for the data transfer
to host and rest are not used anymore.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c | 26 -
From: Ajay Singh
Removed unnecessary check to compare vif interface with zeroth index
element in vif array. Already the caller takes care of passing the
appropriate netdev handler during the del key operation.
Signed-off-by: Ajay Singh
---
.../staging/wilc1000/wilc_wfi_cfgoperations.c | 33 +++
From: Ajay Singh
Move deinitialization of lock during the module remove and the
initialization of lock wilc_cfg80211_init(). This to ensure locks are
available during module load and gets free during unload.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_netdev.c| 14 +
From: Ajay Singh
Make use of RCU list to maintain virtual interfaces instead of an array.
The update operation on 'vif' list is less compare to the read
operations. Mostly the 'vif' list elements are accessed for the read
operation, so RCU list is more suited for this requirement.
The shifting of
From: Ajay Singh
During concurrent mode(AP/STA + P2P), pass the mgmt frames received from
firmware to appropriate interface. Iterate the complete interface list
to pass frames on the interface which has registered to receive mgmt
frame. Added extra time for 'remain_on_ch' timer to ensure that tim
From: Ajay Singh
Remove 'wilc_' prefix from filenames, the driver is already present
inside the 'wilc1000' directory so no need to add 'wilc_' in
filenames.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/Makefile | 8
.../wilc1000/{wilc_wfi_cfgoperation
From: Ajay Singh
This patch series contains changes to address some of the review
comments received during full driver review [1]. Mainly the changes
are related to files rename and comments formatting.
1. https://www.spinics.net/lists/linux-wireless/msg191489.html
Ajay Singh (6):
staging: wi
From: Ajay Singh
Added defines for different types of messages received from firmware.
Removed the unnecessary comments because after the addition of macros
the message types are self-explanatory.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wlan_cfg.c | 20 +---
1 fi
From: Ajay Singh
Use 'WILC_' prefix in header guard to follow the proper naming
convention for macro name.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/cfg80211.h | 4 ++--
drivers/staging/wilc1000/hif.h | 4 ++--
drivers/staging/wilc1000/netdev.h | 4 ++--
3 files changed, 6
From: Ajay Singh
Added proper space for the comments and added newline before the
comments inside a struct.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/mon.c | 2 +-
drivers/staging/wilc1000/netdev.h | 19 ++-
drivers/staging/wilc1000/wlan.h | 2 +-
driv
From: Ajay Singh
Use 'u8' instead of 'bool' datatype for struct element sent to firmware
because storage of bool datatype is not guaranteed.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_hif.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/stagi
From: Ajay Singh
Replace C++ style comment with C style.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/hif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/hif.c b/drivers/staging/wilc1000/hif.c
index 25f035c02b10..5f6706bcedf6 100644
---
From: Ajay Singh
Do not copy the extended supported rates in 'param->supp_rates' if the
array is already full with basic rates values. The array size check
helped to avoid possible illegal memory access [1] while copying to
'param->supp_rates' array.
1. https://marc.info/?l=linux-next&m=15730172
From: Ajay Singh
Moved the handling of p2p related operation in the caller context instead
of using workqueue.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 46 ---
1 file changed, 17 insertions(+), 29 deletions(-)
diff --git a/drivers/s
From: Ajay Singh
Cleanup patch to remove the passing of driver handler, get the 'idx'
value inside the called function.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 116 ++
drivers/staging/wilc1000/wilc_wlan.c | 3 +-
drivers/stag
From: Ajay Singh
Cleanup patch to avoid loop to traverse the interfaces instead make use
of vif received from net_device priv data.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 7 +--
drivers/staging/wilc1000/wilc_netdev.c| 16 +---
2 files cha
From: Ajay Singh
Remove use of 'src_addr' element in wilc_vif, as the same information
already copied to net_device->dev_addr.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_netdev.c| 3 +--
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
drivers/staging/wilc
From: Ajay Singh
This patch series mainly contains the changes to support the
add/delete of wlan0/p2p0 network interfaces dynamically. The driver
will be loaded with a single default interface and later new interfaces
can be added or removed.
Also included few cleanup patches in this series.
Aja
From: Ajay Singh
For the error path in wilc_wlan_initialize(), the resources are not
cleanup in the correct order. Reverted the previous changes and use the
correct order to free during error condition.
Fixes: b46d68825c2d ("staging: wilc1000: remove COMPLEMENT_BOOT")
Cc:
Signed-off-by: Ajay Si
From: Ajay Singh
Rename 'host_interface' source and header file to include the 'wilc_'
prefix in its name.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/Makefile | 2 +-
drivers/staging/wilc1000/{host_interface.c => wilc_hif.c} | 0
drivers/staging/wilc1000/{ho
From: Ajay Singh
Removed the use of two hardcoded interfaces and added support to
add/remove the network interfaces dynamically.
Now the driver will have single default interface with name 'wlan0' and
later other interface can be added from user space application e.g
using 'iw add' command.
Also
From: Ajay Singh
Removed the 'driver_handler_id' & 'ifc_id' elements and used 'idx' to
identify the handler.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 3 +--
drivers/staging/wilc1000/host_interface.h | 1 -
drivers/staging/wilc1000/wilc_netdev.c
On 7/19/2019 1:40 PM, Chuhong Yuan wrote:
>
> Merge the combo use of memcpy and le32_to_cpus.
> Use get_unaligned_le32 instead.
> This simplifies the code.
>
> Signed-off-by: Chuhong Yuan
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +--
> 1 file changed, 1 insertion(+), 2 dele
On 7/19/2019 5:16 PM, Chuhong Yuan wrote:
>
> 于2019年7月19日周五 下午7:34写道：
>>
>> On 7/19/2019 1:40 PM, Chuhong Yuan wrote:
>>>
>>> Merge the combo use of memcpy and le32_to_cpus.
>>> Use get_unaligned_le32 instead.
>>> This simplifies the code.
>>>
>>> Signed-off-by: Chuhong Yuan
>>> ---
>>> driver
From: Ajay Singh
The patch series contains changes to address the below code review
comments -
1/ Avoid use of infinite loops.
2/ Use separate header file to keep firmware related 'struct'.
3/ Remove unused code.
Ajay Singh (4):
staging: wilc1000: remove use of infinite loop conditions
s
From: Ajay Singh
The firmware now uses throughput enhancement code by default for SPI so
remove the previous implementation as its not used anymore. Removed the
use of 'has_thrpt_enh' element as its always true.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/spi.c | 143 +--
From: Ajay Singh
Avoid the use of 'while (1)' infinite loop conditions. It's not
recommended to have infinite loop in kernel code because a small bug can
cause never ending loops so use terminator condition as suggested in
full driver review [1].
[1].
https://lore.kernel.org/linux-wireless/2019
From: Ajay Singh
Use 'wilc_' prefix for 'assoc_resp' struct to have proper naming
convention.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/fw.h | 2 +-
drivers/staging/wilc1000/hif.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/fw.h
From: Ajay Singh
It's recommended to keep the 'struct' used for passing data to firmware
in separate header file. So added 'fw.h' header file to keep struct's
used to pass data to firmware.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/fw.h | 119 +
dr
From: Ajay Singh
In wilc_wlan_handle_txq(), mutex unlock was called without acquiring
it. Also error code for full VMM condition was incorrect as discussed in
[1]. Now used a proper code to indicate VMM is full, for which transfer
to VMM is required again. 'wilc_wlan_handle_txq()' should be calle
From: Ajay Singh
Some of the HIF layer API's return zero for failure and non-zero for
success condition. Now, modified the functions to return zero for success
and non-zero for failure as its recommended approach suggested in [1].
1.
https://lore.kernel.org/driverdev-devel/20191113183322.a54mh2
Hi Dan,
On 27/01/20 1:07 pm, Dan Carpenter wrote:
>
> Looks good.
>
> Reviewed-by: Dan Carpenter
>
> On Thu, Jan 23, 2020 at 12:50:47PM +, ajay.kat...@microchip.com wrote:
>> @@ -384,19 +378,18 @@ static int wilc_sdio_write_reg(struct wilc *wilc, u32
>> addr, u32 data)
>> cm
From: Ajay Singh
Refactor SPI commands handling by making use of 'struct' for data
exchange and extraction of information flow between host and firmware.
The SPI read/write commands are now handled in separate function instead
of using a single function to process all types of command.
The use of
From: Ajay Singh
Refactor handling of P2P specific action frames. Make use of 'struct' to
handle the P2P frames instead of manipulating using 'buf' pointer.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/cfg80211.c | 298
1 file changed, 127 insertions(+),
From: Ajay Singh
The 'priv' handler is already present in 'vif' struct so directly fetch
its value from vif handler in wilc_handle_roc_expired().
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/hif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/w
From: Ajay Singh
Remove the use of vendor specific IE parameter to decide
p2p_GO/p2p_Client roles between two 'wilc' device. Previously p2p group
formation between two 'wilc' device make use of vendor IE for roles
decision. The role is decided based on the 'go_intent' value.
Signed-off-by: Ajay
Hi Dan,
On 11/02/20 12:21 pm, Dan Carpenter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On Mon, Feb 10, 2020 at 06:36:01PM +, ajay.kat...@microchip.com wrote:
>> + if (sta_ch == WILC_INVALID_CHANNEL)
>> + return;
>
From: Ajay Singh
Remove the use of vendor specific IE parameter to decide
p2p_GO/p2p_Client roles between two 'wilc' device. Previously p2p group
formation between two 'wilc' device make use of vendor IE for roles
decision. The role is decided based on the 'go_intent' value.
Signed-off-by: Ajay
From: Ajay Singh
Refactor handling of P2P specific action frames. Make use of 'struct' to
handle the P2P frames instead of manipulating using 'buf' pointer.
Signed-off-by: Ajay Singh
---
v2: corrected 'while' condition by adding 'struct' size as suggested by Dan.
drivers/staging/wilc1000/cfg
From: Ajay Singh
The 'priv' handler is already present in 'vif' struct so directly fetch
its value from vif handler in wilc_handle_roc_expired().
Signed-off-by: Ajay Singh
---
v2: No change
drivers/staging/wilc1000/hif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/d
Hi Greg,
On 12/02/20 12:48 am, Greg KH wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On Tue, Feb 11, 2020 at 09:57:10AM +, ajay.kat...@microchip.com wrote:
>> From: Ajay Singh
>>
>> Refactor handling of P2P specific action frames.
From: Ajay Singh
Refactor handling of P2P specific action frames. Make use of 'struct' to
handle the P2P frames instead of manipulating using 'buf' pointer.
Signed-off-by: Ajay Singh
---
[resending this patch as it failed to apply earlier]
drivers/staging/wilc1000/cfg80211.c | 300 ++
From: Ajay Singh
Simplified the code by making use of FIELD_GET/_PREP bitfield macro.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/cfg80211.c | 2 +-
drivers/staging/wilc1000/mon.c | 2 +-
drivers/staging/wilc1000/netdev.h | 2 --
drivers/staging/wilc1000/spi.c | 2 +-
From: Ajay Singh
Define macros for global as well as SPI/SDIO specific register to avoid
use of magic numbers.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/sdio.c | 7 ++-
drivers/staging/wilc1000/spi.c | 17 ---
drivers/staging/wilc1000/wlan.c | 83 +++-
From: Ajay Singh
Make use of a shorter name for 'hif' variable to avoid possible 80
character checkpatch warning while the replacing hardcoded value with
macros in chip_wakeup().
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wlan.c | 35 +++--
1 file change
From: Ajay Singh
Make use of MAX_NUM_INT existing macro to handle the maximum supported
interrupts count and removed MAX_NUN_INT_THRPT_ENH2 macro.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/sdio.c | 20 +++-
drivers/staging/wilc1000/wlan.h | 2 +-
2 files changed,
From: Ajay Singh
Instead of using hardcoded value for SDIO register address added the
macro for them.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/sdio.c | 77 +
drivers/staging/wilc1000/wlan.h | 36 +++
2 files changed, 76 insertions(+), 3
From: Ajay Singh
This patch series mainly contains changes to remove the magic value for
different registers and define the macros for constant numbers.
Also, it contains few patches to make use FIELD_GET/_PUT macro
to extract the bitfield element.
Ajay Singh (8):
staging: wilc1000: make use o
From: Ajay Singh
Use common function wilc_sdio_set_block_size() to set the block size for
SDIO.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/sdio.c | 51 +++--
1 file changed, 11 insertions(+), 40 deletions(-)
diff --git a/drivers/staging/wilc1000/sdio.c
From: Ajay Singh
Make use of 'ALIGN' macro to align the size data value.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/sdio.c | 34 ++---
drivers/staging/wilc1000/wlan.c | 4 +---
2 files changed, 3 insertions(+), 35 deletions(-)
diff --git a/drivers/stag
From: Ajay Singh
Make use of FIELD_PREP/FIELD_GET macro to refactor the interrupt
handling for SDIO.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/sdio.c | 98 -
drivers/staging/wilc1000/spi.c | 4 --
drivers/staging/wilc1000/wlan.h | 3 +
3 files ch
From: Ajay Singh
Possible double unlocking of 'wilc->hif_cs' mutex was identified by
smatch [1]. Removed the extra call to release_bus() in
wilc_wlan_handle_txq() which was missed in earlier commit fdc2ac1aafc6
("staging: wilc1000: support suspend/resume functionality").
[1].
https://lists.01.o
From: Ajay Singh
Use YAML schemas for wilc1000 DT binding documentations. Currently, the
files are present in '/drivers/staging/wilc1000/' but these will be
moved to '/Documentation/devicetree/bindings/net/wireless/' later once
the driver move out-of-staging.
Signed-off-by: Ajay Singh
---
.../
From: Ajay Singh
Moved '/drivers/staging/wilc1000//microchip,wilc1000,spi.yaml' to
'Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,spi.yaml'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip,wilc1000,spi.yaml | 61 +++
1 file changed, 61 insertions(+
From: Ajay Singh
Moved 'drivers/staging/wilc1000/cfg80211.h' to
'drivers/net/wireless/microchip/wilc1000/cfg80211.h'.
Signed-off-by: Ajay Singh
---
.../wireless/microchip/wilc1000/cfg80211.h| 29 +++
1 file changed, 29 insertions(+)
create mode 100644 drivers/net/wireless/
From: Ajay Singh
Moved '/drivers/staging/wilc1000/microchip,wilc1000,sdio.yaml' to
'Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip,wilc1000,sdio.yaml | 68 +++
1 file changed, 68 insertions(
From: Ajay Singh
Moved 'drivers/staging/wilc1000/sdio.c' to
'drivers/net/wireless/microchip/wilc1000/sdio.c'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip/wilc1000/sdio.c| 1030 +
1 file changed, 1030 insertions(+)
create mode 100644 drivers/net/wireless/microc
From: Ajay Singh
Moved 'drivers/staging/wilc1000/hif.c' to
'drivers/net/wireless/microchip/wilc1000/hif.c'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/microchip/wilc1000/hif.c | 1959 +
1 file changed, 1959 insertions(+)
create mode 100644 drivers/net/wireless/microchi
From: Ajay Singh
Moved 'drivers/staging/wilc1000/wlan_cfg.c' to
'drivers/net/wireless/microchip/wilc1000/wlan_cfg.c'.
Signed-off-by: Ajay Singh
---
.../wireless/microchip/wilc1000/wlan_cfg.c| 413 ++
1 file changed, 413 insertions(+)
create mode 100644 drivers/net/wireless
From: Ajay Singh
Moved 'drivers/staging/wilc1000/fw.h' to
'drivers/net/wireless/microchip/wilc1000/fw.h'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/microchip/wilc1000/fw.h | 119 +++
1 file changed, 119 insertions(+)
create mode 100644 drivers/net/wireless/microchip/w
From: Ajay Singh
Moved 'drivers/staging/wilc1000/spi.c' to
'drivers/net/wireless/microchip/wilc1000/spi.c'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/microchip/wilc1000/spi.c | 1001 +
1 file changed, 1001 insertions(+)
create mode 100644 drivers/net/wireless/microchi
From: Ajay Singh
Moved 'drivers/staging/wilc1000/wlan_if.h' to
'drivers/net/wireless/microchip/wilc1000/wlan_if.h'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip/wilc1000/wlan_if.h | 803 ++
1 file changed, 803 insertions(+)
create mode 100644 drivers/net/wireless/m
From: Ajay Singh
Moved 'drivers/staging/wilc1000/mon.c' to
'drivers/net/wireless/microchip/wilc1000/mon.c'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/microchip/wilc1000/mon.c | 260 ++
1 file changed, 260 insertions(+)
create mode 100644 drivers/net/wireless/microchip
From: Ajay Singh
Moved 'drivers/staging/wilc1000/hif.h' to
'drivers/net/wireless/microchip/wilc1000/hif.h'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/microchip/wilc1000/hif.h | 214 ++
1 file changed, 214 insertions(+)
create mode 100644 drivers/net/wireless/microchip
101 - 200 of 311 matches
Mail list logo
