[PATCH] Staging: Media: sn9c102: Fixed a pointer declaration coding style issue

Fixed the ERROR thrown off by checkpatch.pl. Signed-off-by: Chaitanya Hazarey --- drivers/staging/media/sn9c102/sn9c102_tas5130d1b.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/media/sn9c102/sn9c102_tas5130d1b.c b/drivers/staging/media

Re: [PATCH] Staging: Media: sn9c102: Fixed a pointer declaration coding style issue

Hey Dan, Sorry my bad, will resubmit the patch in a proper manner with the required corrections. Thanks for looking into this. Thanks, Chaitanya On Fri, May 23, 2014 at 12:10 AM, Dan Carpenter wrote: > On Thu, May 22, 2014 at 04:11:38PM -0700, Chaitanya wrote: >> Fixed the ERROR t

[PATCH] Staging: xgifb: Fixed a code-style warning

Added a blank line after declarations to fix the following warning issued by checkpatch.pl: drivers/staging/xgifb/vb_init.c:800: WARNING: Missing a blank line after declarations Signed-off-by: Chaitanya Hazarey --- drivers/staging/xgifb/vb_setmode.c |1 + 1 file changed, 1 insertion

[PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings

-off-by: Chaitanya Hazarey --- drivers/staging/silicom/bypasslib/bypass.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/silicom/bypasslib/bypass.c b/drivers/staging/silicom/bypasslib/bypass.c index a58251f..8e714a8 100644 --- a/drivers/staging/silicom/bypasslib/bypass.c

[PATCH] Staging: Silicom: bpctl_mod.c: Fixed a lot of checkpatch.pl warnings

Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations --- drivers/staging/silicom/bpctl_mod.c | 90 ++- 1 file changed, 88 insertions(+), 2 deletions(-) diff -

[PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Fixed a lot of checkpatch.pl warnings

: Chaitanya Hazarey --- drivers/staging/silicom/bpctl_mod.c| 92 +++- drivers/staging/silicom/bypasslib/bypass.c |2 + 2 files changed, 91 insertions(+), 3 deletions(-) diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c index

Re: [PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings

Hey Dan, Thanks for your patience, I have resubmitted via a new email. Hope that works. Thanks, Chaitanya On Fri, May 23, 2014 at 3:54 PM, Dan Carpenter wrote: > On Fri, May 23, 2014 at 02:39:43PM -0700, Chaitanya Hazarey wrote: >> Added a blank line after declarations to fix the

Re: [PATCH] Staging: Silicom: bpctl_mod.c: Fixed a lot of checkpatch.pl warnings

Forgot to add - what went wrong - I had deleted some whitespaces which made the git apply mad. Thanks, Chaitanya On Fri, May 23, 2014 at 10:32 PM, Chaitanya Hazarey wrote: > Thanks Greg for looking into it, > > I have resubmitted using a new email, hope that works out. &

Re: [PATCH] Staging: Silicom: bpctl_mod.c: Fixed a lot of checkpatch.pl warnings

Thanks Greg for looking into it, I have resubmitted using a new email, hope that works out. Thanks, Chaitanya On Fri, May 23, 2014 at 3:26 PM, Greg KH wrote: > On Fri, May 23, 2014 at 02:47:10PM -0700, Chaitanya Hazarey wrote: >> Added a blank line after declarations in many places t

[PATCH] Staging: rtl8192u: r819xU_firmware_img.c Fixed checkpatch.pl ERRORs

Fixed a lot of errors of the type "ERROR: space required after that ',' (ctx:VxV)" Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r819xU_firmware_img.c | 1036 1 file changed, 518 insertions(+), 518 deletions(-) diff --git a/driv

[PATCH] Staging: rtl8192u: r819xU_firmware_img.c Fixed checkpatch.pl ERRORs

Fixed a lot of errors of the type "ERROR: space required after that ',' (ctx:VxV)" Added tabs at the beginning of line. Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r819xU_firmware_img.c | 1042 1 file changed, 521 insertio

Re: [PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Fixed a lot of checkpatch.pl warnings

Sorry Greg, this is taking so long, will make this against your tree and send it out. Thanks for looking into this, Chaitanya On Sun, May 25, 2014 at 11:03 AM, Greg KH wrote: > On Fri, May 23, 2014 at 10:25:28PM -0700, Chaitanya Hazarey wrote: >> Added a blank line after declaration

[PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Fixed a lot of checkpatch.pl warnings

Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations Lets see if this works now, this patch is prepared against Greg's staging tree. Signed-off-by: Chaitanya Hazarey --- drivers/st

Re: [PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Fixed a lot of checkpatch.pl warnings

OK sure, will do Dan. Greg, the patch has some issues, I did sync to your staging-next branch and am having issues applying it. Will send an update when i am able to do it. Thanks, Chaitanya On Sun, May 25, 2014 at 3:30 PM, Dan Carpenter wrote: > Since you're redoing this one anyway

[PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines

this patch. Signed-off-by: Chaitanya Hazarey --- drivers/staging/silicom/bpctl_mod.c| 88 +++- drivers/staging/silicom/bypasslib/bypass.c |2 + 2 files changed, 88 insertions(+), 2 deletions(-) diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/st

Re: [PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines

On its way. Chaitanya On Sun, May 25, 2014 at 5:51 PM, Greg KH wrote: > On Sun, May 25, 2014 at 05:36:58PM -0700, Chaitanya Hazarey wrote: >> Added a blank line after declarations in many places to fix the following >> warning issued by checkpatch.pl: > > Always wrap you

[PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines

Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations Signed-off-by: Chaitanya Hazarey --- drivers/staging/silicom/bpctl_mod.c| 88 +++- drivers/staging

[PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

hibited before that close parenthesis ')' WARNING: suspect code indent for conditional statements (16, 16) WARNING: __func__ should be used instead of gcc specific __FUNCTION__ Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8180_93cx6.c | 58 ++--- drivers/stag

Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

Please ignore this. Chaitanya On Mon, May 26, 2014 at 10:32 PM, Chaitanya Hazarey wrote: > Fixed the following: > > WARNING: line over 80 characters > ERROR: do not use C99 // comments > ERROR: else should follow close brace '}' > ERROR: space required after that

[PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

(ctx:VxV) ERROR: that open brace { should be on the previous line ERROR: trailing statements should be on next line WARNING: Missing a blank line after declarations WARNING: missing space after struct definition WARNING: please, no spaces at the start of a line WA

Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

Hey there, Thanks for looking into this, Will be sending out the modified version soon. Thanks, Chaitanya On Mon, May 26, 2014 at 11:56 PM, DaeSeok Youn wrote: > Hi, > > 2014-05-27 14:43 GMT+09:00 Chaitanya Hazarey : >> Fixed the following: >> >> ERROR: do not u

[PATCH 1/6] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

spaces required around that '<' (ctx:VxV) ERROR: space required after that close brace '}' ERROR: spaces required around that '==' (ctx:VxV) ERROR: space required before the open parenthesis '(' Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r

[PATCH 2/6] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

e ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that close parenthesis ')' WARNING: missing space after struct definition WARNING: Missing a blank line after declarations WARNING: please, no spaces at the start of a line WARNING: suspect cod

[PATCH 3/6] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

e ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that close parenthesis ')' WARNING: missing space after struct definition WARNING: Missing a blank line after declarations WARNING: please, no spaces at the start of a line WARNING: suspect cod

[PATCH 5/6] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

e ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that close parenthesis ')' WARNING: missing space after struct definition WARNING: Missing a blank line after declarations WARNING: please, no spaces at the start of a line WARNING: suspect cod

[PATCH 4/6] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

e ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that close parenthesis ')' WARNING: missing space after struct definition WARNING: Missing a blank line after declarations WARNING: please, no spaces at the start of a line WARNING: suspect cod

[PATCH 6/6] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

e ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that close parenthesis ')' WARNING: missing space after struct definition WARNING: Missing a blank line after declarations WARNING: please, no spaces at the start of a line WARNING: suspect cod

Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

Hey DaeSeok, I fixed all of them except - this "if" condition like below: if (5 == wrqu->encoding.length || 13 == wrqu->encoding.length) mask = 0x00; and this should be outside "for" loop Can you please elaborate on this? Thanks, Chaitanya On Mon, May 26, 2014

Re: [PATCH 1/6] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

Well, it is what it is, will send the patch the right way. Best, Chaitanya On Tue, May 27, 2014 at 1:39 PM, Dan Carpenter wrote: > On Tue, May 27, 2014 at 01:09:45PM -0700, Chaitanya Hazarey wrote: >> Fixed the following: >> >> ERROR: do not use C99 // comments >>

[PATCH] Staging: rtl8192u: r8180_93cx6.c Added missing spaces

ace required before the open parenthesis '(' ERROR: spaces required around that '<' (ctx:VxV) ERROR: spaces required around that '=' (ctx:VxV) ERROR: spaces required around that '==' (ctx:VxV) Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r

[PATCH 1/2] Staging: rtl8192u: r8192U_wx.c Added missing spaces

ibited before that '--' (ctx:WxO) ERROR: space prohibited before that close parenthesis ')' ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 146 +-- 1

[PATCH 2/2] Staging: rtl8192u: r8192U_wx.c Added {} braces and newlines

open brace { should be on the previous line Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 84 1 file changed, 46 insertions(+), 38 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c

[PATCH 2/2] Staging: rtl8192u: r8192U_wx.c Code cleanup and code-style additions

Removed dead code Deleted stray newlines Added newlines for better code readability Addressed the following errors: ERROR: do not use C99 // comments ERROR: need consistent spacing around '|' (ctx:VxW) Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_

[PATCH 1/2] Staging: rtl8192u: r8192U_wx.c Fixed misplaced brace

Fixed a misplaced brace in a function Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c index 1af7c5d..675a12d 100644 --- a

Re: [PATCH 1/2] Staging: rtl8192u: r8192U_wx.c Fixed misplaced brace

Please ignore this patch, there seems something wrong with it, will resend with a new subject. Thanks, Chaitanya On Wed, May 28, 2014 at 4:17 PM, Chaitanya Hazarey wrote: > Fixed a misplaced brace in a function > > Signed-off-by: Chaitanya Hazarey > --- > drivers/staging/rtl81

Re: [PATCH 2/2] Staging: rtl8192u: r8192U_wx.c Code cleanup and code-style additions

Please ignore this patch, there seems something wrong with it, will resend with a new subject. Thanks, Chaitanya On Wed, May 28, 2014 at 4:17 PM, Chaitanya Hazarey wrote: > Removed dead code > Deleted stray newlines > Added newlines for better code readability > > Addresse

[PATCH 2/2] Staging: rtl8192u: r8192U_wx.c Various Code cleanups and code-style additions

Removed dead code Deleted stray newlines Added newlines for better code readability Addressed the following errors: ERROR: do not use C99 // comments ERROR: need consistent spacing around '|' (ctx:VxW) Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_

[PATCH 1/2] Staging: rtl8192u: r8192U_wx.c Fixed a misplaced brace

Fixed a misplaced brace in a function Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c index 1af7c5d..675a12d 100644 --- a

Re: [PATCH 2/2] Staging: rtl8192u: r8192U_wx.c Various Code cleanups and code-style additions

ok will send a new one out soon. Thanks for looking into this and sorry about the repetition. Chaitanya On Wed, May 28, 2014 at 4:36 PM, Greg KH wrote: > On Wed, May 28, 2014 at 04:23:48PM -0700, Chaitanya Hazarey wrote: >> Removed dead code >> Deleted stray newlines >&g

[PATCH 3/5] Staging: rtl8192u: r8192U_wx.c Removed C99 comments

To address the error - ERROR: do not use C99 // comments Removed all C99 comments. Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 130 +-- 1 file changed, 65 insertions(+), 65 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH 2/5] Staging: rtl8192u: r8192U_wx.c removed dead code

Removed dead code, commented out printks and DMESG. Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c index 675a12d..7dc2a96 100644

[PATCH 5/5] Staging: rtl8192u: r8192U_wx.c Removed commented out dead code

Removed dead code from the file. Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c index 09b1e81..f2c970e 100644 --- a/drivers

[PATCH 4/5] Staging: rtl8192u: r8192U_wx.c Added a space for code-style issue

Added a space around '|' to address: ERROR: need consistent spacing around '|' (ctx:VxW) Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.

[PATCH 1/5] Staging: rtl8192u: r8192U_wx.c Fixed a misplaced brace

Fixed a misplaced brace in the r8192_wx_set_scan_type function. Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c index

Re: [PATCH 5/5] Staging: rtl8192u: r8192U_wx.c Removed commented out dead code

Ok I will edit PATCH[5/5] and resend. On Thu, May 29, 2014 at 2:54 AM, Dan Carpenter wrote: > On Wed, May 28, 2014 at 09:49:21PM -0700, Chaitanya Hazarey wrote: >> static iw_handler r8192_private_handler[] = { >> - /* r8192_wx_set_monitor, */ /*

[PATCH 5/5] Staging: rtl8192u: r8192U_wx.c Removed commented out dead code

Removed dead code from the file. Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c index 09b1e81..ceb06d8

[PATCH 1/5] Staging: rtl8192u: r8192U_wx.c Fixed a misplaced brace

Fixed a misplaced brace in the r8192_wx_set_scan_type function. Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c index

[PATCH 3/5] Staging: rtl8192u: r8192U_wx.c Removed C99 comments

To address the error - ERROR: do not use C99 // comments Removed all C99 comments. Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 130 +-- 1 file changed, 65 insertions(+), 65 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH 4/5] Staging: rtl8192u: r8192U_wx.c Added a space for code-style issue

Added a space around '|' to address: ERROR: need consistent spacing around '|' (ctx:VxW) Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.

[PATCH 2/5] Staging: rtl8192u: r8192U_wx.c removed dead code

Removed dead code, commented out printks and DMESG. Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c index 675a12d..7dc2a96 100644

Re: [PATCH 1/2] Staging: rtl8192u: r8192U_wx.c Fixed a misplaced brace

I have 1/5 through to 5/5. Will resend rightaway with slightly changed subjects. Chaitanya On Thu, May 29, 2014 at 1:43 PM, Greg KH wrote: > On Wed, May 28, 2014 at 04:23:47PM -0700, Chaitanya Hazarey wrote: >> Fixed a misplaced brace in a function >> >> Signed-off-

[PATCH 1/5] Staging: rtl8192u: r8192U_wx.c Fixed one misplaced brace

Fixed a misplaced brace in the r8192_wx_set_scan_type function. Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c index

[PATCH 2/5] Staging: rtl8192u: r8192U_wx.c removed commented dead code

Removed dead code, commented out printks and DMESG. Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c index 675a12d..7dc2a96 100644

[PATCH 4/5] Staging: rtl8192u: r8192U_wx.c Added a single space for code-style issue

Added a space around '|' to address: ERROR: need consistent spacing around '|' (ctx:VxW) Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.

[PATCH 5/5] Staging: rtl8192u: r8192U_wx.c Removed commented dead code

Removed dead code from the file. Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c index 09b1e81..ceb06d8

[PATCH 3/5] Staging: rtl8192u: r8192U_wx.c Removed all C99 comments

To address the error - ERROR: do not use C99 // comments Removed all C99 comments. Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 130 +-- 1 file changed, 65 insertions(+), 65 deletions(-) diff --git a/drivers/staging/rtl8192u

Re: [PATCH 1/2] Staging: rtl8192u: r8192U_wx.c Fixed a misplaced brace

Ok will be quite for till the last ones get accepted. Sorry for the bother ! Chaitanya On Thu, May 29, 2014 at 2:41 PM, Dan Carpenter wrote: > On Thu, May 29, 2014 at 02:00:51PM -0700, Greg KH wrote: >> On Thu, May 29, 2014 at 01:43:01PM -0700, Chaitanya Hazarey wrote: >> >

[PATCH 1/4] Staging: rtl8192u: r8192U_wx.c removed some dead code

Removed dead code, commented out printks and DMESG. Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c index 675a12d..7dc2a96 100644

[PATCH 3/4] Staging: rtl8192u: r8192U_wx.c Added a single space for code-style issue

Added a space around '|' to address: ERROR: need consistent spacing around '|' (ctx:VxW) Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.

[PATCH 4/4] Staging: rtl8192u: r8192U_wx.c Removed some more commented out dead code

Removed dead code from the file. Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c index 09b1e81..ceb06d8

[PATCH 2/4] Staging: rtl8192u: r8192U_wx.c Removed all C99 comments

To address the error - ERROR: do not use C99 // comments Removed all C99 comments. Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 130 +-- 1 file changed, 65 insertions(+), 65 deletions(-) diff --git a/drivers/staging/rtl8192u

Re: [PATCH 2/4] Staging: rtl8192u: r8192U_wx.c Removed all C99 comments

On Tue, Jun 3, 2014 at 11:36 AM, Dan Carpenter wrote: > It always feels much better after the dead code is gone. So patches are still good ? No change required for my side, right ? I just need to wait for Greg's needle to come to this point and pick them up. Best, C

Re: [PATCH 2/4] Staging: rtl8192u: r8192U_wx.c Removed all C99 comments

On Tue, Jun 3, 2014 at 2:42 PM, Greg KH wrote: > So keep working on things, > these aren't lost, I'll get to them in a few weeks. > Ok will do, Chaitanya ___ devel mailing list de...@linuxdriverproject.org http://driverdev.lin

[PATCH 2/3] Staging: rtl8192u: r8192U_core.c Rearranged statements to fix code-style errors

Rearranged statements around if and switch statements to address the following error: ERROR: trailing statements should be on next line Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_core.c | 553 - 1 file changed, 402 insertions(+), 151

[PATCH 1/3] Staging: rtl8192u: r8192U_core.c Added a space after ','

Added spaces after ',' to fix the following warning: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_core.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/driv

[PATCH 3/3] Staging: rtl8192u: r8192U_core.c Converted some C99 comments to fix code-style errors

Converted some C99 warnings to fix the following error: ERROR: trailing statements should be on next line Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_core.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers

[PATCH 2/2] Staging: rtl8192u: r8192U_core.c Converted a C99 comment to fix code-style error

Converted a C99 comment to fix the following error: ERROR: trailing statements should be on next line Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b

[PATCH 1/2] Staging: rtl8192u: r8192U_core.c Fixed open brace { placement

Fixed open brace placement to address the following code-style errors: ERROR: that open brace { should be on the previous line Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_core.c | 69 -- 1 file changed, 23 insertions(+), 46 deletions

[PATCH 2/3] Staging: rtl8192u: r8192U_wx.c Fixed some more code-style warnings about spaces

Fixed the following warnings issued by checkpatch.pl WARNING: please, no space before tabs Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging

[PATCH 1/3] Staging: rtl8192u: r8192U_wx.c Fixed code-style warnings

Fixed some of the following warning generated by checkpatch.pl: WARNING: Missing a blank line after declarations Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u

[PATCH 3/3] Staging: rtl8192u: r8192U_wx.c Fixed a code-style error about trailing whitespace

Fixed the following error reported by running checkpatch.pl ERROR: trailing whitespace Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u

[PATCH] Staging: netlogic: xlr_net.c Fixed code-style warnings

Fixed the following warning generated by checkpatch.pl: WARNING: Missing a blank line after declarations Signed-off-by: Chaitanya Hazarey --- drivers/staging/netlogic/xlr_net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic

[PATCH] Staging: rtl8188eu: Replaced kzalloc and memcpy combination with kmemdup

This change was detected with the help of coccinelle tool. It performs the same function as kzalloc amd memcpy. Signed-off-by: Chaitanya Dhere --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu

[PATCH] staging: rtl8192u: Modify if, else if conditions to remove unnecessary equality checks. This change was detected with the help of coccinelle tool.

Signed-off-by: Chaitanya Dhere Reply-To: --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c index

[PATCH] staging: rtl8192u: Patch to modify if, else conditions

detected with help of coccinelle tool. Signed-off-by: Chaitanya Dhere --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211

Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions

On Sun, May 31, 2015 at 10:38:18AM +0900, gre...@linuxfoundation.org wrote: > On Tue, May 19, 2015 at 04:55:57PM +, Dhere, Chaitanya (C.) wrote: > > In this patch: > > 1. the if condition is modified to remove > > the unnecessary equality check. > > 2. The else if

[PATCH v2 1/2] staging: rtl8192u: Patch to modify if, else conditions

From: Chaitanya Dhere In this patch, the if, else conditions are modified to remove the unnecessary equality checks. This change was detected with help of coccinelle tool. Signed-off-by: Chaitanya Dhere --- .../staging/rtl8192u/ieee80211/ieee80211_softmac.c |6 ++ 1 file changed, 2

[PATCH v2 2/2] staging: rtl8192u: Fix indentation issue

From: Chaitanya Dhere This change was detected with help of coccinelle tool. Signed-off-by: Chaitanya Dhere --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions

On Sun, May 31, 2015 at 10:38:18AM +0900, gre...@linuxfoundation.org wrote: > On Tue, May 19, 2015 at 04:55:57PM +, Dhere, Chaitanya (C.) wrote: > > In this patch: > > 1. the if condition is modified to remove > > the unnecessary equality check. > > 2. The else if

[PATCH v3 1/2] staging: rtl8192u: Patch to modify if, else conditions

From: Chaitanya Dhere In this patch, the if, else conditions are modified to remove the unnecessary equality checks. This change was detected with help of coccinelle tool. Signed-off-by: Chaitanya Dhere --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c |6 ++ 1 file changed

[PATCH v3 2/2] staging: rtl8192u: Fix indentation issue

From: Chaitanya Dhere This change was detected with help of checkpatch.pl script. Signed-off-by: Chaitanya Dhere --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH] staging: wilc1000: Modification in code to use ARRAY_SIZE macro

From: Chaitanya Dhere In this patch, ARRAY_SIZE() macro is used to determine the size. This change was detected with the help of coccinelle tool. Signed-off-by: Chaitanya Dhere --- drivers/staging/wilc1000/linux_wlan.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH] Staging: rtl8188eu: Replaced kzalloc and memcpy combination with kmemdup

This change was detected with the help of coccinelle tool. It performs the same function as kzalloc amd memcpy. Signed-off-by: Chaitanya Dhere --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu

[PATCH] staging: lustre: replace kzalloc with copy_from_user with memdup_user

This patch replaces kzalloc and copy_from_user with memdup_user call This change was detected with coccinelle tool Signed-off-by: Chaitanya Dhere --- drivers/staging/lustre/lustre/llite/file.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging