On 14/09/18 12:43, Alex Elder wrote:
> On 09/14/2018 06:24 AM, Colin King wrote:
>> From: Colin Ian King
>>
>> Trivial fix to spelling mistake
>
> I hate to have two-character fixes to documentation like this. I.e.,
> as long as you're touching the REA
ping?
On 22/12/2018 11:49, Colin King wrote:
> From: Colin Ian King
>
> The comparison css->pipes[pipe].bindex < 0 is always false because
> bindex is an unsigned int. Fix this by using a signed integer for
> the comparison.
>
> Detected by CoverityScan, CID#
On 03/02/2019 11:31, Dan Carpenter wrote:
> On Sat, Feb 02, 2019 at 10:56:27PM +, Colin King wrote:
>> From: Colin Ian King
>>
>> There is an earlier null check on pointer dev which implies it may be null,
>> however the assignment of pointer pref and the call to
On 11/03/2019 14:07, Dan Carpenter wrote:
> On Mon, Mar 11, 2019 at 10:14:05PM +0800, Mao Wenan wrote:
>> There is no need to have the 'T *v' variable static
>> since new value always be assigned before use it.
>>
>> Signed-off-by: Mao Wenan
>> ---
>> drivers/staging/media/davinci_vpfe/dm365_resi
Hi,
Static analysis with cppcheck found a couple of interesting issues with
memcpy'ing of an uninitialized variable. Two occurrences of the same
issue are found in drivers/staging/rtl8712/rtl8712_cmd.c in functions
read_bbreg_hdl and read_rfreg_hdl.
For example:
static u8 read_bbreg_hdl(struct _
Hi,
static analysis with cppcheck has detected use of an uninitialized array
tmp_ssid in drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c in
function ieee80211_softmac_new_net()
Array tmp_ssid is only initialized when ssidbroad is non-null, however
it is being copied and the copy of this is
On 19/03/2019 13:29, Greg Kroah-Hartman wrote:
> On Mon, Mar 18, 2019 at 09:32:59PM +, Jeremy Sowden wrote:
>> On 2019-03-18, at 10:57:49 +, Colin King wrote:
>>> The range check on auth_type is redundant as there is a prior
>>> check on the auth_type values and the only way the block is en
Hi,
Static analysis with Coverity Scan has detected a potential assignment
bug in ad5380.c:
217case IIO_CHAN_INFO_CALIBBIAS:
218ret = regmap_read(st->regmap,
AD5380_REG_OFFSET(chan->address),
219val);
220if (ret)
221
Hi,
Static analysis of linux-next picked up an issue with the following commit:
commit 8fc8598e61f6f384f3eaf1d9b09500c12af47b37
Author: Jerry Chuang
Date: Tue Nov 3 07:17:11 2009 -0200
Staging: Added Realtek rtl8192u driver to staging
In drivers/staging/rtl8192u/ieee80211/ieee80211_softm
Hi,
Static analysis on exfat with Coverity has picked up an assignment of
FFS_MEDIAERR that gets over-written:
1750if (is_dir) {
1751if ((fid->dir.dir == p_fs->root_dir) &&
1752(fid->entry == -1)) {
1753if (p_fs->dev_ejected)
On 05/09/2019 15:52, Dan Carpenter wrote:
> It would be better to remove "n" altogether.
Good point, will resend a V2 later.
>
> regards,
> dan carpenter
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mai
On 10/09/2019 13:44, Dan Carpenter wrote:
> On Fri, Aug 30, 2019 at 07:38:00PM +0100, Colin Ian King wrote:
>> Hi,
>>
>> Static analysis on exfat with Coverity has picked up an assignment of
>> FFS_MEDIAERR that gets over-written:
>>
>>
>> 1750
Hi,
static analysis with Coverity has detected an issues in the rtl8723bs
wifi driver:
File: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c in function
rtw_dbg_port():
CID 18480: Operands don't affect result (CONSTANT_EXPRESSION_RESULT)
dead_error_condition: The condition (extra_arg & 7U) > 7U c
On 17/06/2019 13:47, Colin King wrote:
> From: Colin Ian King
>
> Variable rtStatus is initialized with a value that is never read
> and later it is reassigned a new value. Hence the initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unus
Hi,
Static analysis with Coverity on Linux next has found a potential issue
with the following commit:
commit 3ef46bc97ca2c918b7657a08220c7340a9bb07a2
Author: Steve Longerbeam
Date: Fri May 10 17:50:11 2019 -0400
media: staging/imx: Improve pipeline searching
The issue is in drivers/sta
> Thanks,
>
> Marcus
>
>
> Am 09.11.2017 um 19:19 schrieb Colin King:
>> From: Colin Ian King
>>
>> The PI433_IOC_WR_RX_CFG case is missing a break and will fall through
>> to the default case and errorenously return -EINVAL. Fix this by
>>
On 05/09/18 11:06, Alexander Stein wrote:
> On Wednesday, September 5, 2018, 11:46:05 AM CEST Colin King wrote:
>> From: Colin Ian King
>>
>> Currently we have structrues comp (which is empty) and comp_info being
>> used to register and deregister the componen
On 12/04/18 16:12, Dan Carpenter wrote:
> This isn't right. It introduces a leak.
Yup, and I see Gustavo is working on a correct fix, I'll leave that to him.
>
> regards,
> dan carpenter
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a messa
Hi,
Static analysis via CoverityScan picked up an issue in
cmpk_handle_query_config_rx where the following operation on an u8 is
clearly not correct:
rx_query_cfg.cfg_action = (pmsg[4] & 0x8000) >> 31;
The result of this operation is always zero. I suspect this should be:
On 23/09/16 19:20, Vaibhav Agarwal wrote:
> On Fri, Sep 23, 2016 at 10:28 PM, Greg Kroah-Hartman
> wrote:
>> On Fri, Sep 23, 2016 at 11:25:40AM +0100, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> Currently, if info is null, the dev_err message is de
On 29/11/16 21:02, Greg Kroah-Hartman wrote:
> On Tue, Nov 29, 2016 at 08:37:35PM +, Kershner, David A wrote:
>>
>>
>>> -Original Message-
>>> From: Colin King [mailto:colin.k...@canonical.com]
>>> Sent: Tuesday, November 29, 2016 2:07 PM
>>> To: Kershner, David A ; Greg Kroah-Hartman
>
On 20/07/17 12:01, Wolf Entwicklungen wrote:
> Declare rf69_set_dc_cut_off_frequency_intern as static since it
> is used internaly only
>
> Fixes: 874bcba65f9a ("staging: pi433: New driver")
> Signed-off-by: Marcus Wolf
>
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
Oops, should have been marked as [V2] in the subject line
On 20/07/17 23:33, Colin King wrote:
> From: Colin Ian King
>
> The functions rf69_set_bandwidth_intern and also
> rf69_set_dc_cut_off_frequency_intern is local to the source and
> do not need to be in global scope, so
On 16/08/17 14:37, Laurentiu Tudor wrote:
> On 08/16/2017 03:06 PM, Dan Carpenter wrote:
>> On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> The previous fix removed the equal to zero comparisons by the strcmps and
On 08/09/17 14:52, Colin King wrote:
> From: Colin Ian King
>
> The call to _rtl_dbg_trace via macro HALMAC_RT_TRACE will trigger a null
> pointer deference on a null driver_adapter. Fix this by assigning
> driver_adapter earlier to halmac_adapter->driver_adapter before the
Hi,
CoverityScan detected a couple of issues, one of which was introduced
with the following commit:
commit 6106c0f82481e686b337ee0c403821fb5c3c17ef
Author: NeilBrown
Date: Thu Jan 11 15:06:40 2018 +1100
CoverityScan CID#1464078 ("Uninitialized scalar variable")
I'm not sure what the expecte
On 23/03/18 17:36, Colin King wrote:
> From: Colin Ian King
>
> The #define for __PHYDMKFREE_H__ is missing a character and is not
> the same as the guard check. Defined this correctly.
>
> Cleans up clang warning:
> warning: '__PHYDMKFREE_H__' is used as a h
On 26/03/18 16:35, Ajay Singh wrote:
> Thanks for submitting the patch.
>
> On Wed, 21 Mar 2018 13:03:18 -0700
> Joe Perches wrote:
>
>> On Wed, 2018-03-21 at 19:19 +, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> There are three kma
Hi,
Static analysis with Coverity has detected an uninitialized value being
used in a comparison. The error was detected on a recent change to
drivers/staging/greybus/audio_topology.c however the issue actually
dates back to the original commit:
commit 6339d2322c47f4b8ebabf9daf0130328ed72648b
Au
29 matches
Mail list logo
