of Hyper-V PCI driver's hv_compose_msi_msg().
Signed-off-by: Dexuan Cui
Cc: sta...@vger.kernel.org
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
---
drivers/hv/channel_mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/
I didn't really hit a bug, but just happened to notice the redundant line.
Signed-off-by: Dexuan Cui
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
Cc: sta...@vger.kernel.org
---
drivers/hv/hv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> From: Michael Kelley (EOSG)
> Sent: Saturday, March 3, 2018 08:10
> > From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Dexuan Cui
> > Sent: Friday, March 2, 2018 4:21 PM
> > When we hot-remove the device, we first receive a PCI_EJECT mes
Changes since v1 are:
Patch 1, 6: no change since v1.
Patch 2,4,5: I added these new patches, as suggested by Michael Kelley.
Patch 3: Removed the unnecessary drain_workqueue(), as suggested by Michael
Kelley.
Dexuan Cui (6):
PCI: hv: fix a comment typo in _hv_pcifront_read_config()
PCI
No functional change.
Signed-off-by: Dexuan Cui
Fixes: bdd74440d9e8 ("PCI: hv: Add explicit barriers to config space access")
Cc: Vitaly Kuznetsov
Cc: sta...@vger.kernel.org
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
---
drivers/pci/host/pci-hyperv.c | 2 +-
1 file changed, 1 inser
When we're in the function, hpdev->state must be hv_pcichild_ejecting:
see hv_pci_eject_device().
Signed-off-by: Dexuan Cui
Cc: Vitaly Kuznetsov
Cc: Jack Morgenstein
Cc: sta...@vger.kernel.org
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
Cc: Michael Kelley (EOSG)
---
drivers/pci/
Since we serialize the present/eject work items now, we don't need the
semaphore any more.
This is suggested by Michael Kelley.
Signed-off-by: Dexuan Cui
Cc: Vitaly Kuznetsov
Cc: Jack Morgenstein
Cc: sta...@vger.kernel.org
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
Cc: Michael Kelley
If there is a pending work, we just need to add the new dr into
the dr_list.
This is suggested by Michael Kelley.
Signed-off-by: Dexuan Cui
Cc: Vitaly Kuznetsov
Cc: Jack Morgenstein
Cc: sta...@vger.kernel.org
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
Cc: Michael Kelley (EOSG)
---
drivers
ing
list_del(&hpdev->list_entry), causing general protection fault, because
system_wq can run them concurrently.
The patch eliminates the race condition.
Signed-off-by: Dexuan Cui
Tested-by: Adrian Suhov
Tested-by: Chris Valean
Cc: Vitaly Kuznetsov
Cc: Jack Morgenstein
Cc: sta...@vger.ker
the PCI vendor ID.
Note: actually the above issues also happen to a SMP VM, if
"hbus->hdev->channel->target_cpu == smp_processor_id()" is true.
Signed-off-by: Dexuan Cui
Tested-by: Adrian Suhov
Tested-by: Chris Valean
Cc: sta...@vger.kernel.org
Cc: Stephen Hemminger
> From: Michael Kelley (EOSG)
> Sent: Monday, March 5, 2018 15:48
> > @@ -1756,11 +1757,23 @@ static void hv_pci_devices_present(struct
> hv_pcibus_device
> > *hbus,
> > }
> >
> > spin_lock_irqsave(&hbus->device_list_lock, flags);
> > +
> > + /*
> > +* If pending_dr is true, we have a
If there is a pending work, we just need to add the new dr into
the dr_list.
This is suggested by Michael Kelley.
Signed-off-by: Dexuan Cui
Cc: Vitaly Kuznetsov
Cc: Jack Morgenstein
Cc: sta...@vger.kernel.org
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
Cc: Michael Kelley (EOSG)
---
drivers
the PCI vendor ID.
Note: actually the above issues also happen to a SMP VM, if
"hbus->hdev->channel->target_cpu == smp_processor_id()" is true.
Signed-off-by: Dexuan Cui
Tested-by: Adrian Suhov
Tested-by: Chris Valean
Cc: sta...@vger.kernel.org
Cc: Stephen Hemminger
ing
list_del(&hpdev->list_entry), causing general protection fault, because
system_wq can run them concurrently.
The patch eliminates the race condition.
Signed-off-by: Dexuan Cui
Tested-by: Adrian Suhov
Tested-by: Chris Valean
Cc: Vitaly Kuznetsov
Cc: Jack Morgenstein
Cc: sta...@vger.ker
Since we serialize the present/eject work items now, we don't need the
semaphore any more.
This is suggested by Michael Kelley.
Signed-off-by: Dexuan Cui
Cc: Vitaly Kuznetsov
Cc: Jack Morgenstein
Cc: sta...@vger.kernel.org
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
Cc: Michael Kelley
No functional change.
Signed-off-by: Dexuan Cui
Fixes: bdd74440d9e8 ("PCI: hv: Add explicit barriers to config space access")
Cc: Vitaly Kuznetsov
Cc: sta...@vger.kernel.org
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
---
drivers/pci/host/pci-hyperv.c | 2 +-
1 file changed, 1 inser
Michael Kelley.
Dexuan Cui (6):
PCI: hv: fix a comment typo in _hv_pcifront_read_config()
PCI: hv: hv_eject_device_work(): remove the bogus test
PCI: hv: serialize the present/eject work items
PCI: hv: remove hbus->enum_sem
PCI: hv: hv_pci_devices_present(): only queue a new work w
When we're in the function, hpdev->state must be hv_pcichild_ejecting:
see hv_pci_eject_device().
Signed-off-by: Dexuan Cui
Cc: Vitaly Kuznetsov
Cc: Jack Morgenstein
Cc: sta...@vger.kernel.org
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
Cc: Michael Kelley (EOSG)
---
drivers/pci/
> From: Lorenzo Pieralisi
> Sent: Wednesday, March 7, 2018 04:35
> On Tue, Mar 06, 2018 at 06:21:56PM +0000, Dexuan Cui wrote:
> > 1. With the patch "x86/vector/msi: Switch to global reservation mode"
> > (4900be8360), the recent v4.15 and newer kernels always hang
> From: Dexuan Cui
> Sent: Wednesday, March 7, 2018 13:40
> To: Lorenzo Pieralisi
> Cc: bhelg...@google.com; linux-...@vger.kernel.org; KY Srinivasan
> ; Stephen Hemminger ;
> o...@aepfle.de; a...@canonical.com; jasow...@redhat.com; linux-
> ker...@vger.kernel
> From: Lorenzo Pieralisi
> Sent: Wednesday, March 14, 2018 04:50
> On Tue, Mar 13, 2018 at 06:23:39PM +0000, Dexuan Cui wrote:
>
> [...]
>
> > Hi Lorenzo, Bjorn, and all,
> > Do you need more ACKs? Currently Michael and Haiyang reviewed and ack'd
> >
omit
anything this time. :-)
Dexuan Cui (2):
PCI: hv: Serialize the present and eject work items
PCI: hv: Fix 2 hang issues in hv_compose_msi_msg()
drivers/pci/host/pci-hyperv.c | 75 ---
1 file changed, 71 insertions(+), 4 deletions(-)
--
MP VM, if
"hbus->hdev->channel->target_cpu == smp_processor_id()" is true.
Fixes: 4900be83602b ("x86/vector/msi: Switch to global reservation mode")
Tested-by: Adrian Suhov
Tested-by: Chris Valean
Signed-off-by: Dexuan Cui
Reviewed-by: Michael Kelley
Acked-by: Haiyan
ing
list_del(&hpdev->list_entry), causing general protection fault, because
system_wq can run them concurrently.
The patch eliminates the race condition.
Tested-by: Adrian Suhov
Tested-by: Chris Valean
Signed-off-by: Dexuan Cui
Reviewed-by: Michael Kelley
Acked-by: Haiyang Zhan
issues in changelog (I hope I have fixed all of them).
Dexuan Cui (4):
PCI: hv: Fix a comment typo in _hv_pcifront_read_config()
PCI: hv: Remove the bogus test in hv_eject_device_work()
PCI: hv: Remove hbus->enum_sem
PCI: hv: Only queue a new work in hv_pci_devices_present()
No functional change.
Fixes: bdd74440d9e8 ("PCI: hv: Add explicit barriers to config space access")
Signed-off-by: Dexuan Cui
Acked-by: Haiyang Zhang
Cc: Vitaly Kuznetsov
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
---
drivers/pci/host/pci-hyperv.c | 2 +-
1 file changed, 1 inser
Since we serialize the present/eject work items now, we don't need the
semaphore any more.
Signed-off-by: Dexuan Cui
Reviewed-by: Michael Kelley
Acked-by: Haiyang Zhang
Cc: Vitaly Kuznetsov
Cc: Jack Morgenstein
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
---
drivers/pci/host/pci-hyp
When we're in the function, hpdev->state must be hv_pcichild_ejecting:
see hv_pci_eject_device().
Signed-off-by: Dexuan Cui
Reviewed-by: Michael Kelley
Acked-by: Haiyang Zhang
Cc: Vitaly Kuznetsov
Cc: Jack Morgenstein
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
---
drivers/pci/
If there is a pending work, we just need to add the new dr into
the dr_list.
Signed-off-by: Dexuan Cui
Reviewed-by: Michael Kelley
Acked-by: Haiyang Zhang
Cc: Vitaly Kuznetsov
Cc: Jack Morgenstein
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
---
drivers/pci/host/pci-hyperv.c | 15
> From: Lorenzo Pieralisi
> Sent: Thursday, March 15, 2018 10:02
> On Thu, Mar 15, 2018 at 02:20:53PM +0000, Dexuan Cui wrote:
> > When we hot-remove the device, we first receive a PCI_EJECT message and
> > then receive a PCI_BUS_RELATIONS message with bus_rel->device_c
> From: Dexuan Cui
> > From: Lorenzo Pieralisi
> > I need to know either what commit you are fixing (ie Fixes: tag - which
> > is preferrable) or you tell me which kernel versions we are targeting
> > for the stable backport.
> > Lorenzo
>
> Sorry. Here I
> From: Lorenzo Pieralisi
> Sent: Friday, March 16, 2018 03:54
> ...
> Dexuan,
> while applying/updating these patches I notice this one may be squashed
> into: https://patchwork.ozlabs.org/patch/886266/
>
> since they logically belong in the same patch. Are you OK with me doing
> that ? Is my re
> From: Lorenzo Pieralisi
> Sent: Friday, March 16, 2018 11:32
> ...
>
> OK, patch series reworked and queued in my pci/hv branch please have
> a look and let me know if that looks OK for you, I won't ask Bjorn
> to move it into -next till you give me the go-ahead.
>
> Lorenzo
Yes, it looks goo
Commit-ID: 2f285f46240d67060061d153786740d4df53cd78
Gitweb: https://git.kernel.org/tip/2f285f46240d67060061d153786740d4df53cd78
Author: Dexuan Cui
AuthorDate: Tue, 18 Sep 2018 22:29:50 +
Committer: Thomas Gleixner
CommitDate: Thu, 27 Sep 2018 21:19:14 +0200
x86/hyperv: Suppress
501 - 534 of 534 matches
Mail list logo
