On 2015.01.19 01:38, Ahmadposten wrote:
> ---
> drivers/staging/vt6655/device_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/device_main.c
> b/drivers/staging/vt6655/device_main.c
> index f5cc78e..34e3a76 100644
> --- a/drivers/staging/vt66
kzalloc() could fail so add a check and return -ENOMEM if it does that gets
propogated to the pci layer
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_tty.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc
On Tue, 7 Apr 2015, Sudip Mukherjee wrote:
> On Tue, Apr 07, 2015 at 01:26:32PM +0300, Giedrius Statkevičius wrote:
> > kzalloc() could fail so add a check and return -ENOMEM if it does that gets
> > propogated to the pci layer
> >
> > Signed-off-by: Giedrius Statkev
won't execute
that if any of the allocations failed.
Signed-off-by: Giedrius Statkevičius
---
v2: Only returning -ENOMEM if an allocation failed isn't enough as it was
spotted by Sudip so create a new label that frees all successfully allocated
stuff and only then returns -ENOMEM. Also
On Tue, 7 Apr 2015, Dan Carpenter wrote:
> On Tue, Apr 07, 2015 at 03:40:17PM +0300, Giedrius Statkevičius wrote:
> > If one of the allocations of memory for storing a channel information struct
> > fails then free all the successful allocations and return -ENOMEM that gets
> &
se probe failing if we can't allocate enough
memory means that this scenario isn't possible.
Signed-off-by: Giedrius Statkevičius
---
v3: Remove the wrong comment at dgnc_tty_init() that says the allocation could
happen somewhere else before this and remove the check if (!brd->channels[
On Tue, 7 Apr 2015, Sudip Mukherjee wrote:
> On Tue, Apr 07, 2015 at 05:11:15PM +0300, Giedrius Statkevičius wrote:
> > If one of the allocations of memory for storing a channel information struct
> > fails then free all the successful allocations and return -ENOMEM that gets
&g
On Tue, 7 Apr 2015, Dan Carpenter wrote:
> You will need to update the subject to reflect the new patch.
>
> The original code did check for kzalloc() failure but it had lots of
> checks scattered around instead nicely at the point where the memory
> was allocated.
>
There are a lot missing too
ent and
check in the same loop because ->channels[i] isn't allocated anywhere else.
Finally, remove a unnecessary check if ->channels[i] is NULL in the next loop
because it can't be.
Signed-off-by: Giedrius Statkevičius
---
v4: Make this patch only for dgnc_tty.c and only for this
Remove checks that are redundant since we don't have boards with partially
initialized ->channels[i].
Signed-off-by: Giedrius Statkevičius
---
v4: splitted this from the one patch.
drivers/staging/dgnc/dgnc_cls.c | 4 ++--
drivers/staging/dgnc/dgnc_neo.c | 2 +-
2 files changed, 3 in
Add a check if ->channels[i] is NULL because a NULL pointer may be dereferenced
in case one of the allocations failed
Reported-by: Dan Carpenter
Signed-off-by: Giedrius Statkevičius
---
v4: new patch that fixes a bug reported by Dan Carpenter
drivers/staging/dgnc/dgnc_tty.c | 8 ++--
Remove some dead code that will never be executed or which serves no purpose
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_tty.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index
On Sat, 11 Apr 2015, Sudip Mukherjee wrote:
> On Fri, Apr 10, 2015 at 05:48:54PM +0300, Giedrius Statkevičius wrote:
> > Remove the dead code protected by in_user in dgnc_tty_write() because it is
> > set
> > to 0 and never changed to 1 thus the code in ifs never gets execu
On Thu, 16 Apr 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> rts522a(rts5227s) is derived from rts5227, and mainly same with rts5227.
> Add it to file mfd/rts5227.c to support this chip.
>
> Signed-off-by: Micky Ching
> ---
Maybe update the Kconfig as well? So that the peopl
On Mon, Apr 25, 2016 at 4:00 AM, Parth Sane wrote:
> Added missing signed off by line and fixed alignment to match
> open parenthesis.
Put "Added missing signed off by line" below the ---. This is not what
we want to have in change logs.
___
devel maili
On Sun, Mar 06, 2016 at 03:50:16PM +0530, PrasannaKumar Muralidharan wrote:
> From: PrasannaKumar Muralidharan
>
> Signed-off-by: PrasannaKumar Muralidharan
Commit message is missing.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev
llowing it.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/ft1000/ft1000-usb/ft1000_download.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
index 5def347..345c
Convert a Microsoft compiler specific directive "#pragma pack(1)" to a
GCC equivalent __packed. Also, by doing this we save
ourselves from trouble if any other struct definitions are added after
the #pragma because it will be applied to all of the definitions
following it.
Signed-off-by
On 2015.03.06 23:20, Nicholas Krause wrote:
> Removes the no longer required structure definition,_STA_QOS due to
> no functions using any structures of this type anymore.
>
> Signed-off-by: Nicholas Krause
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 48
>
On 2015.03.08 14:31, Sudip Mukherjee wrote:
> mention correct format specifier while printing
>
> Signed-off-by: Sudip Mukherjee
> ---
>
> this patch will give checkpatch warnings about use of printk.
> this patch was mainly to fix the build warnings. printk will be
> converted to pr_* and dev_*
On 2015.03.08 14:31, Sudip Mukherjee wrote:
> check if it is already defined before defining SM750LE_REVISION_ID
> again and at the same time mention correct data type.
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/staging/sm750fb/ddk750_chip.h | 4 +++-
> 1 file changed, 3 insertions(+), 1
On 2015.03.08 14:31, Sudip Mukherjee wrote:
> kbuild test robot reported that for microblaze-allyesconfig
> chan_to_field() and lynxfb_ops_set_par() were not defined. These two
> functions were defined under CONFIG_PM, so for any archtecture if
> CONFIG_PM is not defined we will have this error.
>
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_driver.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driver.c
index fa1ee79..73ee667 100644
--- a/drivers/staging/dgnc/dgnc
Some of the lines are over 80 characters so fix that by moving the
comments before the struct definition and before #define's.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_cls.h | 40
1 file changed, 28 insertions(+), 12 dele
Some of the lines are over 80 characters in dgnc_driver.c so fix them by
moving the comments closer to the code, tidying the comments to make
them smaller, and remove a redundant space after +.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_driver.c | 15 ---
1
There are a lot double of blank lines in dgnc_cls.c thus remove them to make
the file follow the CodingStyle. Also, remove one blank line at the
end of dgnc_cls.c.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_cls.c | 36
1 file changed
Fix comments to make lines less than 80 characters by moving them,
breaking the lines or making them neater.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_driver.h | 55 +-
1 file changed, 36 insertions(+), 19 deletions(-)
diff --git a
This one is bad. I've accidentally sent it, sorry. Don't pull/review
this.
On 2015.03.09 01:49, Giedrius Statkevičius wrote:
> Fix comments to make lines less than 80 characters by moving them,
> breaking the lines or making them neater.
>
[...]
-
On 2015.03.09 15:06, Dan Carpenter wrote:
> Added Matteo to the CC list because he was working on this function as
> well and I remembered something I wanted to tell him.
>
> On Sun, Mar 08, 2015 at 07:46:37PM +0200, Giedrius Statkevičius wrote:
>> Currently the label is onl
place where state was set to BOARD_FAILED which was even redundant
before this patch.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_driver.c | 19 ++-
drivers/staging/dgnc/dgnc_driver.h | 3 +--
drivers/staging/dgnc/dgnc_mgmt.c | 5 +
drivers/staging
On 2015.03.09 17:27, Giedrius Statkevičius wrote:
> Remove BOARD_FAILED and don't save dgnc_boards which failed to
> initialize.
>
> Assign the result of kzalloc() to brd in dgnc_found_board() and only put
> it in the dgnc_Board[] if it successfully initializes. Also, remove
place where state was set to BOARD_FAILED which was even redundant
before this patch.
Signed-off-by: Giedrius Statkevičius
---
v2: Remove "brd = dgnc_Board[dgnc_NumBoards];" line which I forgot to do
in the first version
drivers/staging/dgnc/dgnc_driver.c | 20 ++--
y that
have failed to initialize" and make sysfs files after initializing the
board in dgnc_driver.c or IOW they are already set for successfully
initialized boards before their sysfs files created (412 and 593 lines
in dgnc_driver.c).
Signed-off-by: Giedrius Statkevičius
---
drivers/stag
Dgnc_state array of strings is never used anywhere and it seems pretty
useless anyway since the board state enum names speak for themselves.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_driver.c | 8
drivers/staging/dgnc/dgnc_driver.h | 1 -
2 files changed, 9
ng e-mails
of people which are responsible for these drivers - see TODO or
MAINTAINERS for that. We can preserve the original copyright at the top
of the most files because it shows who originally made them.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_cls.c | 16 ---
On 2015.03.11 16:04, Quentin Lambert wrote:
> This patch introduces goto statments for error handling
> and in cases where a lock needs to be released.
>
> A simplified version of the semantic patch that finds this problem is as
> follows: (http://coccinelle.lip6.fr)
>
> @candidates exists@
> ide
On 2015.03.11 23:03, Janakarajan Natarajan wrote:
> Addition of blank line after declaration in ft1000_hw.c
> Minor changes to remove {} from single line if and remove extra parenthesis.
> Fixes checkpatch warning for and usage.
>
Greg may complain that you've done too much in 1 patch.
> Signed
Hi Daniele,
On 2015.03.12 00:05, Daniele Alessandrelli wrote:
> Fix all the trivial style issues (as reported by checkpatch.pl) not requiring
> code refactoring. A following patch is expected to fix the remaining issues by
> performing some code refactoring.
>
> Signed-off-by: Daniele Alessandrel
On 2015.03.12 12:08, Greg KH wrote:
> On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote:
>> Remove BOARD_FAILED and don't save dgnc_boards which failed to
>> initialize.
>>
>> Assign the result of kzalloc() to brd in dgnc_found_board() and only
Dpacompat.h contained a lot of unused #defines and only few things are
used from it so since we've trimmed down digi.h, now we can delete
dpacompat.h and move remaining stuff into digi.h.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_driver.c | 1 -
drivers/staging
sm-generic/ioctls.h defines them too.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/digi.h | 235
1 file changed, 235 deletions(-)
diff --git a/drivers/staging/dgnc/digi.h b/drivers/staging/dgnc/digi.h
index 554fbeb..7e5e6b0 100644
---
TRUE/FALSE defined in dgnc_types.h are only used in dgnc_tty.c thus it
would be better to just use 1/0 to avoid unnecessary extra files and
includes.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_cls.h| 3 ---
drivers/staging/dgnc/dgnc_driver.h | 1 -
drivers/staging
Remove unused defines from dgnc_cls.h
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_cls.h | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls.h
index 85042bd..2597e36 100644
--- a/drivers/staging
dgnc_kcompat.h contains some old legacy defines in case the kernel
doesn't have __user defined but for current kernel versions these
defines don't make sense and are useless so remove them. Move the
TTY_FLIPBUF_SIZE define to digi.h because it's used in the code.
Signed-o
Remove redundant blank lines, move absolute include after relative
include.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_sysfs.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.h
b/drivers/staging/dgnc/dgnc_sysfs.h
On 2015.03.12 20:59, Dan Carpenter wrote:
> On Thu, Mar 12, 2015 at 08:14:25PM +0200, Giedrius Statkevičius wrote:
>> TRUE/FALSE defined in dgnc_types.h are only used in dgnc_tty.c thus it
>> would be better to just use 1/0 to avoid unnecessary extra files and
>> includes.
&
dgnc_ioctl_name() is never used anywhere so remove it
Signed-off-by: Giedrius Statkevičius
---
v2: Forgot to include this patch in the first version. Without this some
of the other patches in this set will fail.
drivers/staging/dgnc/dgnc_utils.c | 52
Remove a lot of unused structs and defines from digi.h. We still have to
be careful with TIOCM_LE and TIOCMSET/TIOCMBIC because termios.h and
ioctls.h respectfully redefine them.
Signed-off-by: Giedrius Statkevičius
---
v2: Updated commit msg and remove some more unused stuff
drivers/staging
Remove redundant blank lines, move absolute include after relative
include.
Signed-off-by: Giedrius Statkevičius
---
v2: no change
drivers/staging/dgnc/dgnc_sysfs.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.h
b/drivers/staging/dgnc
Dgnc_types.h unnecesarily defines TRUE as 1 and FALSE as 0 because we
already have a widely used linux/types.h so convert all TRUE to true,
FALSE to false and edit the dgnc_board struct to make sure it uses
"bool".
Signed-off-by: Giedrius Statkevičius
---
I'm still not sure wheth
dgnc_kcompat.h contains some old legacy defines in case the kernel
doesn't have __user defined but for current kernel versions these
defines don't make sense and are useless so remove them. Move the
TTY_FLIPBUF_SIZE define to digi.h because it's used in the code.
Signed-o
Dpacompat.h contained a lot of unused #defines and only few things are
used from it so since we've trimmed down digi.h, now we can delete
dpacompat.h and move remaining stuff into digi.h.
Signed-off-by: Giedrius Statkevičius
---
v2: No change
drivers/staging/dgnc/dgnc_driver.c | 1 -
dr
Remove unused defines from dgnc_cls.h
Signed-off-by: Giedrius Statkevičius
---
v2: No change
drivers/staging/dgnc/dgnc_cls.h | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls.h
index 85042bd..2597e36 100644
--- a
Hi Greg,
On 2015.03.12 12:08, Greg KH wrote:
> On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote:
>> Remove BOARD_FAILED and don't save dgnc_boards which failed to
>> initialize.
>>
>> Assign the result of kzalloc() to brd in dgnc_found_b
Hi Ragavendra,
On 2015.03.14 03:04, Ragavendra Nagraj wrote:
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the
> code give no
> warnings by the checpath.pl. Please accept.
The "Please accept."
Greg, you probably missed these :) Could you look at these when you have
some time?
On 2015.03.13 15:56, Giedrius Statkevičius wrote:
> dgnc_ioctl_name() is never used anywhere so remove it
>
> Signed-off-by: Giedrius Statkevičius
> ---
> v2: Forgot to include this patch in th
Hi Amitoj Kaur Chawla,
On 2015.03.19 19:39, Amitoj Kaur Chawla wrote:
> The edits have been made to remove C99 Comments and properly indent
> the if-else statements in the file while taking care of the braces according
> to
> Linux coding style.
>
> Signed-off-by: Amitoj Kaur Chawla
> ---
> dr
Hi Amitoj Kaur Chawla,
On 2015.03.19 20:05, Amitoj Kaur Chawla wrote:
> The edits have been made to add a space before the comment and the errors in
> braces in the if-else statements.
> Previously in commit 2d34f53f1065878cd881ac61a183f8e836583d51, removed
> the C99 comments and errors in if-else
On Sat, 4 Apr 2015, Andreas Theodosiou wrote:
> This is a patch to the fb_ili9163.c file that inserts a line break in
> line #92 to make the line fit into the 80 character limit.
>
> Signed-off-by: Andreas Theodosiou
> ---
> drivers/staging/fbtft/fb_ili9163.c | 3 ++-
> 1 file changed, 2 insert
On Sat, 4 Apr 2015, Nickolaus Woodruff wrote:
> This patch fixes the following sparse warning in sm7xx.h:
>
> drivers/staging/sm7xxfb/sm7xx.h:122:17: warning: symbol 'vgamode'
> was not declared. Should it be static?
>
> Signed-off-by: Nickolaus Woodruff
> ---
> drivers/staging/sm7xxfb/sm7xx.h
> to 0 and never changed to 1 thus the code in ifs never gets executed.
>
> Signed-off-by: Giedrius Statkevičius
> ---
> v2: Just remove the dead code protected by in_user and join the first and
> third
> patches.
>
> drivers/staging/dgnc/dgnc_tty.c | 45
> +
On Sun, Jul 31, 2016 at 6:44 PM, Nadim almas wrote:
> This patch compresses two lines in to a single line in file
> ion.c
> if immediate return statement is found.It also removes variable
> ret as it is no longer needed.
>
> ne using script Coccinelle. And coccinelle uses following semantic
> patc
Hello shyam saini,
On Tue, Aug 2, 2016 at 2:33 PM, shyam saini wrote:
> Remove the explicit NULL comparison and rewrite in a compact form using
> Coccinelle
>
> Signed-off-by: shyam saini
Where are the other 1650 patches? Also, a patch series that consists
of 1651 patches???
__
On Sun, Sep 4, 2016 at 12:08 PM, Amit Ghadge wrote:
> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
> WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Amit Ghadge
> ---
[...]
Why are you sending so many copies of the same patch?
On Wed, Sep 28, 2016 at 7:27 PM, Sergio Paracuellos
wrote:
> This patch series fix some warnings reported by checkpatch.pl script in
> hfa384x.h:
> WARNING: Block comments use * on subsequent lines
> WARNING: Block comments use a trailing */ on a separate line
> WARNING: do not add new typedefs
>
On 2014.09.19 01:57, Rene Kolarik wrote:
> Hello,
>
> I've fixed coding style issues in drivers/staging/imx-drm directory. This is
> a part of Eudyptula Challenge.
Please submit your patches "inline" (look at /Documentation/SubmittingPatches
section 7). Also, think about if it's worth seperating
On Fri, Aug 21, 2015 at 06:38:39PM +0530, Aparna Karuthodi wrote:
> Made the comment into a new lineto remove a coding style error detected
> by checkpatch.
> The warning is given below:
> drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters
>
> Signed-off-by: Aparna Karuthodi
On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote:
> Oh! Sorry! I made the changes to correct the faults you figured out.
> Is it okay now?
Resubmit it properly with "PATCH v2" in the title and a good commit message.
>
> Signed-off-by: Aparna Karuthodi
> ---
> drivers/staging/fb
On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote:
> Oh! Sorry! I made the changes to correct the faults you figured out.
> Is it okay now?
Better. Also, submit it again with proper commit message and put "PATCH v2" in
the subject.
>
> Signed-off-by: Aparna Karuthodi
> ---
> dri
On Wed, Aug 26, 2015 at 11:52:12AM +0800, Peng Sun wrote:
> Signed-off-by: Peng Sun
Please always add a changelog message. Also, you need to fix the subject. The
convention is to use something like: "a: b: ..."
So in this case it should be something like: "staging: android: ..."
You can look at `
70 matches
Mail list logo
