On Sun, Nov 26, 2017 at 01:45:55AM +0300, Mike wrote:
>
> This is my task from Little Penguin :)
What does that mean?
>
> Mike (10):
> trailing whitespace fixed
> spaces before tabs are fixed
> trailing */ on a separate line fixed
> if-else code style fixed
> space prohibited before t
On Sun, Nov 26, 2017 at 01:45:56AM +0300, Mike wrote:
> Signed-off-by: Mike
> ---
> drivers/staging/irda/drivers/ali-ircc.c | 1002
> +++
> 1 file changed, 501 insertions(+), 501 deletions(-)
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sen
On Sat, Dec 02, 2017 at 11:58:12AM +0200, Marcus Wolf wrote:
> From: root
I think something went wrong here :)
Also, you should never need to do kernel development as root...
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverde
On Sat, Dec 02, 2017 at 12:32:20PM +0200, Marcus Wolf wrote:
> Defines used in cases contain already shifted bits, so currentValue must not
> be shifted.
Please properly wrap your changelog text.
And you need a blank line before your signed-off-by line.
> signed_of_by: Marcus Wolf
"Signed-off
On Sat, Dec 02, 2017 at 12:51:54PM +0200, Marcus Wolf wrote:
> Defines used in cases contain already shifted bits, so currentValue must not
> be shifted.
> Signed-off-by: Marcus Wolf
Odd extra ' ' in your subject :(
And again, linewrap please.
thanks,
greg k-h
On Sat, Dec 02, 2017 at 01:45:50PM +0200, Marcus Wolf wrote:
> Since dev_dbg already depends on define DEBUG, there was no sense, to enclose
> dev_dbg lines with #ifdef DEBUG.
> Instead of removing #ifdef DEBUG, I introduced define DEBUG_FUNC_ENTRY. So
> now it is
> possible to switch of the funct
On Thu, Nov 30, 2017 at 07:38:41PM +0200, Marcus Wolf wrote:
> Hi Greg,
>
> don't know, wether that's best option.
What is?
> With that procedure, it will be very hard, to integrate large patches, if
> the owner of the patch isn't dealing with kernel source in his daily
> business and thus isn't
On Sat, Dec 02, 2017 at 02:21:32PM +0200, Marcus Wolf wrote:
> To increase the readability of the register accesses, the abstraction of the
> helpers was increased from simple read and write to set bit, reset bit and
> read modify write bit. In addition - according to the proposal from Walter
> Har
On Wed, Nov 29, 2017 at 03:00:56PM +0100, Benjamin Gaignard wrote:
> 2017-11-28 14:32 GMT+01:00 Greg KH :
> > On Mon, Nov 06, 2017 at 04:59:45PM +0100, Benjamin Gaignard wrote:
> >> Instead a getting only one common device "/dev/ion" for
> >> all the heaps
On Sat, Dec 02, 2017 at 05:14:08PM +0200, Marcus Wolf wrote:
> The define FIFO_SIZE was moved to rf69_registers.h. Although it is not a
> register,
> it is a value, that is given by hardware (like the registers).
>
> The define FIFO_THRESHOLD was moved to pi433_if.c, since it is a value, that
>
On Sat, Dec 02, 2017 at 05:20:22PM +0200, Marcus Wolf wrote:
> rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only.
> Therefore removed the function from header and declared it staic in
> the implemtation.
> Signed-off-by: Marcus Wolf
No blank line before signed-off-by :(
___
On Sat, Dec 02, 2017 at 05:43:20PM +0200, Marcus Wolf wrote:
> Leftover changes from patch [PATCH 2/5] staging: pi433: rf69.c style fix -
> spaces required around
> from Marcin Ciupak (11.10.2017)
Please properly wrap your changelog text at 72 columns like git asks you
do :)
thanks,
greg k-h
__
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I inclu
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I inclu
On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
>
> Unit Testing:
>
> - build successful
> - LTP testsuite passes.
> - checkpatch.pl pas
The following changes since commit 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323:
Linux 4.15-rc1 (2017-11-26 16:01:47 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-4.15-rc3
for you to fetch changes up to e168e9845d9
On Tue, Dec 05, 2017 at 03:01:42PM -0800, Laura Abbott wrote:
> On 12/02/2017 07:53 AM, Greg KH wrote:
> > > This is one of the item in the TODO list before been able to unstage ION
> > > which is my real need.
> > Why does it matter where in the tree this code is? Don
On Wed, Dec 06, 2017 at 12:35:29PM +0530, Akash Kumar wrote:
> Added spaces around '+'. Warning found using checkpatch.pl
> ---
> drivers/staging/rtl8192u/ieee80211/dot11d.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.c
> b/d
On Mon, Dec 04, 2017 at 10:21:56PM +0300, Aliaksei Karaliou wrote:
> Lustre code lacks checking the result of register_shrinker()
> in several places. register_shrinker() was tagged __must_check
> recently so that sparse has started reporting it.
>
> Signed-off-by: Aliaksei Karaliou
> ---
> driv
On Wed, Nov 08, 2017 at 07:13:56PM +0200, Marcus Wolf wrote:
> Fixes issue with bit shift in rf69_get_modulation
What "issue"?
>
> Signed-off-by: Marcus Wolf
> ---
> drivers/staging/pi433/rf69.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/pi433/
On Wed, Nov 29, 2017 at 10:32:00PM +0900, Tetsuo Handa wrote:
> register_shrinker() might return -ENOMEM error since Linux 3.12.
>
> Signed-off-by: Tetsuo Handa
> Cc: Robert Love
> Cc: Marco Nelissen
> Cc: John Stultz
> Cc: Greg Kroah-Hartman
> Cc: Michal Hocko
> ---
> drivers/staging/andro
On Wed, Nov 29, 2017 at 10:33:39PM +0900, Tetsuo Handa wrote:
> register_shrinker() might return -ENOMEM error since Linux 3.12.
> But since callers of ion_device_add_heap() are not ready to receive an
> error and it is not simple enough to fix within this patch, this patch
> just prints a warning
On Wed, Dec 06, 2017 at 09:48:07PM +0530, Nipun Gupta wrote:
> Signed-off-by: Nipun Gupta
> ---
I can't take patches without any changelog text :(
Please fix and resend the series.
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://dr
On Wed, Dec 06, 2017 at 12:02:13PM +0200, Marcus Wolf wrote:
>
>
> Am 06.12.2017 um 11:02 schrieb Greg KH:
> > On Wed, Nov 08, 2017 at 07:13:56PM +0200, Marcus Wolf wrote:
> > > Fixes issue with bit shift in rf69_get_modulation
> >
> > What "issue"
On Mon, Dec 04, 2017 at 11:45:16PM +0200, Marcus Wolf wrote:
> To increase the readability of the register accesses, the abstraction
> of the helpers was increased from simple read and write to set bit,
> clear bit and read modify write bit.
>
> Annotation: This patch contains a lot of long lines
On Sat, Dec 02, 2017 at 07:00:17PM +0200, Marcus Wolf wrote:
> Am 02.12.2017 um 17:00 schrieb Greg KH:
> > On Sat, Dec 02, 2017 at 01:45:50PM +0200, Marcus Wolf wrote:
> > > Since dev_dbg already depends on define DEBUG, there was no sense, to
> > > enclose
> >
On Mon, Dec 04, 2017 at 09:40:10PM +0100, Tomas Marek wrote:
> This patch fix several brace on next line, braces not necessary, space
> around =/<, and space before/after open/close parenthesis coding style
> errors find by checkpatch in pi433_if.c.
>
> In addition, the interrupt routine DIO0_irq_
On Wed, Dec 06, 2017 at 12:07:20PM +0200, Marcus Wolf wrote:
>
>
> Am 06.12.2017 um 11:37 schrieb Dan Carpenter:
> > On Wed, Dec 06, 2017 at 11:05:22AM +0200, Marcus Wolf wrote:
> > >
> > >
> > > Am 06.12.2017 um 00:08 schrieb Simon Sandström:
> > > > Splits rf69_set_crc_enabled(dev, enabled) i
On Tue, Dec 05, 2017 at 11:08:44PM +0100, Simon Sandström wrote:
> Splits rf69_set_crc_enabled(dev, enabled) into
> rf69_enable_crc(dev) and rf69_disable_crc(dev).
>
> Signed-off-by: Simon Sandström
> ---
> drivers/staging/pi433/pi433_if.c | 22 --
> drivers/staging/pi433/rf6
On Wed, Dec 06, 2017 at 08:40:43PM +0300, Aliaksei Karaliou wrote:
> On 12/06/2017 11:51 AM, Greg KH wrote:
>
> > On Mon, Dec 04, 2017 at 10:21:56PM +0300, Aliaksei Karaliou wrote:
> > > Lustre code lacks checking the result of register_shrinker()
> > > in several p
On Thu, Dec 07, 2017 at 12:24:34AM +0200, Marcus Wolf wrote:
>
>
> Am 06.12.2017 um 22:42 schrieb Simon Sandström:
> > The enum is now only used for ioctl, so move it pi433_if.h.
> >
> > Signed-off-by: Simon Sandström
> > ---
> > drivers/staging/pi433/pi433_if.h | 5 +
> > drivers/stagi
On Wed, Dec 06, 2017 at 11:08:09PM +0100, SUNIL KALLUR RAMEGOWDA wrote:
> My first kernel patch, fixed warnings.
>
> Signed-off-by: SUNIL KALLUR RAMEGOWDA
> ---
> drivers/staging/ccree/ssi_aead.c | 179
> +++
> 1 file changed, 123 insertions(+), 56 deletions(
On Wed, Dec 06, 2017 at 09:32:01PM +0530, Akash Kumar wrote:
> Added spaces around '+'. Warning found using checkpatch.pl
> Signed-off-by: Akash Kumar
Please put a blank line before your signed-off-by line. I'll fix it up
this time, but be more careful next time.
thanks,
greg k-h
_
On Wed, Dec 06, 2017 at 09:42:19PM +0100, Simon Sandström wrote:
> Splits rf69_set_crc_enabled(dev, enabled) into
> rf69_enable_crc(dev) and rf69_disable_crc(dev).
>
> Signed-off-by: Simon Sandström
> ---
> drivers/staging/pi433/pi433_if.c | 22 --
> drivers/staging/pi433/rf6
On Thu, Dec 07, 2017 at 03:58:01PM +0100, Simon Sandström wrote:
> On Thu, Dec 07, 2017 at 03:38:57PM +0100, Greg KH wrote:
> > On Wed, Dec 06, 2017 at 09:42:19PM +0100, Simon Sandström wrote:
> > > Splits rf69_set_crc_enabled(dev, enabled) into
> > > rf69_enable_crc(de
On Thu, Dec 07, 2017 at 12:11:07PM -0500, David Kershner wrote:
> Move the visorbus driver out of staging (drivers/staging/unisys/visorbus)
> and to drivers/visorbus. Modify the configuration and makefiles so they
> now reference the new location. The s-Par header file visorbus.h that is
> referenc
On Fri, Dec 08, 2017 at 02:13:18PM -0800, Joe Perches wrote:
> On Fri, 2017-12-08 at 21:55 +, Kershner, David A wrote:
> > > -Original Message-
> > > From: Joe Perches [mailto:j...@perches.com]
> > > Sent: Friday, December 8, 2017 11:53 AM
> &g
On Mon, Dec 11, 2017 at 08:41:44PM +, Dexuan Cui wrote:
> > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> > Behalf Of Stephen Hemminger
> > Sent: Tuesday, November 28, 2017 9:30 AM
> > To: Greg KH
> > Cc: o...@aepfle.de; Stephen Hemmi
On Mon, Dec 11, 2017 at 01:23:28PM -0800, Todd Kjos wrote:
> Greg- when this is in, we'll want it in 4.14 as well.
Ugh, missed that, I'll be sure to mark it for stable, thanks for letting
me know.
greg k-h
___
devel mailing list
de...@linuxdriverproject
On Fri, Dec 08, 2017 at 09:27:54PM +0100, SUNIL KALLUR RAMEGOWDA wrote:
> Removing the extra spaces before tabs, checkpatch:
> WARNING: please, no space before tabs
>
> Signed-off-by: SUNIL KALLUR RAMEGOWDA
> ---
> drivers/staging/ks7010/ks_wlan_net.c | 4 ++--
> 1 file changed, 2 insertions(+),
On Sat, Dec 09, 2017 at 12:41:11PM -0800, Tomas Marek wrote:
> This patch fix several brace on next line, braces not necessary, space
> around =/<, and space before/after open/close parenthesis coding style
> errors find by checkpatch in pi433_if.c.
>
> Signed-off-by: Tomas Marek
> ---
> Changes
On Wed, Dec 13, 2017 at 11:31:15AM -0800, Tomas Marek wrote:
> On 12/13/2017 03:55 AM, Greg KH wrote:
>
> > On Sat, Dec 09, 2017 at 12:41:11PM -0800, Tomas Marek wrote:
> >> This patch fix several brace on next line, braces not necessary, space
> >> around =/<,
On Wed, Dec 13, 2017 at 01:23:38PM -0800, Stephen Hemminger wrote:
> On Wed, 13 Dec 2017 09:54:19 +0100
> Vincent Legoll wrote:
>
> > Hello,
> >
> > On Sun, Dec 10, 2017 at 6:50 AM, Stephen Hemminger
> > wrote:
> > > Will this break existing configs?
> >
> > I don't think so. Last time I did
On Thu, Dec 14, 2017 at 11:40:03PM +0300, Mikhail Shvetsov wrote:
> Signed-off-by: Mikhail Shvetsov
I can't take patches without any changelog text at all.
Please fix all of these up and resend.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriv
The following changes since commit 73996933b53ff396d63a7fccd8e824758634dc19:
Merge tag 'staging-4.15-rc3' of
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging (2017-12-05
09:57:34 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh
On Fri, Dec 15, 2017 at 01:03:03PM -0800, Linus Torvalds wrote:
> On Fri, Dec 15, 2017 at 11:00 AM, Greg KH wrote:
> >
> > While there are 4 patches in here, there's really only 2, as one ion
> > patch got reverted due to build errors reported by 0-day.
>
> Since
On Mon, Dec 18, 2017 at 07:27:58PM +0200, Marcus Wolf wrote:
> sizeof(array) != sizeof(pointer to array)
> Fixes: "staging: pi433: reduce stack size in tx thread"
>
> Signed-off-by: Marcus Wolf
This should be listed as:
Fixes: 62f39d49d168 ("staging: pi433: reduce stack size in tx thread")
righ
On Sat, Dec 16, 2017 at 10:15:59PM +0200, Kamal Heib wrote:
> Cleanup the "Unnecessary parentheses around " checkpatch.pl error.
>
> Signed-off-by: Kamal Heib
> ---
> drivers/staging/dgnc/dgnc_tty.c | 38 +++---
> 1 file changed, 19 insertions(+), 19 deletions(-)
On Sat, Dec 16, 2017 at 10:16:00PM +0200, Kamal Heib wrote:
> Cleanup the "Unnecessary parentheses around " checkpatch.pl error.
>
> Signed-off-by: Kamal Heib
> ---
> drivers/staging/dgnc/dgnc_cls.c | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/driver
On Sat, Dec 16, 2017 at 10:16:01PM +0200, Kamal Heib wrote:
> Cleanup the "Unnecessary parentheses around " checkpatch.pl error.
>
> Signed-off-by: Kamal Heib
> ---
> drivers/staging/dgnc/dgnc_neo.c | 22 +++---
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git
On Sat, Dec 16, 2017 at 01:25:19PM +0530, Aditya Shankar wrote:
> This patch fixes the "Lines should not end with a '('"
> problem reported by checkpatch
>
> Signed-off-by: Aditya Shankar
> ---
> drivers/staging/wilc1000/linux_mon.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletio
On Wed, Nov 29, 2017 at 12:08:44PM +0200, laurentiu.tu...@nxp.com wrote:
> From: Stuart Yoder
>
> Move the source files out of staging into their final locations:
> -include files in drivers/staging/fsl-mc/include go to include/linux/fsl
> -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip
On Tue, Dec 19, 2017 at 03:21:19PM +, Laurentiu Tudor wrote:
>
>
> On 12/19/2017 04:48 PM, Greg KH wrote:
> > On Wed, Nov 29, 2017 at 12:08:44PM +0200, laurentiu.tu...@nxp.com wrote:
> >> From: Stuart Yoder
> >>
> >> Move the source files
On Sun, Jun 24, 2018 at 10:57:24AM +0100, John Whitmore wrote:
> Simple coding style changes to single file
> drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
Nit, please include the driver and subsystem in your 00/XX emails,
otherwise they get lost in my filters and I see an odd semi-completed
On Sun, Jun 24, 2018 at 04:34:51PM +0100, John Whitmore wrote:
> Changed a number of hard coded function names to use %s and __func__
>
> Mailing list response suggest that there is a better method for debugging
> using netdev_dbg(). I can't argue with that, but for the moment this change
> will c
On Fri, Jun 08, 2018 at 02:16:35PM +0200, Sergio Paracuellos wrote:
> Adding spaces between if condition and parenthesis are not
> needed at all and checkpatch script complains about them.
> Fix one in driver code.
>
> Signed-off-by: Sergio Paracuellos
> ---
> drivers/staging/mt7621-pinctrl/pinc
On Thu, Jun 28, 2018 at 01:32:41PM +0100, John Whitmore wrote:
> On Thu, Jun 28, 2018 at 10:38:28AM +0300, Dan Carpenter wrote:
> > On Wed, Jun 27, 2018 at 09:22:50PM +0100, John Whitmore wrote:
> > > On Tue, Jun 26, 2018 at 11:56:24AM +0800, Greg KH wrote:
> > > >
On Tue, Jun 19, 2018 at 06:23:52PM +0200, Vitor Fernandes Ferreira wrote:
> Signed-off-by: Vitor Fernandes Ferreira
> ---
> drivers/staging/comedi/comedi_fops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent h
On Wed, Jun 27, 2018 at 02:47:55PM -0700, r...@google.com wrote:
> From: Roman Kiryanov
>
> Add functions
> * to read and write u64 to be used in the goldfish sync driver.
Why not just keep these in the sync driver? No need to put them in a .h
file if only one .c file uses it, right?
thanks,
On Wed, Jun 27, 2018 at 02:50:52PM -0700, r...@google.com wrote:
> From: Roman Kiryanov
>
> This is kernel driver for controlling the Goldfish sync
> device on the host. It is used to maintain ordering
> in critical OpenGL state changes while using
> GPU emulation.
Why are you adding new feature
On Thu, Jun 28, 2018 at 11:39:53AM -0700, Roman Kiryanov wrote:
> Hi Greg,
>
> we wanted to include our changes into this year LTS.
Great, then get the audio driver cleaned up this week and all is fine,
it shouldn't take you very long, right?
> > get the existing code cleaned up and out of the s
On Thu, Jun 28, 2018 at 01:33:23PM -0700, r...@google.com wrote:
> From: Roman Kiryanov
>
> The goldfish nand driver was retired (not used).
>
> Signed-off-by: Roman Kiryanov
> ---
> drivers/staging/goldfish/README | 6 --
> 1 file changed, 6 deletions(-)
Your subject line needs to say wh
On Thu, Jun 28, 2018 at 06:19:13PM -0700, r...@google.com wrote:
> From: Roman Kiryanov
>
> Linux kernel coding style: spaces are never used for
> indentation.
>
> Signed-off-by: Roman Kiryanov
> ---
> drivers/staging/goldfish/goldfish_audio.c | 15 ---
> 1 file changed, 8 insertio
On Thu, Jun 28, 2018 at 06:19:14PM -0700, r...@google.com wrote:
> From: Roman Kiryanov
>
> * added a mutex to protect open/read/write/release calls;
> * put the global atomic counter for opened files into the
> driver state;
> * retired the global variable for the driver state;
> * retired t
On Fri, Jun 29, 2018 at 05:20:32PM +0200, Radek Dostál wrote:
> Signed-off-by: Radek Dostál
> ---
> drivers/staging/fbtft/fbtft_device.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that
On Sat, Jun 30, 2018 at 02:30:44PM +, Tamir Suliman wrote:
> Fixed Coding style issues
>
> Signed-off-by: Tamir Suliman
> ---
> drivers/staging/netlogic/Kconfig | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/netlogic/Kconfig
> b/drivers/stagi
On Sat, Jun 30, 2018 at 02:32:39PM +, Tamir Suliman wrote:
> ---
> drivers/staging/fbtft/fb_sh1106.c | 26 +-
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_sh1106.c
> b/drivers/staging/fbtft/fb_sh1106.c
> index 3fc18c0..
The following changes since commit 7daf201d7fe8334e2d2364d4e8ed3394ec9af819:
Linux 4.18-rc2 (2018-06-24 20:54:29 +0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-4.18-rc3
for you to fetch changes up to ebc2dc5f9b2
On Fri, Jun 29, 2018 at 07:10:05PM +0100, John Whitmore wrote:
> Chnaged logging statements to use %s and __func__ instead of hard coding the
> function name in a string.
>
> Signed-off-by: John Whitmore
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++--
> 1 file chan
On Mon, Jul 02, 2018 at 09:59:34AM +0100, John Whitmore wrote:
> I'll fix that up and re-submit
Please do not top-post, or send html email, as the mailing lists will
reject it (as you saw...)
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
On Tue, Jul 03, 2018 at 07:31:20AM +, Tamir Suliman wrote:
> Fixed the following style/coding issues:
> *updated ---help to the prefered new help texts which reduces the code/file
> size and fixes the warning messages
> *Used else if instead of elese as else is not generally useful after a bre
On Tue, Jul 03, 2018 at 05:05:24PM +0300, Razvan Stefanescu wrote:
> Signed-off-by: Razvan Stefanescu
No changelog text?
> ---
> MAINTAINERS | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b6d0cc0..0d36546 100644
> --- a/MAINTAINERS
On Thu, Jul 05, 2018 at 02:12:20AM +, Tamir Suliman wrote:
> Updated printk() of i18n messages to include KERN_INFO facility level to
> improve debuggin.
> then later noticed that I forgot to add a space on printk.
>
> Signed-off-by: Tamir Suliman
> ---
> drivers/staging/speakup/kobjects.c
On Sat, Jul 07, 2018 at 01:22:50PM +0200, Michael Straube wrote:
> Simplify rtw_get_rateset_len() by replacing the while loop
> with a shorter for loop. Also replace tabs with spaces in
> the definition line.
Normally I will insist that this be two separate patches, as you are
doing two different
On Sun, Jul 08, 2018 at 02:57:08PM +0200, Sergio Paracuellos wrote:
> This patch series clean up a bit mt7621-pci driver.
Your subject line for the 00/XX email needs some work (like putting what
driver and subsystem it is for in it please...)
For future patch series.
thanks,
greg k-h
__
On Sun, Jul 08, 2018 at 02:57:26PM +0200, Sergio Paracuellos wrote:
> It's good to have SPDX identifiers in driver files to make it easier to
> audit the kernel tree for correct licenses.
>
> Fix up the one of staging pci-mt7621.c file to have a proper SPDX
> identifier, based on the license text
On Sat, Jul 07, 2018 at 10:19:40PM -0400, Jacob Feder wrote:
> Hi all,
> I have developed this driver for a Xilinx-provided IP block for their Zynq
> SoC. I fixed all of the checkpatch.pl problems I knew how to. If someone
> could chime in on how to fix the remaining few it would be appreciated.
>
On Sun, Jul 08, 2018 at 04:06:08PM +0200, Sergio Paracuellos wrote:
> On Sun, Jul 8, 2018 at 3:16 PM, Greg KH wrote:
> > On Sun, Jul 08, 2018 at 02:57:26PM +0200, Sergio Paracuellos wrote:
> >> It's good to have SPDX identifiers in driver files to make it easier to
> &g
On Sat, Jul 07, 2018 at 09:48:37PM +0200, Sergio Paracuellos wrote:
> This commit simplifies and clean a lot of stuff related with pci
> reads and writes. It deletes a lot of not needed at all functions
> and use kernel arch operations read[b,w,l] and write[b,w,l] instead
> of use custom macros. It
On Sat, Jul 07, 2018 at 03:55:04PM +0100, John Whitmore wrote:
> Coding style change to simply remove the unrequired spaces before a closing
> brace or before an opening brace.
That would be good, but that's not what this patch does :(
It removes lines, not spaces, as the subject line said. You
On Mon, Jul 09, 2018 at 11:52:30AM -0400, Janani Sankara Babu wrote:
> This driver uses the same unregistered vendor id that the
> firewire core does (0xd00d1e). Hence it is exposed as a
> define in firewire.h.
>
> Signed-off-by:Janani Sankara Babu
> ---
> drivers/staging/fwserial/fwserial.c | 1
On Mon, Jul 09, 2018 at 06:30:07AM +0200, Sergio Paracuellos wrote:
> On Mon, Jul 09, 2018 at 09:40:18AM +1000, NeilBrown wrote:
> > On Thu, Jun 28 2018, Sergio Paracuellos wrote:
> >
> > > We don't really need initialization of this at such an early stage.
> > > Just use builtin_platform_driver t
On Mon, Jul 09, 2018 at 06:41:15AM +0200, Sergio Paracuellos wrote:
> On Mon, Jul 09, 2018 at 11:08:58AM +1000, NeilBrown wrote:
> > On Sun, Jul 08 2018, Sergio Paracuellos wrote:
> >
> > > This patch series clean up a bit mt7621-pci driver.
> > >
> > > Changes from v2:
> > > - It includes new
On Sun, Jul 08, 2018 at 02:25:38PM -0400, jacob feder wrote:
> On Sun, Jul 8, 2018 at 9:28 AM Greg KH wrote:
>
> On Sat, Jul 07, 2018 at 10:19:40PM -0400, Jacob Feder wrote:
> > Hi all,
> > I have developed this driver for a Xilinx-provided IP block for their
&
On Mon, Jul 09, 2018 at 02:14:06PM +0530, Jaya Durga wrote:
> From: root
That's an odd author name :)
>
> CHECK: Macro argument reuse 'gdm' - possible side-effects?
>
> convert GDM_TTY_READY to gdm_tty_ready static function
> to fix checkpath check
>
> Signed-off-by: Jaya Durga
It doesn't m
On Mon, Jul 09, 2018 at 04:27:58PM +0530, Jaya Durga wrote:
> From: root
Again, wrong address :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Jul 09, 2018 at 10:29:54AM +0100, John Whitmore wrote:
> On Sun, Jul 08, 2018 at 05:38:11PM +0200, Greg KH wrote:
> > On Sat, Jul 07, 2018 at 03:55:04PM +0100, John Whitmore wrote:
> > > Coding style change to simply remove the unrequired spaces before a
> >
On Mon, Jul 09, 2018 at 06:05:48PM +0200, Sergio Paracuellos wrote:
> Remove driver from staging. It has been accepted in
> the linux-gpio tree.
>
> Signed-off-by: Sergio Paracuellos
> ---
>
> Refer to commits in linux-gpio:
> -
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gp
On Tue, Jul 10, 2018 at 12:03:17PM +0200, Sophie Matter wrote:
> Lines have been split where it makes sense to shorten them in order
> to comply with the coding standards and fix checkpatch.pl warnings.
> There are still lines left that are too long, however breaking
> those would impair readabilit
On Tue, Jul 10, 2018 at 12:03:16PM +0200, Sophie Matter wrote:
> The missing SPDX tag was added to the top of the files of this
> driver, according to the comments on top of each file (GPL license
> or higher).
>
> Signed-off-by: Sophie Matter
> Signed-off-by: Rico Schrage
What tree are you wor
On Mon, Jul 09, 2018 at 10:21:06PM +0200, Sergio Paracuellos wrote:
> The logic for this functions is kind of mess calling to other
> functions which ends up in using very ugly macros. Reimplement
> this two using kernel write[b,w,l] and read[b,w,l] and the variable
> 'mt7621_pci_base'. Function pr
On Mon, Jul 09, 2018 at 10:21:05PM +0200, Sergio Paracuellos wrote:
> Add new 'mt7621_pci_base' variable as a pointer to definition
> RALINK_PCI_BASE to use it along the code.
>
> Signed-off-by: Sergio Paracuellos
> ---
> drivers/staging/mt7621-pci/pci-mt7621.c | 3 +++
> 1 file changed, 3 inser
On Mon, Jul 09, 2018 at 10:21:02PM +0200, Sergio Paracuellos wrote:
> This patch series clean up a bit mt7621-pci driver.
>
> Chnages in v3:
> - PATCH 1 has been splited in several patches for better review
> - PATCH "avoid pointer arithmetics in some macros" gets back
> a needed swi
On Tue, Jul 10, 2018 at 12:55:10PM +0200, Greg KH wrote:
> On Mon, Jul 09, 2018 at 10:21:02PM +0200, Sergio Paracuellos wrote:
> > This patch series clean up a bit mt7621-pci driver.
> >
> > Chnages in v3:
> > - PATCH 1 has been splited in several patches for be
On Tue, Jul 10, 2018 at 09:33:46PM +0200, Sergio Paracuellos wrote:
> Add new 'mt7621_pcie_port' struct as data for the pci controller.
>
> Signed-off-by: Sergio Paracuellos
> ---
> drivers/staging/mt7621-pci/pci-mt7621.c | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/driv
On Wed, Jul 11, 2018 at 10:29:43AM +0300, Dan Carpenter wrote:
> On Tue, Jul 10, 2018 at 09:33:47PM +0200, Sergio Paracuellos wrote:
> > +static int mt7621_pcie_parse_dt(struct mt7621_pcie_port *port)
> > +{
> > + struct device *dev = port->dev;
> > + struct device_node *node = dev->of_node;
>
On Tue, Jul 10, 2018 at 09:33:47PM +0200, Sergio Paracuellos wrote:
> map_bus callback is called before every .read/.write operation.
> Implement it and change custom read write operations for the
> pci subsystem generics. Make the probe function to assign data
> for controller data and get pci reg
The following changes since commit 021c91791a5e7e85c567452f1be3e4c2c6cb6063:
Linux 4.18-rc3 (2018-07-01 16:04:53 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-4.18-rc5
for you to fetch changes up to d59d2f9995d
On Tue, Jul 10, 2018 at 04:05:18PM +0100, John Whitmore wrote:
> Corrected coding style issues aroung opening and closed parenthesis. Spaces,
> or blank line, removed from after '(' or before ')'
Wrap your changelog text at 72 columns like your editor asked you to :(
I'll fix it up this time...
On Wed, Jul 11, 2018 at 03:09:37PM +0100, John Whitmore wrote:
> On Wed, Jul 11, 2018 at 01:13:49PM +0200, Greg KH wrote:
> > On Tue, Jul 10, 2018 at 04:05:18PM +0100, John Whitmore wrote:
> > > Corrected coding style issues aroung opening and closed parenthesis.
> >
1101 - 1200 of 4990 matches
Mail list logo
