[PATCH 2/3] rtl8188eu: Fix a typo in rtw_led.*

A rather obvious typo in one of the identifier has been found. This patch fixes the typo and ensures any lines changed do not exceed 80 characters as indicated by scripts/checkpatch.pl Signed-off-by: Krzysztof Konopko --- drivers/staging/rtl8188eu/core/rtw_led.c| 6 -- drivers/staging

[PATCH 1/3] rtl8188eu: Fix FSF_MAILING_ADDRESS in rtw_led.*

rtw_led.* files include Free Software Foundation's mailing address in the sample GPL notice. This is not desired and picked when running scripts/checkpatch.pl. Signed-off-by: Krzysztof Konopko --- drivers/staging/rtl8188eu/core/rtw_led.c| 4 drivers/staging/rtl8188eu/include/rtw_

[PATCH 3/3] rtl8188eu: Remove leading spaces in rtw_led.c

According to Linux coding convention leading spaces are not allowed. This patch removes leading spaces in rtw_led.c Signed-off-by: Krzysztof Konopko --- drivers/staging/rtl8188eu/core/rtw_led.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu

[PATCH] rtl8188eu: Remove unnecessary braces for simple return in xmit_linux.c

scripts/checkpatch.pl reports a coding style problem in xmit_linux.c WARNING:BRACES: braces {} are not necessary for single statement blocks #61852: FILE: rtl8188eu/os_dep/xmit_linux.c:70: This patch removes unnecessary braces. Signed-off-by: Krzysztof Konopko --- drivers/staging

Re: [PATCH] rtl8188eu: Remove unnecessary braces for simple return in xmit_linux.c

On 08/11/14 21:23, Joe Perches wrote: > On Sat, 2014-11-08 at 22:14 +0100, Krzysztof Konopko wrote: >> scripts/checkpatch.pl reports a coding style problem in xmit_linux.c > [] >> diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c >> b/drivers/staging/rtl81

Re: [PATCH] rtl8188eu: Fix several stylistic problems in rtw_led.*

On 06/11/14 23:03, Greg Kroah-Hartman wrote: > On Thu, Nov 06, 2014 at 11:56:05PM +0100, k...@konagma.com wrote: >> From: Krzysztof Konopko >> >> Several stylistics problems are reported by scripts/checkpatch.pl run on >> rtw_led.*: >> >> * FSF_

[PATCH] rtl8188eu: Simplify rtw_endofpktfile() in xmit_linux.c

-off-by: Krzysztof Konopko --- drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c b/drivers/staging/rtl8188eu/os_dep/xmit_linux.c index d5e41a5..5acf9a9 100644 --- a/drivers/staging

[PATCH] staging: rtl8723au: Fix sparse warnings

__le16 This patch changes declared types of the struct fields involved. Signed-off-by: Krzysztof Konopko --- drivers/staging/rtl8723au/include/wifi.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/include/wifi.h b/drivers/staging/rtl8723au

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

On 12/12/14 00:53, Larry Finger wrote: > On 12/11/2014 04:23 PM, Krzysztof Konopko wrote: >> Some struct fields in wifi.h are meant to be __le16 bu were declared as >> unsigned short. This was reported by sparse: >> >>rtw_wlan_util.c:538:24: warning

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

On 12/12/14 17:43, Larry Finger wrote: > On 12/12/2014 06:52 AM, Dan Carpenter wrote: >> On Thu, Dec 11, 2014 at 05:53:30PM -0600, Larry Finger wrote: >>> On 12/11/2014 04:23 PM, Krzysztof Konopko wrote: >>>> Some struct fields in wifi.h are meant to be __le16 bu

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

On 12/12/14 18:12, Jes Sorensen wrote: > Krzysztof Konopko writes: >> Some struct fields in wifi.h are meant to be __le16 bu were declared as >> unsigned short. This was reported by sparse: >> >> rtw_wlan_util.c:538:24: warning: cast to restricted __le16 >>

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

On 12/12/14 18:35, Larry Finger wrote: > On 12/12/2014 05:35 AM, Krzysztof Konopko wrote: >> On 12/12/14 00:53, Larry Finger wrote: >>> In particular, did you test on big-endian hardware after you >>> made this change? >> >> Nope. I don't have any

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

On 12/12/14 19:52, Jes Sorensen wrote: > Larry Finger writes: >> On 12/12/2014 05:35 AM, Krzysztof Konopko wrote: >>> I was hunting particularly for inconsistencies with `sparse` and came >>> across this one. But I dug a bit further and I wonder why the driver is &

[PATCH] staging: rtl8723au: Fix sparse warnings

__le16 This patch changes the types of the struct fields involved to be little-endian which is what is received over the air and consistent with relevant structs in include/linux/ieee80211.h. Signed-off-by: Krzysztof Konopko --- drivers/staging/rtl8723au/include/wifi.h | 8 1 file

[PATCH] staging: rtl8723au: Fix sparse warnings

__le16 This patch updates the types of the fields in `AC_param` and `ADDBA_request` structs to be consistent with relevant structs in include/linux/ieee80211.h. Signed-off-by: Krzysztof Konopko --- drivers/staging/rtl8723au/include/wifi.h | 14 +++--- 1 file changed, 7 insertions(+), 7