Functions cckrates_included() and cckratesonly_included() are used only
in the file core/rtw_wlan_util.c. Make them static and remove extern
declarations from include/rtw_mlme_ext.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 4 ++--
drivers/staging
Remove unnecessary comparsions to boolean values.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
b/drivers/staging/rtl8723bs/core
Functions cckrates_included() and cckratesonly_included() return
boolean values. Convert the return type from int to bool.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
Refactor cckrates_included() and cckratesonly_included() to simplify
the code and improve readability.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs
On 2020-09-12 20:22, Joe Perches wrote:
On Sat, 2020-09-12 at 10:45 +0200, Michael Straube wrote:
Refactor cckrates_included() and cckratesonly_included() to simplify
the code and improve readability.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 14
unused variable ratelen.
Signed-off-by: Michael Straube
---
.../staging/rtl8723bs/core/rtw_wlan_util.c| 34 ++-
.../staging/rtl8723bs/include/rtw_mlme_ext.h | 2 --
2 files changed, 3 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
Acoording to the TODO code valid only for 5 GHz should be removed.
- find and remove remaining code valid only for 5 GHz. Most of the obvious
ones have been removed, but things like channel > 14 still exist.
Remove code path only valid for channels > 14.
Signed-off-by: Michael S
Remove extra indentations to follow kernel coding style and clear
checkpatch warnings.
WARNING: suspect code indent for conditional statements
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 6 +--
.../staging/rtl8188eu/core/rtw_wlan_util.c| 48
K: Please don't use multiple blank lines
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_security.c | 6 +-
drivers/staging/rtl8188eu/hal/odm.c | 1 -
drivers/staging/rtl8188eu/hal/rf.c| 1 +
drivers/staging/rtl8188eu/include
Use __func__ instead of hardcoded function names to clear
checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 4 +-
drivers/staging/rtl8188eu/hal/odm.c | 60 +--
drivers/staging/rtl8188eu/hal/phy.c | 2
Move constants to the right side of comparsions to follow kernel
coding style and clear checkpatch warnings. In case of comparsion
to _FAIL we can use '!' since _FAIL is defined as '0'.
WARNING: Comparisons should place the constant on the right side of the test
Signed-off
Clean up comparsions to NULL Reported by checkpatch.
if (x == NULL) -> if (!x)
if (x != NULL) -> if (x)
Signed-off-by: Michael Straube
---
drivers/staging/rtl8712/rtl871x_cmd.c | 4 ++--
drivers/staging/rtl8712/rtl871x_io.c | 2 +-
drivers/staging/r
Use empty brace syntax to initialize zero valued arrays.
Simplifies and shortens the code a little bit.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8712/rtl871x_xmit.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c
b
Clean up block comment style issues to follow kernel coding style
and clear checkpatch warnings.
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
WARNING: Block comments use * on subsequent lines
Signed-off-by: Michael Straube
Clean up alignment style issues to follow kernel coding style
and clear checkpatch issues.
CHECK: Alignment should match open parenthesis
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
drivers/staging/rtl8188eu/hal/phy.c | 21 ++--
drivers
Clean up comparsions to NULL reported by checkpatch.
if (x == NULL) -> if (!x)
if (x != NULL) -> if (x)
Signed-off-by: Michael Straube
---
drivers/staging/rtl8192u/r8192U_wx.c | 6 +++---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 4 ++--
drivers/staging/rtl8192u/r819xU_phy.c| 2
nes aren't necessary after an open brace '{'
Signed-off-by: Michael Straube
---
drivers/staging/rtl8192u/r8192U_dm.c | 12 +--
drivers/staging/rtl8192u/r8192U_hw.h | 1 +
drivers/staging/rtl8192u/r8192U_wx.c | 31 ++-
drivers/staging
Move 'else if' to the same line as the closing brace of the
corresponding 'if' to follow kernel coding style.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8192u/r8192U_wx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl
to skb, decrypt with lib80211_crypt_ccmp, and place back to tx buffer.
Cc: Ivan Safonov
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_security.c | 778 ++
1 file changed, 72 insertions(+), 706 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_security.
to skb, decrypt with lib80211_crypt_ccmp, and place back to tx buffer.
Cc: Ivan Safonov
Signed-off-by: Michael Straube
---
v1 -> v2:
Added missing spaces around '+' and removed unnecessary parentheses.
if ((curfragnum+1) == pattrib->nr_frags)
if (curfragnum + 1 == pattrib->nr_
Replace spaces with tab to clear checkpatch error.
ERROR: code indent should use tabs where possible
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c
b
Use ETH_ALEN instead of hard coded array size.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/rtw_security.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_security.h
b/drivers/staging/rtl8188eu/include
Clean up remaining comparsions to NULL reported by checkpatch.
x == NULL -> !x
x != NULL -> x
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_security.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188e
Removep unused macros and definitions from rtw_security.h leftover
from previous cleanup patches.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/include/rtw_security.h | 58 ---
1 file changed, 58 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include
: Michael Straube
---
.../staging/rtl8188eu/core/rtw_wlan_util.c| 34 +++
.../staging/rtl8188eu/include/rtw_mlme_ext.h | 3 --
2 files changed, 4 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
b/drivers/staging/rtl8188eu/core
Rename field of struct rt_pmkid_list to avoid camel case.
Bssid -> bssid
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme.c| 2 +-
drivers/staging/rtl8188eu/include/rtw_security.h | 2 +-
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 8
3 fi
Rename field of struct rt_pmkid_list to avoid camel case.
bUsed -> used
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme.c| 2 +-
drivers/staging/rtl8188eu/include/rtw_security.h | 2 +-
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 6 +++---
3 fi
After the removal of cckrates_included() and cckrates_only_included()
from rtw_wlan_util.c the variable/parameter 'ratelen' is unused now.
Remove it from update_wireless_mode() and judge_network_type().
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_wlan_ut
Remove commented defines from ioctl_linux.c. They are included from
include/uapi/linux/wireless.h. Also clears a checkpatch warning.
WARNING: Block comments use * on subsequent lines
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 11 ---
1 file
x.de/
>
> Fixes: cc62c74749a3 ("media: allegro: add missed checks in allegro_open()")
> Signed-off-by: Dan Carpenter
Reviewed-by: Michael Tretter
> ---
> From static analysis. Not tested.
>
> drivers/staging/media/allegro-dvt/allegro-core.c | 3 +--
> 1 fi
Add missing braces around else arm of if else statement to clear
style issues reported by checkpatch.
CHECK: braces {} should be used on all arms of this statement
CHECK: Unbalanced braces around else statement
Signed-off-by: Michael Straube
---
drivers/staging/rtl8723bs/core/rtw_efuse.c | 3
ist on a 2n+1
> boundary.
Not sure, what you mean by this.
> But that is only likely if part of some binary sequence.
> In which case I'd expect it to be marked __be or __le.
It is part of a binary sequence. It is the header of messages in a mailbox
that is used to exchange data wit
ndows/reference/tlfs
> >
> > mshyperv.h defines Linux-specific structures and routines for
> > interacting with Hyper-V. It is split into an ARM64 specific file
> > and an architecture independent file in include/asm-generic.
> >
> > Signed-off-by: Michael Kelley
&
yered patches in the next
version.
>
> > This code is architecture dependent code and is mostly driven by
> > architecture independent code in the VMbus driver in drivers/hv/hv.c
> > and drivers/hv/vmbus_drv.c.
> >
> > This code is built only when CONFIG_HYPER
The arrays WFD_OUI and WMM_INFO_OUI are not used anywhere,
so remove them.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 2 --
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu
Replace tabs with spaces and/or remove spaces in declarations.
Remove unused/commented declarations, remove unnecessary comment,
remove blank lines between declarations and add missing lines after
declarations. Also clears some line over 80 characters checkpatch
warnings.
Signed-off-by: Michael
Simplfy initialization of null arrays to improve readability
and save some lines.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_xmit.c | 6 ++
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a
Covert unsigned char arrays to u8 and make them static and/or const
where possible.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 18 ++---
.../staging/rtl8188eu/core/rtw_wlan_util.c| 26 +--
drivers/staging/rtl8188eu/include
Add spaces around '&' to follow kernel coding style.
Reported by ceckpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 92 ++-
1 file changed, 47 insertions(+), 45 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw
The function is_basicrate() returns true or false, so change the
return type from int to bool.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
b
Remove unnecessary parentheses reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 324 +-
1 file changed, 162 insertions(+), 162 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
b/drivers/staging
The values of these arrays are never changed, so make them const.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
b/drivers/staging
Cleanup brace coding style issues reported by checkpatch.
ERROR: space required before the open brace '{'
WARNING: braces {} are not necessary for single statement blocks
CHECK: Unbalanced braces around else statement
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core
On 12/15/18 5:53 PM, Joe Perches wrote:
On Sat, 2018-12-15 at 17:46 +0100, Michael Straube wrote:
Replace tabs with spaces and/or remove spaces in declarations.
Remove unused/commented declarations, remove unnecessary comment,
remove blank lines between declarations and add missing lines after
Remove unused/commented declarations.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
index 8c566180d808
The arrays WFD_OUI and WMM_INFO_OUI are not used anywhere,
so remove them.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 2 --
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu
Change the order of array declarations in rtw_mlme_ext.c to improve
readability.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
b/drivers/staging
Add a missing blank line after declarations in rtw_mlme_ext.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
Replace tabs with spaces where appropriate.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
b/drivers/staging/rtl8188eu/core
Remove blank lines between declarations in rtw_mlme_ext.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
index
Change the type of some arrays from unsigned char to u8.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 16 +++---
.../staging/rtl8188eu/core/rtw_wlan_util.c| 22 +--
drivers/staging/rtl8188eu/include/rtw_mlme.h | 6
Remove comments from 'endif's where the corresponding 'if' is just
a few lines above to improve readability.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drive
Remove unnecessary parentheses, most of them reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 322 +-
1 file changed, 161 insertions(+), 161 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
b
Replace tabs with spaces and/or remove spaces in declarations.
Signed-off-by: Michael Straube
---
v1 -> v2
one logical thing per patch
replace some more tabs with spaces
remove some more comments
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 482 +-
1 file changed,
The function is_basicrate() returns true or false, so change the
return type from int to bool.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
b
Simplfy initialization of null arrays to improve readability
and save some lines.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_xmit.c | 6 ++
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a
Add spaces around '&' to follow kernel coding style.
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 90 +--
1 file changed, 45 insertions(+), 45 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/
Cleanup brace coding style issues reported by checkpatch.
ERROR: space required before the open brace '{'
WARNING: braces {} are not necessary for single statement blocks
CHECK: Unbalanced braces around else statement
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core
The array REALTEK_96B_IE is already declared in rtw_mlme.h,
so remove the declaration in rtw_mlme_ext.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
b/drivers
Make some arrays that are only used in rtw_mlme_ext.c static and
remove the corresponding extern declarations from rtw_mlme_ext.h.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 6 +++---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 5 -
2 files
The values of these arrays in rtw_mlme_ext.c and rtw_wlan_util.c
are never changed, so make them const.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 14 +-
.../staging/rtl8188eu/core/rtw_wlan_util.c| 26 +--
drivers/staging
With high IOPS storage being increasingly prevalent for guests
on Hyper-V and in Azure, make blk-mq the default so that the
full performance of the storage can be realized without having
to tweak other configuration settings.
Signed-off-by: Michael Kelley
---
drivers/scsi/storvsc_drv.c | 1 +
1
Use the correct comment style for SPDX identifiers in header files.
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/fsl-dpaa2/ethsw/dpsw-cmd.h | 2 +-
drivers/staging/fsl-dpaa2/ethsw/dpsw.h | 2 +-
drivers/staging/fsl-dpaa2/ethsw/ethsw.h| 2 +-
3 files changed
In these two cases, a value returned by rdmsr() or rdmsrl()
is ignored. Indicate that ignoring the value is intentional, so
that with the W=1 compilation option no warning is generated.
Signed-off-by: Michael Kelley
---
arch/x86/hyperv/hv_apic.c | 2 +-
arch/x86/hyperv/hv_spinlock.c | 2
The SPDX identifier is a legally binding shorthand,
which can be used instead of the full boiler plate text.
There is a SPDX identifier line in goldfish_audio.c.
Remove the GPL boiler plate text to reduce file size.
Signed-off-by: Michael Straube
---
drivers/staging/goldfish/goldfish_audio.c
This satisfies a checkpatch warning and is the preferred
method for notating the license.
The SPDX identifier is a legally binding shorthand, which
can be used instead of the full boiler plate text.
Signed-off-by: Michael Straube
---
drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 12
Cleanup alignment issue reported by checkpatch.
CHECK: Alignment should match open parenthesis
Signed-off-by: Michael Straube
---
drivers/staging/gs_fpgaboot/io.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/gs_fpgaboot/io.c b/drivers/staging/gs_fpgaboot
This satisfies a checkpatch warning and is the preferred
method for notating the license.
The SPDX identifier is a legally binding shorthand, which
can be used instead of the full boiler plate text.
Signed-off-by: Michael Straube
---
drivers/staging/mt29f_spinand/mt29f_spinand.c | 11
c 29 19:21:17 gentoo kernel: BUG: unable to handle kernel NULL pointer
dereference at
Fixes: 6bd082af7e36 ("staging:r8188eu: use lib80211 CCMP decrypt")
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/Kconfig | 1 -
drivers/s
On 1/1/19 3:17 AM, Larry Finger wrote:
On 12/30/18 12:39 PM, Michael Straube wrote:
Commit 6bd082af7e36 ("staging:r8188eu: use lib80211 CCMP decrypt")
is causing hardfreeze whenever the driver tries to connect to my wifi
network. That makes the driver unusable on my system. Reverting
try_then_request_module() in rtw_aes_encrypt() and it looks good.
Perhaps the same applies for the reverted TKIP changes?
Michael
On 1/1/19 5:17 AM, Larry Finger wrote:
On 12/30/18 12:39 PM, Michael Straube wrote:
Commit 6bd082af7e36 ("staging:r8188eu: use lib80211 CCMP decrypt")
is causing hardfreez
thru 7.8.7.5 in the
Hyper-V TLFS. So Hyper-V defines its own VP index that is akin to the index
into the cpu_logical_map, though it may not be the same mapping. My earlier
comments may have been misleading -- the Hyper-V VP index is an integer
ranging from 0 thru (# vCPUs - 1).
Wi
re is any higher level synchronization
that prevents multiple threads from running the above code on the same channel.
Even if there is such higher level synchronization, this code probably shouldn't
depend on it for correctness.
Michael
___
devel ma
Hi,
I noticed "D-Link DWA-121 rev B1" was added to the stand-alone driver on github.
https://github.com/lwfinger/rtl8188eu/commit/a0619a07cd1e31776b1c9bb956a5b8570a912598
Should it also be added to the staging driver?
I have no such device to test.
This device was added to the stand-alone driver on github.
Add it to the staging driver as well.
Link: https://github.com/lwfinger/rtl8188eu/commit/a0619a07cd1e
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
rs/hv/channel_mgmt.c | 18 +++
> drivers/hv/hyperv_vmbus.h | 4 +-
> drivers/hv/vmbus_drv.c| 48 +++
> include/linux/hyperv.h| 98 +++----
> 5 files changed, 79 insertions(+), 93 deletions(-)
Reviewed-by: Michae
Replace tabs with spaces and/or remove extra spaces in declarations.
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index 668
Remove unnecessary parentheses reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging/rtl8188eu/os_dep
Add spaces around '+', '<<' and '*' to follow kernel coding style.
Reported by checkpatch.
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging/rtl8188eu/os_dep/os_in
Add spaces around '+', '<<' and '*' to follow kernel coding style.
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/st
Replace tabs with spaces and/or remove extra spaces in declarations.
Signed-off-by: Michael Straube
---
v1 -> v2
added missing Signed-off-by
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl818
.c | 14 -
> drivers/hv/vmbus_drv.c | 32
> include/linux/hyperv.h | 38
> 4 files changed, 116 insertions(+), 1 deletion(-)
>
Reviewed-by: Michael Kelley
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Cleanup indenting issue reported by checkpatch.
CHECK: Alignment should match open parenthesis
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/mlme_linux.c
Add spaces around '+' and '-' to follow kernel coding style.
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/mlm
On 1/17/19 8:44 PM, Joe Perches wrote:
On Thu, 2019-01-17 at 20:23 +0100, Michael Straube wrote:
Cleanup indenting issue reported by checkpatch.
CHECK: Alignment should match open parenthesis
[]
diff --git a/drivers/staging/rtl8188eu/os_dep/mlme_linux.c
b/drivers/staging/rtl8188eu/os_dep
f RSS indirection table")
> Reported-by: Wei Hu
> Signed-off-by: Haiyang Zhang
> ---
> drivers/net/hyperv/rndis_filter.c | 25 +++--
> 1 file changed, 19 insertions(+), 6 deletions(-)
>
Reviewed-by: Michael Kelley
___
d
> drivers/net/hyperv/netvsc_drv.c | 134
> 1 file changed, 85 insertions(+), 49 deletions(-)
>
Reviewed-by: Michael Kelley
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
t/hyperv/netvsc.c | 2 +-
> drivers/net/hyperv/netvsc_drv.c | 5 -
> drivers/net/hyperv/rndis_filter.c | 9 +++--
> 4 files changed, 19 insertions(+), 7 deletions(-)
>
Reviewed-by: Michael Kelley
__
From: Michael Kelley Sent: Friday, January 4, 2019 12:05 PM
>
> > >> As Will said, this isn't a viable option. Please follow SMCCC 1.1.
> > >
> > > I'll have to start a conversation with the Hyper-V team about this.
> > > I don't
+-
> include/uapi/linux/ndctl.h | 1 +
> 3 files changed, 10 insertions(+), 2 deletions(-)
>
Reviewed-by: Michael Kelley
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
r
> of struct hv_pcibus_device.
>
> Signed-off-by: Maya Nakamura
> ---
> Change in v2:
> - None
>
Right -- there was no code change. But it's customary to note that
you updated the commit message.
Reviewed-by: Michael Kelley
eturns
0, and the other case returns -1. The above test only catches the 0
failure case. Need to modify the test to catch both cases.
Michael
> + res = 1;
> + goto exit_unlock;
> + }
>
___
Cleanup comments to avoid lines over 80 characters
and follow kernel style for block comments.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep
Instead of first asign 'wrqu.data.length = p - buff' use 'p - buff'
directly in min_t() in the subsequent asignment. Clears a line over
80 characters checkpatch warning.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 3 +--
1 file change
Replace tabs with spaces in declarations to cleanup whitespace.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/mlme_linux.c
b/drivers/staging/rtl8188eu
Move the declaration of 'psec_priv' out of the else path and use it
in the if path as well to improve readability. Also clears line over
80 characters checkpatch warnings.
Suggested-by: Joe Perches
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/mlme_li
Change '&array[0]' to just 'array' in rtw_reset_securitypriv().
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/mlme_linux.c
b/d
The local variables backup_index, backup_counter and backup_time
in rtw_reset_securitypriv() are all asigned before their uses, so
initialization to zero is not necessary.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 6 +++---
1 file changed, 3 insertions
uct hv_pcibus_device.
>
> Signed-off-by: Maya Nakamura
> ---
> Change in v3:
> - Correct the v2 change log.
>
> Change in v2:
> - Update the commit message.
>
Reviewed-by: Michael Kelley
___
devel mailing list
de...@li
essary dev_err()'s.
> - Unlock before returning.
> - Update the commit message.
>
Reviewed-by: Michael Kelley
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
201 - 300 of 1079 matches
Mail list logo
