Re: [PATCH v2] staging: iio: tsl2x7x: clean up limit checks

Hi Dan, just minor nitpicking on the commit message: On 08/09/2017 12:53, Dan Carpenter wrote: > The background of this code is that we can either use the default > tables or load our own table with sysfs. The default tables are three > element arrays of struct tsl2x7x_lux. If we load the table

Re: [PATCH v2] staging: iio: tsl2x7x: clean up limit checks

On 16/09/2017 13:37, Dan Carpenter wrote: > On Sat, Sep 16, 2017 at 01:11:29PM +0200, Paolo Cretaro wrote: >> Hi Dan, >> just minor nitpicking on the commit message: >> >> On 08/09/2017 12:53, Dan Carpenter wrote: >>> The background of this code is that we can

[PATCH] staging: android: ion: Remove whitespace before quoted newline

Fix checkpatch.pl warning about unnecessary whitespace before a quoted newline. Signed-off-by: Paolo Cretaro --- drivers/staging/android/ion/ion_chunk_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging

Re: [PATCH] staging: android: ion: Remove whitespace before quoted newline

On 19/04/2017 09:34, Paolo Cretaro wrote: Fix checkpatch.pl warning about unnecessary whitespace before a quoted newline. Signed-off-by: Paolo Cretaro --- drivers/staging/android/ion/ion_chunk_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android

[PATCH v2] staging: android: ion: Remove whitespace before quoted newline

Fix checkpatch.pl warning about unnecessary whitespace before a quoted newline. Signed-off-by: Paolo Cretaro --- drivers/staging/android/ion/ion_chunk_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging

[PATCH] staging: iio: tsl2x7x: Replace deprecated macros (S_IRUGO, S_IWUSR)

Use octal digits as suggested by checkpatch instead of deprecated macros. Signed-off-by: Paolo Cretaro --- drivers/staging/iio/light/tsl2x7x_core.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers

[PATCH v3] staging: android: ion: Remove whitespace before quoted newline

Fix checkpatch.pl warning about unnecessary whitespace before a quoted newline. Signed-off-by: Paolo Cretaro --- Sorry seems in v2 some white spaces corrupted the patch drivers/staging/android/ion/ion_chunk_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] staging: media: atomisp: declare not-exported functions as static

clared. Should it be static? Signed-off-by: Paolo Cretaro --- .../media/atomisp/platform/intel-mid/atomisp_gmin_platform.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c b/drivers/

[PATCH] staging: lustre: lnet: specify address space

Fix warning issued by sparse: incorrect type in assignment (different address spaces). Signed-off-by: Paolo Cretaro --- drivers/staging/lustre/lnet/lnet/lib-socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/lnet/lib-socket.c b/drivers

[PATCH] staging: android: ion: set init function as static

Fix warning issued by sparse: symbol 'ion_device_create' was not declared. Should it be static? Signed-off-by: Paolo Cretaro --- drivers/staging/android/ion/ion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/a

[PATCH] [media] atomisp: use NULL instead of 0 for pointers

Fix warning issued by sparse: Using plain integer as NULL pointer Signed-off-by: Paolo Cretaro --- drivers/staging/media/atomisp/i2c/ov5693/ov5693.c | 2 +- .../media/atomisp/pci/atomisp2/css2400/runtime/bufq/src/bufq.c| 2 +- .../media/atomisp/pci/atomisp2/css2400

[PATCH] staging: pi433: use IS_ERR to check kthread_run return value

Fix compiler warning: ordered comparison of pointer with integer zero Signed-off-by: Paolo Cretaro --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 1bc478a7f49e

Re: [PATCH] staging: pi433: use IS_ERR to check kthread_run return value

On 22/07/2017 12:27, Paolo Cretaro wrote: > Fix compiler warning: ordered comparison of pointer with integer zero Sorry, just noticed a similar patch has been submitted a few days ago, please ignore this patch. Paolo > > Signed-off-by: Paolo Cretaro > --- > drivers/staging/p

[PATCH] staging: vboxvideo: remove unused variables

Fix compiler warnings: vbox_mode.c:57:15: warning: variable ‘crtc_id’ set but not used vbox_mode.c:581:25: warning: variable ‘vbox_connector’ set but not used Signed-off-by: Paolo Cretaro --- drivers/staging/vboxvideo/vbox_mode.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers