于 2013年09月05日 18:48, Dan Carpenter 写道:
On Thu, Sep 05, 2013 at 05:45:38PM +0800, wei_w...@realsil.com.cn wrote:
From: Wei WANG
In some platforms, specially Thinkpad series, rts5249 won't be
initialized properly. So we need adjust some phy parameters to
improve the compatibility issue.
Signed-
于 2013年09月10日 17:09, wei_w...@realsil.com.cn 写道:
> From: Wei WANG
>
> In some platforms, specially Thinkpad series, rts5249 won't be
> initialized properly. So we need adjust some phy parameters to
> improve the compatibility issue.
Hi all:
Sorry, forget to modify the subject prefix. Please igno
于 2013年09月09日 21:02, Lee Jones 写道:
#define PHY_FLD4 0x1E
>+#define FLDEN_SEL 0x4000
>+#define REQ_REF 0x2000
>+#define RXAMP_OFF 0x1000
>+#define REQ_ADDA 0x0800
>+#define BER_COUNT 0x00
于 2013年09月10日 17:28, Lee Jones 写道:
I would like some more information in the commit log though. You're
making a lot of configuration changes here and due to the
incomprehensible 'magic numbers' used previously, it's impossible to
know what you're changing by just reading the code.
Why won't the
于 2013年09月10日 19:08, Lee Jones 写道:
I'm not asking for in-depth analysis, just an overview.
What's wrong with the default config?
Why is the signal quality bad and what makes it bad?
What did the old magic numbers do?
How will the configuration differ if I applied your patch?
It is a little dif
