"(or else something is customized in your submission process that has somehow broken this functionality)."
Exactly right, Tim. There was some long-forgotten code in edit-metadata.jsp from a programmer who used to work here which was causing the problem. Thanks to you, Mark and Stuart for all your help. Regards Gary GARY BROWNE | Development Programmer Library IT Services | University Library THE UNIVERSITY OF SYDNEY T +61 2 9351 5946 | F +61 2 9036 0000 > -----Original Message----- > From: Tim Donohue [mailto:tdono...@duraspace.org] > Sent: Wednesday, 3 February 2010 4:53 AM > To: dspace-tech@lists.sourceforge.net > Subject: Re: [Dspace-tech] Display order of authors doesn't match > submission order > > Gary, > > This issue that you are seeing still sounds like it's the exact same as > this old, fixed issue: > > http://jira.dspace.org/jira/browse/DS-153 > > If you read that issue text, the reordering often occurred *during* the > submission process (as you are seeing). But, that issue was fixed in > the 1.5.2 release, so I'm not sure why you are still seeing this > problem > (unless your upgrade did not work properly, or unless there is still an > unfixed version of the org.dspace.submit.step.DescribeStep class in > your > installation). > > If you have a chance, you may want to try this same activity on a fresh > installation of 1.5.2. It works fine in both the JSPUI and XMLUI > submission processes (I just re-tested both of them). > > Alternatively, you could add in some logging methods into the > org.dspace.submit.step.DescribeStep getRepeatedParameter() method to > ensure that the fixed version of this file is being called (and not > some > other version on your PATH). Your org.dspace.submit.step.DescribeStep > getRepeatedParameter() method should include a comment saying "//First, > add the previously entered values" --> following this comment is the > new > bit of code that ensures author ordering is maintained. > > The only thing that I could think of being a problem is that some part > of your upgrade didn't work right (or else something is customized in > your submission process that has somehow broken this functionality). > > Good luck. Let us know if you discover the cause of the problem or > need > more help. > > - Tim > > On 2/1/2010 6:56 PM, Gary Browne wrote: > > Further to my last message, I've also discovered that even if I > simply add the authors and then click through to submission, at the > Verify Submission step the authors have been reordered too. > > > > GARY BROWNE | Development Programmer > > Library IT Services | University Library > > THE UNIVERSITY OF SYDNEY > > T +61 2 9351 5946 | F +61 2 9036 0000 > > > > > >> -----Original Message----- > >> From: Gary Browne > >> Sent: Tuesday, 2 February 2010 11:52 AM > >> To: 'dspace-tech@lists.sourceforge.net' > >> Subject: RE: [Dspace-tech] Display order of authors doesn't match > >> submission order > >> > >> Hi all, > >> > >> An update on this issue - I've discovered that perhaps it is not a > >> problem with the code ordering the authors after submission but > >> possibly DURING submission. > >> > >> I've noticed that after you have added more than one author and do > the > >> following: > >> > >> * click the "Add More" button > >> * go to the next page and come back using the next/prev buttons > >> > >> That the author names are reordered on the metadata form. If you do > >> this multiple times it appears that there is a specific pattern to > the > >> reordering eg: in a list with three authors, 1st becomes 3rd, 2nd > >> becomes 1st and 3rd becomes 2nd. > >> > >> With this behaviour, it is very likely that users are not going to > pick > >> up on this and that the intended ordering of authors (whilst I > realise > >> is not a given anyway) will not be reflected in the database and, > >> hence, GUI display. > >> > >> Has anyone else noticed this or similar behaviours, and what can be > >> done about it? > >> > >> Thanks > >> Gary > >> > >> > >> GARY BROWNE | Development Programmer > >> Library IT Services | University Library > >> THE UNIVERSITY OF SYDNEY > >> T +61 2 9351 5946 | F +61 2 9036 0000 > >> > >> > >>> -----Original Message----- > >>> From: Stuart Lewis [mailto:s.le...@auckland.ac.nz] > >>> Sent: Monday, 1 February 2010 4:45 PM > >>> To: Gary Browne > >>> Cc: Sten Christensen > >>> Subject: Re: [Dspace-tech] Display order of authors doesn't match > >>> submission order > >>> > >>> Are you still getting the error when building with 'mvn package'? > >>> > >>> If so, you could try running 'mvn clean' first to get blow away the > >>> previously compiled code, then run 'mvn -U package' to build the > >> whole > >>> thing from scratch again. > >>> > >>> Thanks, > >>> > >>> > >>> Stuart > >>> > >>> On 1/02/2010, at 3:43 PM, Gary Browne wrote: > >>> > >>>> Thanks Stuart, > >>>> > >>>> Yep, I've been through the patch and that code is certainly > already > >>> in my 1.5.2 production instance. It is an upgraded instance from > >> 1.4.2 > >>> - does that make a difference? > >>>> > >>>> Cheers > >>>> Gary > >>>> > >>>> GARY BROWNE | Development Programmer > >>>> Library IT Services | University Library > >>>> THE UNIVERSITY OF SYDNEY > >>>> T +61 2 9351 5946 | F +61 2 9036 0000 > >>>> > >>>> > >>>>> -----Original Message----- > >>>>> From: Stuart Lewis [mailto:s.le...@auckland.ac.nz] > >>>>> Sent: Sunday, 31 January 2010 6:21 AM > >>>>> To: Gary Browne > >>>>> Cc: Sten Christensen > >>>>> Subject: Re: [Dspace-tech] Display order of authors doesn't match > >>>>> submission order > >>>>> > >>>>> Sorry, forgot to 'reply-all' to my last reply: > >>>>> > >>>>> > >>>>> Hi Gary, > >>>>> > >>>>> You could try using the original complete patch, which is > >> available > >>>>> from: > >>>>> > >>>>> - > >>>>> > >>> > >> > http://sourceforge.net/tracker/index.php?func=detail&aid=2541285&group_ > >>>>> id=19984&atid=119984 > >>>>> > >>>>> This should be in your 1.5.2 instance though, as it was added in > >>> that > >>>>> release, so it is confusing why you are seeing this problem. Is > it > >>> an > >>>>> upgraded instance (was previously an older version) or a fresh > >>>>> installation? > >>>>> > >>>>> Thanks, > >>>>> > >>>>> > >>>>> Stuart Lewis > >>>>> IT Innovations Analyst and Developer > >>>>> Te Tumu Herenga The University of Auckland Library > >>>>> Auckland Mail Centre, Private Bag 92019, Auckland 1142, New > >> Zealand > >>>>> Ph: 64 9 373-7599 x81928 > >>>>> http://www.library.auckland.ac.nz/ > >>>>> > >>>>> > >>>>> On 29/01/2010, at 12:57 PM, Gary Browne wrote: > >>>>> > >>>>>> Hi Stuart, > >>>>>> > >>>>>> My manager, Sten Christensen, advised that I write to you > >> directly > >>>>>> regarding this issue. > >>>>>> > >>>>>> See thread below: basically, when items are submitted to our > >>>>> production > >>>>>> 1.5.2 environment, the submission author ordering is messed up > in > >>> the > >>>>>> GUI. I tried Mark Diggory's suggestion of replacing the > >>>>>> DescribeStep.java file with the patched version, but it is > >> missing > >>> a > >>>>>> method which then causes an exception to be thrown. > >>>>>> > >>>>>> Would you have any other suggestions on how to get this working? > >>>>>> > >>>>>> Thanks very much, > >>>>>> Gary Browne > >>>>>> > >>>>>> > >>>>>> GARY BROWNE | Development Programmer > >>>>>> Library IT Services | University Library > >>>>>> THE UNIVERSITY OF SYDNEY > >>>>>> T +61 2 9351 5946 | F +61 2 9036 0000 > >>>>>> > >>>>>> From: Gary Browne [mailto:gary.bro...@sydney.edu.au] > >>>>>> Sent: Thursday, 21 January 2010 11:57 AM > >>>>>> To: dspace-tech@lists.sourceforge.net > >>>>>> Subject: Re: [Dspace-tech] Display order of authors doesn't > match > >>>>>> submissionorder > >>>>>> > >>>>>> Hi Mark, > >>>>>> > >>>>>> I tried copying the suggested file (DescribeStep.java) to > >>>>>> [dspace-src]/dspace- > >>>>> api/src/main/java/org/dspace/submit/step/DescribeSte > >>>>>> p.java, however now on submission the following error is > >> triggered: > >>>>>> > >>>>>> > >>>>>> HTTP Status 500 - > >>>>>> > >>>>>> type Exception report > >>>>>> > >>>>>> message > >>>>>> > >>>>>> description The server encountered an internal error () that > >>>>> prevented > >>>>>> it from fulfilling this request. > >>>>>> > >>>>>> exception > >>>>>> > >>>>>> java.lang.NoSuchMethodError: > >>>>>> > >>>>> > >>> > >> > org.dspace.submit.step.DescribeStep.getInputsReader(Ljava/lang/String;) > >>>>> L > >>>>>> org/dspace/app/util/DCInputsReader; > >>>>>> > >>>>>> > >>>>> > >>> > >> > org.dspace.app.webui.submit.step.JSPDescribeStep.showEditMetadata(JSPDe > >>>>> s > >>>>>> cribeStep.java:241) > >>>>>> > >>>>>> > >>>>> > >>> > >> > org.dspace.app.webui.submit.step.JSPDescribeStep.doPreProcessing(JSPDes > >>>>> c > >>>>>> ribeStep.java:144) > >>>>>> > >>>>>> > >>>>> > >>> > >> > org.dspace.app.webui.submit.JSPStepManager.doStepStart(JSPStepManager.j > >>>>> a > >>>>>> va:315) > >>>>>> > >>>>>> > >>>>> > >>> > >> > org.dspace.app.webui.submit.JSPStepManager.processStep(JSPStepManager.j > >>>>> a > >>>>>> va:278) > >>>>>> > >>>>>> > >>>>>> This would appear to be because, AFAICS, the patch file compared > >> to > >>>>> my > >>>>>> current production file removes two code blocks: > >>>>>> > >>>>>> The first is: > >>>>>> > >>>>>> // Only check for required fields if user clicked the "next", > the > >>>>>> "previous" or the "progress bar" button > >>>>>> if (buttonPressed.equals(NEXT_BUTTON) > >>>>>> || buttonPressed.startsWith(PROGRESS_BAR_PREFIX) > >>>>>> || buttonPressed.equals(PREVIOUS_BUTTON) > >>>>>> || buttonPressed.equals(CANCEL_BUTTON)) > >>>>>> { > >>>>>> > >>>>>> The second (and troublesome one in this instance) is: > >>>>>> > >>>>>> /** > >>>>>> * @param filename > >>>>>> * file to get the input reader for > >>>>>> * @return the current DCInputsReader > >>>>>> */ > >>>>>> public static DCInputsReader getInputsReader(String filename) > >>>>> throws > >>>>>> ServletException > >>>>>> { > >>>>>> inputsReader = new DCInputsReader(filename); > >>>>>> return inputsReader; > >>>>>> } > >>>>>> > >>>>>> Thus the above exception is thrown. I presume this > DCInputsReader > >>>>> method > >>>>>> is being called from somewhere - do I need to make changes to > or > >>>>>> replace any other classes? > >>>>>> > >>>>>> Thanks > >>>>>> Gary > >>>>>> > >>>>>> > >>>>>> GARY BROWNE | Development Programmer > >>>>>> Library IT Services | University Library > >>>>>> THE UNIVERSITY OF SYDNEY > >>>>>> T +61 2 9351 5946 | F +61 2 9036 0000 > >>>>>> > >>>>>> From: mdigg...@gmail.com [mailto:mdigg...@gmail.com] On Behalf > Of > >>>>> Mark > >>>>>> Diggory > >>>>>> Sent: Thursday, 14 January 2010 3:39 PM > >>>>>> To: Gary Browne > >>>>>> Cc: dspace-tech@lists.sourceforge.net > >>>>>> Subject: Re: [Dspace-tech] Display order of authors doesn't > match > >>>>>> submission order > >>>>>> > >>>>>> Gary, > >>>>>> On Wed, Jan 13, 2010 at 3:32 PM, Gary Browne > >>>>> <gary.bro...@sydney.edu.au> > >>>>>> wrote: > >>>>>> Hi all, > >>>>>> > >>>>>> I'm running dspace 1.5.2. After submitting an item, the author > >>>>> listing > >>>>>> is not preserved in the same order as the submission order. Is > >>> there > >>>>>> some configuration in dspace.cfg which applies to this? I note > >> that > >>>>>> there is the jira issue DS-153 but I'm not clear whether this > >>> applies > >>>>> to > >>>>>> 1.5.2. If so, are there instructions somewhere about applying > >>> patches > >>>>> to > >>>>>> DSpace? I found this: > >>>>>> > >>>>>> http://wiki.dspace.org/index.php/ApplyingPatches > >>>>>> > >>>>>> but it doesn't actually describe the technical process. > >>>>>> > >>>>>> Quick, dirty solution. > >>>>>> > >>>>>> Take the following patched version of the file > >>>>>> > >>>>>> http://dspace.svn.sourceforge.net/viewvc/dspace/branches/dspace- > >>>>> 1_5_x/ds > >>>>>> pace- > >>>>> > >> api/src/main/java/org/dspace/submit/step/DescribeStep.java?revision > >>>>>> =3394&pathrev=3394 > >>>>>> > >>>>>> and place it in one of three possible locations: > >>>>>> > >>>>>> If using the full source distribution, you can replace the > >> contents > >>>>> of > >>>>>> the class directly... > >>>>>> > >>>>>> [dspace-src]/dspace- > >>>>> api/src/main/java/org/dspace/submit/step/DescribeSte > >>>>>> p.java > >>>>>> > >>>>>> > >>>>>> or if using either distribution you cna choose one of the two > >>>>> following > >>>>>> locations: > >>>>>> > >>>>>> if using jspui > >>>>>> > >>>>>> [dspace- > >>>>> src]/dspace/modules/jspui/src/main/java/org/dspace/submit/step/D > >>>>>> escribeStep.java > >>>>>> > >>>>>> or if using xmlui > >>>>>> > >>>>>> [dspace- > >>>>> src]/dspace/modules/xmlui/src/main/java/org/dspace/submit/step/D > >>>>>> escribeStep.java > >>>>>> > >>>>>> > >>>>>> The later two place the class only within the webapplication you > >>> are > >>>>>> building. While the first option will put the class into all > >>>>>> webapplications and the lib directory used for the commandline > >>>>>> functionality. > >>>>>> > >>>>>> ... > >>>>>> > >>>>>> > >>>>>> Furthermore, I am running another (unpatched) 1.5.2 instance of > >>>>> dspace > >>>>>> which doesn't suffer from this problem - how can that be? > >>>>>> > >>>>>> Without reviewing the code, I recall the order of the authors is > >>>>>> actually driven off the order of database records within the > >>>>>> metadatavalue table in database. (someone correct me if I'm in > >>>>> error). > >>>>>> Thus differences in behavior may actually be an artifact of the > >>>>> database > >>>>>> behavior. Or perhaps your running the 1.5.x branch from svn > which > >>> has > >>>>>> this patch applied? > >>>>>> > >>>>>> Unfortunately, this is an area where flat old DC records and > >>>>> conversely > >>>>>> DSpace do not have particularly strong support. I suspect that > >>>>>> capturing the priority of authors could possibly best be held in > >>>>> textual > >>>>>> form within an additional field such as > >>>>>> dc.identifier.bibliographicCitation field as an unambiguous > >>> original > >>>>>> citation for the resource. > >>>>>> > >>>>>> I was reading... > >>>>>> http://www.mail-archive.com/dspace- > >>>>> t...@lists.sourceforge.net/msg05213.h > >>>>>> tml > >>>>>> > >>>>>> Which might make things "look" ok in the UI, but I wonder if its > >> of > >>>>> any > >>>>>> benefit in other parts of DSpace like crosswalks or oai. > Relying > >>> on > >>>>> the > >>>>>> order of XML fields for semantic detail about which is the > first, > >>>>>> second, third,... author is going to be both impossible to > >> validate > >>>>> and > >>>>>> preserve across disparate technologies/systems... > >>>>>> > >>>>>> See the Dublin Core usage guide, section 3... > >>>>>> > >>>>>> http://dublincore.org/documents/usageguide/ > >>>>>> Each Dublin Core element is optional and repeatable, and there > is > >>> no > >>>>>> defined order of elements. The ordering of multiple occurrences > >> of > >>>>> the > >>>>>> same element (e.g., Creator) may have a significance intended by > >>> the > >>>>>> provider, but ordering is not guaranteed to be preserved in > every > >>>>> user > >>>>>> environment. Ordering or sequencing may be syntax dependent; for > >>>>>> instance, RDF/XML supports ordering, but HTML does not. > >>>>>> > >>>>>> Best attempt to preserve this ordering detail in some field such > >> as > >>>>> I've > >>>>>> recommended with dc.identifier.bibliographicCitation, even > though > >>> the > >>>>>> usage here is not going to get recorded perfectly by your users > >> in > >>>>> all > >>>>>> cases it will be obvious at least somewhere in the record. > >>>>>> > >>>>>> Best Regards, > >>>>>> Mark > >>>>>> > >>>>>> Mark R. Diggory > >>>>>> Head of U.S. Operations - @mire > >>>>>> > >>>>>> http://www.atmire.com - Institutional Repository Solutions > >>>>>> http://www.togather.eu - Before getting together, get t...@ther > >>>>> > >>>>> Stuart Lewis > >>>>> IT Innovations Analyst and Developer > >>>>> Te Tumu Herenga The University of Auckland Library > >>>>> Auckland Mail Centre, Private Bag 92019, Auckland 1142, New > >> Zealand > >>>>> Ph: 64 9 373-7599 x81928 > >>>>> http://www.library.auckland.ac.nz/ > >>>> > >>> > >>> Stuart Lewis > >>> IT Innovations Analyst and Developer > >>> Te Tumu Herenga The University of Auckland Library > >>> Auckland Mail Centre, Private Bag 92019, Auckland 1142, New Zealand > >>> Ph: 64 9 373-7599 x81928 > >>> http://www.library.auckland.ac.nz/ > > > > > > --------------------------------------------------------------------- > --------- > > The Planet: dedicated and managed hosting, cloud storage, colocation > > Stay online with enterprise data centers and the best network in the > business > > Choose flexible plans and management services without long-term > contracts > > Personal 24x7 support from experience hosting pros just a phone call > away. > > http://p.sf.net/sfu/theplanet-com > > _______________________________________________ > > DSpace-tech mailing list > > DSpace-tech@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/dspace-tech > > ----------------------------------------------------------------------- > ------- > The Planet: dedicated and managed hosting, cloud storage, colocation > Stay online with enterprise data centers and the best network in the > business > Choose flexible plans and management services without long-term > contracts > Personal 24x7 support from experience hosting pros just a phone call > away. > http://p.sf.net/sfu/theplanet-com > _______________________________________________ > DSpace-tech mailing list > DSpace-tech@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/dspace-tech ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ DSpace-tech mailing list DSpace-tech@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-tech
