Re: [DynInst_API:] BPatch_binaryEdit openBinary crashing

2015-02-25 Thread Bill Williams
On 02/25/2015 05:31 AM, Aleksandar Nikolic wrote: Hi list, So I am slowly working through issues regarding binary rewriting on windows. I made few patches so far and things are going in the right direction, I'd say. To document the patches more easily, I'm commiting them to github with

Re: [DynInst_API:] BPatch_binaryEdit openBinary crashing

2015-02-25 Thread Aleksandar Nikolic
On 02/25/2015 05:56 PM, Bill Williams wrote: On 02/25/2015 05:31 AM, Aleksandar Nikolic wrote: Hi list, So I am slowly working through issues regarding binary rewriting on windows. I made few patches so far and things are going in the right direction, I'd say. To document the patches

Re: [DynInst_API:] BPatch_binaryEdit openBinary crashing

2015-02-25 Thread Aleksandar Nikolic
I seem to have tracked down the cause of all my issues, at least partialy, to this piece of code in binaryEdit: base += (1024*1024); base -= (base (1024*1024-1)); in openFile Now, this base adjustment clearly has a purpose, but if commented out, the instrumented PE file that is produced has a

Re: [DynInst_API:] BPatch_binaryEdit openBinary crashing

2015-02-25 Thread Bill Williams
On 02/25/2015 02:28 PM, Aleksandar Nikolic wrote: I seem to have tracked down the cause of all my issues, at least partialy, to this piece of code in binaryEdit: base += (1024*1024); base -= (base (1024*1024-1)); in openFile Now, this base adjustment clearly has a purpose, but if commented

Re: [DynInst_API:] BPatch_binaryEdit openBinary crashing

2015-02-25 Thread Aleksandar Nikolic
Hi list, So I am slowly working through issues regarding binary rewriting on windows. I made few patches so far and things are going in the right direction, I'd say. To document the patches more easily, I'm commiting them to github with intention of submitting a complete patch directly to you

Re: [DynInst_API:] BPatch_binaryEdit openBinary crashing

2015-02-11 Thread Bill Williams
On 02/11/2015 05:03 AM, Aleksandar Nikolic wrote: Hi, looking at the codebase, a lot of code seems to already be there. I'll be getting to know the code in more details. Any directions into what would need to be implemented or what parts are missing? Thanks, Alex The biggest thing that needs

Re: [DynInst_API:] BPatch_binaryEdit openBinary crashing

2015-02-11 Thread Aleksandar Nikolic
Hi, looking at the codebase, a lot of code seems to already be there. I'll be getting to know the code in more details. Any directions into what would need to be implemented or what parts are missing? Thanks, Alex On 02/08/2015 10:59 PM, Barton Miller wrote: BTW, if there are any individuals

Re: [DynInst_API:] BPatch_binaryEdit openBinary crashing

2015-02-08 Thread Barton Miller
BTW, if there are any individuals or groups that would like to work on getting rewriting to work on Windows, we'd be happy to provide support. Not a small effort but interesting and worthwhile. --bart On 2/6/2015 4:36 PM, Bill Williams wrote: No, and not exactly. Windows binary rewriting is

Re: [DynInst_API:] BPatch_binaryEdit openBinary crashing

2015-02-06 Thread Aleksandar Nikolic
Ah, I see. Thanks for a quick response. Keep up the good work. On 02/06/2015 11:36 PM, Bill Williams wrote: On 02/06/2015 04:20 PM, Aleksandar Nikolic wrote: Hello list, I've been trying to use Dyninst to instrument a binary on Windows 7. There are some problems I'm having and I was

Re: [DynInst_API:] BPatch_binaryEdit openBinary crashing

2015-02-06 Thread Bill Williams
On 02/06/2015 04:20 PM, Aleksandar Nikolic wrote: Hello list, I've been trying to use Dyninst to instrument a binary on Windows 7. There are some problems I'm having and I was wondering if it's a bug or I am doing something wrong. No, and not exactly. Windows binary rewriting is not

[DynInst_API:] BPatch_binaryEdit openBinary crashing

2015-02-06 Thread Aleksandar Nikolic
Hello list, I've been trying to use Dyninst to instrument a binary on Windows 7. There are some problems I'm having and I was wondering if it's a bug or I am doing something wrong. What follows are some details. I've built Dyninst 8.2.1 on Windows 7 (32bit) with VS2010 and SDK 7.1, with boost