[DynInst_API:] [PATCH v2] Cleanup warnings

2016-04-30 Thread Peter Foley
Fix a bunch of misc warnings. [ 8%] Building CXX object common/CMakeFiles/common.dir/src/arch-aarch64.C.o /home/peter/dyninst/common/src/arch-aarch64.C:111:45: warning: unused parameter ‘ptr’ [-Wunused-parameter] void instruction::setInstruction(codeBuf_t *ptr, Address) {

Re: [DynInst_API:] [RFC PATCH] Cleanup warnings

2016-04-30 Thread Peter Foley
On Fri, Apr 29, 2016 at 5:24 PM, Bill Williams wrote: > InstructionDecoder-aarch64.C: we'd better be null-checking and failing the > entire decode if we hit the failure cases in this patch. Since most of the functions that call this code path return void, it wasn't at all clear