Re: [E1000-devel] [PATCH 00/62] drivers/net: Use static const

2010-11-20 Thread David Miller
From: Joe Perches Date: Sat, 20 Nov 2010 18:38:01 -0800 > Using static const generally increases object text and decreases data size. > It also generally decreases overall object size. Joe, I'm going to be frank and say that I'm not going to review and apply such a large chunk of networking patc

[E1000-devel] [PATCH 27/62] ixgbevf: Use static const

2010-11-20 Thread Joe Perches
Using static const generally increases object text and decreases data size. It also generally decreases overall object size. textdata bss dec hex filename 8436 3721728 105362928 drivers/net/ixgbevf/ethtool.o.old 8469 2521728 1044928d1 drivers/ne

[E1000-devel] [PATCH 28/62] ixgb: Use static const

2010-11-20 Thread Joe Perches
Using static const generally increases object text and decreases data size. It also generally decreases overall object size. textdata bss dec hex filename 4115 416 44849791373 drivers/net/ixgb/ixgb_param.o.old 3998 416 448486212fe drivers/ne

[E1000-devel] [PATCH 23/62] igb: Use static const

2010-11-20 Thread Joe Perches
Using static const generally increases object text and decreases data size. It also generally decreases overall object size. textdata bss dec hex filename 2544812806176 329048088 drivers/net/igb/e1000_phy.o.new 2546212806176 329188096 drivers/net/

[E1000-devel] [PATCH 26/62] ixgbe: Use static const

2010-11-20 Thread Joe Perches
Using static const generally increases object text and decreases data size. It also generally decreases overall object size. textdata bss dec hex filename 31444 566552 3805294a4 drivers/net/ixgbe/ixgbe_ethtool.o.new 30905 5606552 380179481 driver

[E1000-devel] [PATCH 00/62] drivers/net: Use static const

2010-11-20 Thread Joe Perches
Using static const generally increases object text and decreases data size. It also generally decreases overall object size. Summary of sizes old and new. Compiled allyesconfig x86 only. textdata bss dec hex filename 2075402 67170 466644 2609216 27d040 (TOTALS) -new 207459

[E1000-devel] [PATCH 16/62] e1000: Use static const

2010-11-20 Thread Joe Perches
Using static const generally increases object text and decreases data size. It also generally decreases overall object size. textdata bss dec hex filename 90831772 936 117912e0f drivers/net/e1000/e1000_param.o.new 91471772 936 118552e4f drivers/

[E1000-devel] [PATCH 15/62] e1000: Use static const

2010-11-20 Thread Joe Perches
Using static const generally increases object text and decreases data size. It also generally decreases overall object size. textdata bss dec hex filename 745384296 19168 98002 17ed2 drivers/net/e1000/e1000_hw.o.old 745014296 19168 97965 17ead drivers/net

[E1000-devel] [PATCH 17/62] e1000e: Use static const

2010-11-20 Thread Joe Perches
Using static const generally increases object text and decreases data size. It also generally decreases overall object size. textdata bss dec hex filename 3084714007088 3933599a7 drivers/net/e1000e/phy.o.new 3086114007088 3934999b5 drivers/net/e10