Re: [E1000-devel] [PATCH v2] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-06 Thread Al Viro
On Wed, Dec 07, 2011 at 02:36:20PM +0800, Michael Wang wrote: > On 12/07/2011 02:19 PM, Joe Perches wrote: [snip] > > if (*i2cctl & IXGBE_I2C_DATA_IN) > > - data = 1; > > + data = true; > > else > > - data = 0; > > + data = false; > > > > return

Re: [E1000-devel] [PATCH v2] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-06 Thread Joe Perches
On Wed, 2011-12-07 at 07:20 +, Al Viro wrote: > On Wed, Dec 07, 2011 at 02:36:20PM +0800, Michael Wang wrote: > > On 12/07/2011 02:19 PM, Joe Perches wrote: > > [snip] > > > if (*i2cctl & IXGBE_I2C_DATA_IN) > > > - data = 1; > > > + data = true; > > > else > > > - d

Re: [E1000-devel] [PATCH v2] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-06 Thread Michael Wang
On 12/07/2011 02:19 PM, Joe Perches wrote: > On Wed, 2011-12-07 at 14:08 +0800, Michael Wang wrote: >> I'm not good at script, if you are interested, we can work together to >> fix all the remain cases, and send out some patches. > > You should try coccinelle and spatch. > Hi, Joe I have not u

Re: [E1000-devel] [PATCH v2] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-06 Thread Joe Perches
On Wed, 2011-12-07 at 14:08 +0800, Michael Wang wrote: > I'm not good at script, if you are interested, we can work together to > fix all the remain cases, and send out some patches. You should try coccinelle and spatch. If you run the script, this is the intel output. drivers/net/ethernet/inte

Re: [E1000-devel] [PATCH v2] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-06 Thread Michael Wang
On 12/07/2011 02:01 PM, Joe Perches wrote: > On Wed, 2011-12-07 at 12:49 +0800, Michael Wang wrote: >> On 12/07/2011 12:14 PM, Joe Perches wrote: >> >>> On Tue, 2011-12-06 at 19:43 -0800, Jeff Kirsher wrote: On Tue, 2011-12-06 at 18:33 -0800, Michael Wang wrote: > From: Michael Wang

Re: [E1000-devel] [PATCH v2] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-06 Thread Joe Perches
On Wed, 2011-12-07 at 12:49 +0800, Michael Wang wrote: > On 12/07/2011 12:14 PM, Joe Perches wrote: > > > On Tue, 2011-12-06 at 19:43 -0800, Jeff Kirsher wrote: > >> On Tue, 2011-12-06 at 18:33 -0800, Michael Wang wrote: > >>> From: Michael Wang > >>> Use true and false instead of 1 and 0 when as

Re: [E1000-devel] [PATCH v2] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-06 Thread Michael Wang
On 12/07/2011 12:14 PM, Joe Perches wrote: > On Tue, 2011-12-06 at 19:43 -0800, Jeff Kirsher wrote: >> On Tue, 2011-12-06 at 18:33 -0800, Michael Wang wrote: >>> From: Michael Wang >>> Use true and false instead of 1 and 0 when assign value to a bool type >>> variable. >> Thanks Michael, I have a

[E1000-devel] programm eeprom - 82574L

2011-12-06 Thread 5snkaz3rw7
How do I program the eeprom on the 82574L under linux? I have a new part on an embedded product and right now the kernel is telling me: Dec 5 17:39:03 foo kernel: :03:00.0: :03:00.0: The NVM Checksum Is Not Valid This seems to prevent the interface from attaching, and so prevents me f

Re: [E1000-devel] [PATCH v2] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-06 Thread Joe Perches
On Tue, 2011-12-06 at 19:43 -0800, Jeff Kirsher wrote: > On Tue, 2011-12-06 at 18:33 -0800, Michael Wang wrote: > > From: Michael Wang > > Use true and false instead of 1 and 0 when assign value to a bool type > > variable. > Thanks Michael, I have added your patch to my queue of e1000e patches.

[E1000-devel] [PATCH v2] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-06 Thread Michael Wang
From: Michael Wang Use true and false instead of 1 and 0 when assign value to a bool type variable. This patch is try to keep the style of driver, and according to David's suggestion on patch "e1000e: Avoid wrong check on TX hang": http://marc.info/?l=linux-netdev&m=132296931201839&w=2 v2: add

Re: [E1000-devel] [PATCH] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-06 Thread Michael Wang
On 12/07/2011 04:10 AM, Jesse Brandeburg wrote: > On Mon, 5 Dec 2011 17:04:09 -0800 > Michael Wang wrote: >> Actually, I make this change because of my last patch: >> e1000e: Avoid wrong check on TX hang >> >> And I get the suggestion from David, the mail like below. >> He want me to use true and

Re: [E1000-devel] [PATCH] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-06 Thread Brandeburg, Jesse
sending this again as it didn't show up on the list for some reason (probably rejected because I pgp signed the message) -Original Message- From: Jesse Brandeburg [mailto:jesse.brandeb...@intel.com] Sent: Tuesday, December 06, 2011 12:10 PM To: Michael Wang Cc: e1000-devel@lists.sourcefo