Re: [E1000-devel] igb hard-coded mac_table[0] in igb_probe

2012-02-29 Thread James Bulpin
Hi Greg, Thanks for the reply and explanation. It does sound like a top down allocation strategy would work. From my point of view it's not high priority so maybe something for the possible future enhancements backlog. We could easily make the code change but we don't have the test infrastructu

Re: [E1000-devel] igb hard-coded mac_table[0] in igb_probe

2012-02-29 Thread Rose, Gregory V
> -Original Message- > From: James Bulpin [mailto:james.bul...@eu.citrix.com] > Sent: Wednesday, February 29, 2012 5:34 AM > To: e1000-devel@lists.sourceforge.net > Subject: [E1000-devel] igb hard-coded mac_table[0] in igb_probe > > We've noticed that the igb_probe() function hard-codes ma

[E1000-devel] igb hard-coded mac_table[0] in igb_probe

2012-02-29 Thread James Bulpin
We've noticed that the igb_probe() function hard-codes mac_table index 0 when setting the PF MAC entry. Unfortunately this happens after igb_set_sriov_capability() has run and used mac_table[0] for the VF0 initial MAC and therefore the PF MAC silently obliterates the VF0 config. In practice thi