Re: [E1000-devel] [PATCH 198/493] ethernet: remove use of __devinit

2012-11-21 Thread Russell King - ARM Linux
On Mon, Nov 19, 2012 at 01:22:27PM -0500, Bill Pemberton wrote: > drivers/net/ethernet/8390/etherh.c | 4 +- > drivers/net/ethernet/amd/am79c961a.c | 2 +- > drivers/net/ethernet/i825xx/ether1.c | 8 +- > drivers/net/ethernet/seeq/ether3.c

Re: [E1000-devel] Poor performance with ixgbe and E5-2643

2012-11-21 Thread Alexander Duyck
On 11/21/2012 09:18 AM, Ben Greear wrote: > On 11/21/2012 09:09 AM, Alexander Duyck wrote: >> On 11/20/2012 05:05 PM, Ben Greear wrote: >>> On 11/20/2012 04:34 PM, Ben Greear wrote: On 11/20/2012 04:18 PM, Ben Greear wrote: >>> >> Also, have you checked to make sure the feature set is comp

Re: [E1000-devel] Poor performance with ixgbe and E5-2643

2012-11-21 Thread Ben Greear
On 11/21/2012 09:09 AM, Alexander Duyck wrote: > On 11/20/2012 05:05 PM, Ben Greear wrote: >> On 11/20/2012 04:34 PM, Ben Greear wrote: >>> On 11/20/2012 04:18 PM, Ben Greear wrote: >> > Also, have you checked to make sure the feature set is comparable? > For > instance the E5 can suppo

Re: [E1000-devel] Poor performance with ixgbe and E5-2643

2012-11-21 Thread Alexander Duyck
On 11/20/2012 05:05 PM, Ben Greear wrote: > On 11/20/2012 04:34 PM, Ben Greear wrote: >> On 11/20/2012 04:18 PM, Ben Greear wrote: > Also, have you checked to make sure the feature set is comparable? For instance the E5 can support VT-d. If that is enabled it can have a negati

Re: [E1000-devel] [PATCH 331/493] ethernet: remove use of __devinitdata

2012-11-21 Thread Russell King - ARM Linux
This is getting painful to review; why couldn't all the changes to one set of drivers be grouped together? I'm having to search out the same drivers I'm responsible for many times in this patch set to do a review, and it's getting extremely tiresome and probably becoming more probable that I'll ma