Re: [E1000-devel] [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll

On 20/05/2013 23:20, Or Gerlitz wrote: > On Mon, May 20, 2013 at 1:16 PM, Eliezer Tamir > wrote: >> Add the ixgbe driver code implementing ndo_ll_poll. >> It should be easy for other drivers to do something similar >> in order to enable support for CONFIG_INET_LL_RX_POLL > > I am not sure, Willem

Re: [E1000-devel] [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll

On Tue, May 21, 2013 at 12:01 AM, Andi Kleen wrote: > > On Mon, May 20, 2013 at 11:42:37PM +0300, Or Gerlitz wrote: > > On Mon, May 20, 2013 at 11:33 PM, Andi Kleen wrote: > > > > > > > > This is discussed in 0/x > > > > > > > I am not with you, V3's cover letter is empty, and in V2's cover lette

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

On 20/05/2013 19:22, Andi Kleen wrote: >> diff --git a/Documentation/networking/ip-sysctl.txt >> b/Documentation/networking/ip-sysctl.txt >> index f98ca63..cfcf0ea 100644 >> --- a/Documentation/networking/ip-sysctl.txt >> +++ b/Documentation/networking/ip-sysctl.txt >> @@ -19,6 +19,11 @@ ip_no_pmt

Re: [E1000-devel] [PATCH v2 net-next 0/4] net: low latency Ethernet device polling

On Sun, 19 May 2013, Or Gerlitz wrote: > On Sun, May 19, 2013 at 1:25 PM, Eliezer Tamir > wrote: > > This is an updated version of the code we posted on February. > > Last time you've placed a copy of the patchset in the rfc branch of > git://github.com/jbrandeb/lls.git - can you repost there V2

Re: [E1000-devel] [PATCH v2 net-next 0/4] net: low latency Ethernet device polling

On Mon, May 20, 2013 at 1:09 PM, Jeff Kirsher wrote: > On Sun, 2013-05-19 at 22:20 +0300, Eliezer Tamir wrote: > > On 19/05/2013 22:06, Or Gerlitz wrote: > > > On Sun, May 19, 2013 at 1:25 PM, Eliezer Tamir > > > wrote: > > >> This is an updated version of the code we posted on February. > > > >

Re: [E1000-devel] [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll

On Mon, May 20, 2013 at 11:42:37PM +0300, Or Gerlitz wrote: > On Mon, May 20, 2013 at 11:33 PM, Andi Kleen wrote: > > > > > This is discussed in 0/x > > > > I am not with you, V3's cover letter is empty, and in V2's cover letter I > don't see that It was here. Looks like Eliezer didn't reuse th

Re: [E1000-devel] [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll

On Mon, May 20, 2013 at 11:33 PM, Andi Kleen wrote: > > This is discussed in 0/x > I am not with you, V3's cover letter is empty, and in V2's cover letter I don't see that -- AlienVault Unified Security Management (USM)

Re: [E1000-devel] [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll

> guys, so what is going here, you were asking to put this series in > net-next, and you expect each other driver implementing this ndo to > follow this undocumented hack? or maybe this code was just left here > by mistake from previous implementations and just needed to be > removed? please clari

Re: [E1000-devel] [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll

On Mon, May 20, 2013 at 1:16 PM, Eliezer Tamir wrote: > Add the ixgbe driver code implementing ndo_ll_poll. > It should be easy for other drivers to do something similar > in order to enable support for CONFIG_INET_LL_RX_POLL I am not sure, > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

Re: [E1000-devel] [PATCH v2 net-next 0/4] net: low latency Ethernet device polling

On Sun, 2013-05-19 at 22:20 +0300, Eliezer Tamir wrote: > On 19/05/2013 22:06, Or Gerlitz wrote: > > On Sun, May 19, 2013 at 1:25 PM, Eliezer Tamir > > wrote: > >> This is an updated version of the code we posted on February. > > > > Last time you've placed a copy of the patchset in the rfc branch

Re: [E1000-devel] [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

From: Eric Dumazet Date: Mon, 20 May 2013 08:29:24 -0700 > Part of this information was in your 0/4 text, but it wont be included > in the git tree. Yes it will, in the merge commit I make when I merge this stuff in. --

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

From: Eliezer Tamir Date: Mon, 20 May 2013 12:39:59 +0300 > On 20/05/2013 10:54, David Miller wrote: >> From: Eliezer Tamir >> Date: Sun, 19 May 2013 13:25:33 +0300 >> >>> +#else /* CONFIG_INET_LL_RX_FLUSH */ >>> + >>> +#define sk_valid_ll(sk) 0 >>> +#define sk_poll_ll(sk, nonblock) do {} while

Re: [E1000-devel] [PATCH 3/4] e1000e: Calculate the desc_len based on adapter type

On Mon, May 20, 2013 at 02:37:48AM -0700, Jeff Kirsher wrote: >On 05/20/2013 01:15 AM, Wei Yang wrote: >> desc_len represents the size of descriptor in rx_ring. There are two kinds of >> rx descriptors, e1000_rx_desc_packet_split(32 byte) and >> e1000_rx_desc_extended(16 byte). Different adapter wi

Re: [E1000-devel] [PATCH 4/4] e1000e: Not initialize the e1000_ps_page array when packet-split is not used

On Mon, May 20, 2013 at 02:38:07AM -0700, Jeff Kirsher wrote: >On 05/20/2013 01:15 AM, Wei Yang wrote: >> When packet split is not used, those fields are still initialized and memory >> is allocated for them. >> >> This patch check whether packet split is used and do the initialization base >> on t

Re: [E1000-devel] [PATCH 1/4] e1000e: Remove duplicate assignment of default rx/tx ring size

On Mon, May 20, 2013 at 02:37:16AM -0700, Jeff Kirsher wrote: >On 05/20/2013 01:15 AM, Wei Yang wrote: >> tx_ring/rx_ring size is assigned in function e1000_alloc_queues(), which is >> called by e1000_sw_init() in the early stage of e1000_probe(). >> >> This patch just remove the duplicate assignme

Re: [E1000-devel] [PATCH 2/4] e1000e: Use marco instead of digit for defining e1000_rx_desc_packet_split

On Mon, May 20, 2013 at 02:37:29AM -0700, Jeff Kirsher wrote: >On 05/20/2013 01:15 AM, Wei Yang wrote: >> In structure e1000_rx_desc_packet_split, the size of wb.upper.length is >> defined by a digit. This may introduce some problem when the lenght is >> changed. >> >> This patch use the marco PS_P

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

> diff --git a/Documentation/networking/ip-sysctl.txt > b/Documentation/networking/ip-sysctl.txt > index f98ca63..cfcf0ea 100644 > --- a/Documentation/networking/ip-sysctl.txt > +++ b/Documentation/networking/ip-sysctl.txt > @@ -19,6 +19,11 @@ ip_no_pmtu_disc - BOOLEAN > Disable Path MTU Dis

Re: [E1000-devel] [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

On Mon, 2013-05-20 at 13:16 +0300, Eliezer Tamir wrote: > Adds a new ndo_ll_poll method and the code that supports and uses it. > This method can be used by low latency applications to busy poll ethernet > device queues directly from the socket code. The ip_low_latency_poll sysctl > entry controls

Re: [E1000-devel] [PATCH v3 net-next 2/4] tcp: add TCP support for low latency receive poll.

on 20/05/2013 16:49, Eric Dumazet wrote: > On Mon, 2013-05-20 at 13:16 +0300, Eliezer Tamir wrote: >> >> +config INET_LL_TCP_POLL >> +bool "Low Latency TCP Receive Poll" >> +depends on INET_LL_RX_POLL >> +default n >> +---help--- >> + TCP support for Low Latency TCP Queue Poll.

Re: [E1000-devel] interface link goes down

> -Original Message- > From: ratheesh kannoth [mailto:ratheesh@gmail.com] > Sent: Saturday, May 11, 2013 8:34 AM > To: e1000-devel@lists.sourceforge.net > Subject: [E1000-devel] interface link goes down > > Hi, > > driver = igb-3.3.6 > hw->mac.type = e1000_82576 > media type =

Re: [E1000-devel] [PATCH v3 net-next 2/4] tcp: add TCP support for low latency receive poll.

On Mon, 2013-05-20 at 13:16 +0300, Eliezer Tamir wrote: > > +config INET_LL_TCP_POLL > + bool "Low Latency TCP Receive Poll" > + depends on INET_LL_RX_POLL > + default n > + ---help--- > + TCP support for Low Latency TCP Queue Poll. > + (For network cards that support

Re: [E1000-devel] [PATCH v2 net-next 0/4] net: low latency Ethernet device polling

On 19/05/2013 22:56, Or Gerlitz wrote: > On Sun, May 19, 2013 at 10:25 PM, Eliezer Tamir < > eliezer.ta...@linux.intel.com> wrote: > >> On 19/05/2013 22:06, Or Gerlitz wrote: >> >>> Last time you've placed a copy of the patchset in the rfc branch of >>> git://github.com/jbrandeb/lls.**git

[E1000-devel] [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll

Add the ixgbe driver code implementing ndo_ll_poll. It should be easy for other drivers to do something similar in order to enable support for CONFIG_INET_LL_RX_POLL Signed-off-by: Alexander Duyck Signed-off-by: Jesse Brandeburg Tested-by: Willem de Bruijn Signed-off-by: Eliezer Tamir --- dr

[E1000-devel] [PATCH v3 net-next 4/4] ixgbe: add extra stats for ndo_ll_poll

Add additional statistics to the ixgbe driver for ndo_ll_poll Defined under LL_EXTENDED_STATS Signed-off-by: Alexander Duyck Signed-off-by: Jesse Brandeburg Tested-by: Willem de Bruijn Signed-off-by: Eliezer Tamir --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 14 drivers/

[E1000-devel] [PATCH v3 net-next 2/4] tcp: add TCP support for low latency receive poll.

an example of how one could add support for ndo_ll_poll to TCP. Signed-off-by: Alexander Duyck Signed-off-by: Jesse Brandeburg Tested-by: Willem de Bruijn Signed-off-by: Eliezer Tamir --- net/ipv4/Kconfig | 11 +++ net/ipv4/tcp.c |9 + net/ipv4/tcp_input.c |

[E1000-devel] [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

Adds a new ndo_ll_poll method and the code that supports and uses it. This method can be used by low latency applications to busy poll ethernet device queues directly from the socket code. The ip_low_latency_poll sysctl entry controls how many cycles to poll. Set to zero to disable. Signed-off-by:

[E1000-devel] [PATCH v3 net-next 0/4] net: low latency Ethernet device polling

updated with the comments I got so far. Thanks, Eliezer -- AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently confi

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

On 20/05/2013 10:54, David Miller wrote: > From: Eliezer Tamir > Date: Sun, 19 May 2013 13:25:33 +0300 > >> +#else /* CONFIG_INET_LL_RX_FLUSH */ >> + >> +#define sk_valid_ll(sk) 0 >> +#define sk_poll_ll(sk, nonblock) do {} while (0) >> +#define skb_mark_ll(napi, skb) do {} while (0) >> +#define sk

Re: [E1000-devel] [PATCH 4/4] e1000e: Not initialize the e1000_ps_page array when packet-split is not used

On 05/20/2013 01:15 AM, Wei Yang wrote: > When packet split is not used, those fields are still initialized and memory > is allocated for them. > > This patch check whether packet split is used and do the initialization base > on the status. > > Signed-off-by: Wei Yang > --- > drivers/net/etherne

Re: [E1000-devel] [PATCH 3/4] e1000e: Calculate the desc_len based on adapter type

On 05/20/2013 01:15 AM, Wei Yang wrote: > desc_len represents the size of descriptor in rx_ring. There are two kinds of > rx descriptors, e1000_rx_desc_packet_split(32 byte) and > e1000_rx_desc_extended(16 byte). Different adapter will use different rx > descriptors. > > When allocating the dma spa

Re: [E1000-devel] [PATCH 2/4] e1000e: Use marco instead of digit for defining e1000_rx_desc_packet_split

On 05/20/2013 01:15 AM, Wei Yang wrote: > In structure e1000_rx_desc_packet_split, the size of wb.upper.length is > defined by a digit. This may introduce some problem when the lenght is > changed. > > This patch use the marco PS_PAGE_BUFFERS for the definition. And move the > definition to hw.h. >

Re: [E1000-devel] [PATCH 1/4] e1000e: Remove duplicate assignment of default rx/tx ring size

On 05/20/2013 01:15 AM, Wei Yang wrote: > tx_ring/rx_ring size is assigned in function e1000_alloc_queues(), which is > called by e1000_sw_init() in the early stage of e1000_probe(). > > This patch just remove the duplicate assignment of this default ring size > value. > > Signed-off-by: Wei Yang

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

From: Joe Perches Date: Mon, 20 May 2013 01:29:47 -0700 > On Mon, 2013-05-20 at 00:54 -0700, David Miller wrote: >> From: Eliezer Tamir > [] >> > { >> > struct socket *sock; >> > + unsigned int poll_result; >> >> Please order local variable declarations from longest line to >> shorte

[E1000-devel] Supplying Polyamide 6( Nylon 6)

Dear Sirs : This is Ms Sophia . We are a leading PA chips mfg, locatedin a Chemical Tech Zone, Hebei, China . We have a strategic cooperation with Sinopec. Pls check our PA chips . 1. Name : PA6 Chips, Virgin resin 2. Package : 25/800 kg net bag,16-18 tons in a 20'FCL 3. Delivery :

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

On Mon, 2013-05-20 at 00:54 -0700, David Miller wrote: > From: Eliezer Tamir [] > > { > > struct socket *sock; > > + unsigned int poll_result; > > Please order local variable declarations from longest line to > shortest line. reverse christmas tree doesn't seem especially valuable or

[E1000-devel] [PATCH 2/4] e1000e: Use marco instead of digit for defining e1000_rx_desc_packet_split

In structure e1000_rx_desc_packet_split, the size of wb.upper.length is defined by a digit. This may introduce some problem when the lenght is changed. This patch use the marco PS_PAGE_BUFFERS for the definition. And move the definition to hw.h. Signed-off-by: Wei Yang --- drivers/net/ethernet/

[E1000-devel] [PATCH 4/4] e1000e: Not initialize the e1000_ps_page array when packet-split is not used

When packet split is not used, those fields are still initialized and memory is allocated for them. This patch check whether packet split is used and do the initialization base on the status. Signed-off-by: Wei Yang --- drivers/net/ethernet/intel/e1000e/netdev.c | 38 ++---

[E1000-devel] [PATCH 0/4] trivial clean up for e1000e driver

Here is several trivial clean up for e1000e driver. Wei Yang (4): e1000e: Remove duplicate assignment of default rx/tx ring size e1000e: Use marco instead of digit for defining e1000_rx_desc_packet_split e1000e: Calculate the desc_len based on adapter type e1000e: Not initialize the e1

[E1000-devel] [PATCH 3/4] e1000e: Calculate the desc_len based on adapter type

desc_len represents the size of descriptor in rx_ring. There are two kinds of rx descriptors, e1000_rx_desc_packet_split(32 byte) and e1000_rx_desc_extended(16 byte). Different adapter will use different rx descriptors. When allocating the dma space for this descriptor in current implementation, t

[E1000-devel] [PATCH 1/4] e1000e: Remove duplicate assignment of default rx/tx ring size

tx_ring/rx_ring size is assigned in function e1000_alloc_queues(), which is called by e1000_sw_init() in the early stage of e1000_probe(). This patch just remove the duplicate assignment of this default ring size value. Signed-off-by: Wei Yang Reviewed-by: Gavin Shan Reviewed-by: Da Yu Qiu ---

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

From: Eliezer Tamir Date: Sun, 19 May 2013 13:25:33 +0300 > +#ifndef _LINUX_NET_LL_POLL_H > +#define _LINUX_NET_LL_POLL_H > +#ifdef CONFIG_INET_LL_RX_POLL Please put an empty line before the final ifdef test here. > +static inline void sk_mark_ll(struct sock *sk, struct sk_buff *skb) > +{ > +