Re: [E1000-devel] [PATCH net-next 1/2] net: remove NET_LL_RX_POLL config menue

2013-06-12 Thread Eliezer Tamir
On 13/06/2013 05:01, Stephen Hemminger wrote: > On Wed, 12 Jun 2013 15:12:05 -0700 (PDT) > David Miller wrote: > >> From: Eliezer Tamir >> Date: Tue, 11 Jun 2013 17:24:28 +0300 >> >>> depends on X86_TSC >> >> Wait a second, I didn't notice this before. There needs to be a better >> way to te

Re: [E1000-devel] [PATCH net-next 1/2] net: remove NET_LL_RX_POLL config menue

2013-06-12 Thread Stephen Hemminger
On Wed, 12 Jun 2013 15:12:05 -0700 (PDT) David Miller wrote: > From: Eliezer Tamir > Date: Tue, 11 Jun 2013 17:24:28 +0300 > > > depends on X86_TSC > > Wait a second, I didn't notice this before. There needs to be a better > way to test for the accuracy you need, or if the issue is lack o

Re: [E1000-devel] [PATCH net-next 1/2] net: remove NET_LL_RX_POLL config menue

2013-06-12 Thread David Miller
From: Eliezer Tamir Date: Tue, 11 Jun 2013 17:24:28 +0300 > depends on X86_TSC Wait a second, I didn't notice this before. There needs to be a better way to test for the accuracy you need, or if the issue is lack of a proper API for cycle counter reading, fix that rather than add ugly arc

Re: [E1000-devel] e1000e + suspend, 3.9-rc2

2013-06-12 Thread Konstantin Khlebnikov
Jiri Slaby wrote: > On 04/15/2013 05:29 PM, Jiri Slaby wrote: >> On 03/29/2013 07:04 PM, Allan, Bruce W wrote: -Original Message- From: Jiri Slaby [mailto:jirisl...@gmail.com] On Behalf Of Jiri Slaby Sent: Tuesday, March 19, 2013 5:23 AM To: Konstantin Khlebnikov Cc

Re: [E1000-devel] e1000e + suspend, 3.9-rc2

2013-06-12 Thread Jiri Slaby
On 04/15/2013 05:29 PM, Jiri Slaby wrote: > On 03/29/2013 07:04 PM, Allan, Bruce W wrote: >>> -Original Message- >>> From: Jiri Slaby [mailto:jirisl...@gmail.com] On Behalf Of Jiri Slaby >>> Sent: Tuesday, March 19, 2013 5:23 AM >>> To: Konstantin Khlebnikov >>> Cc: Borislav Petkov; Kirsher

Re: [E1000-devel] [PATCH] PCI: Remove not needed check in disable aspm link

2013-06-12 Thread Bjorn Helgaas
On Wed, Jun 12, 2013 at 12:20 AM, Yinghai Lu wrote: > On Tue, Apr 2, 2013 at 1:10 PM, Bjorn Helgaas wrote: >> On Mon, Apr 1, 2013 at 6:03 PM, Yinghai Lu wrote: commit 96e5d01cd536458435ef0678d9fa3dc542afb41f Author: Bjorn Helgaas Date: Mon Apr 1 15:47:39 2013 -0600

Re: [E1000-devel] [PATCH v2 net-next 3/3] net: add socket option for low latency polling

2013-06-12 Thread Eric Dumazet
On Wed, 2013-06-12 at 15:54 +0300, Eliezer Tamir wrote: > On 12/06/2013 15:44, Eric Dumazet wrote: > > On Wed, 2013-06-12 at 14:20 +0300, Eliezer Tamir wrote: > >> adds a socket option for low latency polling. > >> This allows overriding the global sysctl value with a per-socket one. > >> > >> Sign

Re: [E1000-devel] [PATCH v2 net-next 3/3] net: add socket option for low latency polling

2013-06-12 Thread Eliezer Tamir
On 12/06/2013 15:54, Eliezer Tamir wrote: > On 12/06/2013 15:44, Eric Dumazet wrote: >> On Wed, 2013-06-12 at 14:20 +0300, Eliezer Tamir wrote: >>> adds a socket option for low latency polling. >>> This allows overriding the global sysctl value with a per-socket one. >>> >>> Signed-off-by: Eliezer

Re: [E1000-devel] [PATCH v2 net-next 3/3] net: add socket option for low latency polling

2013-06-12 Thread Eliezer Tamir
On 12/06/2013 15:44, Eric Dumazet wrote: > On Wed, 2013-06-12 at 14:20 +0300, Eliezer Tamir wrote: >> adds a socket option for low latency polling. >> This allows overriding the global sysctl value with a per-socket one. >> >> Signed-off-by: Eliezer Tamir >> --- > > It seems EXPORT_SYMBOL_GPL(sysc

Re: [E1000-devel] [PATCH v2 net-next 2/3] net: change sysctl_net_ll_poll into an unsigned int

2013-06-12 Thread Eliezer Tamir
On 12/06/2013 15:04, Avner Ben Hanoch wrote: > Maybe better, I suggest opening an issue in sockperf issue system - > https://code.google.com/p/sockperf/issues/list > Then anyone can add notes or read/receive them. Thanks, I will do that once the review of the Linux patch is complete. -Eliezer

Re: [E1000-devel] [PATCH v2 net-next 3/3] net: add socket option for low latency polling

2013-06-12 Thread Eric Dumazet
On Wed, 2013-06-12 at 14:20 +0300, Eliezer Tamir wrote: > adds a socket option for low latency polling. > This allows overriding the global sysctl value with a per-socket one. > > Signed-off-by: Eliezer Tamir > --- It seems EXPORT_SYMBOL_GPL(sysctl_net_ll_poll) can now be removed ? -

Re: [E1000-devel] [PATCH v2 net-next 2/3] net: change sysctl_net_ll_poll into an unsigned int

2013-06-12 Thread Avner Ben Hanoch
Hi, Please make sure to include sockperf-...@googlegroups.com among the recipients of this thread (I just added). Maybe better, I suggest opening an issue in sockperf issue system - https://code.google.com/p/sockperf/issues/list . Then anyone can add notes or read/receive them. You can see an

[E1000-devel] [PATCH v2 sockperf] sockperf: add SO_LL socketop support

2013-06-12 Thread Eliezer Tamir
Add lls socket option support. use --lls (value in usecs) to override global setting. Right now we always get and print the value of the option before we set, to show that the option works properly. This should be removed in an official release. --- src/Defs.h |3 +++ src/SockPerf.cpp

[E1000-devel] [PATCH v2 net-next 3/3] net: add socket option for low latency polling

2013-06-12 Thread Eliezer Tamir
adds a socket option for low latency polling. This allows overriding the global sysctl value with a per-socket one. Signed-off-by: Eliezer Tamir --- arch/alpha/include/uapi/asm/socket.h |2 ++ arch/avr32/include/uapi/asm/socket.h |2 ++ arch/cris/include/uapi/asm/socket.h|2

[E1000-devel] [PATCH v2 net-next 1/3] net: remove NET_LL_RX_POLL config menue

2013-06-12 Thread Eliezer Tamir
Remove NET_LL_RX_POLL from the config menu. Change default to y. Busy polling still needs to be enabled at run time. Signed-off-by: Eliezer Tamir --- net/Kconfig | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/net/Kconfig b/net/Kconfig index d6a9ce6..8fe8845 1

[E1000-devel] [PATCH v2 net-next 2/3] net: change sysctl_net_ll_poll into an unsigned int

2013-06-12 Thread Eliezer Tamir
There is no reason for sysctl_net_ll_poll to be an unsigned long. Change it into an unsigned int. Fix the proc handler. Add a cast in ll_end_time() Signed-off-by: Eliezer Tamir --- include/net/ll_poll.h |5 +++-- net/core/sysctl_net_core.c |4 ++-- net/socket.c |2

[E1000-devel] [PATCH v2 net-next 0/3] net: low latency sockets follow ups

2013-06-12 Thread Eliezer Tamir
David, Here are two clean up patches, plus one that adds a socket option for LLS. Patch 1 removes the config menu for NET_LL_RX_POLL and defaults to y. Patch 2 converts sysctl_net_ll_poll into an unsigned int Patch 3 adds an SO_LL socket option to allow per-socket control of busy polling. I will

Re: [E1000-devel] [PATCH] sockperf: add SO_LL socketop support

2013-06-12 Thread Eliezer Tamir
On 12/06/2013 11:36, Amir Vadai wrote: > On 11/06/2013 17:26, Eliezer Tamir wrote: >> Add lls socket option support to sockperf. >> Right now we always get the option before set to show the option is >> working properly. We should probably remove that in an official release. >> use --lls (value in

Re: [E1000-devel] [PATCH] sockperf: add SO_LL socketop support

2013-06-12 Thread Amir Vadai
On 11/06/2013 17:26, Eliezer Tamir wrote: > Add lls socket option support to sockperf. > Right now we always get the option before set to show the option is > working properly. We should probably remove that in an official release. > use --lls (value in usecs) to override global setting. > --- > >