On Mon, 2013-08-26 at 22:45 -0700, Joe Perches wrote:
> __GFP_ZERO is an uncommon flag and perhaps is better
> not used. static inline dma_zalloc_coherent exists
> so convert the uses of dma_alloc_coherent with __GFP_ZERO
> to the more common kernel style with zalloc.
>
> Remove memset from the s
From: "Nelson, Shannon"
Date: Tue, 27 Aug 2013 20:34:04 +
> I understand the aesthetics as it does make the code look a little
> cleaner, and we can do this with a lot of our functions. However,
> there are several instances where one declaration initialization
> depends on a previous declar
On Fri, Aug 23, 2013 at 3:41 PM, Skidmore, Donald C
wrote:
>> -Original Message-
>> From: Bjorn Helgaas [mailto:bhelg...@google.com]
>> Sent: Friday, August 23, 2013 1:43 PM
>> To: Skidmore, Donald C
>> Cc: e1000-devel@lists.sourceforge.net; linux-...@vger.kernel.org; linux-
>> ker...@vger
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Friday, August 23, 2013 12:28 AM
[...]
>
> > +{
> > + int i;
> > + struct i40e_pf *pf = vsi->back;
>
> Please order local variable declarations from longest line to shortest.
I understand the aesthetics as
On Mon, 26 Aug 2013 22:45:23 -0700
Joe Perches wrote:
> __GFP_ZERO is an uncommon flag and perhaps is better
> not used. static inline dma_zalloc_coherent exists
> so convert the uses of dma_alloc_coherent with __GFP_ZERO
> to the more common kernel style with zalloc.
>
> Remove memset from the
On 26/08/2013 09:03, Eliezer Tamir wrote:
> On 26/08/2013 00:30, Amir Vadai wrote:
>> I'm on vacation, will test and have some inputs later this week when I be
>> back.
>>
> Hello Amir,
>
> Ping me when you get back and I will send you my latest so you can
> play with it.
>
Hi Eliezer,
You can
On Mon, Aug 26, 2013 at 10:45:23PM -0700, Joe Perches wrote:
> __GFP_ZERO is an uncommon flag and perhaps is better
> not used. static inline dma_zalloc_coherent exists
> so convert the uses of dma_alloc_coherent with __GFP_ZERO
> to the more common kernel style with zalloc.
>
> Remove memset fro
