On Fri, 2013-08-30 at 16:06 -0700, Joe Perches wrote:
> Just some potential cleanings...
>
> Joe Perches (4):
> i40e: Whitespace cleaning
> i40e: Add and use pf_
> i40e: pf_ remove "%s: " ... __func__
> i40e: Convert pf_ macros to functions
Thanks Joe, I will add these to my queue.
sign
On Fri, 2013-08-30 at 18:47 -0700, Joe Perches wrote:
> When dma_addr_t is a 32 bit value, >> 32 emits compiler warnings
> Use ((addr>>16) >>16) to avoid this.
>
> I presume the macro should actually use the kernel.h
> macro upper_32_bits() eventually.
>
> Signed-off-by: Joe Perches
> ---
> dri
When dma_addr_t is a 32 bit value, >> 32 emits compiler warnings
Use ((addr>>16) >>16) to avoid this.
I presume the macro should actually use the kernel.h
macro upper_32_bits() eventually.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/i40e/i40e_hmc.h | 2 +-
drivers/net/ethernet/in
Reduces object size ~10KB by removing "%s: ", __func__
and using the %pf extension and __builtin_return_address(0)
to emit the function name.
$ size drivers/net/ethernet/intel/i40e/built-in.o*
textdata bss dec hex filename
166271 36043 50032 252346 3d9ba
drivers/net/eth
Just some potential cleanings...
Joe Perches (4):
i40e: Whitespace cleaning
i40e: Add and use pf_
i40e: pf_ remove "%s: " ... __func__
i40e: Convert pf_ macros to functions
drivers/net/ethernet/intel/i40e/i40e.h | 149 +--
drivers/net/ethernet/intel/i40e/i40e_common.c |
From: Stephen Hemminger
Date: Fri, 30 Aug 2013 11:10:29 -0700
> On Fri, 30 Aug 2013 09:32:48 -0700
> Joe Perches wrote:
>
>> > +static int debug = -1;
>> > +module_param(debug, int, 0);
>> > +MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
>>
>> Maybe make debug a bitfield instea
On Fri, 2013-08-30 at 05:39 -0700, Jeff Kirsher wrote:
> From: Jesse Brandeburg
trivial comments only:
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
> b/drivers/net/ethernet/intel/i40e/i40e_main.c
> +#define DRV_KERN "-k"
> +
> +#define DRV_VERSION_MAJOR 0
> +#define DRV_VERSION_M
On Fri, 2013-08-30 at 14:40 -0400, David Miller wrote:
> From: Stephen Hemminger
> Date: Fri, 30 Aug 2013 11:10:29 -0700
>
> > On Fri, 30 Aug 2013 09:32:48 -0700
> > Joe Perches wrote:
> >
> >> > +static int debug = -1;
> >> > +module_param(debug, int, 0);
> >> > +MODULE_PARM_DESC(debug, "Debug
On Fri, 30 Aug 2013 09:32:48 -0700
Joe Perches wrote:
> > +static int debug = -1;
> > +module_param(debug, int, 0);
> > +MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
>
> Maybe make debug a bitfield instead?
No Joe, this is the standard mapping of debug to msglevel used
by most
From: Jesse Brandeburg
This patch contains the main driver header files, containing
structures and data types specific to the linux driver.
i40e_osdep.h contains some code that helps us adapt our OS agnostic code to
Linux.
Signed-off-by: Jesse Brandeburg
Signed-off-by: Shannon Nelson
CC: PJ W
From: Jesse Brandeburg
This patch contains the transmit, receive, and napi routines, as well
as ancillary routines.
This file is code that is (will be) shared between the VF and PF
drivers.
Signed-off-by: Jesse Brandeburg
Signed-off-by: Shannon Nelson
CC: PJ Waskiewicz
CC: e1000-devel@lists.
From: Jesse Brandeburg
This patch contains the ethtool interface and implementation.
The goal in this patch series is minimal functionality while not
including much in the way of "set support."
Signed-off-by: Jesse Brandeburg
Signed-off-by: Shannon Nelson
CC: PJ Waskiewicz
CC: e1000-devel@li
From: Jesse Brandeburg
This patch adds the Kconfig, readme, MAINTAINERS and Kbuild
changes to build i40e with the kernel.
New driver build option is CONFIG_I40E
Signed-off-by: Jesse Brandeburg
Signed-off-by: Shannon Nelson
CC: PJ Waskiewicz
CC: e1000-devel@lists.sourceforge.net
Tested-by: Ka
Hi,
I am new to linux programming. I have an intel NIC with e1000e driver. I am
working on precise time stamping of packets being captured from a network. An
interrupt is generated at every packet reception. Thus an interrupt handler
registered by the driver queues the captured packets and times
14 matches
Mail list logo
