Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

2013-09-04 Thread Stephen Hemminger
I am very busy with work and personal issues. Don't depend on my time. More surprising is that others did not see the same things. Your business is your problem. On Wed, Sep 4, 2013 at 6:25 PM, Nelson, Shannon wrote: >> -Original Message- >> From: Stephen Hemminger [mailto:step...@network

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

2013-09-04 Thread David Miller
From: "Brandeburg, Jesse" Date: Thu, 5 Sep 2013 04:08:39 + > On Wed, 2013-09-04 at 23:19 -0400, David Miller wrote: >> You will fix the problems people are reporting with this patch series >> before I apply it. > > Okay, the quickest path to that might be to drop the sysfs patch for > now.

[E1000-devel] Intel igb module command line configuration in kernel sources

2013-09-04 Thread Andrew Davidoff
Hi, I apologize that this is a user-type question but linux-net seems to have gone away, and I cannot find a more appropriate networking related mailing list. Why are the Intel igb module configuration parameters, usually found in igb_param.c and part of the source from Intel, not included in the

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

2013-09-04 Thread Brandeburg, Jesse
On Wed, 2013-09-04 at 23:19 -0400, David Miller wrote: > You will fix the problems people are reporting with this patch series > before I apply it. Okay, the quickest path to that might be to drop the sysfs patch for now. If that is acceptable I will re-spin the patches tonight.

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

2013-09-04 Thread David Miller
From: "Nelson, Shannon" Date: Thu, 5 Sep 2013 01:25:47 + > Will this work for you? You will fix the problems people are reporting with this patch series before I apply it. -- Learn the latest--Visual Studio 2012, Sh

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

2013-09-04 Thread Nelson, Shannon
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, September 04, 2013 5:38 PM > [ ... many good comments on i40e_sysfs.c ... ] Hi Stephen, Thanks for your comments. Frankly, we were hoping for this kind of feedback when we posted the

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

2013-09-04 Thread Stephen Hemminger
I don't think you need this. If you put a NULL pointer in for the __ATTR() then it will do the right thing for you. > +/** > + * i40e_sys_store_ro - callback for readonly attributes in sysfs > + * @kobj: object in the sysfs model > + * @attr: attribute being read > + * @buf: buffer to put data >

[E1000-devel] [net-next v4 4/8] i40e: driver core headers

2013-09-04 Thread Jeff Kirsher
From: Jesse Brandeburg This patch contains the main driver header files, containing structures and data types specific to the linux driver. i40e_osdep.h contains some code that helps us adapt our OS agnostic code to Linux. Signed-off-by: Jesse Brandeburg Signed-off-by: Shannon Nelson Tested-b

[E1000-devel] [net-next v4 3/8] i40e: driver ethtool core

2013-09-04 Thread Jeff Kirsher
From: Jesse Brandeburg This patch contains the ethtool interface and implementation. The goal in this patch series is minimal functionality while not including much in the way of "set support." Signed-off-by: Jesse Brandeburg Signed-off-by: Shannon Nelson Tested-by: Kavindya Deegala CC: PJ W

[E1000-devel] [net-next v4 8/8] i40e: include i40e in kernel proper

2013-09-04 Thread Jeff Kirsher
From: Jesse Brandeburg This patch adds the Kconfig, i40e.txt, MAINTAINERS and Kbuild changes to build i40e with the kernel. New driver build option is CONFIG_I40E Signed-off-by: Jesse Brandeburg Signed-off-by: Shannon Nelson Tested-by: Kavindya Deegala CC: PJ Waskiewicz CC: e1000-devel@list

[E1000-devel] [net-next v4 2/8] i40e: transmit, receive, and napi

2013-09-04 Thread Jeff Kirsher
From: Jesse Brandeburg This patch contains the transmit, receive, and napi routines, as well as ancillary routines. This file is code that is (will be) shared between the VF and PF drivers. Signed-off-by: Jesse Brandeburg Signed-off-by: Shannon Nelson Tested-by: Kavindya Deegala CC: PJ Waski

Re: [E1000-devel] Fwd: libvirt-qemu/kvm passthru w/Intel 82598EB

2013-09-04 Thread Skidmore, Donald C
Hey Larry, It almost sounds like you are running out of memory, although I have never seen that libvirt error myself. Could you verify your VM's has enough memory? Thanks, -Don Skidmore > -Original Message- > From: laurence.schuler [mailto:laurence.schu...@nasa.gov] > Sent: Wednesday

Re: [E1000-devel] e1000e: HW Unit hang on 3.7.10+ kernel.

2013-09-04 Thread Ben Greear
On 09/04/2013 07:56 AM, Ertman, DavidX M wrote: > There was recently a fix implemented for a hang issue that seems to be the > same thing you are experiencing. The hang was sporadic and hard to > reproduce, but specific bridging configurations were prone to causing the > hang to be more common

Re: [E1000-devel] Huge Performance Regression with adding of IXGBE_FLAG_IN_NETPOLL flag

2013-09-04 Thread Tantilov, Emil S
Hi Shyam, We are working on cleaning up the Rx code path which will also remove the IXGBE_FLAG_IN_NETPOLL. Thanks, Emil >-Original Message- >From: Shyam Kaushik [mailto:sh...@zadarastorage.com] >Sent: Monday, September 02, 2013 4:32 AM >To: Rose, Gregory V >Cc: e1000-devel@lists.source

Re: [E1000-devel] [PATCH 5/7] ixgbe: use pcie_capability_read_word() to simplify code

2013-09-04 Thread Bjorn Helgaas
[+cc Jacob, Jeff] On Tue, Sep 03, 2013 at 03:35:13PM +0800, Yijing Wang wrote: > use pcie_capability_read_word() to simplify code. > > Signed-off-by: Yijing Wang > Cc: e1000-devel@lists.sourceforge.net > Cc: net...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org > --- > drivers/net/ethernet/

Re: [E1000-devel] [PATCH 5/7] ixgbe: use pcie_capability_read_word() to simplify code

2013-09-04 Thread Keller, Jacob E
On Wed, 2013-09-04 at 10:20 -0600, Bjorn Helgaas wrote: > [+cc Jacob, Jeff] > > On Tue, Sep 03, 2013 at 03:35:13PM +0800, Yijing Wang wrote: > > use pcie_capability_read_word() to simplify code. > > > > Signed-off-by: Yijing Wang > > Cc: e1000-devel@lists.sourceforge.net > > Cc: net...@vger.kern

Re: [E1000-devel] Fwd: libvirt-qemu/kvm passthru w/Intel 82598EB

2013-09-04 Thread laurence.schuler
Hi Emil, We are only using the 82598 with the dom1 hosts. They are running Centos 2.6.18-348.12.1 kernel with an updated ixgbe driver v3.17.3 downloaded from the Intel site. We have ixgbe blacklisted on dom0 which is running Centos6 2.6.32-358.18.1 I do see a lot of the messages like this in th

Re: [E1000-devel] e1000e: HW Unit hang on 3.7.10+ kernel.

2013-09-04 Thread Ertman, DavidX M
> -Original Message- > From: Ben Greear [mailto:gree...@candelatech.com] > Sent: Tuesday, September 03, 2013 3:18 PM > To: e1000-devel list > Subject: [E1000-devel] e1000e: HW Unit hang on 3.7.10+ kernel. > > I'm helping another company debug some network issues. > > They are seeing a han

Re: [E1000-devel] [PATCH 5/7] ixgbe: use pcie_capability_read_word() to simplify code

2013-09-04 Thread Jeff Kirsher
On Tue, 2013-09-03 at 15:35 +0800, Yijing Wang wrote: > use pcie_capability_read_word() to simplify code. > > Signed-off-by: Yijing Wang > Cc: e1000-devel@lists.sourceforge.net > Cc: net...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |

Re: [E1000-devel] [net-next v3 1/8] i40e: main driver core

2013-09-04 Thread Nelson, Shannon
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Friday, August 30, 2013 9:33 AM > Hi Joe, thanks for your comments, and we're working through another version to be posted Real Soon. In the meantime I thought I'd respond to a couple specific comments. > > +#d