Re: [E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel proper

2013-09-05 Thread Joe Perches
On Fri, 2013-09-06 at 06:28 +, Brandeburg, Jesse wrote: > On Sep 5, 2013, at 11:15 PM, "Stephen Hemminger" > mailto:step...@networkplumber.org>> wrote: > > Dumb question why is this named Kbuild instead of Makefile like almost > every other network driver? > > All the new kids are doing it,

Re: [E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel proper

2013-09-05 Thread Brandeburg, Jesse
On Sep 5, 2013, at 11:15 PM, "Stephen Hemminger" mailto:step...@networkplumber.org>> wrote: Dumb question why is this named Kbuild instead of Makefile like almost every other network driver? All the new kids are doing it, we'll at least that is what I thought when I made it. Re-reading https:/

Re: [E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel proper

2013-09-05 Thread Stephen Hemminger
On Thu, 5 Sep 2013 23:01:18 -0700 Jeff Kirsher wrote: > diff --git a/drivers/net/ethernet/intel/i40e/Kbuild > b/drivers/net/ethernet/intel/i40e/Kbuild > new file mode 100644 > index 000..479b2c4 Dumb question why is this named Kbuild instead of Makefile like almost every other network driv

[E1000-devel] [net-next v5 2/8] i40e: transmit, receive, and NAPI

2013-09-05 Thread Jeff Kirsher
From: Jesse Brandeburg This patch contains the transmit, receive, and NAPI routines, as well as ancillary routines. This file is code that is (will be) shared between the VF and PF drivers. Signed-off-by: Jesse Brandeburg Signed-off-by: Shannon Nelson CC: PJ Waskiewicz CC: e1000-devel@lists.

[E1000-devel] [net-next v5 4/8] i40e: driver core headers

2013-09-05 Thread Jeff Kirsher
From: Jesse Brandeburg This patch contains the main driver header files, containing structures and data types specific to the linux driver. i40e_osdep.h contains some code that helps us adapt our OS agnostic code to Linux. Signed-off-by: Jesse Brandeburg Signed-off-by: Shannon Nelson CC: PJ W

[E1000-devel] [net-next v5 3/8] i40e: driver ethtool core

2013-09-05 Thread Jeff Kirsher
From: Jesse Brandeburg This patch contains the ethtool interface and implementation. The goal in this patch series is minimal functionality while not including much in the way of "set support." Signed-off-by: Jesse Brandeburg Signed-off-by: Shannon Nelson CC: PJ Waskiewicz CC: e1000-devel@li

[E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel proper

2013-09-05 Thread Jeff Kirsher
From: Jesse Brandeburg This patch adds the Kconfig, i40e.txt, MAINTAINERS and Kbuild changes to build i40e with the kernel. New driver build option is CONFIG_I40E Signed-off-by: Jesse Brandeburg Signed-off-by: Shannon Nelson CC: PJ Waskiewicz CC: e1000-devel@lists.sourceforge.net Tested-by:

[E1000-devel] [net-next v5 0/8][pull request] Intel Wired LAN Driver Updates

2013-09-05 Thread Jeff Kirsher
This series implements the new i40e driver for Intel's upcoming Intel(R) Ethernet Controller XL710 Family of devices. V1: initial send V2: each patch has individual comments, in general, feedback from the list was applied and addressed. Many changes due to internal review and coding as wel

Re: [E1000-devel] [net-next 0/8][pull request] Intel Wired LAN Driver Updates

2013-09-05 Thread Jeff Kirsher
On Thu, 2013-09-05 at 22:43 -0700, Jeff Kirsher wrote: > This series implements the new i40e driver for Intel's upcoming > Intel(R) Ethernet Controller XL710 Family of devices. > > V1: initial send > V2: each patch has individual comments, in general, feedback from the > list was applied and a

[E1000-devel] [net-next 8/8] i40e: include i40e in kernel proper

2013-09-05 Thread Jeff Kirsher
From: Jesse Brandeburg This patch adds the Kconfig, i40e.txt, MAINTAINERS and Kbuild changes to build i40e with the kernel. New driver build option is CONFIG_I40E Signed-off-by: Jesse Brandeburg Signed-off-by: Shannon Nelson CC: PJ Waskiewicz CC: e1000-devel@lists.sourceforge.net Tested-by:

[E1000-devel] [net-next 3/8] i40e: driver ethtool core

2013-09-05 Thread Jeff Kirsher
From: Jesse Brandeburg This patch contains the ethtool interface and implementation. The goal in this patch series is minimal functionality while not including much in the way of "set support." Signed-off-by: Jesse Brandeburg Signed-off-by: Shannon Nelson CC: PJ Waskiewicz CC: e1000-devel@li

[E1000-devel] [net-next 4/8] i40e: driver core headers

2013-09-05 Thread Jeff Kirsher
From: Jesse Brandeburg This patch contains the main driver header files, containing structures and data types specific to the linux driver. i40e_osdep.h contains some code that helps us adapt our OS agnostic code to Linux. Signed-off-by: Jesse Brandeburg Signed-off-by: Shannon Nelson CC: PJ W

[E1000-devel] [net-next 2/8] i40e: transmit, receive, and NAPI

2013-09-05 Thread Jeff Kirsher
From: Jesse Brandeburg This patch contains the transmit, receive, and NAPI routines, as well as ancillary routines. This file is code that is (will be) shared between the VF and PF drivers. Signed-off-by: Jesse Brandeburg Signed-off-by: Shannon Nelson CC: PJ Waskiewicz CC: e1000-devel@lists.

[E1000-devel] [net-next 0/8][pull request] Intel Wired LAN Driver Updates

2013-09-05 Thread Jeff Kirsher
This series implements the new i40e driver for Intel's upcoming Intel(R) Ethernet Controller XL710 Family of devices. V1: initial send V2: each patch has individual comments, in general, feedback from the list was applied and addressed. Many changes due to internal review and coding as wel

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

2013-09-05 Thread Nelson, Shannon
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, September 04, 2013 9:38 PM > To: Brandeburg, Jesse > Cc: Nelson, Shannon; step...@networkplumber.org; Kirsher, Jeffrey T; > e1000-devel@lists.sourceforge.net; net...@vger.kernel.org; > go...@redhat.com

Re: [E1000-devel] Intel igb module command line configuration in kernel sources

2013-09-05 Thread Andrew Davidoff
On Thu, Sep 5, 2013 at 2:26 PM, Tantilov, Emil S wrote: > On the upstream driver you can use ethtool -L (set-channels) to set the > number of queues: > > You will need the right combination of ethtool and kernel/driver with > get/set-channels support in order for this to work. Unfortunately fro

Re: [E1000-devel] Intel igb module command line configuration in kernel sources

2013-09-05 Thread Brown, Aaron F
> -Original Message- > From: Tantilov, Emil S [mailto:emil.s.tanti...@intel.com] > Sent: Thursday, September 05, 2013 11:26 AM > To: Andrew Davidoff; e1000-devel@lists.sourceforge.net > Subject: Re: [E1000-devel] Intel igb module command line configuration in > kernel sources > > >-O

[E1000-devel] [PATCH net-next] intel: pci_register_driver tail return

2013-09-05 Thread Stephen Hemminger
Remove unnecessary assignment, just return result of pci_register_driver Glad to see that Intel does lots of code reuse :-) Signed-off-by: Stephen Hemminger --- drivers/net/ethernet/intel/e1000e/netdev.c|5 + drivers/net/ethernet/intel/igb/igb_main.c |4 +--- drivers

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

2013-09-05 Thread John Fastabend
On 9/5/2013 11:32 AM, Stephen Hemminger wrote: [...] > > IMHO attributes are a nice way of handling the VSI attributes since they > seem hardware specific. Not sure how to do the right thing with switching. > Should it look like Macvlan, bridge, VXLAN, or something else. I think if you add a n

Re: [E1000-devel] Intel igb module command line configuration in kernel sources

2013-09-05 Thread Tantilov, Emil S
>-Original Message- >From: Andrew Davidoff [mailto:david...@qedmf.net] >Sent: Wednesday, September 04, 2013 8:32 PM >To: e1000-devel@lists.sourceforge.net >Subject: [E1000-devel] Intel igb module command line >configuration in kernel sources > >Hi, > >I apologize that this is a user-type qu

Re: [E1000-devel] Fwd: libvirt-qemu/kvm passthru w/Intel 82598EB

2013-09-05 Thread Tantilov, Emil S
>-Original Message- >From: laurence.schuler [mailto:laurence.schu...@nasa.gov] >Sent: Thursday, September 05, 2013 11:35 AM >To: Tantilov, Emil S >Cc: e1000-devel@lists.sourceforge.net >Subject: Re: [E1000-devel] Fwd: libvirt-qemu/kvm passthru >w/Intel 82598EB > >On 09/05/2013 01:39 PM, Tan

Re: [E1000-devel] Fwd: libvirt-qemu/kvm passthru w/Intel 82598EB

2013-09-05 Thread laurence.schuler
On 09/05/2013 02:40 PM, Tantilov, Emil S wrote: >> -Original Message- >> From: laurence.schuler [mailto:laurence.schu...@nasa.gov] >> Sent: Thursday, September 05, 2013 11:35 AM >> To: Tantilov, Emil S >> Cc: e1000-devel@lists.sourceforge.net >> Subject: Re: [E1000-devel] Fwd: libvirt-qemu/

Re: [E1000-devel] [net-next v4 1/7] i40e: main driver core

2013-09-05 Thread Nelson, Shannon
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, September 05, 2013 9:27 AM > > More review comments, these are non-blocking, and can be fixed later. Thanks, Stephen, we'll roll these updates in soon. sln > > Minor > - > * style >

Re: [E1000-devel] Fwd: libvirt-qemu/kvm passthru w/Intel 82598EB

2013-09-05 Thread Tantilov, Emil S
>-Original Message- >From: laurence.schuler [mailto:laurence.schu...@nasa.gov] >Sent: Wednesday, September 04, 2013 10:22 AM >To: Tantilov, Emil S >Cc: e1000-devel@lists.sourceforge.net >Subject: Re: [E1000-devel] Fwd: libvirt-qemu/kvm passthru >w/Intel 82598EB > >Hi Emil, > > We are only u

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

2013-09-05 Thread Nelson, Shannon
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, September 04, 2013 5:38 PM [...] > Also, anything in sysfs is device specific and you really need to make > a strong case for why your device is special and needs an exception. > Other de

Re: [E1000-devel] Fwd: libvirt-qemu/kvm passthru w/Intel 82598EB

2013-09-05 Thread laurence.schuler
On 09/05/2013 01:39 PM, Tantilov, Emil S wrote: >> -Original Message- >> From: laurence.schuler [mailto:laurence.schu...@nasa.gov] >> Sent: Wednesday, September 04, 2013 10:22 AM >> To: Tantilov, Emil S >> Cc: e1000-devel@lists.sourceforge.net >> Subject: Re: [E1000-devel] Fwd: libvirt-qemu

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

2013-09-05 Thread Stephen Hemminger
On Thu, 5 Sep 2013 17:53:38 + "Nelson, Shannon" wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, September 04, 2013 5:38 PM > > [...] > > > Also, anything in sysfs is device specific and you really need to make > > a

Re: [E1000-devel] [net-next v4 1/7] i40e: main driver core

2013-09-05 Thread Stephen Hemminger
More review comments, these are non-blocking, and can be fixed later. Minor - * style not a fan of doing own error codes and handling (ie. I40E_SUCCESS) which probably is side effect of OS abstraction. * extra parens aren't needed on return return (budget > 0); * i40e_config_net

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

2013-09-05 Thread Stephen Hemminger
Has anyone else noticed how big the drivers are getting. Intel e1002275 e1000 11971 e1000e 17502 igb 15720 ixgbe 22451 i40e22603 -- Learn the la

[E1000-devel] IT IS OUR 2013 SPRINGS SALE, DO NOT MISS OUT ON THE SPECIALS!!

2013-09-05 Thread AE Electronics
Dear Sir/Ma, We are proud to bring to you our spring mega sale deals of the month. Tell friends to tell friends,limited stock available and all are going fast.Visit our website www.aeelectronics.wozaonline.co.za to view latest stock e.g CANON EOS 5D MKIII NOW R18,000 OR SAMSUNG UN50ES6500 50-

Re: [E1000-devel] Fwd: libvirt-qemu/kvm passthru w/Intel 82598EB

2013-09-05 Thread laurence.schuler
Seems to have enough memory on both doms, right? dom0: MemTotal: 37070980 kB MemFree: 7246200 kB dom1: MemTotal: 24190044 kB MemFree: 23587668 kB Thanks, --Larry On 09/04/2013 05:56 PM, Skidmore, Donald C wrote: > Hey Larry, > > It almost sounds l

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

2013-09-05 Thread Bjørn Mork
Stephen Hemminger writes: > More surprising is that others did not see the same things. If I were to guess the 3 primary reasons for that: 1) the series is too large for anyone to actually read it all without being paid to do so 2) the sysfs code is at the end of a huge debugfs patch, w