Re: [E1000-devel] [PATCH 02/10] intel: Remove extern from function prototypes

2013-09-24 Thread David Miller
From: Ben Hutchings Date: Tue, 24 Sep 2013 23:16:52 +0100 > On Tue, 2013-09-24 at 15:07 -0700, Jeff Kirsher wrote: >> On Tue, 2013-09-24 at 14:09 -0700, Joe Perches wrote: >> > There are a mix of function prototypes with and without extern >> > in the kernel sources. Standardize on not using ext

Re: [E1000-devel] [PATCH 02/10] intel: Remove extern from function prototypes

2013-09-24 Thread Joe Perches
On Tue, 2013-09-24 at 15:07 -0700, Jeff Kirsher wrote: > On Tue, 2013-09-24 at 14:09 -0700, Joe Perches wrote: > > There are a mix of function prototypes with and without extern > > in the kernel sources. Standardize on not using extern for > > function prototypes. > > > > Function prototypes do

Re: [E1000-devel] [PATCH 02/10] intel: Remove extern from function prototypes

2013-09-24 Thread Ben Hutchings
On Tue, 2013-09-24 at 15:07 -0700, Jeff Kirsher wrote: > On Tue, 2013-09-24 at 14:09 -0700, Joe Perches wrote: > > There are a mix of function prototypes with and without extern > > in the kernel sources. Standardize on not using extern for > > function prototypes. > > > > Function prototypes don

Re: [E1000-devel] [PATCH 02/10] intel: Remove extern from function prototypes

2013-09-24 Thread Jeff Kirsher
On Tue, 2013-09-24 at 14:09 -0700, Joe Perches wrote: > There are a mix of function prototypes with and without extern > in the kernel sources. Standardize on not using extern for > function prototypes. > > Function prototypes don't need to be written with extern. > extern is assumed by the compi

[E1000-devel] [PATCH 02/10] intel: Remove extern from function prototypes

2013-09-24 Thread Joe Perches
There are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes. Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic

[E1000-devel] [PATCH 00/10 - GIT PULL] drivers: net: Next block of Remove extern from function prototypes

2013-09-24 Thread Joe Perches
The following changes since commit b0983d3c9b132c33b6fb2e28d157a1edc18a173c: tcp: fix dynamic right sizing (2013-09-24 11:07:32 -0400) are available in the git repository at: git://repo.or.cz/linux-2.6/trivial-mods.git 20130924_dn_externs_2 for you to fetch changes up to 294da3abaa73a0b69fd