[E1000-devel] [PATCH 2/2 Net-next v4] ixgbe: set driver_max_VFs should be done before enabling SRIOV

2014-01-15 Thread ethan zhao
commit 43dc4e01 Limit number of reported VFs to device specific value It doesn't work and always returns -EBUSY because VFs ware already enabled. ixgbe_enable_sriov() pci_enable_sriov() sriov_enable() { ... .. iov->ctrl

[E1000-devel] [PATCH 1/2 net-next v4] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread ethan zhao
Because ixgbe driver limit the max number of VF functions could be enalbed to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const 63 in code. v3: revised for net-next tree. V4: remove one signoff of two. Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/ixgbe/ixgbe_ma

Re: [E1000-devel] [PATCH 1/2 Net-next] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
David, Sorry about the signoffs, I am confused about how to sign the patch, If I sign it with off-work mail address, some of it is done within work-hours, maybe that why I sign if with both personal mail address and work one. If that bother you, just remove it. Thanks, Ethan On Thu, Jan 16, 20

Re: [E1000-devel] [PATCH 1/2 Net-next] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread David Miller
From: ethan zhao Date: Thu, 16 Jan 2014 12:25:01 +0800 > Signed-off-by: Ethan Zhao > Signed-off-by: Ethan Zhao Please don't give two signoffs for yourself, it is not appropriate at all. I am very genuinely curious where you got the idea to do that, particularly as I've never seen anyone else

[E1000-devel] [PATCH 2/2 Net-next] ixgbe: set driver_max_VFs should be done before enabling SRIOV

2014-01-15 Thread ethan zhao
commit 43dc4e01 Limit number of reported VFs to device specific value It doesn't work and always returns -EBUSY because VFs ware already enabled. ixgbe_enable_sriov() pci_enable_sriov() sriov_enable() { ... .. iov->ctrl

[E1000-devel] [PATCH 1/2 Net-next] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread ethan zhao
Because ixgbe driver limit the max number of VF functions could be enalbed to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const 63 in code. v3: revised for net-next tree. Signed-off-by: Ethan Zhao Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

Re: [E1000-devel] [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
Aaron, Revised those patches for Dave Miller's net-next OK, passed building. resent. Thanks, Ethan On Thu, Jan 16, 2014 at 11:08 AM, Ethan Zhao wrote: > Aaron, > Ok, Dave Miler's net-next tree. > > Thanks, > Etan > > On Thu, Jan 16, 2014 at 10:51 AM, Brown, Aaron F > wrote: >> On Thu, 2

Re: [E1000-devel] [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
Aaron, Ok, Dave Miler's net-next tree. Thanks, Etan On Thu, Jan 16, 2014 at 10:51 AM, Brown, Aaron F wrote: > On Thu, 2014-01-16 at 09:58 +0800, Ethan Zhao wrote: >> Aaron, >> >> Is this your net-next repo ? if so, I rebuild the patch with this repo >> right now . >> git://git.kernel.org/pub

Re: [E1000-devel] [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Brown, Aaron F
On Thu, 2014-01-16 at 09:58 +0800, Ethan Zhao wrote: > Aaron, > > Is this your net-next repo ? if so, I rebuild the patch with this repo > right now . > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next.git > > Thanks, > Ethan > Only sort of. Jeff uses it to push patches up, but I

Re: [E1000-devel] [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
Aaron, Is this your net-next repo ? if so, I rebuild the patch with this repo right now . git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next.git Thanks, Ethan On Thu, Jan 16, 2014 at 9:54 AM, Brown, Aaron F wrote: > On Thu, 2014-01-16 at 09:27 +0800, Ethan Zhao wrote: >> On Thu, Ja

Re: [E1000-devel] [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Brown, Aaron F
On Thu, 2014-01-16 at 09:27 +0800, Ethan Zhao wrote: > On Thu, Jan 16, 2014 at 6:00 AM, Brown, Aaron F > wrote: > > On Wed, 2014-01-15 at 22:12 +0800, Ethan Zhao wrote: > >> Because ixgbe driver limit the max number of VF functions could be enabled > >> to 63, so define one macro IXGBE_MAX_VFS_DR

Re: [E1000-devel] [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
On Thu, Jan 16, 2014 at 6:00 AM, Brown, Aaron F wrote: > On Wed, 2014-01-15 at 22:12 +0800, Ethan Zhao wrote: >> Because ixgbe driver limit the max number of VF functions could be enabled >> to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const 63 >> in code. >> >> v2: fix a typ

Re: [E1000-devel] [PATCH] [trivial] ixgbe: Fix format string in ixgbe_fcoe.c

2014-01-15 Thread Brown, Aaron F
On Wed, 2014-01-15 at 14:55 -0800, David Miller wrote: > From: Masanari Iida > Date: Wed, 15 Jan 2014 01:14:42 +0900 > > > cppcheck detected following warning in ixgbe_fcoe.c > > (warning) %d in format string (no. 1) requires 'int' but the > > argument type is 'unsigned int'. > > > > Signed-off-

Re: [E1000-devel] [PATCH] [trivial] ixgbe: Fix format string in ixgbe_fcoe.c

2014-01-15 Thread David Miller
From: Masanari Iida Date: Wed, 15 Jan 2014 01:14:42 +0900 > cppcheck detected following warning in ixgbe_fcoe.c > (warning) %d in format string (no. 1) requires 'int' but the > argument type is 'unsigned int'. > > Signed-off-by: Masanari Iida Intel folks, please be sure to pick this up. -

Re: [E1000-devel] [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Brown, Aaron F
On Wed, 2014-01-15 at 22:12 +0800, Ethan Zhao wrote: > Because ixgbe driver limit the max number of VF functions could be enabled > to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const 63 > in code. > > v2: fix a typo. > v3: fix a encoding issue. > > Signed-off-by: Ethan Zhao

Re: [E1000-devel] ixgbe/ixgbevf: How to enable RSC for VFs passthrough to Linux VM ?

2014-01-15 Thread Chaitanya Lala
Hi Alex, ... On 1/15/14 8:12 AM, "Alexander Duyck" wrote: >You mentioned using a 3.15.1 driver for the PF, I was wondering what >version of the ixgbevf driver it was you were using? 2.12.1 i.e. latest > The older versions >of the VF drivers used an older single buffer approach to receive and

Re: [E1000-devel] ixgbe/ixgbevf: How to enable RSC for VFs passthrough to Linux VM ?

2014-01-15 Thread Alexander Duyck
You mentioned using a 3.15.1 driver for the PF, I was wondering what version of the ixgbevf driver it was you were using? The older versions of the VF drivers used an older single buffer approach to receive and it is possible that some of that 40% drop you are seeing is due to differences in the d

Re: [E1000-devel] [PATCH 1/2 v2] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Brown, Aaron F
On Fri, 2013-12-27 at 01:02 -0800, Jeff Kirsher wrote: > On Wed, 2013-12-25 at 00:12 +0800, Ethan Zhao wrote: > > Because ixgbe driver limit the max number of VF functions could be > > enabled > > to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the > > const 63 > > in code. > > > >

[E1000-devel] [PATCH 2/2] ixgbe: set driver_max_VFs should be done before enabling SRIOV

2014-01-15 Thread Ethan Zhao
commit 43dc4e01 Limit number of reported VFs to device specific value It doesn't work and always returns -EBUSY because VFs ware already enabled. ixgbe_enable_sriov() pci_enable_sriov() sriov_enable() { ... .. iov->ctrl |= PCI

[E1000-devel] [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
Because ixgbe driver limit the max number of VF functions could be enabled to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const 63 in code. v2: fix a typo. v3: fix a encoding issue. Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++-- driver

Re: [E1000-devel] [PATCH 1/2 v2] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
Aaron, I will check the patch and make it pass the building, seems encoding issue. Thanks, Ethan On Wed, Jan 15, 2014 at 11:46 AM, Brown, Aaron F wrote: > On Fri, 2013-12-27 at 01:02 -0800, Jeff Kirsher wrote: >> On Wed, 2013-12-25 at 00:12 +0800, Ethan Zhao wrote: >> > Because ixgbe driver l