Re: [E1000-devel] [PATCH 00/30] drivers/net: remove unnecessary break after return

2014-07-20 Thread Fabian Frederick
> On 21 July 2014 at 06:31 David Miller wrote: > > > From: Fabian Frederick > Date: Sun, 20 Jul 2014 16:16:08 +0200 > > > Second patchset after "remove unnecessary break after goto" addressing break > > redundancy on drivers/net branch > > (suggested by Joe Perches) > > All applied except the i

Re: [E1000-devel] [PATCH 00/30] drivers/net: remove unnecessary break after return

2014-07-20 Thread David Miller
From: Fabian Frederick Date: Sun, 20 Jul 2014 16:16:08 +0200 > Second patchset after "remove unnecessary break after goto" addressing break > redundancy on drivers/net branch > (suggested by Joe Perches) All applied except the i40e patch, which did not apply to net-next at all. ---

Re: [E1000-devel] [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-20 Thread David Miller
From: Benoit Taine Date: Fri, 18 Jul 2014 17:26:47 +0200 > We should prefer `const struct pci_device_id` over > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. > This issue was reported by checkpatch. > > A simplified version of the semantic patch that makes this change is as >

Re: [E1000-devel] [PATCH 1/2 V3] PCI: introduce device assignment interface and refactory related code

2014-07-20 Thread Ethan Zhao
On Sun, Jul 20, 2014 at 10:48 PM, Yuval Mintz wrote: >> On Fri, 2014-07-11 at 07:13 -0600, Alex Williamson wrote: >> > On Fri, 2014-07-11 at 20:30 +0800, Ethan Zhao wrote: >> > > This patch introduces two new device assignment functions >> > > >> > > pci_iov_assign_device(), >> > > pci_iov_deassig

Re: [E1000-devel] [PATCH 1/2 V3] PCI: introduce device assignment interface and refactory related code

2014-07-20 Thread Ethan Zhao
On Mon, Jul 21, 2014 at 9:58 AM, Alex Williamson wrote: > On Sun, 2014-07-20 at 14:48 +, Yuval Mintz wrote: >> > On Fri, 2014-07-11 at 07:13 -0600, Alex Williamson wrote: >> > > On Fri, 2014-07-11 at 20:30 +0800, Ethan Zhao wrote: >> > > > This patch introduces two new device assignment functi

[E1000-devel] Problem: 82574L device (e1000e driver): Reset adapter unexpectedly / transmit queue 0 timed out

2014-07-20 Thread Andrew Cooks
Hi The 82574L device, using the e1000e driver, is unstable on the fit-MultiLAN (aka CompuLab MultiLAN)[1] that I'm using and I need some help to understand what's causing it. The fit-MultiLAN has four 82574L devices[2]. On two different occasions I've seen a (different) device drop into an unusab

Re: [E1000-devel] [PATCH 1/2 V3] PCI: introduce device assignment interface and refactory related code

2014-07-20 Thread Alex Williamson
On Sun, 2014-07-20 at 14:48 +, Yuval Mintz wrote: > > On Fri, 2014-07-11 at 07:13 -0600, Alex Williamson wrote: > > > On Fri, 2014-07-11 at 20:30 +0800, Ethan Zhao wrote: > > > > This patch introduces two new device assignment functions > > > > > > > > pci_iov_assign_device(), > > > > pci_iov_d

Re: [E1000-devel] [PATCH 1/2 V3] PCI: introduce device assignment interface and refactory related code

2014-07-20 Thread Yuval Mintz
> On Fri, 2014-07-11 at 07:13 -0600, Alex Williamson wrote: > > On Fri, 2014-07-11 at 20:30 +0800, Ethan Zhao wrote: > > > This patch introduces two new device assignment functions > > > > > > pci_iov_assign_device(), > > > pci_iov_deassign_device() > > > > > > along with the existed one > > > > >

[E1000-devel] [PATCH 20/30] igb: remove unnecessary break after return

2014-07-20 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/net/ethernet/intel/igb/e1000_82575.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c b/drivers/net/ethernet/intel/igb/e1000_82575.c index ee74f95..807496e 100644 --- a/drivers/net/ethernet/intel/igb/e1000

[E1000-devel] [PATCH 19/30] e1000e: remove unnecessary break after return

2014-07-20 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/net/ethernet/intel/e1000e/82571.c | 4 drivers/net/ethernet/intel/e1000e/ethtool.c | 2 -- drivers/net/ethernet/intel/e1000e/ich8lan.c | 1 - drivers/net/ethernet/intel/e1000e/mac.c | 1 - 4 files changed, 8 deletions(-) diff --git a/drivers

[E1000-devel] [PATCH 16/30] i40e: remove unnecessary break after return

2014-07-20 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/net/ethernet/intel/i40e/i40e_common.c | 1 - drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c inde

[E1000-devel] [PATCH 18/30] ixgbe: remove unnecessary break after return

2014-07-20 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c | 1 - drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c ind

[E1000-devel] [PATCH 17/30] e1000: remove unnecessary break after return

2014-07-20 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 3 --- drivers/net/ethernet/intel/e1000/e1000_hw.c | 2 -- 2 files changed, 5 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c

[E1000-devel] [PATCH 00/30] drivers/net: remove unnecessary break after return

2014-07-20 Thread Fabian Frederick
Second patchset after "remove unnecessary break after goto" addressing break redundancy on drivers/net branch (suggested by Joe Perches) Fabian Frederick (30): dlci: remove unnecessary break after return eth_v10: remove unnecessary break after return brcm80211: remove unnecessary break afte

Re: [E1000-devel] [PATCH] Packet drops/loss with 82579LM - fixed

2014-07-20 Thread Hrvoje Habjanić
Hi. On 19.06.2014 11:33, Hrvoje Habjanić wrote: > On 10.06.2014 17:08, Hrvoje Habjanić wrote: >> On 09.06.2014 17:46, Ertman, DavidX M wrote: >> >>> Good Morning, >>> >>> The fix for this went into the in-kernel driver with commit 77e61146c677 >>> "e1000e: Workaround for dropped packets in Gig/1