Re: [E1000-devel] [PATCH] net: ethernet: intel: ixgbe: ixgbe_main.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-28 Thread Stephen Hemminger
On Sat, 26 Jul 2014 16:24:36 +0200 Rickard Strandqvist wrote: > Replacing strncpy with strlcpy to avoid strings that lacks null terminate. > > Signed-off-by: Rickard Strandqvist > --- hw->mac.type, hw->phy.type, hw->phy.sfp_type, This patch doesn't change anything. N

Re: [E1000-devel] [PATCH] ixgbe: remove useless bd_number from adapter struct

2014-07-28 Thread Ethan Zhao
Thanks Brown, Aaron F On Tue, Jul 29, 2014 at 10:51 AM, Brown, Aaron F wrote: >> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- >> ow...@vger.kernel.org] On Behalf Of Ethan Zhao >> Sent: Monday, July 28, 2014 12:41 AM >> To: Kirsher, Jeffrey T; Brandeburg, Jesse; Allan, Bruce W; W

Re: [E1000-devel] [PATCH] ixgbe: remove useless bd_number from adapter struct

2014-07-28 Thread Brown, Aaron F
> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Ethan Zhao > Sent: Monday, July 28, 2014 12:41 AM > To: Kirsher, Jeffrey T; Brandeburg, Jesse; Allan, Bruce W; Wyborny, > Carolyn; Skidmore, Donald C; Rose, Gregory V; Duyck, Alexander H; Ronciak,

[E1000-devel] [PATCH] ixgbevf: remove useless bd_number from struct ixgbevf_adapter

2014-07-28 Thread Ethan Zhao
It is useless and buggy, just remove it. Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/ixgbevf/ixgbevf.h |1 - drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c |4 2 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgb

[E1000-devel] [PATCH] ixgbe: remove useless bd_number from adapter struct

2014-07-28 Thread Ethan Zhao
Because bd_number is not useful anymore, so remove it from adapter struct, or if keep it, we have to fix the boards driven counter bug in ixgbe_remove() and ixgbe_probe() only for trival debug purpose -- other output is enough. Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/ixgbe/ixgbe