Re: [E1000-devel] [PATCH 2/2] e1000e: start network tx queue only when link is up

2019-04-25 Thread Brown, Aaron F
> From: Konstantin Khlebnikov [mailto:khlebni...@yandex-team.ru] > Sent: Wednesday, April 17, 2019 1:13 AM > To: net...@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- > ker...@vger.kernel.org; Kirsher, Jeffrey T > Cc: Sasha Levin ; Joseph Yasi ; > Brown, Aaron F

Re: [E1000-devel] [PATCH 1/2] Revert "e1000e: fix cyclic resets at link up with active tx"

2019-04-25 Thread Brown, Aaron F
> From: Konstantin Khlebnikov [mailto:khlebni...@yandex-team.ru] > Sent: Wednesday, April 17, 2019 1:13 AM > To: net...@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- > ker...@vger.kernel.org; Kirsher, Jeffrey T > Cc: Sasha Levin ; Joseph Yasi ; > Brown, Aaron F

Re: [E1000-devel] [PATCH net-next 1/2] igb: add function to set I210 transmit mode

2015-12-21 Thread Brown, Aaron F
> From: Gangfeng Huang [gangfeng.hu...@ni.com] > Sent: Wednesday, October 28, 2015 6:47 PM > To: e1000-devel@lists.sourceforge.net > Subject: [E1000-devel] [PATCH net-next 1/2] igb: add function to set I210 > transmit mode > > I210 supports two transmit modes, legacy and Qav. The transmit

Re: [E1000-devel] [PATCH net-next 2/2] igb: add a character device to support AVB

2015-12-17 Thread Brown, Aaron F
> From: Richard Cochran [richardcoch...@gmail.com] > Sent: Thursday, October 29, 2015 3:27 AM > To: Gangfeng Huang > Cc: e1000-devel@lists.sourceforge.net > Subject: Re: [E1000-devel] [PATCH net-next 2/2] igb: add a character device > to support AVB > > On Thu, Oct 29, 2015 at 09:47:36AM +0800,

Re: [E1000-devel] [bisected regression] e1000e: Detected Hardware Unit Hang

2015-05-29 Thread Brown, Aaron F
From: Thomas Jarosch [mailto:thomas.jaro...@intra2net.com] Sent: Wednesday, May 27, 2015 9:01 AM To: Brown, Aaron F Cc: Kirsher, Jeffrey T; 'Linux Netdev List'; Eric Dumazet; e1000-devel Subject: Re: RE: [bisected regression] e1000e: Detected Hardware Unit Hang Hi Aaron, On Monday, 23

Re: [E1000-devel] igb: Decrease time until link is up

2015-03-24 Thread Brown, Aaron F
From: Paul Menzel [mailto:paulepan...@users.sourceforge.net] Sent: Tuesday, March 24, 2015 12:53 AM To: Kirsher, Jeffrey T Cc: e1000-devel@lists.sourceforge.net Subject: Re: [E1000-devel] igb: Decrease time until link is up Dear Jeff, thank you for the reply! Am Sonntag, den

Re: [E1000-devel] [bisected regression] e1000e: Detected Hardware Unit Hang

2015-03-23 Thread Brown, Aaron F
-Original Message- From: Thomas Jarosch [mailto:thomas.jaro...@intra2net.com] Sent: Monday, March 23, 2015 6:58 AM To: Brown, Aaron F Cc: Kirsher, Jeffrey T; 'Linux Netdev List'; Eric Dumazet; e1000-devel Subject: Re: [bisected regression] e1000e: Detected Hardware Unit Hang Hi

Re: [E1000-devel] [bisected regression] e1000e: Detected Hardware Unit Hang

2015-02-20 Thread Brown, Aaron F
-Original Message- From: Thomas Jarosch [mailto:thomas.jaro...@intra2net.com] Sent: Friday, February 13, 2015 8:15 AM To: Brown, Aaron F Cc: Kirsher, Jeffrey T; 'Linux Netdev List'; Eric Dumazet; e1000-devel Subject: Re: [bisected regression] e1000e: Detected Hardware Unit Hang

Re: [E1000-devel] [bisected regression] e1000e: Detected Hardware Unit Hang

2015-02-12 Thread Brown, Aaron F
From: Kirsher, Jeffrey T Sent: Wednesday, February 11, 2015 3:34 AM To: Thomas Jarosch; Brown, Aaron F Cc: 'Linux Netdev List'; Eric Dumazet; e1000-devel Subject: Re: [bisected regression] e1000e: Detected Hardware Unit Hang On Wed, 2015-02-11 at 12:23 +0100, Thomas Jarosch wrote: Hi

Re: [E1000-devel] [PATCH net-next 0/2] Fix some typos and an excessive space character

2014-08-04 Thread Brown, Aaron F
On Sat, 2014-08-02 at 20:37 -0600, Jean Sacren wrote: This small series fixes some typos in the kernel doc and an excessive space character in the debug message. Both are associated with e1000_mng_enable_host_if() of the Intel e1000e driver. Please apply in the order as annotated. Jean

Re: [E1000-devel] [PATCH] net: ethernet: intel: ixgbe: ixgbe_main.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-29 Thread Brown, Aaron F
On Tue, 2014-07-29 at 14:15 +0200, Rickard Strandqvist wrote: Den 29 jul 2014 04:40 skrev Stephen Hemminger step...@networkplumber.org : On Sat, 26 Jul 2014 16:24:36 +0200 Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Replacing strncpy with strlcpy to avoid strings

Re: [E1000-devel] [PATCH 3/9] i40e: use correct structure type name in sizeof

2014-07-29 Thread Brown, Aaron F
On Tue, 2014-07-29 at 17:16 +0200, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has no impact on compilation or execution. This problem was found using

Re: [E1000-devel] [PATCH -next] i40e: fix sparse non static symbol warning

2014-07-29 Thread Brown, Aaron F
On Wed, 2014-07-30 at 07:20 +0800, weiyj...@163.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fixes the following sparse warnings: drivers/net/ethernet/intel/i40e/i40e_nvm.c:254:13: warning: symbol 'i40e_write_nvm_aq' was not declared. Should it be static? Signed-off-by:

Re: [E1000-devel] [PATCH] ixgbe: remove useless bd_number from adapter struct

2014-07-28 Thread Brown, Aaron F
From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- ow...@vger.kernel.org] On Behalf Of Ethan Zhao Sent: Monday, July 28, 2014 12:41 AM To: Kirsher, Jeffrey T; Brandeburg, Jesse; Allan, Bruce W; Wyborny, Carolyn; Skidmore, Donald C; Rose, Gregory V; Duyck, Alexander H; Ronciak,

Re: [E1000-devel] [PATCH net-next] ixgbevf: fix skb-pkt_type checks

2014-02-28 Thread Brown, Aaron F
On Thu, 2014-02-27 at 14:58 -0800, Aaron Brown wrote: On Wed, 2014-02-26 at 14:44 -0800, Florian Fainelli wrote: skb-pkt_type is not a bitmask, but contains only value at a time from the range defined in include/uapi/linux/if_packet.h. Checking it like if it was a bitmask of values would

Re: [E1000-devel] [PATCH net-next v2] ixgbevf: fix skb-pkt_type checks

2014-02-28 Thread Brown, Aaron F
On Fri, 2014-02-28 at 15:46 -0800, Florian Fainelli wrote: skb-pkt_type is not a bitmask, but contains only value at a time from the range defined in include/uapi/linux/if_packet.h. Checking it like if it was a bitmask of values would also cause PACKET_OTHERHOST, PACKET_LOOPBACK and

Re: [E1000-devel] [PATCH net] igb: Fix Null-pointer dereference in igb_reset_q_vector

2014-02-18 Thread Brown, Aaron F
On Tue, 2014-02-18 at 14:06 +0100, Christoph Paasch wrote: When igb_set_interrupt_capability() calls igb_reset_interrupt_capability() (e.g., because CONFIG_PCI_MSI is unset), num_q_vectors has been set but no vector has yet been allocated. igb_reset_interrupt_capability() will then call

Re: [E1000-devel] [PATCH net] igb: Unset IGB_FLAG_HAS_MSIX-flag when falling back to msi-only

2014-02-18 Thread Brown, Aaron F
On Wed, 2014-02-19 at 00:36 +0100, Christoph Paasch wrote: rior to cd14ef54d25 (igb: Change to use statically allocated array for MSIx entries), having msix_entries different from NULL was an indicator that MSIX is enabled. In igb_set_interrupt_capabiliy we may fall back to MSI-only. Prior to

Re: [E1000-devel] [PATCH] i40evf: Fix variable out-of-scope in i40e_aq_send_msg_to_pf()

2014-02-04 Thread Brown, Aaron F
On Mon, 2014-02-03 at 21:40 +0100, Christian Engelmayer wrote: In case the function parameter 'cmd_details' is false, the pointer passed by value is locally set to point to struct 'details'. When passing pointer 'cmd_details' to i40evf_asq_send_command(), 'details' is already out of scope.

Re: [E1000-devel] [PATCH 0/2] Remove dead code

2014-01-31 Thread Brown, Aaron F
From: Bjorn Helgaas [mailto:bhelg...@google.com] Sent: Friday, January 31, 2014 9:59 AM To: Brown, Aaron F Cc: linux-...@vger.kernel.org; e1000-devel@lists.sourceforge.net; Arjan van de Ven; linux-ker...@vger.kernel.org Subject: Re: [E1000-devel] [PATCH 0/2] Remove dead code On Fri, Jan

Re: [E1000-devel] [PATCH net] e100: Fix disabling already-disabled device warning

2014-01-30 Thread Brown, Aaron F
On Thu, 2014-01-30 at 10:51 +, Michele Baldessari wrote: From: Michele Baldessari mich...@acksyn.org Reply-to: Michele Baldessari mich...@acksyn.org To: net...@vger.kernel.org

Re: [E1000-devel] [PATCH] ixgbevf: delete unneeded call to pci_set_power_state

2014-01-21 Thread Brown, Aaron F
On Tue, 2014-01-07 at 18:00 +0100, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr This driver does not need to adjust the power state on suspend, so the call to pci_set_power_state in the resume function is a no-op. Drop it, to make the code more understandable.

Re: [E1000-devel] [PATCH] [trivial] ixgbe: Fix format string in ixgbe_fcoe.c

2014-01-21 Thread Brown, Aaron F
On Wed, 2014-01-15 at 01:14 +0900, Masanari Iida wrote: cppcheck detected following warning in ixgbe_fcoe.c (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. Signed-off-by: Masanari Iida standby2...@gmail.com Tested-By: Jack Morgan

Re: [E1000-devel] [patch v2] i40e: potential array underflow in i40e_vc_process_vf_msg()

2014-01-20 Thread Brown, Aaron F
On Sat, 2014-01-11 at 12:58 +0300, Dan Carpenter wrote: If vf_id is smaller than hw-func_caps.vf_base_id then it leads to an array underflow of the pf-vf[] array. This is unlikely to happen unless the hardware is bad, but it's a small change and it silences a static checker warning. Fixes:

Re: [E1000-devel] [PATCH 1/2 Net-next v5] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-16 Thread Brown, Aaron F
On Thu, 2014-01-16 at 16:05 +0800, ethan zhao wrote: Because ixgbe driver limit the max number of VF functions could be enabled to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const 63 in code. v3: revised for net-next tree. v4: remove one signoff of two v5: fix style

Re: [E1000-devel] [PATCH 1/2 v2] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Brown, Aaron F
On Fri, 2013-12-27 at 01:02 -0800, Jeff Kirsher wrote: On Wed, 2013-12-25 at 00:12 +0800, Ethan Zhao wrote: Because ixgbe driver limit the max number of VF functions could be enabled to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const 63 in code. v2: fix a

Re: [E1000-devel] [PATCH] [trivial] ixgbe: Fix format string in ixgbe_fcoe.c

2014-01-15 Thread Brown, Aaron F
On Wed, 2014-01-15 at 14:55 -0800, David Miller wrote: From: Masanari Iida standby2...@gmail.com Date: Wed, 15 Jan 2014 01:14:42 +0900 cppcheck detected following warning in ixgbe_fcoe.c (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.

Re: [E1000-devel] [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Brown, Aaron F
On Thu, 2014-01-16 at 09:27 +0800, Ethan Zhao wrote: On Thu, Jan 16, 2014 at 6:00 AM, Brown, Aaron F aaron.f.br...@intel.com wrote: On Wed, 2014-01-15 at 22:12 +0800, Ethan Zhao wrote: Because ixgbe driver limit the max number of VF functions could be enabled to 63, so define one macro

Re: [E1000-devel] [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Brown, Aaron F
On Thu, 2014-01-16 at 09:58 +0800, Ethan Zhao wrote: Aaron, Is this your net-next repo ? if so, I rebuild the patch with this repo right now . git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next.git Thanks, Ethan Only sort of. Jeff uses it to push patches up, but I don't

Re: [E1000-devel] [PATCH] [trivial] ixgbe: Fix format string in ixgbe_fcoe.c

2014-01-14 Thread Brown, Aaron F
On Wed, 2014-01-15 at 01:14 +0900, Masanari Iida wrote: cppcheck detected following warning in ixgbe_fcoe.c (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. Signed-off-by: Masanari Iida standby2...@gmail.com ---

Re: [E1000-devel] [patch v2] i40e: potential array underflow in i40e_vc_process_vf_msg()

2014-01-11 Thread Brown, Aaron F
From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Saturday, January 11, 2014 1:59 AM To: Kirsher, Jeffrey T Cc: kernel-janit...@vger.kernel.org; e1000-devel@lists.sourceforge.net; Allan, Bruce W; Brandeburg, Jesse; Wei Yongjun; Ronciak, John Subject: [E1000-devel] [patch v2] i40e:

Re: [E1000-devel] [patch] i40e: potential array underflow in i40e_vc_process_vf_msg()

2014-01-10 Thread Brown, Aaron F
-Original Message- From: Williams, Mitch A Sent: Friday, January 10, 2014 10:50 AM To: Dan Carpenter; Kirsher, Jeffrey T; Brown, Aaron F Cc: Brandeburg, Jesse; Allan, Bruce W; Wyborny, Carolyn; Skidmore, Donald C; Rose, Gregory V; Duyck, Alexander H; Ronciak, John; Nelson, Shannon

Re: [E1000-devel] [PATCH] e1000: avoid potential deadlock in e1000_do_[read|write]_eeprom()

2014-01-10 Thread Brown, Aaron F
From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Alexey Khoroshilov Sent: Friday, December 20, 2013 2:25 PM To: Kirsher, Jeffrey T Cc: Alexey Khoroshilov; Brandeburg, Jesse; Allan, Bruce W; Wyborny, Carolyn; Skidmore, Donald C; Rose, Gregory V; Duyck,

Re: [E1000-devel] [PATCH] ixgbevf: delete unneeded call to pci_set_power_state

2014-01-07 Thread Brown, Aaron F
From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Julia Lawall Sent: Tuesday, January 07, 2014 9:00 AM To: Kirsher, Jeffrey T Cc: kernel-janit...@vger.kernel.org; Brandeburg, Jesse; Allan, Bruce W; Wyborny, Carolyn; Skidmore, Donald C; Rose, Gregory V;

Re: [E1000-devel] [PATCH net V4 0/2] igb: ptp hardware clock

2012-01-27 Thread Brown, Aaron F
From: Richard Cochran [mailto:richardcoch...@gmail.com] Sent: Friday, January 27, 2012 4:12 AM To: Kirsher, Jeffrey T Cc: Eric Dumazet; Brown, Aaron F; net...@vger.kernel.org; e1000- de...@lists.sourceforge.net; Keller, Jacob E; Ronciak, John; John Stultz; Thomas Gleixner Subject: Re