On Tue, Mar 31, 2015 at 08:10:31PM +, Fujinaka, Todd wrote:
> I have a fix for this already, if Dan doesn't mind.
>
I don't mind.
regards,
dan carpenter
--
Dive into the World of Parallel Pr
set and not set then
there aren't any other possibilities so the else statement is dead
code.
This function always returns zero so if you delete the "ret_val"
variable, the code is shorter and more clear.
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/ethernet/intel/igb/ig
On Fri, Jan 30, 2015 at 11:41:27AM +0300, Dan Carpenter wrote:
> Static checkers complain that the shifts in "(vid << 4) >> 4" perfectly
> cancel each other out and the code is a no-op. "vid" is a u16. The
> comment says that the intention here is to dro
xes: 401b5383c6c9 ('fm10k: Add support for configuring PF interface')
Signed-off-by: Dan Carpenter
---
Static analysis. Not tested.
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c
b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c
index 275423d..ee30d06 100644
--- a/drivers/net/ethern
type)
105 I40E_INC_BP_REFCNT(&sd_entry->u.bp);
106 exit:
107 if (ret_code)
Here.
108 if (dma_mem_alloc_done)
109 i40e_free_dma_mem(hw, &mem);
regards,
dan carpenter
-
The ">>" operation has higher precedence than the "&" operation. Also
the casting is not needed.
Signed-off-by: Dan Carpenter
---
This is static checker work and I haven't tested it on real hardware.
diff --git a/drivers/net/ethernet/intel/i40e/i40e_dcb_nl.c
We accidentally mask by the _SHIFT variable. It means that "event" is
always zero.
Signed-off-by: Dan Carpenter
---
Not tested.
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
b/drivers/net/ethernet/intel/i40e/i40e_main.c
index ed5f1c1..c3a7f4a 100644
--- a/drivers/net/ethe
he write combining memory and
> then perhaps it will make a bit more sense.
>
Yes. That would make it more clear.
regards,
dan carpenter
--
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achiev
ast get rid of the
incorrect/misleading ones?
regards,
dan carpenter
--
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Read
The IXGBE_MAX_L2A_QUEUES define is cut and pasted twice so we can delete
the second instance.
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
index ac9f214..bfb2c23 100644
--- a/drivers/net/ethernet/intel/ixgbe
On Fri, Mar 28, 2014 at 12:17:16PM -0700, Jeff Kirsher wrote:
> On Fri, 2014-03-28 at 11:29 +0300, Dan Carpenter wrote:
> > We know "ret" is zero here. No need to check again.
> >
> > Signed-off-by: Dan Carpenter
>
> Dan with the latest bunch of patches I
We know "ret" is zero here. No need to check again.
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index 28da412..2640004 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/d
p adding numbers to tlv and it becomes even more non-zero.
364 }
regards,
dan carpenter
--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critica
On Tue, Jan 07, 2014 at 06:40:47PM +, Williams, Mitch A wrote:
>
>
> > -Original Message-
> > From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> > Sent: Monday, January 06, 2014 10:12 PM
> > To: Rose, Gregory V
> > Cc: e1000-devel@list
arc.info archive has the curly braces in
the right place.
http://marc.info/?l=kernel-janitors&m=138943435730292&w=2
regards,
dan carpenter
--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Wh
rt VFs on PFs other than 0')
Signed-off-by: Dan Carpenter
---
v2: rebased. commit message updated.
diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
index 51a4f6125437..b77d7e79d977 100644
--- a/drivers/net/ethernet/intel/i40e/i
If "vf_id" is smaller than hw->func_caps.vf_base_id then we leads to an
array underflow of the pf->vf[] array.
Fixes: 7efa84b7abc1 ('i40e: support VFs on PFs other than 0')
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
b/
I40EVF_FLAG_IMIR_ENABLED (u32)(1 << 5)
235 #define I40EVF_FLAG_MQ_CAPABLE (u32)(1 << 6)
236 #define I40EVF_FLAG_NEED_LINK_UPDATE (u32)(1 << 7)
The flags are explicitly u32 and the ->flags member is unsigned long.
And, of course, che
;t want to
have dev_err() message.
This is a static checker fix and I'm not sure what the impact is.
---
v2: reformat and also remove the dev_err()
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c
b/drivers/net/ethernet/intel/igbvf/netdev.c
index 95d5430..
ve namespaces
> > configured.
> >
> > This is a static checker fix and I'm not sure what the impact is.
> >
> > Signed-off-by: Dan Carpenter
> >
> > diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c
> > b/drivers/net/ethernet/intel/igbvf/netd
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c
b/drivers/net/ethernet/intel/igbvf/netdev.c
index 95d5430..24e3883 100644
--- a/drivers/net/ethernet/intel/igbvf/netdev.c
+++ b/drivers/net/ethernet/intel/igbvf/netdev.c
@@ -2342,7 +2342,7 @@ static struct n
There can never be a negative number of bytes_not_copied. Also return
-EFAULT on error.
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
index 8dbd91f..de9f60d 100644
--- a/drivers/net/ethernet/intel/i40e
On Mon, Jan 21, 2013 at 06:58:38PM +, Wyborny, Carolyn wrote:
> > -Original Message-
> > From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> > Sent: Monday, January 21, 2013 10:36 AM
> > To: Wyborny, Carolyn
> > Cc: e1000-devel@lists.sourceforge.net
st == NULL)
7643 goto exit;
regards,
dan carpenter
--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with Lea
fs is type unsigned int. We take an unsigned long from sysfs.
We silently truncate it to an unsigned int. Then we cast it to a
negative number and compare against 63 and take the minimum...
It's root only so it's not a problem but it's a hassle to audit.
regards,
dan carpente
Also Catherine's email address is dead. And I was so excited that
someone was using an @intel.com instead of an @linux.intel.com
address. Those have all been broken since July...
regards,
dan carpenter
--
Live Sec
o a buffer and then call
simple_read_from_buffer().
regards,
dan carpenter
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed an
be controlled through ethtool which passes a bit
number that is used to do a bit shift.
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c
b/drivers/net/ethernet/intel/igbvf/netdev.c
index 217c143..e50c2ec 100644
--- a/drivers/net/ethernet/intel/igbvf/netdev.c
^
New dereference.
3367
3368 ixgbe_dcb_hw_pfc_config(&adapter->hw,
pfc->pfc_en,
regards,
dan carpenter
--
All the data continuously generated in your IT infrastr
The e_dev_err() macro dereferences "adapter" which is NULL here.
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 9203759..0360260 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -6549
The bitwise negate is intended here. With the logical negate the
condition is always false.
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index 24507f3..57a7e41 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
31 matches
Mail list logo
