Re: [E1000-devel] [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Greg KH
On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote: > On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: > > On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: > > > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: > > > >

Re: [E1000-devel] [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Greg KH
On Sat, Jul 19, 2014 at 07:14:12AM +1000, Dave Airlie wrote: > > > > We have almost 1000 more uses of the non-macro version than the "macro" > > version in the kernel today: > > $ git grep -w DEFINE_PCI_DEVICE_TABLE | wc -l > > 262 > > $ git grep "const struct pci_device_id" | wc -l > > 1254 > > d

Re: [E1000-devel] [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Greg KH
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: > > We should prefer `const struct pci_device_id` over > > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. > > This issue was reported by checkpatch. >

Re: [E1000-devel] [PATCH] drivers/base/core.c: always output device renaming messages.

2013-10-11 Thread Greg KH
On Fri, Oct 11, 2013 at 10:08:09AM -0600, Bjorn Helgaas wrote: > [+cc Don, e1000-devel] > > On Fri, Oct 11, 2013 at 9:35 AM, Greg KH wrote: > > On Fri, Oct 11, 2013 at 10:58:18AM +0800, ethan.zhao wrote: > >> From: "ethan.zhao" > >> > >> Wh

Re: [E1000-devel] [PATCH RFC 04/77] PCI/MSI/s390: Remove superfluous check of MSI type

2013-10-02 Thread Greg KH
On Wed, Oct 02, 2013 at 12:48:20PM +0200, Alexander Gordeev wrote: > arch_setup_msi_irqs() hook can only be called from the generic > MSI code which ensures correct MSI type parameter. > > Signed-off-by: Alexander Gordeev > --- > arch/s390/pci/pci.c |2 -- > 1 files changed, 0 insertions(+),

Re: [E1000-devel] [PATCH] ixgbevf: don't release the soft entries

2013-02-28 Thread Greg KH
On Thu, Feb 28, 2013 at 03:02:07PM +0800, xunleer wrote: > This patch fix an oops issue caused by NULL pointer. The call stack > may be like this: > [] ixgbevf_down+0x10b/0x300 [ixgbevf] > [] ixgbevf_open+0x27d/0x2b0 [ixgbevf] > [] __dev_open+0xa7/0x100 > [] dev_open+0x35/0x60 > > When opening the

Re: [E1000-devel] [PATCH] e1000: save skb counts in TX to avoid cache misses

2012-06-14 Thread Greg KH
On Wed, Jun 13, 2012 at 03:12:17PM +0400, Roman Kagan wrote: > On Fri, 2012-06-08 at 11:37 +0400, Roman Kagan wrote: > > On Fri, 2012-06-08 at 06:15 +0400, Greg KH wrote: > > > On Thu, Jun 07, 2012 at 02:43:58PM -0700, David Miller wrote: > > > > From: Jeff Kirsher

Re: [E1000-devel] [PATCH] e1000: save skb counts in TX to avoid cache misses

2012-06-07 Thread Greg KH
On Thu, Jun 07, 2012 at 02:43:58PM -0700, David Miller wrote: > From: Jeff Kirsher > Date: Thu, 07 Jun 2012 14:38:17 -0700 > > > Thanks! I have applied the patch to my queue > > Why? > > My impression is that this is a patch already in the tree, and it's > being submitted for -stable but such m

Re: [E1000-devel] [PATCH 1/2] e1000e: Disable ASPM L1 on 82574

2012-06-06 Thread Greg KH
On Fri, Jun 01, 2012 at 10:17:08PM +0100, Chris Boot wrote: > On 23/04/2012 22:29, Chris Boot wrote: > > ASPM on the 82574 causes trouble. Currently the driver disables L0s for > > this NIC but only disables L1 if the MTU is >1500. This patch simply > > causes L1 to be disabled regardless of the MT

Re: [E1000-devel] Detected Hardware Unit Hang on Intel Wired Ethernet

2012-01-05 Thread Greg KH
On Thu, Jan 05, 2012 at 10:00:39AM +0530, Pratyush Anand wrote: > On 1/5/2012 12:52 AM, Greg KH wrote: > >On Wed, Jan 04, 2012 at 04:31:36PM +0530, Pratyush Anand wrote: > >>Adding PCI mailing list too, as problem is coming only when MSI is enabled. > >> > >>

Re: [E1000-devel] Detected Hardware Unit Hang on Intel Wired Ethernet

2012-01-04 Thread Greg KH
On Wed, Jan 04, 2012 at 04:31:36PM +0530, Pratyush Anand wrote: > Adding PCI mailing list too, as problem is coming only when MSI is enabled. > > If I connect an PCIe analyzer, I see that at the time of issue > MRd(64) for 32 words has been issued with a wrong 64 bit address > from ethernet card t

Re: [E1000-devel] [stable] Li-nux 2.6.27.19 2.6.28.7

2009-03-13 Thread Greg KH
On Fri, Mar 13, 2009 at 03:10:51PM -0700, Andrew Morton wrote: > > I fired up this kernel up on my FC8 laptop and I see > http://userweb.kernel.org/~akpm/p3130212.jpg > > On the next two boot attempts, the kernel came up OK. > That's wierd, it can't find the root filesystem? What driver contro