.
Please contact us if you would require more information.
Looking forward to your response.
Thanks,
Joe
Email: fion...@sina.com
--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide yo
.
Please contact us if you would require more information.
Looking forward to your response.
Thanks,
Joe
Email: fion...@sina.com
--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide yo
Use bool constants as the return values instead of 1 and 0.
Signed-off-by: Joe Perches
---
> To be honest I'd might rather get bunches of these, there has to be a ton
> of them, than a slow trickle of one every few weeks/days.
There aren't too many...
drivers/net/etherne
Use the built-in function instead of memset.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/amd/pcnet32.c | 2 +-
drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 2 +-
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c| 6 +++---
drivers/net/ethernet/broadcom/bnx2x
Joe Perches (14):
etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code
ethernet: Use eth__addr instead of memset
net: usb: Use eth__addr instead of memset
wireless: Use eth__addr instead of memset
netconsole: Use eth__addr instead of memset
xen: Use eth__addr instead
On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote:
> On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
> > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
> > > We should prefer `const struct pci_device_id` over
> > > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding styl
Use the zeroing function instead of dma_alloc_coherent & memset(,0,)
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/ixgb/ixgb_main.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgb/ixgb_main.c
b/drivers/net/ethernet/i
Use the zeroing function instead of dma_alloc_coherent & memset(,0,)
Joe Perches (26):
powerpc: Use dma_zalloc_coherent
sh: Use dma_zalloc_coherent
ata: Use dma_zalloc_coherent
block: Use dma_zalloc_coherent
crypto: Use dma_zalloc_coherent
dma: Use dma_zalloc_coherent
gpu:
On Wed, 2014-06-04 at 23:29 +0200, Rickard Strandqvist wrote:
> Added a guaranteed null-terminate after call to strncpy.
Perhaps all of these should be strlcpy
--
Learn Graph Databases - Download FREE O'Reilly Book
"Gra
All of these are pointless...
Joe Perches (7):
altera: Remove casts of pointer to same type
alx: Remove casts of pointer to same type
intel: Remove casts of pointer to same type
qlcnic: Remove casts of pointer to same type
carl9170: Remove casts of pointer to same type
mwifiex: Remove
Casting a pointer to a pointer of the same type is pointless,
so remove these unnecessary casts.
Done via coccinelle script:
$ cat typecast_2.cocci
@@
type T;
T *foo;
@@
- (T *)foo
+ foo
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 4 ++--
1
Using addressof then casting to the original type is pointless,
so remove these unnecessary casts.
Done via coccinelle script:
$ cat typecast.cocci
@@
type T;
T foo;
@@
- (T *)&foo
+ &foo
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/i40e/i40e_common
On Fri, 2014-03-14 at 19:02 +0100, Jakub Kiciński wrote:
> On Fri, 14 Mar 2014 10:48:37 -0700, Joe Perches wrote:
> > On Fri, 2014-03-14 at 18:34 +0100, Jakub Kicinski wrote:
> > > Hardware may fail to report time stamp e.g.:
> > > - when hardware time stamping is not
On Fri, 2014-03-14 at 18:34 +0100, Jakub Kicinski wrote:
> Hardware may fail to report time stamp e.g.:
> - when hardware time stamping is not enabled
> - when time stamp is requested shortly after ifup
trivia:
> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c
> b/drivers/net/ethernet/
The use of __constant_ has been unnecessary for quite awhile now.
Make these uses consistent with the rest of the kernel.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 8 +++
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 30 +--
2
The use of __constant_ has been unnecessary for quite awhile now.
Make these uses consistent with the rest of the kernel.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/igbvf/netdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel
The use of __constant_ has been unnecessary for quite awhile now.
Make these uses consistent with the rest of the kernel.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/e100.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/e100.c
The use of __constant_ has been unnecessary for quite awhile now.
Make these uses consistent with the rest of the kernel.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/igb/igb_main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net
The use of __constant_ has been unnecessary for quite awhile now.
Make these uses consistent with the rest of the kernel.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net
Joe Perches (9):
brocade: Convert uses of __constant_ to
e100: Convert uses of __constant_ to
igb: Convert uses of __constant_ to
igbvf: Convert uses of __constant_ to
ixgbe: Convert uses of __constant_ to
ixgbevf: Convert uses of __constant_ to
xilinx: Convert uses of
On Fri, 2014-03-07 at 12:14 -0300, Marcelo Tosatti wrote:
> On Thu, Mar 06, 2014 at 07:24:31PM -0800, Jeff Kirsher wrote:
> > On Thu, 2014-03-06 at 23:04 -0300, Marcelo Tosatti wrote:
> > > There is a race on the shutdown path of the e1000 driver
> > > that allows the card to DMA into free'd memory
Don't emit these as there's a generic OOM with a dump_stack()
on allocation failures.
Signed-off-by: Joe Perches
---
With patch attached this time...
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 5 +---
drivers/net/ethernet/intel/i40evf/i40evf_main.c| 20
Don't emit these as there's a generic OOM with a dump_stack()
on allocation failures.
Signed-off-by: Joe Perches
---
--
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for An
] (followed by s16 vlan)
struct net_device.dev_addr (pointer to char array of MAX_ADDR_LEN)
struct sockaddr.sa_data (array of 14 bytes)
struct netdev_hw_addr.addr (pointer to char array of MAX_ADDR_LEN)
Signed-off-by: Joe Perches
---
On Fri, 2013-12-27 at 12:46 -0800, Joe Perches wrote:
> On
On Tue, 2013-12-24 at 22:35 +0800, Ding Tianhong wrote:
> 于 2013/12/24 22:22, Joe Perches 写道:
> > On Tue, 2013-12-24 at 19:27 +0800, Ding Tianhong wrote:
> >> Use possibly more efficient ether_addr_equal_unaligned
> >> and ether_addr_equal to instead of memcmp.
>
On Tue, 2013-12-24 at 19:27 +0800, Ding Tianhong wrote:
> Use possibly more efficient ether_addr_equal_unaligned
> and ether_addr_equal to instead of memcmp.
A negative of adding so many different drivers in a single
patch is that you miss sending patches to the named maintainers.
Most of these b
e format string that emits this too.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_
Convert the memset/memcpy uses of 6 to ETH_ALEN
where appropriate.
Also convert some struct definitions and u8 array
declarations of [6] to ETH_ALEN.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/8390/ax88796.c| 2 +-
drivers/net/ethernet/amd/atarilance.c
On Tue, 2013-09-24 at 15:07 -0700, Jeff Kirsher wrote:
> On Tue, 2013-09-24 at 14:09 -0700, Joe Perches wrote:
> > There are a mix of function prototypes with and without extern
> > in the kernel sources. Standardize on not using extern for
> > function prototypes.
> &g
clare automatic/local variables in a block.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/e1000/e1000.h | 32 ++---
drivers/net/ethernet/intel/e1000e/e1000.h| 45 ---
drivers/net/ethernet/intel/igb/e1000_82575.h | 16 +--
drivers/net/ethernet/intel/igb/e1000_hw.h| 6 +-
dr
294da3abaa73a0b69fd54e442b0b5bd9455b7be6:
irda: Remove extern from function prototypes (2013-09-24 12:54:17 -0700)
Joe Perches (10):
ibm/emac: Remove extern from function prototypes
intel: Remove extern from function prototypes
oki-semi
On Wed, 2013-09-11 at 07:32 -0700, Jeff Kirsher wrote:
> On Wed, 2013-09-11 at 05:20 -0700, Joe Perches wrote:
> > On Wed, 2013-09-11 at 02:50 -0700, Jeff Kirsher wrote:
> > > New driver build option is CONFIG_I40E
> >
> > > diff --git a/Documentation/networkin
On Wed, 2013-09-11 at 07:32 -0700, Jeff Kirsher wrote:
> On Wed, 2013-09-11 at 05:20 -0700, Joe Perches wrote:
> > On Wed, 2013-09-11 at 02:50 -0700, Jeff Kirsher wrote:
> > > New driver build option is CONFIG_I40E
> >
> > > diff --git a/Documentation/networkin
On Wed, 2013-09-11 at 02:50 -0700, Jeff Kirsher wrote:
> From: Jesse Brandeburg
>
> This is the driver for the Intel(R) Ethernet Controller XL710 Family.
trivial:
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
> b/drivers/net/ethernet/intel/i40e/i40e_main.c
[]
> +int i40e_allocate_
On Wed, 2013-09-11 at 02:50 -0700, Jeff Kirsher wrote:
> New driver build option is CONFIG_I40E
> diff --git a/Documentation/networking/00-INDEX
> b/Documentation/networking/00-INDEX
[]
> +i40e.txt
> + - README for the Intel Ethernet Controller XL710 Driver (i40e).
Just curious but why the X
On Fri, 2013-09-06 at 17:28 +, Williams, Mitch A wrote:
> My goal was to make our out-of-tree driver as close as possible -
> including the makefiles - to the upstream driver. Doing this makes it
> simpler for us to backport and forward-port patches. It makes it less
> confusing for us when we'
On Fri, 2013-09-06 at 06:28 +, Brandeburg, Jesse wrote:
> On Sep 5, 2013, at 11:15 PM, "Stephen Hemminger"
> mailto:step...@networkplumber.org>> wrote:
>
> Dumb question why is this named Kbuild instead of Makefile like almost
> every other network driver?
>
> All the new kids are doing it,
l it works or doesn't work for you all.
Bug reports (and patches) welcome.
cheers, Joe
--
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous
On Wed, 2013-09-04 at 00:59 +, Nelson, Shannon wrote:
> > -Original Message-
> > From: Joe Perches [mailto:j...@perches.com]
[]
> Hi Joe,
Hi again.
> > > +/**
> > > + * i40e_get_netdev_stats_struct - Get statistics for netdev interface
> >
On Wed, 2013-09-04 at 01:00 +, Nelson, Shannon wrote:
Hi Shannon.
> > -Original Message- > From: Joe Perches
> [mailto:j...@perches.com] > Sent: Friday, August 30, 2013 4:06 PM > >
> Just some potential cleanings...
>
> > i40e: Whitespace cleaning
;
@@
- ether_addr_equal(a, b) == 0
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) != 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !!ether_addr_equal(a, b)
+ ether_addr_equal(a, b)
Signed-off-by: Joe Perches
---
drivers/net/ethernet
When dma_addr_t is a 32 bit value, >> 32 emits compiler warnings
Use ((addr>>16) >>16) to avoid this.
I presume the macro should actually use the kernel.h
macro upper_32_bits() eventually.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/i40e/i40e_hmc.h | 2 +-
dr
rivers/net/ethernet/intel/i40e/built-in.o.new
177030 35867 49936 262833 402b1
drivers/net/ethernet/intel/i40e/built-in.o.old
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/i40e/i40e.h | 12
drivers/net/ethernet/intel/i40e/i40e_main.c | 45 ++
Just some potential cleanings...
Joe Perches (4):
i40e: Whitespace cleaning
i40e: Add and use pf_
i40e: pf_ remove "%s: " ... __func__
i40e: Convert pf_ macros to functions
drivers/net/ethernet/intel/i40e/i40e.h | 149 +--
drivers/net/ethernet/intel/i40e/i40
On Fri, 2013-08-30 at 05:39 -0700, Jeff Kirsher wrote:
> From: Jesse Brandeburg
trivial comments only:
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
> b/drivers/net/ethernet/intel/i40e/i40e_main.c
> +#define DRV_KERN "-k"
> +
> +#define DRV_VERSION_MAJOR 0
> +#define DRV_VERSION_M
On Fri, 2013-08-30 at 14:40 -0400, David Miller wrote:
> From: Stephen Hemminger
> Date: Fri, 30 Aug 2013 11:10:29 -0700
>
> > On Fri, 30 Aug 2013 09:32:48 -0700
> > Joe Perches wrote:
> >
> >> > +static int debug = -1;
> >> > +module_p
On Thu, 2013-08-29 at 22:09 -0400, David Miller wrote:
> Applied, thanks a lot Joe.
Too bad I didn't know there was a dma_zalloc_coherent
the first time...
cheers, Joe
--
Learn the latest--Visual Stu
__GFP_ZERO instead.
Trivially reduces the size of the existing uses of
dma_zalloc_coherent.
Realign arguments as appropriate.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/aeroflex/greth.c | 12 -
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 6 ++---
drivers/net
On Thu, 2013-06-13 at 20:55 -0700, Jeff Kirsher wrote:
> From: Jesse Brandeburg
>
> This is the driver for the Intel(R) Ethernet Controller XL710 Family.
This code looks very generic and not tailored to linux.
Are you intending to fix it to be more linux-kernel like?
> diff --git a/drivers/net/
On Mon, 2013-05-20 at 00:54 -0700, David Miller wrote:
> From: Eliezer Tamir
[]
> > {
> > struct socket *sock;
> > + unsigned int poll_result;
>
> Please order local variable declarations from longest line to
> shortest line.
reverse christmas tree doesn't seem especially valuable or
Add some empty static inlines instead to make
the code more readable.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/ixgbe/ixgbe.h | 5 +
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 --
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers
On Fri, 2013-03-15 at 22:51 +, Abodunrin, Akeem G wrote:
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
> Behalf Of Joe Perches
[]
> Reduce the number of calls required to alloc a zeroed block of memory.
[]
> diff --gi
Signed-off-by: Joe Perches
---
drivers/net/ethernet/aeroflex/greth.c | 8 ++--
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 8
drivers/net/ethernet/broadcom/bnx2.c | 5 ++---
drivers/net/ethernet/broadcom/bnx2x/bnx2x.h| 9 +++--
drivers
.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/aeroflex/greth.c | 20 ---
drivers/net/ethernet/amd/sunlance.c| 5 ++-
drivers/net/ethernet/apple/macmace.c | 16 -
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 --
drivers
alignment.
Signed-off-by: Joe Perches
---
Let me know if you want multiple small patches instead.
drivers/net/can/usb/ems_usb.c | 4 +-
drivers/net/ethernet/amd/pcnet32.c | 47 +++---
drivers/net/ethernet/freescale/gianfar.c | 25
to vzalloc.
Remove now unused size variables.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c| 6 ++---
drivers/net/ethernet/atheros/atl1e/atl1e_main.c| 2 --
drivers/net/ethernet/broadcom/b44.c| 4 +---
drivers/net/ethernet/broadcom/bcm6
Remove all the OOM messages that follow kernel alloc
failures as there is already a generic equivalent to
these messages in the mm subsystem.
Joe Perches (8):
caif: Remove unnecessary alloc/OOM messages
can: Remove unnecessary alloc/OOM messages
ethernet: Remove unnecessary alloc/OOM
Hi Yijing,
Thanks for your reference, the patch looks good for me, but I have no chance
to test it on customer's env.
Best Regards,
Joe
On 12/19/12 13:52, Yijing Wang wrote:
> On 2012/12/19 11:04, Joe Jin wrote:
>> Hi all,
>>
>> I backported mps commits
Hi all,
I backported mps commits and ask customer pass "pci=pcie_bus_peer2pee" to kernel
to limited MPS to 128 and issue disappeared, sound like this is a BIOS bug.
Thanks all of your help.
Best Regards,
Joe
On 11/29/12 23:52, Fujinaka, Todd wrote:
> Someone else pointed this out
I'm trying to use ethtool modify it from eeprom to see if help or no.
Todd, I'll review all MaxPayload for all devices, but need to say if it
mismatch,
customer could not modify it from BIOS for there was not entry at there, to
test it, we hav
is, so I had to use ethtool, now I need to get the offset
of MaxPayload size in eeprom, I ever tried to find from Intel online document
but failed, any idea?
Thanks in advance,
Joe
--
Monitor your physical, virtual and
L0
<4us, L1 <64us
ClockPM- Surprise- LLActRep- BwNot-
LnkCtl: ASPM Disabled; RCB 64 bytes Disabled- Retrain- CommClk+
ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
LnkSta: Speed 2.5GT/s,
ASPM L0s, Latency L0
<4us, L1 <64us
ClockPM- Surprise- LLActRep- BwNot-
LnkCtl: ASPM Disabled; RCB 64 bytes Disabled- Retrain- CommClk+
ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
LnkSta: Speed 2.5GT/s,
On 11/16/12 04:26, Dave, Tushar N wrote:
>> Would you please help to fine the offset of max payload size in eeprom?
>> I'd like to have a try to modify it by ethtool.
>
> It is defined using bit 8 of word 0x1A.
> Bit value 0 = 128B , bit value 1 = 256B
Hi Tushar,
I checked one of my server which
On 11/14/12 11:45, Dave, Tushar N wrote:
>> -Original Message-
>> From: Joe Jin [mailto:joe@oracle.com]
>> Sent: Tuesday, November 13, 2012 6:48 PM
>> To: Dave, Tushar N
>> Cc: e1000-de...@lists.sf.net; net...@vger.kernel.org; linux-
>> ker...@vger
from BIOS, can I modify it from driver side?
Thanks,
Joe
--
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastruc
On 11/09/12 04:35, Dave, Tushar N wrote:
> Are you sure this is not similar issue as before that you reported.
> i.e.
Tushar,
Thanks for your quick response, I'll check with customer if they can modify the
Max
payload size from BIOS, this time issue hit on HP's server.
Thanks
Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr+
Stepping- SERR- FastB2B- DisINTx-
- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- TAbort- SERR- http://www.oracle.com>
Joe Jin | Software Development Senior Manager | +8610.6106.5624
ORACLE |
*)
ipv4_addr_(__be32)
ipv6_addr_(const struct in6_addr *)
Add temporary backward compatibility #defines for the old names too.
Joe Perches (21):
etherdevice: Rename is__ether_addr tests to eth_addr_
net: Convert is__ether_addr uses to eth_addr_
arch: Convert is__ether_addr uses to eth_addr_
On 07/15/12 11:42, Dave, Tushar N wrote:
>> -Original Message-
>> From: Joe Jin [mailto:joe@oracle.com]
>> Sent: Thursday, July 12, 2012 9:34 PM
>> To: Dave, Tushar N
>> Cc: e1000-de...@lists.sf.net; net...@vger.kernel.org; linux-
>> ker...@vge
Convert the existing uses of random_ether_addr to
the new eth_random_addr.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/atheros/atl1c/atl1c_hw.c |2 +-
drivers/net/ethernet/atheros/atlx/atl1.c |2 +-
drivers/net/ethernet/atheros/atlx/atl2.c |2
net-next commit ad7eee98be ("etherdevice: introduce eth_broadcast_addr")
added a new style API. Rename random_ether_addr to eth_random_addr to
create some API symmetry.
Joe Perches (8):
etherdevice: Rename random_ether_addr to eth_random_addr
ethernet: Use eth_random_addr
net
On 07/12/12 13:57, Dave, Tushar N wrote:
>> -Original Message-
>> From: Joe Jin [mailto:joe@oracle.com]
>> Sent: Wednesday, July 11, 2012 8:13 PM
>> To: Dave, Tushar N
>> Cc: e1000-de...@lists.sf.net; net...@vger.kernel.org; linux-
>> ker...@vge
On 07/12/12 11:07, Dave, Tushar N wrote:
>> -Original Message-
>> From: Joe Jin [mailto:joe@oracle.com]
>> Sent: Wednesday, July 11, 2012 7:58 PM
>> To: Dave, Tushar N
>> Cc: e1000-de...@lists.sf.net; net...@vger.kernel.org; linux-
>> ker...@vge
On 07/12/12 10:52, Dave, Tushar N wrote:
> What is the exact error messages in BIOS log?
Error message from BIOS event log:
07/12/12 05:54:00
PCI Express Non-Fatal Error
Thanks,
Joe
--
Live Security Virt
On 07/12/12 02:51, Dave, Tushar N wrote:
>
> Joe,
>
> I see couple of errors in lspci output.
> Device capability status register shows UnCorrectable PCIe error. This means
> there is certainly something went wrong. The only way to recover from
> Uncorrec
On 07/11/12 15:50, Dave, Tushar N wrote:
> Device status and AER sections show some errors that looks little suspicious
> to me but I'm not too sure. I will get back tomorrow.
>
Thanks a lot, Tushar!
Joe
--
Oracle <http://www.oracle.com>
Joe Jin | Software Develo
On 07/11/12 15:37, Dave, Tushar N wrote:
>> -Original Message-
>> From: Joe Jin [mailto:joe@oracle.com]
>> Sent: Wednesday, July 11, 2012 12:18 AM
>> To: Dave, Tushar N
>> Cc: e1000-de...@lists.sf.net; net...@vger.kernel.org; linux-
>> ker...@vge
On 07/11/12 15:11, Dave, Tushar N wrote:
>> -Original Message-
>> From: Joe Jin [mailto:joe@oracle.com]
>> Sent: Tuesday, July 10, 2012 10:03 PM
>> To: Dave, Tushar N
>> Cc: e1000-de...@lists.sf.net; net...@vger.kernel.org; linux-
>> ker...@vge
r I tried to scp big file (~1GB) will hit it at once.
Thanks,
Joe
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT man
On 07/11/12 11:22, Dave, Tushar N wrote:
> Thanks for info. I see that hang occurs right when HW processing first TX
> descriptor with TSO.
> Would you be able to reproduce issue with TSO off? Disable TSO by 'ethtool
> -K ethx tso off'
> Let all debug enabled as it is, that will help us debug f
On 07/11/12 03:02, Dave, Tushar N wrote:
>> -Original Message-
>> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org]
>> On Behalf Of Joe Jin
>> Sent: Tuesday, July 10, 2012 12:40 AM
>> To: Joe Jin
>> Cc: e1000-de...@lists.sf.net; n
count)) {
<--- snip --->
1487 }
I checked all driver codes I did not found anywhere will set the upper.data
with
E1000_TXD_STAT_DD, I guess upper.data be set by hardware?
If OS is 32bit system, what which happen?
Thanks in advance,
Joe
On 07/09/12 16:51, Joe Jin wrote:
> Hi
On 07/09/12 17:21, Eric Dumazet wrote:
> On Mon, 2012-07-09 at 16:51 +0800, Joe Jin wrote:
>> Hi list,
>>
>> I'm seeing a Unit Hang even with the latest e1000e driver 2.0.0 when doing
>> scp test. this issue is easy do reproduced on SUN FIRE X2270 M2, just copy
&g
rt_kernel+0x64/0xb0
---[ end trace 5502b55cd4d4e5cb ]---
e1000e :05:00.0: eth0: Reset adapter
e1000e: eth0 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: Rx/Tx
Thanks,
Joe
--
Live Security Virtual Conference
disable receive hashing.
Signed-off-by: Joe Jin
Signed-off-by: Guru Anbalagane
Acked-by: Adnan Misherfi
Cc: David S. Miller
---
drivers/net/ethernet/intel/e1000e/netdev.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000e
On Wed, 2012-05-30 at 16:42 +0200, Eric Dumazet wrote:
> On Wed, 2012-05-30 at 07:09 -0700, Joe Perches wrote:
>
> > Whatever evals A and B once would be better.
>
> Why do you believe they could be evaluated several time ?
>
> #define POSDIFF(A, B) max_t(int, (A) - (B)
On Wed, 2012-05-30 at 13:59 +0200, Eric Dumazet wrote:
> On Wed, 2012-05-30 at 04:20 -0700, Joe Perches wrote:
> > On Wed, 2012-05-30 at 13:08 +0200, Eric Dumazet wrote:
> > > Maybe we should change all POSDIFF(), not selected ones.
> > > #define POSDIFF(A, B) ((int)((A)
On Wed, 2012-05-30 at 13:08 +0200, Eric Dumazet wrote:
> Maybe we should change all POSDIFF(), not selected ones.
> #define POSDIFF(A, B) ((int)((A) - (B)) > 0 ? (A) - (B) : 0)
maybe use an eval once statement expression macro
({
typeof (A) _a = (A);
typeof (B) _b = (B);
((
Remove an unnecessary #define and use memcpy
instead of a loop to copy an ethernet address.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/igbvf/defines.h |4
drivers/net/ethernet/intel/igbvf/vf.c |7 ++-
2 files changed, 2 insertions(+), 9 deletions(-)
diff
Just some neatening
Joe Perches (4):
if_vlan: Remove VLAN_ETH_ALEN define and the 1 use of it
atlx: Use ETH_ALEN
igbvf: Use ETH_ALEN
rtlwifi: Remove unused ETH_ADDR_LEN defines
drivers/net/ethernet/atheros/atlx/atl2.c | 13 +
drivers/net/ethernet/atheros/atlx/atl2.h
Separate a complicated bit of e1000_config_dsp_after_link_change
into a new static function e1000_1000Mb_check_cable_length.
Reduces indentation and adds a bit of clarity.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/e1000/e1000_hw.c | 156 +--
1 files
On Wed, 2011-12-07 at 07:20 +, Al Viro wrote:
> On Wed, Dec 07, 2011 at 02:36:20PM +0800, Michael Wang wrote:
> > On 12/07/2011 02:19 PM, Joe Perches wrote:
>
> [snip]
> > > if (*i2cctl & IXGBE_I2C_DATA_IN)
> > > - data = 1;
>
On Wed, 2011-12-07 at 14:08 +0800, Michael Wang wrote:
> I'm not good at script, if you are interested, we can work together to
> fix all the remain cases, and send out some patches.
You should try coccinelle and spatch.
If you run the script, this is the intel output.
drivers/net/ethernet/inte
On Wed, 2011-12-07 at 12:49 +0800, Michael Wang wrote:
> On 12/07/2011 12:14 PM, Joe Perches wrote:
>
> > On Tue, 2011-12-06 at 19:43 -0800, Jeff Kirsher wrote:
> >> On Tue, 2011-12-06 at 18:33 -0800, Michael Wang wrote:
> >>> From: Michael Wang
> >>&g
On Tue, 2011-12-06 at 19:43 -0800, Jeff Kirsher wrote:
> On Tue, 2011-12-06 at 18:33 -0800, Michael Wang wrote:
> > From: Michael Wang
> > Use true and false instead of 1 and 0 when assign value to a bool type
> > variable.
> Thanks Michael, I have added your patch to my queue of e1000e patches.
printks should use KERN_ levels.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/igb/e1000_82575.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c
b/drivers/net/ethernet/intel/igb/e1000_82575.c
index c0857bd
ble output interleaving from other modules.
Coalesce formats as appropriate.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/igb/igb_main.c | 155 +---
1 files changed, 72 insertions(+), 83 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
b/d
Just some conversions of printks to pr_
and some trivial defect corrections.
Joe Perches (5):
e1000e: Convert printks to pr_
ixgbevf: Convert printks to pr_
igbvf: Convert printks to pr_
igb: Convert printks to pr_
igb: Convert bare printk to pr_notice
drivers/net/ethernet/intel
Use current logging styles.
Prefix all output via #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Neaten link status dev_info.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/igbvf/netdev.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/d
1 - 100 of 148 matches
Mail list logo
