On 16-07-05 08:38 AM, Alexander Duyck wrote:
> On Tue, Jul 5, 2016 at 8:17 AM, ayuj wrote:
>> I'm trying to configure DCB in back-to-back scenario.
>> System details
>>
>> OS :- CentOS 7.2
>> kernel 3.10.0-327.el7.x86_64
>> lldpad:- lldpad v0.9.46
>> dcbtool:- v0.9.46
>> ixgbe :- ixgbe-4.3.15
>>
>
xmit() and we can just reuse the code of
> dev_queue_xmit() to do the transmission.
>
> In the future, it was also required for macvtap l2 forwarding support since it
> provides a necessary synchronization method.
>
> Cc: John Fastabend
> Cc: Neil Horman
> Cc: e1000-devel@lists.
xmit().
>
> In the future, it was also required for macvtap l2 forwarding support since it
> provides a necessary synchronization method.
>
> Cc: John Fastabend
> Cc: Neil Horman
> Cc: e1000-devel@lists.sourceforge.net
> Signed-off-by: Jason Wang
> ---
[...]
> index
[...]
>>
>> +int dfwd_direct_xmit(struct sk_buff *skb, struct net_device *dev,
>> + void *accel_priv)
>> +{
>> +struct netdev_queue *txq;
>> +int ret = NETDEV_TX_BUSY;
>> +int index;
>> +
>> +BUG_ON(!dev->netdev_ops->ndo_dfwd_select_queue);
>> +index =dev->netde
>> With this fixes, NETIF_F_LLTX could be preserved for macvlan and there's no
>> need
>> to check txq against NULL in dev_hard_start_xmit().
>>
>> In the future, it was also required for macvtap l2 forwarding support since
>> it
>> provides a necessa
PID: 2173 at net/core/dev.c:4448
> netdev_all_upper_get_next_dev_rcu+0x6b/0xa0()
This should be fixed when net is synced with net-next by the
following commit,
author John Fastabend
committer Jeff Kirsher
commit 85328240c625f322af9f69c7b60e619717101d77
net: allow netdev_
On 12/19/2013 10:08 AM, Florian Fainelli wrote:
> Hi John,
>
> In commit 815cccbf ("ixgbe: add setlink, getlink support to ixgbe and
> ixgbevf") this line was added:
>
>
> + if ((skb->pkt_type & (PACKET_BROADCAST | PACKET_MULTICAST)) &&
> + !(compare_ether_addr(adapt
On 12/18/2013 10:00 PM, Jiang Liu wrote:
> According to documentation for netdev_for_each_all_upper_dev_rcu(),
> caller should take RCU read lock, otherwise it will trigger following
> warnings. The simplest fix is to protect with rcu_read_lock()/
> rcu_read_unlock(). And this solutions passes basi
On 9/5/2013 11:32 AM, Stephen Hemminger wrote:
[...]
>
> IMHO attributes are a nice way of handling the VSI attributes since they
> seem hardware specific. Not sure how to do the right thing with switching.
> Should it look like Macvlan, bridge, VXLAN, or something else.
I think if you add a n
On 8/2/2012 4:01 PM, Jay Vosburgh wrote:
> Chris Friesen wrote:
>
>> On 08/02/2012 04:26 PM, Chris Friesen wrote:
>>> On 08/02/2012 02:30 PM, Jay Vosburgh wrote:
>>
The best long term solution is to have a user space API that
provides link state input to bonding on a per-slave basis, and
On 4/20/2012 12:13 PM, Ben Greear wrote:
> On 04/20/2012 12:05 PM, Tom Herbert wrote:
>>> I am seeing something similar with the 'igb' driver, though this
>>> NIC also involves a side-driver that does bypass. When I enable/disable
>>> bypass, the links bounce (as expected), and igb reports the sam
On 2/9/2012 11:16 AM, John Fastabend wrote:
> Hi Dan,
>
> These should fix the two smatch hits you found. I'll probably send these
> through Jeff Kirsher. Seeing they are mostly ixgbe fixups.
>
> ---
>
> John Fastabend (2):
> net: dcb: getnumtcs()/
to an int.
Reported-by: Dan Carpenter
Signed-off-by: John Fastabend
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c |4 ++--
drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c |4 ++--
include/net/dcbnl.h |4 ++--
3 files changed, 6 insertions(+), 6
Hi Dan,
These should fix the two smatch hits you found. I'll probably send these
through Jeff Kirsher. Seeing they are mostly ixgbe fixups.
---
John Fastabend (2):
net: dcb: getnumtcs()/setnumtcs() should return an int
ixgbe: dcb: check setup_tc return codes
drivers/net/eth
seen in practive its best to check return codes.
Reported-by: Dan Carenter
Signed-off-by: John Fastabend
---
drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c | 26 ---
1 files changed, 18 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe
On 2/7/2012 11:20 PM, Dan Carpenter wrote:
> Smatch complains about a couple bogus return codes in
> drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c
Thanks Dan, I'll whip up a fix for these tomorrow.
>
>112 static u8 ixgbe_dcbnl_set_state(struct net_device *netdev, u8 state)
>113 {
>
On 10/11/2011 11:35 PM, Dan Carpenter wrote:
> Hello John Fastabend,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 32701dc2e616: "ixgbe: fixup hard dependencies on supporting
> 8 traffic classes" from Sep 27, 2011, leads to the
17 matches
Mail list logo
