Re: [E1000-devel] [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt

2013-10-07 Thread Jon Mason
On Mon, Oct 07, 2013 at 08:38:45PM +0200, Alexander Gordeev wrote: > On Mon, Oct 07, 2013 at 09:50:57AM -0700, Jon Mason wrote: > > On Sat, Oct 05, 2013 at 11:43:04PM +0200, Alexander Gordeev wrote: > > > On Wed, Oct 02, 2013 at 05:48:05PM -0700, Jon Mason wrote: > > > &

Re: [E1000-devel] [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt

2013-10-07 Thread Jon Mason
On Sat, Oct 05, 2013 at 11:43:04PM +0200, Alexander Gordeev wrote: > On Wed, Oct 02, 2013 at 05:48:05PM -0700, Jon Mason wrote: > > On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: > > > Signed-off-by: Alexander Gordeev > > > --- > > > dri

Re: [E1000-devel] [PATCH RFC 01/77] PCI/MSI: Fix return value when populate_msi_sysfs() failed

2013-10-03 Thread Jon Mason
On Thu, Oct 03, 2013 at 10:46:21PM +0100, Ben Hutchings wrote: > On Wed, 2013-10-02 at 17:39 -0700, Jon Mason wrote: > > On Wed, Oct 02, 2013 at 12:48:17PM +0200, Alexander Gordeev wrote: > > > Signed-off-by: Alexander Gordeev > > > > Since you ar

Re: [E1000-devel] [PATCH RFC 53/77] ntb: Fix missed call to pci_enable_msix()

2013-10-03 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:49:09PM +0200, Alexander Gordeev wrote: > Current MSI-X enablement code assumes MSI-Xs were successfully > allocated in case less than requested vectors were available. > That assumption is wrong, since MSI-Xs should be enabled with > a repeated call to pci_enable_msix().

Re: [E1000-devel] [PATCH RFC 55/77] ntb: Update MSI/MSI-X interrupts enablement code

2013-10-02 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:49:11PM +0200, Alexander Gordeev wrote: > As result of recent re-design of the MSI/MSI-X interrupts enabling > pattern this driver has to be updated to use the new technique to > obtain a optimal number of MSI/MSI-X interrupts required. > > Signed-off-by: Alexander Gorde

Re: [E1000-devel] [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt

2013-10-02 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: > Signed-off-by: Alexander Gordeev > --- > drivers/ntb/ntb_hw.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c > index de2062c..eccd5e5 100644 > --- a/dr

Re: [E1000-devel] [PATCH RFC 01/77] PCI/MSI: Fix return value when populate_msi_sysfs() failed

2013-10-02 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:48:17PM +0200, Alexander Gordeev wrote: > Signed-off-by: Alexander Gordeev Since you are changing the behavior of the msix_capability_init function on populate_msi_sysfs error, a comment describing why in this commit would be nice. > --- > drivers/pci/msi.c | 11 +++

Re: [E1000-devel] [PATCH RFC 77/77] vxge: Update MSI/MSI-X interrupts enablement code

2013-10-02 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:49:33PM +0200, Alexander Gordeev wrote: > As result of recent re-design of the MSI/MSI-X interrupts enabling > pattern this driver has to be updated to use the new technique to > obtain a optimal number of MSI/MSI-X interrupts required. > > Signed-off-by: Alexander Gorde

[E1000-devel] Ethernet driver on top of shared memory

2012-11-28 Thread Jon Mason
> -Original Message- > From: William Tu [mailto:u9012...@gmail.com] > Sent: Wednesday, November 28, 2012 6:02 AM > To: e1000-devel@lists.sourceforge.net > Subject: [E1000-devel] Ethernet driver on top of shared memory > > Hi Folks, > > I have two machines A and B. And I have a shared mem

Re: [E1000-devel] 82571EB: Detected Hardware Unit Hang

2012-07-16 Thread Jon Mason
g a >> > ruckus about it in the kernel log (and probably fixing it to min(path) >> > while >> > at it)... >> > >> > Is this something that should be raised as a feature request with the >> > PCI/PCIe subsystem? >> >> The feature is

Re: [E1000-devel] 82571EB: Detected Hardware Unit Hang

2012-07-16 Thread Jon Mason
; at it)... >> >> Is this something that should be raised as a feature request with the >> PCI/PCIe subsystem? > > The feature is there, but we ended up with: > > commit 5f39e6705faade2e89d119958a8c51b9b6e2c53c > Author: Jon Mason > Date: Mon Oct 3 09:50:20 201

[E1000-devel] [resend PATCH] ixgb: use PCI_VENDOR_ID_*

2011-08-03 Thread Jon Mason
Use PCI_VENDOR_ID_* from pci_ids.h instead of creating #define locally. Signed-off-by: Jon Mason --- drivers/net/ixgb/ixgb_hw.c |5 +++-- drivers/net/ixgb/ixgb_ids.h |5 - drivers/net/ixgb/ixgb_main.c | 10 +- 3 files changed, 8 insertions(+), 12 deletions(-) diff

[E1000-devel] [resend PATCH] ixgbe: remove unused #define

2011-08-03 Thread Jon Mason
Remove unused IXGBE_INTEL_VENDOR_ID #define Signed-off-by: Jon Mason --- drivers/net/ixgbe/ixgbe_type.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_type.h b/drivers/net/ixgbe/ixgbe_type.h index e0d970e..b5bf2e1 100644 --- a/drivers/net

Re: [E1000-devel] Warning: myri10ge/sky2/vxge/r8169/niu/bnx2/bnx2x/igb/e100e/cxgb3/mlx4/tg3/vxge : removal of PCI_CAP_ID_EXP

2011-07-05 Thread Jon Mason
On Fri, Jul 1, 2011 at 10:28 AM, Jon Mason wrote: > On Fri, Jul 1, 2011 at 9:49 AM, James Smart wrote: >> All, >> >> I wanted to communicate a potential warning to those drivers that had a >> patch submitted to replace config space searches of PCI_CAP_ID_EXP with &

Re: [E1000-devel] Warning: myri10ge/sky2/vxge/r8169/niu/bnx2/bnx2x/igb/e100e/cxgb3/mlx4/tg3/vxge : removal of PCI_CAP_ID_EXP

2011-07-01 Thread Jon Mason
; hal/platform that isn't sufficiently built up.  We detected this issue >> while >> testing AER/EEH, and are functional only if the pci_find_capability() >> option >> is used. >> >> -- james s >> >> >> >> On 6/27/2011 1:39 PM, Jon Mason w

[E1000-devel] [PATCH 09/19] igb: remove unnecessary reads of PCI_CAP_ID_EXP

2011-06-27 Thread Jon Mason
The PCIE capability offset is saved during PCI bus walking. It will remove an unnecessary search in the PCI configuration space if this value is referenced instead of reacquiring it. Signed-off-by: Jon Mason --- drivers/net/igb/igb_main.c |4 ++-- 1 files changed, 2 insertions(+), 2

[E1000-devel] [PATCH 08/19] e1000e: remove unnecessary reads of PCI_CAP_ID_EXP

2011-06-27 Thread Jon Mason
The PCIE capability offset is saved during PCI bus walking. It will remove an unnecessary search in the PCI configuration space if this value is referenced instead of reacquiring it. Signed-off-by: Jon Mason --- drivers/net/e1000e/lib.c|2 +- drivers/net/e1000e/netdev.c |2 +- 2

[E1000-devel] [PATCH 1/5] ixgb: use PCI_VENDOR_ID_*

2011-06-27 Thread Jon Mason
Use PCI_VENDOR_ID_* from pci_ids.h instead of creating #define locally. Signed-off-by: Jon Mason --- drivers/net/ixgb/ixgb_hw.c |5 +++-- drivers/net/ixgb/ixgb_ids.h |5 - drivers/net/ixgb/ixgb_main.c | 10 +- 3 files changed, 8 insertions(+), 12 deletions(-) diff

[E1000-devel] [PATCH 2/5] ixgbe: remove unused #define

2011-06-27 Thread Jon Mason
Remove unused IXGBE_INTEL_VENDOR_ID #define Signed-off-by: Jon Mason --- drivers/net/ixgbe/ixgbe_type.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_type.h b/drivers/net/ixgbe/ixgbe_type.h index e0d970e..b5bf2e1 100644 --- a/drivers/net

[E1000-devel] [PATCH] ixgbe: ixgbe_fcoe build break

2010-08-03 Thread Jon Mason
struct ixgbe_fcoe has fields that are #ifdef'ed with CONFIG_IXGBE_DCB. However, not all references to those fields check for CONFIG_IXGBE_DCB. This patch adds the necessary check to allow for ixgbe to compile. Signed-off-by: Jon Mason --- drivers/net/ixgbe/ixgbe_main.c |4 1