Re: [E1000-devel] [PATCH net V3 2/2] net: core: explicitly select a txq before doing l2 forwarding

2014-01-10 Thread Neil Horman
o_dfwd_start_xmit() and we can just reuse the code of > dev_queue_xmit() to do the transmission. > > In the future, it was also required for macvtap l2 forwarding support since it > provides a necessary synchronization method. > > Cc: John Fastabend > Cc: Nei

Re: [E1000-devel] [PATCH net V2 2/2] net: core: explicitly select a txq before doing l2 forwarding

2014-01-10 Thread Neil Horman
On Fri, Jan 10, 2014 at 03:03:01PM +0800, Jason Wang wrote: > On 01/09/2014 08:31 PM, Neil Horman wrote: > > On Thu, Jan 09, 2014 at 05:37:32PM +0800, Jason Wang wrote: > >> Currently, the tx queue were selected implicitly in ndo_dfwd_start_xmit(). > >> The >

Re: [E1000-devel] [PATCH net V2 2/2] net: core: explicitly select a txq before doing l2 forwarding

2014-01-09 Thread Neil Horman
gt; > In the future, it was also required for macvtap l2 forwarding support since it > provides a necessary synchronization method. > > Cc: John Fastabend > Cc: Neil Horman > Cc: e1000-devel@lists.sourceforge.net > Signed-off-by: Jason Wang > > --- > Changes from

Re: [E1000-devel] [PATCH net 2/2] net: core: explicitly select a txq before doing l2 forwarding

2014-01-09 Thread Neil Horman
On Thu, Jan 09, 2014 at 04:28:49PM +0800, Jason Wang wrote: > On 01/08/2014 10:40 PM, Neil Horman wrote: > > On Wed, Jan 08, 2014 at 11:21:21AM +0800, Jason Wang wrote: > >> On 01/07/2014 09:17 PM, Neil Horman wrote: > >>> On Tue, Jan 07, 2014 at 11:42:24AM +0800, Jas

Re: [E1000-devel] [PATCH net 2/2] net: core: explicitly select a txq before doing l2 forwarding

2014-01-08 Thread Neil Horman
On Wed, Jan 08, 2014 at 11:21:21AM +0800, Jason Wang wrote: > On 01/07/2014 09:17 PM, Neil Horman wrote: > > On Tue, Jan 07, 2014 at 11:42:24AM +0800, Jason Wang wrote: > >> On 01/06/2014 08:42 PM, Neil Horman wrote: > >>> On Mon, Jan 06, 2014 at 11:2

Re: [E1000-devel] [PATCH net 2/2] net: core: explicitly select a txq before doing l2 forwarding

2014-01-07 Thread Neil Horman
On Tue, Jan 07, 2014 at 11:42:24AM +0800, Jason Wang wrote: > On 01/06/2014 08:42 PM, Neil Horman wrote: > > On Mon, Jan 06, 2014 at 11:21:07AM +0800, Jason Wang wrote: > >> Currently, the tx queue were selected implicitly in ndo_dfwd_start_xmit(). > >> The >

Re: [E1000-devel] [PATCH net 2/2] net: core: explicitly select a txq before doing l2 forwarding

2014-01-06 Thread Neil Horman
On Mon, Jan 06, 2014 at 07:06:25AM -0800, John Fastabend wrote: > On 01/06/2014 04:42 AM, Neil Horman wrote: > >On Mon, Jan 06, 2014 at 11:21:07AM +0800, Jason Wang wrote: > >>Currently, the tx queue were selected implicitly in ndo_dfwd_start_xmit(). > >>The &g

Re: [E1000-devel] [PATCH net 2/2] net: core: explicitly select a txq before doing l2 forwarding

2014-01-06 Thread Neil Horman
ev_hard_start_xmit(). > > In the future, it was also required for macvtap l2 forwarding support since it > provides a necessary synchronization method. > > Cc: John Fastabend > Cc: Neil Horman > Cc: e1000-devel@lists.sourceforge.net > Signed-off-by: Jason Wang Inste

Re: [E1000-devel] [PATCH net-next] drivers:net: Convert dma_alloc_coherent(...__GFP_ZERO) to dma_zalloc_coherent

2013-08-27 Thread Neil Horman
> Remove memset from the static inline dma_zalloc_coherent > and add just one use of __GFP_ZERO instead. > > Trivially reduces the size of the existing uses of > dma_zalloc_coherent. > > Realign arguments as appropriate. > > Signed-

[E1000-devel] [PATCH net-next] e100: Add dma mapping error check

2013-04-02 Thread Neil Horman
: Neil Horman Reported-by: Michal Jaegermann CC: Josh Boyer CC: "David S. Miller" CC: Jeff Kirsher CC: e1000-devel@lists.sourceforge.net --- drivers/net/ethernet/intel/e100.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/d

[E1000-devel] [PATCH net-next] e100: Add dma mapping error check

2013-04-02 Thread Neil Horman
: Neil Horman Reported-by: Michal Jaegermann CC: Josh Boyer CC: "David S. Miller" CC: Jeff Kirsher CC: e1000-devel@lists.sourceforge.net --- drivers/net/ethernet/intel/e100.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/d

Re: [E1000-devel] igb + balance-rr + bridge + IPv6 = no go without promiscuous mode

2012-01-04 Thread Neil Horman
On Wed, Jan 04, 2012 at 04:58:28PM +, Chris Boot wrote: > On 04/01/2012 16:00, Wyborny, Carolyn wrote: > > > > > >>-Original Message- > >>From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > >>On Behalf Of Wyborny, Carolyn > >>Sent: Tuesday, January 03, 2012 3:24 P

Re: [E1000-devel] [PATCH] e1000: enhance frame fragment detection

2010-01-12 Thread Neil Horman
On Tue, Jan 12, 2010 at 06:47:41PM -0800, Brandeburg, Jesse wrote: > On Tue, 12 Jan 2010, Neil Horman wrote: > > I'm sorry, it doesn't clear much up, at least not for me. The patch you're > > referencing above deals only with the jumbo receive path, not the no

Re: [E1000-devel] [PATCH] e1000: enhance frame fragment detection

2010-01-12 Thread Neil Horman
On Tue, Jan 12, 2010 at 05:56:28PM -0800, Brandeburg, Jesse wrote: > On Wed, 6 Jan 2010, Brandeburg, Jesse wrote: > > a counter patch, without atomic ops, since we are protected by napi when > > modifying this variable. > > > > Originally From: Neil Horman > &

Re: [E1000-devel] [PATCH] e1000: enhance frame fragment detection

2010-01-06 Thread Neil Horman
On Wed, Jan 06, 2010 at 03:27:42PM -0800, Brandeburg, Jesse wrote: > a counter patch, without atomic ops, since we are protected by napi when > modifying this variable. > > Originally From: Neil Horman > Modified by: Jesse Brandeburg > > > Hey all- > A secur

Re: [E1000-devel] [PATCH] e1000: enhance frame fragment detection

2010-01-05 Thread Neil Horman
On Tue, Jan 05, 2010 at 01:44:25PM -0800, Brandeburg, Jesse wrote: > Neil, I couple of comments below, I was just looking at the implementation > of this for e1000e. > > On Mon, 28 Dec 2009, Neil Horman wrote: > > > Hey all- > > A security discussion w

Re: [E1000-devel] [PATCH] e1000: enhance frame fragment detection

2009-12-28 Thread Neil Horman
On Mon, Dec 28, 2009 at 04:42:09PM -0800, Jeff Kirsher wrote: > On Mon, Dec 28, 2009 at 12:10, Neil Horman wrote: > > Hey all- > >        A security discussion was recently given: > > http://events.ccc.de/congress/2009/Fahrplan//events/3596.en.html > > And a patch that

[E1000-devel] [PATCH] e1000: enhance frame fragment detection

2009-12-28 Thread Neil Horman
Hey all- A security discussion was recently given: http://events.ccc.de/congress/2009/Fahrplan//events/3596.en.html And a patch that I submitted awhile back was brought up. Apparently some of their testing revealed that they were able to force a buffer fragment in e1000 in which the traili

Re: [E1000-devel] [PATCH 0/3] increase skb size to prevent dma over skb boundary

2009-12-24 Thread Neil Horman
On Wed, Dec 23, 2009 at 11:43:40AM -0800, Brandeburg, Jesse wrote: > On Tue, 22 Dec 2009, Brandon Philips wrote: > > On 11:20 Thu 10 Dec 2009, Tantilov, Emil S wrote: > > > >> I am trying to test the patches you submitted (thanks btw) and so > > > >> far am not able to reproduce the panic you descr

Re: [E1000-devel] [PATCH 0/3] increase skb size to prevent dma over skb boundary

2009-12-10 Thread Neil Horman
On Thu, Dec 10, 2009 at 11:20:58AM -0700, Tantilov, Emil S wrote: > Neil Horman wrote: > > On Tue, Dec 08, 2009 at 04:37:39PM -0700, Tantilov, Emil S wrote: > >> Neil Horman wrote: > >>> Hey all- > >>> I was tracking down a memory corruptor lately in wh

Re: [E1000-devel] [PATCH 0/3] increase skb size to prevent dma over skb boundary

2009-12-08 Thread Neil Horman
On Tue, Dec 08, 2009 at 04:37:39PM -0700, Tantilov, Emil S wrote: > Neil Horman wrote: > > Hey all- > > I was tracking down a memory corruptor lately in which, with > > DEBUG_SLAB enabled we were getting several redzone violoations, which > > was always followed b

Re: [E1000-devel] [PATCH 3/3] ixgb: increase skb size to prevent dma over skb boundary

2009-12-07 Thread Neil Horman
On Mon, Dec 07, 2009 at 12:54:40PM -0800, Jeff Kirsher wrote: > On Mon, Dec 7, 2009 at 06:49, Neil Horman wrote: > > Update xgb driver to not allow dma beyond the end of the allocated skb > > > > Signed-off-by: Neil Horman > > > > ixgb_main.c |   13 +

Re: [E1000-devel] [PATCH 2/3] e1000e: increase skb size to prevent dma over skb boundary (v2)

2009-12-07 Thread Neil Horman
Sorry to reply to myself, but given the comments regarding the e1000 driver, I should take the same changes into account here. New version of the patch, much cleaner than previously. Update e1000e driver to not allow dma beyond the end of the allocated sk Signed-off-by: Neil Horman

Re: [E1000-devel] [PATCH 1/3] e1000: increase skb size to prevent dma over skb boundary (v2)

2009-12-07 Thread Neil Horman
On Mon, Dec 07, 2009 at 04:24:02PM +0100, Franco Fichtner wrote: > Hi Neil, > > Neil Horman wrote: >> Update e1000 driver to not allow dma beyond the end of the allocated skb >> Signed-off-by: Neil Horman >> >> >> e1000_main.c | 34 +

Re: [E1000-devel] [PATCH 3/3] ixgb: increase skb size to prevent dma over skb boundary

2009-12-07 Thread Neil Horman
Update xgb driver to not allow dma beyond the end of the allocated skb Signed-off-by: Neil Horman ixgb_main.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c index bcd0f01..2d8e699 100644 --- a

Re: [E1000-devel] [PATCH 2/3] e1000e: increase skb size to prevent dma over skb boundary

2009-12-07 Thread Neil Horman
Update e1000e driver to not allow dma beyond the end of the allocated skb Signed-off-by: Neil Horman netdev.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index c3105c5

Re: [E1000-devel] [PATCH 1/3] e1000: increase skb size to prevent dma over skb boundary

2009-12-07 Thread Neil Horman
Update e1000 driver to not allow dma beyond the end of the allocated skb Signed-off-by: Neil Horman e1000_main.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index

[E1000-devel] [PATCH 0/3] increase skb size to prevent dma over skb boundary

2009-12-07 Thread Neil Horman
tested this on e1000e and confirmed that it fixes my redzone violations and the observed oops. Visual inspection indicates that e1000 and ixgb also need this fix. I've not explicitly tested them though, so I've split this into three separ

Re: [E1000-devel] [PATCH] catch up device stats when multicast > total frames

2008-08-05 Thread Neil Horman
t; --- > "Those who would give up essential Liberty, to purchase a little temporary > Safety, deserve neither Liberty nor Safety.", Benjamin Franklin 1755 > > -Original Message- > From: Neil Horman [mailto:[EMA

Re: [E1000-devel] [PATCH] catch up device stats when multicast >total frames

2008-08-05 Thread Neil Horman
On Tue, Aug 05, 2008 at 09:43:19AM -0700, Brandeburg, Jesse wrote: > Neil Horman wrote: > > On Tue, Aug 05, 2008 at 01:15:29PM +0100, Ben Hutchings wrote: > >>> REcently observed a problem wherein, if a BMC or other IPMI > device > >>> is attached to a NIC,

Re: [E1000-devel] [PATCH] catch up device stats when multicast > total frames

2008-08-05 Thread Neil Horman
On Tue, Aug 05, 2008 at 01:15:29PM +0100, Ben Hutchings wrote: > Neil Horman wrote: > > Hey- > > REcently observed a problem wherein, if a BMC or other IPMI device is > > attached to a NIC, multicast frames can be consumed by the aformentioned > > device > &g

[E1000-devel] [PATCH] catch up device stats when multicast > total frames

2008-08-05 Thread Neil Horman
adapter->total_rx_packets = adapter->net_stats.multicast; adapter->total_rx_bytes += total_rx_bytes; adapter->net_stats.rx_bytes += total_rx_bytes; adapter->net_stats.rx_packets += total_rx_packets; -- /