Re: [E1000-devel] Need Linux Ethernet Driver for Asus B85M-G Motherboard

On Tue, 7 Feb 2017 22:09:24 -0600 Jarod King wrote: > Help please! I need a Linux Ethernet Driver for Asus B85M-G Motherboard. > I've just installed CentOS 7 and the network adapter is not showing up. > Whatever happened to installing Linux and the drivers just working? > > Thanks, > > Jar

Re: [E1000-devel] link detection incorrect on i40e

On Wed, 27 Jul 2016 20:14:26 + "Fujinaka, Todd" wrote: > I've heard that we're looking into this already. I'll see if I can find out > more. My temporary workaround was to always only use port 0 on i40e. -- __

Re: [E1000-devel] link detection incorrect on i40e

I never got a fix -- What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-ve

Re: [E1000-devel] link detection incorrect on i40e

On Tue, 26 Jul 2016 16:55:15 +0200 Wim wrote: > Hi, > > We're using XL710 cards on linux 4.4.15 using the latest driver 1.5.19 and > it seems that link detection isn't working correctly. > > We've got multiple servers with 2 cards, the first port of every card is > put in to a LACP portchannel

Re: [E1000-devel] [PATCH 1/1] ixgbe: add fiber tranceiver plug/unplug notifier

On Tue, 14 Jun 2016 15:20:07 + "Skidmore, Donald C" wrote: > > -Original Message- > > From: zhuyj [mailto:zyjzyj2...@gmail.com] > > Sent: Tuesday, June 14, 2016 6:55 AM > > To: e1000-devel@lists.sourceforge.net; netdev > > Subject: Re: [E1000-devel] [PATCH 1/1] ixgbe: add fiber tranc

Re: [E1000-devel] [Intel-wired-lan] [PATCH 1/1] ixgbe: force to synchronize reporting "link on" and getting speed and duplex

On Wed, 23 Dec 2015 15:59:24 + "Tantilov, Emil S" wrote: > >-Original Message- > >From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > >Behalf Of zyjzyj2...@gmail.com > >Sent: Tuesday, December 22, 2015 10:47 PM > >To: Kirsher, Jeffrey T; Brandeburg, Jesse; Nel

Re: [E1000-devel] [PATCH 56/86] intel/ixgb: use uapi/linux/pci_ids.h directly

Patch was rejected upstream by Greg On Sun, Mar 29, 2015 at 4:55 PM, Jeff Kirsher wrote: > On Sun, 2015-03-29 at 15:41 +0200, Michael S. Tsirkin wrote: > > Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, > > use the new header directly so we can drop > > the wrapper in include/linux/p

Re: [E1000-devel] [PATCH net v3 2/2] e100: Add netif_napi_del in the driver

On Thu, 25 Dec 2014 10:02:36 +0800 Jia-Ju Bai wrote: > The driver lacks netif_napi_del in the normal path and error path to > match the call of netif_napi_add in e100_probe. > This patch fixes this problem, and it has been tested on the hardware. > > Signed-off-by: Jia-Ju Bai > --- > drivers/

Re: [E1000-devel] [PATCH net v3 3/4] e1000e: Add netif_napi_del in the driver

On Thu, 25 Dec 2014 09:57:02 +0800 Jia-Ju Bai wrote: > The driver lacks netif_napi_del in the normal path > and error path to match the call of netif_napi_add in e1000_probe. > This patch fixes this problem, and it has been tested on the hardware. > > Signed-off-by: Jia-Ju Bai Another case whe

Re: [E1000-devel] [PATCH net v3] e1000: Add netif_napi_del in the driver

On Thu, 25 Dec 2014 10:00:27 +0800 Jia-Ju Bai wrote: > The driver lacks netif_napi_del in the normal path > and error path to match the call of netif_napi_add in e1000_probe. > This patch fixes this problem, and it has been tested on the hardware. > > Signed-off-by: Jia-Ju Bai This is unneces

Re: [E1000-devel] [PATCH] net: ethernet: intel: ixgbe: ixgbe_main.c: Cleaning up missing null-terminate in conjunction with strncpy

On Sat, 26 Jul 2014 16:24:36 +0200 Rickard Strandqvist wrote: > Replacing strncpy with strlcpy to avoid strings that lacks null terminate. > > Signed-off-by: Rickard Strandqvist > --- hw->mac.type, hw->phy.type, hw->phy.sfp_type, This patch doesn't change anything. N

Re: [E1000-devel] Check to see if VT-d is enable at runtime?

On Tue, 24 Jun 2014 09:35:10 -0700 Ben Greear wrote: > On 06/23/2014 09:03 PM, Brandeburg, Jesse wrote: > > I always just check for iommu and dmar in dmesg. > > > > You should be able to boot with intel_iommu=off ? > > Is there any difference (or down-side) to doing intel_iommu=off > as oppose

[E1000-devel] Fw: [Bug 77501] New: e1000 - kernel bug after hard unplug of the LAN cable during data transfer

New in kernel bugzilla Begin forwarded message: Date: Sat, 7 Jun 2014 23:57:29 -0700 From: "bugzilla-dae...@bugzilla.kernel.org" To: "step...@networkplumber.org" Subject: [Bug 77501] New: e1000 - kernel bug after hard unplug of the LAN cable during data transfer https://bugzilla.kernel.org/

[E1000-devel] [PATCH net-next] igb: cleanups

This patch is against current version in net-next, some of this may not apply after other patches you have pending. Make local functions static. Delete unused code (igb_get_eee_status_i354, e1000_write_sfp_data_byte) Signed-off-by: Stephen Hemminger --- drivers/net/ethernet/intel/igb

[E1000-devel] [WARNING net-next] from ixgbe_configure

Warning with current net-next from ixgbe_configure calling netdev_all_upper_get_next_dev_rcu without RCU read lock held. [4.717512] r8169 :03:00.0 eth0: link down [4.717581] r8169 :03:00.0 eth0: link down [4.717590] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready [6.72

[E1000-devel] [PATCH net-next] igb: make local functions static and remove dead code

Make local functions static, and remove unused e1000_write_sfp_data_byte. Signed-off-by: Stephen Hemminger --- drivers/net/ethernet/intel/igb/e1000_82575.c |6 +++--- drivers/net/ethernet/intel/igb/e1000_i210.c | 18 +- drivers/net/ethernet/intel/igb/e1000_i210.h |9

[E1000-devel] [PATCH net-next] i40e: make functions static and remove dead code

Make local functions static in the file they are used. Remove functions i40e_aq_add_vlan and i40e_aq_remove_vlan since they are not used anywhere by current code. Compile tested only. Signed-off-by: Stephen Hemminger --- drivers/net/ethernet/intel/i40e/i40e_adminq.c|6 + drivers

Re: [E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel proper

; proper > > > > On Fri, 2013-09-06 at 06:28 +0000, Brandeburg, Jesse wrote: > > > On Sep 5, 2013, at 11:15 PM, "Stephen Hemminger" > > mailto:step...@networkplumber.org>> wrote: > > > > > > Dumb question why is this named Kbuild instead

Re: [E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel proper

On Thu, 5 Sep 2013 23:01:18 -0700 Jeff Kirsher wrote: > diff --git a/drivers/net/ethernet/intel/i40e/Kbuild > b/drivers/net/ethernet/intel/i40e/Kbuild > new file mode 100644 > index 000..479b2c4 Dumb question why is this named Kbuild instead of Makefile like almost every other network driv

[E1000-devel] [PATCH net-next] intel: pci_register_driver tail return

Remove unnecessary assignment, just return result of pci_register_driver Glad to see that Intel does lots of code reuse :-) Signed-off-by: Stephen Hemminger --- drivers/net/ethernet/intel/e1000e/netdev.c|5 + drivers/net/ethernet/intel/igb/igb_main.c |4

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

On Thu, 5 Sep 2013 17:53:38 + "Nelson, Shannon" wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, September 04, 2013 5:38 PM > > [...] > > > Also, anything in sysfs is device

Re: [E1000-devel] [net-next v4 1/7] i40e: main driver core

More review comments, these are non-blocking, and can be fixed later. Minor - * style not a fan of doing own error codes and handling (ie. I40E_SUCCESS) which probably is side effect of OS abstraction. * extra parens aren't needed on return return (budget > 0); * i40e_config_net

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

Has anyone else noticed how big the drivers are getting. Intel e1002275 e1000 11971 e1000e 17502 igb 15720 ixgbe 22451 i40e22603 -- Learn the la

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

I am very busy with work and personal issues. Don't depend on my time. More surprising is that others did not see the same things. Your business is your problem. On Wed, Sep 4, 2013 at 6:25 PM, Nelson, Shannon wrote: >> -Original Message- >> From: Stephen Hemmi

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

I don't think you need this. If you put a NULL pointer in for the __ATTR() then it will do the right thing for you. > +/** > + * i40e_sys_store_ro - callback for readonly attributes in sysfs > + * @kobj: object in the sysfs model > + * @attr: attribute being read > + * @buf: buffer to put data >

Re: [E1000-devel] [PATCH] i40e: Fix 32 bit shift compilation warnings

On Fri, 30 Aug 2013 18:47:35 -0700 Joe Perches wrote: > When dma_addr_t is a 32 bit value, >> 32 emits compiler warnings > Use ((addr>>16) >>16) to avoid this. > > I presume the macro should actually use the kernel.h > macro upper_32_bits() eventually. > > Signed-off-by: Joe Perches > --- > d

Re: [E1000-devel] [net-next v3 1/8] i40e: main driver core

On Fri, 30 Aug 2013 09:32:48 -0700 Joe Perches wrote: > > +static int debug = -1; > > +module_param(debug, int, 0); > > +MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); > > Maybe make debug a bitfield instead? No Joe, this is the standard mapping of debug to msglevel used by most

Re: [E1000-devel] igb: cannot receive packets bigger than mtu

On Mon, 15 Jul 2013 06:24:20 -0700 Ben Greear wrote: > On 07/14/2013 11:43 PM, Jagdish Motwani wrote: > > On 07/13/2013 09:17 PM, Ben Greear wrote: > >> On 07/13/2013 01:29 AM, jagdish.motw...@elitecore.com wrote: > >>> Yes John, > >>> When i do the ping request, i can see the 2 ip fragment

[E1000-devel] lockdep splat from ixgbe on shutdown (3.10)

During shutdown seeing this on console, looks harmless but should be fixed. [ 283.418229] Ebtables v2.0 unregistered [ 285.685042] INFO: trying to register non-static key. [ 285.685078] the code is fine but needs lockdep annotation. [ 285.685105] turning off the locking correctness validator.

Re: [E1000-devel] igb: cannot receive packets bigger than mtu

On Fri, 12 Jul 2013 14:26:32 +0530 Jagdish Motwani wrote: > Hi list, > I am facing a strange issue with igb driver. > > If i set my mtu to 1000, then ping -s 1200 does not work. (the same > thing works with e1000e interface) > > On further debugging, i reached > http://git.kern

Re: [E1000-devel] [net-next 1/8] i40e: main driver core

On Thu, 13 Jun 2013 20:55:15 -0700 Jeff Kirsher wrote: > + > +char i40e_driver_name[] = "i40e"; Obviously const +/* Helper macros for reading the stats registers + * + * Since the device stats are not reset at PFReset, they likely will not + * be zeroed when the driver starts. We'll save the f

Re: [E1000-devel] [net-next 3/8] i40e: driver ethtool core

On Thu, 13 Jun 2013 20:55:17 -0700 Jeff Kirsher wrote: > + > +static int i40e_get_eeprom_len(struct net_device *netdev) > +{ > + return 0; > +} > + > +static int i40e_get_eeprom(struct net_device *netdev, > +struct ethtool_eeprom *eeprom, u8 *bytes) > +{ > + return

Re: [E1000-devel] [net-next 3/8] i40e: driver ethtool core

On Thu, 13 Jun 2013 20:55:17 -0700 Jeff Kirsher wrote: > + > +/** > + * i40e_set_settings - Set Speed and Duplex > + * @netdev: network interface device structure > + * @ecmd: ethtool command > + * > + * Set speed/duplex per media_types advertised/forced > + **/ > +static int i40e_set_settings(st

Re: [E1000-devel] [net-next 3/8] i40e: driver ethtool core

On Thu, 13 Jun 2013 20:55:17 -0700 Jeff Kirsher wrote: > +static const struct i40e_stats i40e_gstrings_net_stats[] = { > + I40E_NETDEV_STAT(rx_packets), > + I40E_NETDEV_STAT(tx_packets), > + I40E_NETDEV_STAT(rx_bytes), > + I40E_NETDEV_STAT(tx_bytes), > + I40E_NETDEV_STAT(rx_er

Re: [E1000-devel] ixgbe: log splat on shutdown

On Tue, 18 Jun 2013 00:16:57 -0700 Peter P Waskiewicz Jr wrote: > Could be this commit (just speculation): > > commit 499ab5ccbd42839f40d5572e7a4799c412986a11 > Author: akepner > Date: Wed Mar 13 14:54:58 2013 + > > ixgbe: in shutdown, do netif_running() under rtnl_lock > > Du

[E1000-devel] ixgbe: log splat on shutdown

I am seeing this error on shutdown with 3.10 and net-next (on Debian 7.0) Looks like a problem with lockdep seeing issues with canceling work in ixgbe with rtnl held? Not a bit issue, shutdown still works and no real big issue. [ 310.416382] INFO: trying to register non-static key. [ 310.417499

Re: [E1000-devel] [PATCH net-next 1/2] net: remove NET_LL_RX_POLL config menue

On Wed, 12 Jun 2013 15:12:05 -0700 (PDT) David Miller wrote: > From: Eliezer Tamir > Date: Tue, 11 Jun 2013 17:24:28 +0300 > > > depends on X86_TSC > > Wait a second, I didn't notice this before. There needs to be a better > way to test for the accuracy you need, or if the issue is lack o

Re: [E1000-devel] Multiple ports in e1000 NIC

On Fri, 24 May 2013 11:41:22 + (UTC) JelS wrote: > Hello, > > I have to modify e1000 driver to have N ethernet interface (N net_devices > structs) to be visible in kernel, but all of them should send and receive > data through only one NIC with one port. All of that N interfaces should to

Re: [E1000-devel] getting VF link info seems to be broken in 3.9-rc8

On Thu, 25 Apr 2013 13:36:06 -0700 Alexander Duyck wrote: > On 04/25/2013 01:25 PM, David Miller wrote: > > From: Alexander Duyck > > Date: Thu, 25 Apr 2013 13:20:24 -0700 > > > >> On 04/25/2013 12:24 PM, David Miller wrote: > >>> From: Alexander Duyck > >>> Date: Thu, 25 Apr 2013 11:29:04 -070

[E1000-devel] Fw: [Bug 56611] New: Ethernet not working with ac adapter on lenovo t530

Begin forwarded message: Date: Sun, 14 Apr 2013 22:52:37 -0700 From: "bugzilla-dae...@bugzilla.kernel.org" To: "step...@networkplumber.org" Subject: [Bug 56611] New: Ethernet not working with ac adapter on lenovo t530 https://bugzilla.kernel.org/show_bug.cgi?id=56611 Summary: Et

Re: [E1000-devel] Low receive performance with multiple RSS queue

On Mon, 25 Mar 2013 01:40:58 -0700 "Waskiewicz Jr, Peter P" wrote: > Linux does not have the same concept that Windows has with TSS/RSS, > where the RSS table is re-adjusted on the fly to follow a network flow > to another queue. So if your test is transmitting on CPU core 0, RSS > may return

[E1000-devel] [PATCH] igb: make sensor info static

Trivial sparse warning. Signed-off-by: Stephen Hemminger --- a/drivers/net/ethernet/intel/igb/igb_hwmon.c2013-03-14 14:22:58.135958283 -0700 +++ b/drivers/net/ethernet/intel/igb/igb_hwmon.c2013-03-16 09:44:46.455461525 -0700 @@ -39,7 +39,7 @@ #include #ifdef

Re: [E1000-devel] [RFC PATCH 0/5] net: low latency Ethernet device polling

On Wed, 27 Feb 2013 09:55:49 -0800 Eliezer Tamir wrote: > This patchset adds the ability for the socket layer code to poll directly > on an Ethernet device's RX queue. This eliminates the cost of the interrupt > and context switch and with proper tuning allows us to get very close > to the HW la

Re: [E1000-devel] [RFC PATCH 0/5] net: low latency Ethernet device polling

Have you looked at netmap? Seems like a cleaner user API for this. There is a version for Linux, but it needs work. My plan is to send it staging (after merge window reopens). -- Everyone hates slow websites. So do we. Ma

Re: [E1000-devel] Tool for testing packets per second (PPS)

On Wed, 20 Feb 2013 01:23:33 -0500 (EST) Drew Smith wrote: > Is there a good tool for testing packets per second (PPS) of an interface? My > test app starts showing dropped packets at 75k UDP PPS in each direction > (1500 concurrent g711 VOIP calls). I would assume the Intel i350 NIC could > s

Re: [E1000-devel] IXGBE throughput issue with packet size more than 256 bytes

On Wed, 16 Jan 2013 14:01:26 + Mritunjay Kumar wrote: > Hi All, > > We are trying to measure throughput of IXGBE(82599 10G controller) driver for > different packet size. We are enabling bridging between two 10G ports and > pumping traffic. > We are seeing following:- > > 1. For pac

[E1000-devel] [PATCH net-next] igb: make local functions static

Minor, a couple of functions had static prototypes but not actually declared static. Signed-off-by: Stephen Hemminger --- a/drivers/net/ethernet/intel/igb/e1000_82575.c 2012-10-25 09:11:13.863290240 -0700 +++ b/drivers/net/ethernet/intel/igb/e1000_82575.c 2012-10-29 11:28

Re: [E1000-devel] X540 SR-IOV question

On Thu, 23 Aug 2012 18:42:22 -0700 Alexander Duyck wrote: > On Thu, Aug 23, 2012 at 4:29 PM, Stephen Hemminger > wrote: > > Trying to setup new X540 card I have is not allowing VF's to be setup. > > > > [ 11.481677] ixgbe: Intel(R) 10 Gigabit PCI Express Network D

[E1000-devel] X540 SR-IOV question

Trying to setup new X540 card I have is not allowing VF's to be setup. [ 11.481677] ixgbe: Intel(R) 10 Gigabit PCI Express Network Driver - version 3.8.21-k [ 11.481679] ixgbe: Copyright (c) 1999-2012 Intel Corporation. [ 11.836095] ixgbe :01:00.0: pci SR-IOV: not physical [ 11.836101

Re: [E1000-devel] Disable NAPI

On Tue, 24 Jul 2012 19:16:43 +0200 Sandy Herman wrote: > Hello, > > I have a 8 core x86_64 machine that has 2 Intel 82574L NICs using > the e1000 driver. > > Problem: > During a spoofed SYN flooding attack (800 Mbits, ~300K packets/sec) > the ksoftirqd became the bottleneck of the system. The d

Re: [E1000-devel] Need helps about to limit the number of cores ixgbe driver uses.

On Fri, 29 Jun 2012 08:44:52 +0800 Junchang Wang wrote: > > > > > > > > > > > I encountered a similar problem, and we got a significant performance > > boost > > > after limiting the number of queues from 64 to 8. (The sever is equipped > > > with 80 cores.) > > > > > > I'm very curious about wha

Re: [E1000-devel] Need helps about to limit the number of cores ixgbe driver uses.

On Thu, 28 Jun 2012 20:00:55 +0800 Junchang Wang wrote: > Hi Emil and list, > > > > > > > >I asked Luigi Rizzo for help, whom is the author of netmap, told me > > >that I have too many cores in the machine and it should work if I tell > > >ixgbe use less cores (2 to 4 is ok). > > > > You can li

[E1000-devel] [PATCH net-next] ixgbe: simplify padding and length checks (v2)

The check for length <= 0 is bogus because length is unsigned, and network stack never sends zero length packets (unless it is totally broken). The check for really small packets can be optimized (using unlikely) and calling skb_pad directly. Signed-off-by: Stephen Hemminger --- a/drivers/

[E1000-devel] [PATCH 2/2 net-next] ixgbe: remove xmit length check

The check here is bogus. Since len is unsigned, it can never be negative. And it would be a bug in network stack to ever send a zero length packet to device. Signed-off-by: Stephen Hemminger --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c 2012-06-18 10:53:13.742310994 -0700 +++ b

[E1000-devel] [PATCH 1/2 net-next] ixgbe: use skb_padto

The code to pad packets here is the same effective code as the existing inline function skb_padto(). There is a minor performance gain since skb_padto() also uses unlikely(). Signed-off-by: Stephen Hemminger --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c 2012-06-18 10:53:09.130376800

Re: [E1000-devel] Strange latency spikes/TX network stalls on Sun Fire X4150(x86) and e1000e

On Wed, 06 Jun 2012 11:23:32 -0700 (PDT) David Miller wrote: > From: Tom Herbert > Date: Wed, 6 Jun 2012 11:21:40 -0700 > > > I'm not exactly sure what the exact effect of WTHRESH is here. Does > > the device coalesce 5 completions regardless of size? Would the > > problem be avoided if bql l

Re: [E1000-devel] [Bug 43277] New: net/e1000e set mtu larger than 1500 fails

On Tue, 22 May 2012 19:59:16 +0100 Ben Hutchings wrote: > On Tue, 2012-05-22 at 20:39 +0200, Christer Ekholm wrote: > > Stephen Hemminger writes: > > > On Tue, 22 May 2012 11:19:50 -0700 > > > Stephen Hemminger wrote: > > > > > > > > >

[E1000-devel] Fw: [Bug 43277] New: net/e1000e set mtu larger than 1500 fails

Begin forwarded message: Date: Tue, 22 May 2012 18:13:21 + (UTC) From: bugzilla-dae...@bugzilla.kernel.org To: shemmin...@linux-foundation.org Subject: [Bug 43277] New: net/e1000e set mtu larger than 1500 fails https://bugzilla.kernel.org/show_bug.cgi?id=43277 Summary: net/e100

Re: [E1000-devel] [Bug 43277] New: net/e1000e set mtu larger than 1500 fails

On Tue, 22 May 2012 11:19:50 -0700 Stephen Hemminger wrote: > > > Begin forwarded message: > > Date: Tue, 22 May 2012 18:13:21 + (UTC) > From: bugzilla-dae...@bugzilla.kernel.org > To: shemmin...@linux-foundation.org > Subject: [Bug 43277] New: net/e1000e set mt

Re: [E1000-devel] [PATCH] intel: make wired ethernet driver message level consistent

On Sun, 11 Mar 2012 00:38:57 + Ben Hutchings wrote: > On Sat, 2012-03-10 at 16:01 -0800, Stephen Hemminger wrote: > > Dan Carpenter noticed that ixgbevf initial default was different than > > the rest. But the problem is broader than that, only one Intel driver (ixgb) > &g

[E1000-devel] [PATCH] intel: make wired ethernet driver message level consistent

only. Signed-off-by: Stephen Hemminger --- Supersedes patch from Dan Carpenter drivers/net/ethernet/intel/e1000/e1000_main.c |5 +++-- drivers/net/ethernet/intel/e1000e/netdev.c|7 ++- drivers/net/ethernet/intel/igb/igb_main.c |7 ++- drivers/net

[E1000-devel] [PATCH 3/6] igbvf: remove unneeeded cast

The cast and comment are unnecessary in the current upstream kernel. Signed-off-by: Stephen Hemminger --- drivers/net/ethernet/intel/igbvf/ethtool.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/ethernet/intel/igbvf/ethtool.c2011-12-07 10:54

[E1000-devel] [PATCH 0/6] Intel wired driver trivial patches

These fix sparse warnings and make things const. Should have no effect on code. -- Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex infrastructure or vast IT resources to deliver seamless, secure

[E1000-devel] [PATCH 4/6] igb: make local functions static

Sparse caught two functions that were only being used in one file. Signed-off-by: Stephen Hemminger --- drivers/net/ethernet/intel/igb/e1000_mac.c |2 +- drivers/net/ethernet/intel/igb/igb_main.c |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) --- a/drivers/net/ethernet

[E1000-devel] [PATCH 6/6] ixgbevf: make operations tables const

The arrays of function pointers should be const to make life harder for rootkits. Signed-off-by: Stephen Hemminger --- drivers/net/ethernet/intel/ixgbevf/ixgbevf.h |8 drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c |2 +- drivers/net/ethernet/intel/ixgbevf/vf.c

[E1000-devel] [PATCH 5/6] ixgbevf: fix sparse warnings

drivers/net/ethernet/intel/ixgbevf/mbx.c:331:29: warning: symbol 'ixgbevf_mbx_ops' was not declared. Should it be static? Signed-off-by: Stephen Hemminger --- drivers/net/ethernet/intel/ixgbevf/mbx.c |3 ++- drivers/net/ethernet/intel/ixgbevf/vf.c |1 + 2 files change

[E1000-devel] [PATCH 1/6] ixgbe: make ethtool strings table const

Signed-off-by: Stephen Hemminger --- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c 2012-01-03 09:59:58.586742225 -0800 +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c

[E1000-devel] [PATCH 2/6] ixgbevf: make ethtool ops and strings const

Signed-off-by: Stephen Hemminger --- drivers/net/ethernet/intel/ixgbevf/ethtool.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/net/ethernet/intel/ixgbevf/ethtool.c 2011-12-07 10:54:18.812279127 -0800 +++ b/drivers/net/ethernet/intel/ixgbevf/ethtool.c

[E1000-devel] e100e: does it do unicast filtering?

Looks like most of the other Intel drivers set the UNICAST filter flag. Why not e1000e? Looks like the same setup code from e1000 would work on e1000e? -- RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.s

Re: [E1000-devel] igb driver throughput on Intel E31320 vs Intel X3450

On Fri, 29 Apr 2011 01:18:05 -0400 Ed Ravin wrote: > I'm comparing the performance of the Vyatta 6.2 distribution > (Linux 2.6.35-1, 32-bit) on an Intel E31320 box (Supermicro X9SCL) > and on an older Supermicro motherboard with a X3450 CPU. > > Both boxes have a 2-port 82576 card installed ("In

Re: [E1000-devel] BUG in skb_pull with e1000e, PPTP, and L2TP

On Mon, 17 Oct 2011 17:19:53 -0500 Bradley Peterson wrote: > using 3rd > party pptp and l2tp modules.  More than likely your 3rd party modules are buggy and can't handle all the possible types of skb layout. I have seen out of tree code that can't handle non-linear skb's. You need to take it u

[E1000-devel] Fw: [Bug 39742] New: 2.6.39.3 crash and hangs in 1-2 minutes with igb-RSS and L2TP PPTP services on the NAS server

Begin forwarded message: Date: Fri, 22 Jul 2011 10:32:46 GMT From: bugzilla-dae...@bugzilla.kernel.org To: shemmin...@linux-foundation.org Subject: [Bug 39742] New: 2.6.39.3 crash and hangs in 1-2 minutes with igb-RSS and L2TP PPTP services on the NAS server https://bugzilla.kernel.org/show_b

Re: [E1000-devel] Static IP lost every few minutes with e1000e 1.3.17 on ubuntu 10.04

On Tue, 28 Jun 2011 12:58:33 +0300 Adam Katz wrote: > Hi Everyone > > I'm using e1000e 1.3.17 on two ubuntu 10.04 boxes, one 64 bit, the other 32. > both with 2.6.32-32-generic. The boxes are completely different machines > with different hardware but both with an intel e1000e nic. > > The issu

[E1000-devel] [PATCH] ixgbevf: remove unnecessary ampersands

Use standard format for net_device_ops (without &) Signed-off-by: Stephen Hemminger --- a/drivers/net/ixgbevf/ixgbevf_main.c2011-06-08 11:02:37.0 -0700 +++ b/drivers/net/ixgbevf/ixgbevf_main.c2011-06-08 11:06:23.278233318 -0700 @@ -3249,18 +3249,18 @@ static

Re: [E1000-devel] transmit hang under load 82574L

On Sat, 19 Mar 2011 10:50:24 + Nix wrote: > On 17 Mar 2011, Bruce W. Allan said: > > OK, it looks like you are hitting the same issue described in > > > > > > > > where ASPM L0s is supposed to be disabled on

[E1000-devel] transmit hang under load 82574L

Running Intel n450 development board as a network based backup server, I saw the following transmit lockup under load (SMB backup). Kernel is 2.6.37.4. Device did not recover, required a power cycle to get back online. $ /sbin/ethtool -i eth0 driver: e1000e version: 1.2.7-k2 firmware-version: 2.1

[E1000-devel] [PATCH] e1000: fix sparse warning

Sparse complains because the e1000 driver is calling ioread on a pointer not tagged as __iomem. Signed-off-by: Stephen Hemminger --- a/drivers/net/e1000/e1000_osdep.h 2011-02-23 10:00:31.496097384 -0800 +++ b/drivers/net/e1000/e1000_osdep.h 2011-02-23 10:00:47.740287665 -0800 @@ -42,7 +42,8

Re: [E1000-devel] [PATCH 3/3] net: Fix drivers advertising HW_CSUM feature to use csum_start

On Wed, 15 Dec 2010 19:16:55 +0100 Michał Mirosław wrote: > On Tue, Dec 14, 2010 at 07:07:27PM -0800, Stephen Hemminger wrote: > > On Wed, 15 Dec 2010 02:24:08 +0100 (CET) > > Michał Mirosław wrote: > > > Some drivers are using skb_transport_offset(skb) instead o

Re: [E1000-devel] [PATCH 3/3] net: Fix drivers advertising HW_CSUM feature to use csum_start

On Wed, 15 Dec 2010 02:24:08 +0100 (CET) Michał Mirosław wrote: > Some drivers are using skb_transport_offset(skb) instead of skb->csum_start > for NETIF_F_HW_CSUM offload. This does not matter now, but if someone > implements checksumming of encapsulated packets then this will break silently. >

Re: [E1000-devel] [PATCH 0/7] e1000e: cleanup

On Thu, 9 Dec 2010 02:40:50 + Asbjoern Sloth Toennesen wrote: > Hi, > > This patchset fixes most checkstyle problems in e1000e. > > Checkpatch summary: > pre: total: 221 errors, 129 warnings, 24520 lines checked > post: total: 2 errors, 34 warnings,24533 lines checked I

Re: [E1000-devel] e1000/e1000e wrong tx bytes counting

On Mon, 22 Nov 2010 18:48:35 -0200 Flavio Leitner wrote: > On Wed, Nov 10, 2010 at 09:17:20AM -0800, Alexander Duyck wrote: > > On 11/10/2010 9:09 AM, Alexander Duyck wrote: > > >On 11/10/2010 8:54 AM, Stephen Hemminger wrote: > > >>On Wed, 10 Nov 2010 14:33:01 -020

Re: [E1000-devel] e1000/e1000e wrong tx bytes counting

On Wed, 10 Nov 2010 14:33:01 -0200 Flavio Leitner wrote: > On Wed, Nov 10, 2010 at 07:58:55AM -0800, Stephen Hemminger wrote: > > On Wed, 10 Nov 2010 10:56:38 -0200 > > Flavio Leitner wrote: > > > > > > > > Hello, > > > > > > The drive

Re: [E1000-devel] e1000/e1000e wrong tx bytes counting

On Wed, 10 Nov 2010 10:56:38 -0200 Flavio Leitner wrote: > > Hello, > > The driver is calculating the amount of bytes transmitted assuming > the way TCP builds GSO packets which are non-linear. Therefore, > skb_headlen() returns the correct size of the header and the > math is correct. > > How

[E1000-devel] [PATCH 12/12] e1000: make e1000_reinit_safe local

Signed-off-by: Stephen Hemminger --- a/drivers/net/e1000/e1000_main.c2010-10-21 09:35:54.643519367 -0700 +++ b/drivers/net/e1000/e1000_main.c2010-10-21 09:36:01.380214771 -0700 @@ -521,7 +521,7 @@ void e1000_down(struct e1000_adapter *ad e1000_clean_all_rx_rings(adapter

Re: [E1000-devel] [RFC PATCH net-next] drivers/net Documentation/networking: Create directory intel_wired_lan

On Sun, 10 Oct 2010 13:42:32 -0700 Joe Perches wrote: > Perhaps it's better to move drivers from the very populated > drivers/net directory into vendor specific directories similar > to the Atheros approach used for drivers/net/wireless/ath/ > > Move intel drivers and Documentation to separate d

[E1000-devel] Ixgbe driver: routines that could/should be declared static

I got the kernel namespace checker script working again. It showed the following routines are only used in one file, and could be declared static which is better practice and allows gcc to optimize better. drivers/net/ixgbe/ixgbe_82599 ixgbe_atr_get_dst_ipv6_82599 ixgbe_atr_get_vm_pool_8

Re: [E1000-devel] [PATCH] net: enable GRO by default for vlan devices

On Wed, 15 Sep 2010 22:51:46 -0700 (PDT) David Miller wrote: > From: Stephen Hemminger > Date: Wed, 15 Sep 2010 18:16:16 -0700 > > > On Thu, 16 Sep 2010 00:28:11 +0200 > > Eric Dumazet wrote: > > > >> BTW, we have a similar problem for bonding ( GRO i

Re: [E1000-devel] [PATCH] net: enable GRO by default for vlan devices

On Thu, 16 Sep 2010 00:28:11 +0200 Eric Dumazet wrote: > Le jeudi 16 septembre 2010 à 00:03 +0200, Eric Dumazet a écrit : > > Le mercredi 15 septembre 2010 à 12:24 -0700, Brandon Philips a écrit : > > > Currently vlan devices don't have GRO by default as none of the Ethernet > > > drivers add NET

Re: [E1000-devel] 5% dropped packets under high load with e1000e

On Mon, 09 Aug 2010 13:23:29 +0100 Gavin Hamill wrote: > Hi all, > > I'm running Debian Lenny 64-bit (kernel 2.6.26, e1000e version > 0.3.3.3-k2) on a couple of routers which are dropping an alarming number > of packets, and wondered if I could consult the list about it? > > The machines are go

Re: [E1000-devel] igbvf doesn't support promiscuous mode?

On Thu, 5 Aug 2010 15:04:14 -0700 "Ronciak, John" wrote: > Sorry, typo in the message. Should be: > So the long story short is that we will _not_ be considering adding support > for this due to the security risks that this would enable. I hope you > can see the issues involved for us. I don't

[E1000-devel] [PATCH] ixgbe - use likely() macro

There are a couple places in the receive path where it is worth being sure compiler does the right thing. Signed-off-by: Stephen Hemminger --- Patch against version in net-next-2.6 --- a/drivers/net/ixgbe/ixgbe_main.c2010-07-12 15:52:37.236751171 -0700 +++ b/drivers/net/ixgbe/ixgbe_main.c

[E1000-devel] [PATCH] igbvf: make update_mc_addr_list_vf static

This fixes a trivial sparse warning. Signed-off-by: Stephen Hemminger --- a/drivers/net/igbvf/vf.c2010-06-01 08:53:18.179741333 -0700 +++ b/drivers/net/igbvf/vf.c2010-06-01 08:53:46.579740729 -0700 @@ -220,9 +220,9 @@ static u32 e1000_hash_mc_addr_vf(struct * The parameter

Re: [E1000-devel] BUG: using smp_processor_id() in preemptible[00000000] code: arping/9681

On Tue, 20 Apr 2010 12:19:43 +0800 wrote: > Checking https://bugzilla.kernel.org/show_bug.cgi?id=12518 This problem > seems have been submitted as a bug of preempt kernel debugging function > of debug_smp_processor_id() in kernel 2.6.28/29. A patch will fix the > issue > That is the wrong way

Re: [E1000-devel] recent e100 fixes cause kernel panic?

On Fri, 19 Mar 2010 12:42:20 -0700 Jesse Brandeburg wrote: > Added netdev, the place to talk about in-kernel driver problems. > > On Thu, 2010-03-11 at 22:39 -0700, Stephen Hemminger wrote: > > - "Ed Ravin" wrote: > > > > > I'm using the

Re: [E1000-devel] recent e100 fixes cause kernel panic?

- "Ed Ravin" wrote: > I'm using the Vyatta "kenwood" Linux distribution, which is currently > at 2.6.31-1. I upgraded to their latest version, and began seeing > kernel > panics shortly after starting to use ssh/scp on the network connected > to > an e100 NIC. I was able to reproduce the p

Re: [E1000-devel] Question regarding igb and Fair Queueing / QoS

On Wed, 03 Feb 2010 22:10:41 +0200 "Покотиленко Костик" wrote: > How it comes? I see input traffic goes across 4 rx queues each using > its core on my system here. > > Output here mostly sent to one tx queue. > > > At least with transmit Qos, the single threading happens after the "heavy > >

Re: [E1000-devel] Question regarding igb and Fair Queueing / QoS

On Wed, 03 Feb 2010 11:03:18 +0200 Покотиленко Костик wrote: > В Вто, 02/02/2010 в 12:29 -0800, Waskiewicz Jr, Peter P пишет: > > On Tue, 2 Feb 2010, Brandeburg, Jesse wrote: > > > > > > > > > > > On Tue, 2 Feb 2010, Stephen Hemminger wrote: > &g

Re: [E1000-devel] Question regarding igb and Fair Queueing / QoS

On Tue, 02 Feb 2010 20:43:30 +0300 Oleg A. Arkhangelsky wrote: > 02.02.10, 08:23, "Stephen Hemminger" : > > > On Tue, 2 Feb 2010 13:19:30 + > > amnon cohen wrote: > > > > > QoS adds an extra layer of queuing to the tx path. > > >

Re: [E1000-devel] Question regarding igb and Fair Queueing / QoS

On Tue, 2 Feb 2010 13:19:30 + amnon cohen wrote: > QoS adds an extra layer of queuing to the tx path. > If you don't need QoS, turning it off will decrease transmit latency. > Also QoS requires additional overhead (has to make bandwidth decision across multiple queues). Without QoS the driv

Re: [E1000-devel] [PATCH] e1000: the power down when running ifdown command

On Wed, 04 Nov 2009 19:23:43 +0900 Naohiro Ooiwa wrote: > Naohiro Ooiwa wrote: > > Stephen Hemminger wrote: > >> On Sat, 31 Oct 2009 18:39:52 +0900 > >> Naohiro Ooiwa wrote: > >> > >> Does this work with Wake On Lan? > > > > Yes, it w

  1   2   >