I forgot to copy this to e1000-devel when I posted it to netdev.
Mike Mason
-------- Original Message --------
Subject: [PATCH] e1000e: io_error_detected callback should return
PCI_ERS_RESULT_DISCONNECT on permanent failure
Date: Fri, 29 May 2009 14:16:40 -0700
From: Mike Mason <mm...@us.ibm.com>
To: net...@vger.kernel.org
PCI drivers that implement the io_error_detected callback
should return PCI_ERS_RESULT_DISCONNECT if the state
passed in is pci_channel_io_perm_failure. This state is
not checked in many of the network drivers.
This patch fixes the omission in the e1000e driver.
Signed-off-by: Mike Mason <mm...@us.ibm.com>
--- a/drivers/net/e1000e/netdev.c 2009-05-23 14:47:00.000000000 -0700
+++ b/drivers/net/e1000e/netdev.c 2009-05-29 13:43:24.000000000 -0700
@@ -4616,6 +4616,9 @@ static pci_ers_result_t e1000_io_error_d
netif_device_detach(netdev);
+ if (state == pci_channel_io_perm_failure)
+ return PCI_ERS_RESULT_DISCONNECT;
+
if (netif_running(netdev))
e1000e_down(adapter);
pci_disable_device(pdev);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises
looking to deploy the next generation of Solaris that includes the latest
innovations from Sun and the OpenSource community. Download a copy and
enjoy capabilities such as Networking, Storage and Virtualization.
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
