Re: [E1000-devel] [PATCH] e100 in linux-3.18.0: some potential bugs

2014-12-20 Thread David Miller
Your patch submissions are not usable by us. Instead of immediately sending your patch 10 seconds after you receive feedback, take your time and make sure you do everything calmly and cleanly and as tidy as possible. There is absolutely no rush with these changes. --

Re: [E1000-devel] [PATCH] e100 in linux-3.18.0: some potential bugs

2014-12-20 Thread Sergei Shtylyov
On 12/20/2014 5:32 PM, Jia-Ju Bai wrote: > I am inexperienced in submitting patches, sorry. I see. It looks like you're failing to understand my English, too. :-( Please put such remarks under the --- line which should be placed after sign-off area. > I have revised my patch: You s

Re: [E1000-devel] [PATCH] e100 in linux-3.18.0: some potential bugs

2014-12-20 Thread Jia-Ju Bai
I am inexperienced in submitting patches, sorry. I have revised my patch: 1.Check whether pci_pool_create is failed in e100_probe to avoid null dereference in pci_pool_alloc(in e100_alloc_cbs). 2.Add netif_napi_del to match the call of netif_napi_add. Signed-off-by: Jia-Ju Bai diff --git a/driver

Re: [E1000-devel] [PATCH]e100 in linux-3.18.0: some potential bugs

2014-12-20 Thread Sergei Shtylyov
Hello. On 12/20/2014 10:40 AM, Jia-Ju Bai wrote: > I have actually tested e100 driver on the real hardware(Intel 82559 PCI > Ethernet Controller), and find some bugs: > The target file is drivers/net/ethernet/intel/e100.c, which is used to build > e100.ko. > (1) The function pci_pool_create is c

Re: [E1000-devel] [PATCH]e100 in linux-3.18.0: some potential bugs

2014-12-20 Thread Sergei Shtylyov
On 12/20/2014 10:40 AM, Jia-Ju Bai wrote: > I have actually tested e100 driver on the real hardware(Intel 82559 PCI > Ethernet Controller), and find some bugs: > The target file is drivers/net/ethernet/intel/e100.c, which is used to build > e100.ko. > (1) The function pci_pool_create is called by

[E1000-devel] [PATCH]e100 in linux-3.18.0: some potential bugs

2014-12-20 Thread Jia-Ju Bai
I have actually tested e100 driver on the real hardware(Intel 82559 PCI Ethernet Controller), and find some bugs: The target file is drivers/net/ethernet/intel/e100.c, which is used to build e100.ko. (1) The function pci_pool_create is called by e100_probe when initializing the ethernet card drive