Re: [E1000-devel] [PATCH] e1000: the power down when running ifdown command

2009-11-04 Thread Allan, Bruce W
; da...@davemloft.net >Subject: Re: [E1000-devel] [PATCH] e1000: the power down when running >ifdown command > >On Wed, 04 Nov 2009 19:23:43 +0900 >Naohiro Ooiwa wrote: > >> Naohiro Ooiwa wrote: >> > Stephen Hemminger wrote: >> >> On Sat, 31 Oct 2009 18:39:52

Re: [E1000-devel] [PATCH] e1000: the power down when running ifdown command

2009-11-04 Thread Stephen Hemminger
On Wed, 04 Nov 2009 19:23:43 +0900 Naohiro Ooiwa wrote: > Naohiro Ooiwa wrote: > > Stephen Hemminger wrote: > >> On Sat, 31 Oct 2009 18:39:52 +0900 > >> Naohiro Ooiwa wrote: > >> > >> Does this work with Wake On Lan? > > > > Yes, it works WOL. > > Sorry, I made a mistake. > The WOL doesn't wo

Re: [E1000-devel] [PATCH] e1000: the power down when running ifdown command

2009-11-04 Thread Naohiro Ooiwa
Jeff Kirsher wrote: > 2009/11/3 Naohiro Ooiwa : >> Jeff Kirsher wrote: >>> 2009/10/31 Naohiro Ooiwa : >>> >>> I have added this patch to my tree for testing. This patch requires a >>> fair amount of regression testing, so once its passed testing I will >>> push the patch to David/netdev. >> I appr

Re: [E1000-devel] [PATCH] e1000: the power down when running ifdown command

2009-11-04 Thread Naohiro Ooiwa
Naohiro Ooiwa wrote: > Stephen Hemminger wrote: >> On Sat, 31 Oct 2009 18:39:52 +0900 >> Naohiro Ooiwa wrote: >> >> Does this work with Wake On Lan? > > Yes, it works WOL. Sorry, I made a mistake. The WOL doesn't work when my patch applied to kernel. I wasn't myself. I consider the WOL and I w

Re: [E1000-devel] [PATCH] e1000: the power down when running ifdown command

2009-11-03 Thread Jeff Kirsher
2009/11/3 Naohiro Ooiwa : > Jeff Kirsher wrote: >> 2009/10/31 Naohiro Ooiwa : >> >> I have added this patch to my tree for testing.  This patch requires a >> fair amount of regression testing, so once its passed testing I will >> push the patch to David/netdev. > > I appreciate the marge your tree.

Re: [E1000-devel] [PATCH] e1000: the power down when running ifdown command

2009-11-03 Thread Naohiro Ooiwa
Jeff Kirsher wrote: > 2009/10/31 Naohiro Ooiwa : > > I have added this patch to my tree for testing. This patch requires a > fair amount of regression testing, so once its passed testing I will > push the patch to David/netdev. I appreciate the marge your tree. If there is anything I can do, ple

Re: [E1000-devel] [PATCH] e1000: the power down when running ifdown command

2009-11-02 Thread Dan Williams
On Mon, 2009-11-02 at 16:26 -0800, Jeff Kirsher wrote: > 2009/10/31 Naohiro Ooiwa : > > Hi All > > > > I resend my patch. > > Sorry, my previous mail lacked an explanation. > > > > > > The e1000 driver doesn't let the power down when running ifdown command. > > So, I set to the D3hot state of a PCI

Re: [E1000-devel] [PATCH] e1000: the power down when running ifdown command

2009-11-02 Thread Jeff Kirsher
2009/10/31 Naohiro Ooiwa : > Hi All > > I resend my patch. > Sorry, my previous mail lacked an explanation. > > > The e1000 driver doesn't let the power down when running ifdown command. > So, I set to the D3hot state of a PCI device at the end of e1000_close(). > > With this modification, e1000 dr

Re: [E1000-devel] [PATCH] e1000: the power down when running ifdown command

2009-11-01 Thread Naohiro Ooiwa
Stephen Hemminger wrote: > On Sat, 31 Oct 2009 18:39:52 +0900 > Naohiro Ooiwa wrote: > >> Hi All >> >> I resend my patch. >> Sorry, my previous mail lacked an explanation. >> >> >> The e1000 driver doesn't let the power down when running ifdown command. >> So, I set to the D3hot state of a PCI de

Re: [E1000-devel] [PATCH] e1000: the power down when running ifdown command

2009-10-31 Thread Stephen Hemminger
On Sat, 31 Oct 2009 18:39:52 +0900 Naohiro Ooiwa wrote: > Hi All > > I resend my patch. > Sorry, my previous mail lacked an explanation. > > > The e1000 driver doesn't let the power down when running ifdown command. > So, I set to the D3hot state of a PCI device at the end of e1000_close(). >

[E1000-devel] [PATCH] e1000: the power down when running ifdown command

2009-10-31 Thread Naohiro Ooiwa
Hi All I resend my patch. Sorry, my previous mail lacked an explanation. The e1000 driver doesn't let the power down when running ifdown command. So, I set to the D3hot state of a PCI device at the end of e1000_close(). With this modification, e1000 driver reduces power by ifdown. It's about 6

[E1000-devel] [PATCH] e1000: the power down when running ifdown command

2009-10-23 Thread Naohiro Ooiwa
I resend the mail to maintainers of the e1000 driver. and Andrew CC-ed. Original Message Hi all I'm trying to modify e1000 driver for power saving. The e1000 driver doesn't let the power down when running ifdown command. So, I set to the D3hot state of a PCI device at the end

[E1000-devel] [PATCH] e1000: the power down when running ifdown command

2009-10-21 Thread Naohiro Ooiwa
Hi all I'm trying to modify e1000 driver for power saving. The e1000 driver doesn't let the power down when running ifdown command. So, I set to the D3hot state of a PCI device at the end of e1000_close(). With this modification, e1000 driver reduces power by ifdown to the same level as link-dow