Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

2015-02-09 Thread Bjørn Mork
Jeff Kirsher jeffrey.t.kirs...@intel.com writes: If you want to see Nick's patch, feel free to view his patch on my queue tree: https://git.kernel.org/cgit/linux/kernel/git/jkirsher/queue.git/ which said: - s32 i = 0, timeout = 200; /* FIXME: find real value to use here */ + s32 i = 0,

Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

2015-02-09 Thread Jeff Kirsher
On Mon, 2015-02-09 at 10:29 +0100, Bjørn Mork wrote: Jeff Kirsher jeffrey.t.kirs...@intel.com writes: If you want to see Nick's patch, feel free to view his patch on my queue tree: https://git.kernel.org/cgit/linux/kernel/git/jkirsher/queue.git/ which said: - s32 i = 0, timeout =

Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

2015-02-09 Thread Hisashi T Fujinaka
On Mon, 9 Feb 2015, Bj?rn Mork wrote: Jeff Kirsher jeffrey.t.kirs...@intel.com writes: If you want to see Nick's patch, feel free to view his patch on my queue tree: https://git.kernel.org/cgit/linux/kernel/git/jkirsher/queue.git/ which said: - s32 i = 0, timeout = 200; /* FIXME: find

Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

2015-02-09 Thread Jeff Kirsher
On Mon, 2015-02-09 at 02:17 -0500, Andrej Manduch wrote: Hi, Can you please leave full patch with git diff when you're replying to Nicks e-mails? Nick is banned in *@vger.kernel.org so we cannot see his patches and rest of the world is seeing only replyies to his e-mail. And it's really

Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

2015-02-09 Thread Nick Krause
On Mon, Feb 9, 2015 at 12:03 PM, Hisashi T Fujinaka ht...@twofifty.com wrote: On Mon, 9 Feb 2015, Bj?rn Mork wrote: Jeff Kirsher jeffrey.t.kirs...@intel.com writes: If you want to see Nick's patch, feel free to view his patch on my queue tree:

Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

2015-02-08 Thread Andrej Manduch
Hi, Can you please leave full patch with git diff when you're replying to Nicks e-mails? Nick is banned in *@vger.kernel.org so we cannot see his patches and rest of the world is seeing only replyies to his e-mail. And it's really hard to test anything when we don't see changes. On 02/08/2015

Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

2015-02-08 Thread Jeff Kirsher
On Sun, 2015-02-08 at 20:28 -0500, nick wrote: On 2015-02-08 08:26 PM, Jeff Kirsher wrote: On Sun, 2015-02-08 at 17:21 -0800, Jeff Kirsher wrote: On Sun, 2015-02-08 at 00:21 -0500, Nicholas Krause wrote: Removes the outdated fix me comment in the function,gb_acquire_swfw_sync_i210 for

Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

2015-02-08 Thread nick
On 2015-02-08 08:26 PM, Jeff Kirsher wrote: On Sun, 2015-02-08 at 17:21 -0800, Jeff Kirsher wrote: On Sun, 2015-02-08 at 00:21 -0500, Nicholas Krause wrote: Removes the outdated fix me comment in the function,gb_acquire_swfw_sync_i210 for setting the variables, i and timeout to the intended

Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

2015-02-08 Thread Jeff Kirsher
On Sun, 2015-02-08 at 17:21 -0800, Jeff Kirsher wrote: On Sun, 2015-02-08 at 00:21 -0500, Nicholas Krause wrote: Removes the outdated fix me comment in the function,gb_acquire_swfw_sync_i210 for setting the variables, i and timeout to the intended correct values for the

Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

2015-02-08 Thread Jeff Kirsher
On Sun, 2015-02-08 at 00:21 -0500, Nicholas Krause wrote: Removes the outdated fix me comment in the function,gb_acquire_swfw_sync_i210 for setting the variables, i and timeout to the intended correct values for the function,gb_acquire_swfw_sync_i210 to function correctly. This comment is

[E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

2015-02-07 Thread Nicholas Krause
Removes the outdated fix me comment in the function,gb_acquire_swfw_sync_i210 for setting the variables, i and timeout to the intended correct values for the function,gb_acquire_swfw_sync_i210 to function correctly. This comment is no longer due to these values having been no changed in the last