Re: [E1000-devel] [PATCH net] e1000: add dummy allocator to fix race condition between mtu change and netpoll

2015-02-25 Thread Jeff Kirsher
On Wed, 2015-02-25 at 11:05 +0100, Sabrina Dubroca wrote: There is a race condition between e1000_change_mtu's cleanups and netpoll, when we change the MTU across jumbo size: Changing MTU frees all the rx buffers: e1000_change_mtu - e1000_down - e1000_clean_all_rx_rings -

[E1000-devel] [PATCH net] e1000: add dummy allocator to fix race condition between mtu change and netpoll

2015-02-25 Thread Sabrina Dubroca
There is a race condition between e1000_change_mtu's cleanups and netpoll, when we change the MTU across jumbo size: Changing MTU frees all the rx buffers: e1000_change_mtu - e1000_down - e1000_clean_all_rx_rings - e1000_clean_rx_ring Then, close to the end of e1000_change_mtu:

Re: [E1000-devel] [PATCH net] e1000: add dummy allocator to fix race condition between mtu change and netpoll

2015-02-25 Thread Sabrina Dubroca
2015-02-25, 02:26:45 -0800, Eric Dumazet wrote: On Wed, 2015-02-25 at 11:05 +0100, Sabrina Dubroca wrote: There is a race condition between e1000_change_mtu's cleanups and netpoll, when we change the MTU across jumbo size: ... Fixes: edbbb3ca1077 (e1000: implement jumbo receive with

Re: [E1000-devel] [PATCH net] e1000: add dummy allocator to fix race condition between mtu change and netpoll

2015-02-25 Thread Eric Dumazet
On Wed, 2015-02-25 at 11:05 +0100, Sabrina Dubroca wrote: There is a race condition between e1000_change_mtu's cleanups and netpoll, when we change the MTU across jumbo size: ... Fixes: edbbb3ca1077 (e1000: implement jumbo receive with partial descriptors) Signed-off-by: Sabrina Dubroca