Re: [E1000-devel] e1000/e1000e wrong tx bytes counting

2010-11-22 Thread Flavio Leitner
On Mon, Nov 22, 2010 at 02:29:54PM -0800, Stephen Hemminger wrote: > On Mon, 22 Nov 2010 18:48:35 -0200 > Flavio Leitner wrote: > > > On Wed, Nov 10, 2010 at 09:17:20AM -0800, Alexander Duyck wrote: > > > On 11/10/2010 9:09 AM, Alexander Duyck wrote: > > > >On 11/10/2010 8:54 AM, Stephen Hemminge

Re: [E1000-devel] e1000/e1000e wrong tx bytes counting

2010-11-22 Thread Stephen Hemminger
On Mon, 22 Nov 2010 18:48:35 -0200 Flavio Leitner wrote: > On Wed, Nov 10, 2010 at 09:17:20AM -0800, Alexander Duyck wrote: > > On 11/10/2010 9:09 AM, Alexander Duyck wrote: > > >On 11/10/2010 8:54 AM, Stephen Hemminger wrote: > > >>On Wed, 10 Nov 2010 14:33:01 -0200 > > >>Flavio Leitner wrote:

Re: [E1000-devel] e1000/e1000e wrong tx bytes counting

2010-11-22 Thread Flavio Leitner
On Wed, Nov 10, 2010 at 09:17:20AM -0800, Alexander Duyck wrote: > On 11/10/2010 9:09 AM, Alexander Duyck wrote: > >On 11/10/2010 8:54 AM, Stephen Hemminger wrote: > >>On Wed, 10 Nov 2010 14:33:01 -0200 > >>Flavio Leitner wrote: > >> > >>>On Wed, Nov 10, 2010 at 07:58:55AM -0800, Stephen Hemminge

Re: [E1000-devel] e1000/e1000e wrong tx bytes counting

2010-11-10 Thread Alexander Duyck
On 11/10/2010 9:09 AM, Alexander Duyck wrote: > On 11/10/2010 8:54 AM, Stephen Hemminger wrote: >> On Wed, 10 Nov 2010 14:33:01 -0200 >> Flavio Leitner wrote: >> >>> On Wed, Nov 10, 2010 at 07:58:55AM -0800, Stephen Hemminger wrote: On Wed, 10 Nov 2010 10:56:38 -0200 Flavio Leitner wr

Re: [E1000-devel] e1000/e1000e wrong tx bytes counting

2010-11-10 Thread Alexander Duyck
On 11/10/2010 8:54 AM, Stephen Hemminger wrote: > On Wed, 10 Nov 2010 14:33:01 -0200 > Flavio Leitner wrote: > >> On Wed, Nov 10, 2010 at 07:58:55AM -0800, Stephen Hemminger wrote: >>> On Wed, 10 Nov 2010 10:56:38 -0200 >>> Flavio Leitner wrote: >>> Hello, The driver is calcul

Re: [E1000-devel] e1000/e1000e wrong tx bytes counting

2010-11-10 Thread Stephen Hemminger
On Wed, 10 Nov 2010 14:33:01 -0200 Flavio Leitner wrote: > On Wed, Nov 10, 2010 at 07:58:55AM -0800, Stephen Hemminger wrote: > > On Wed, 10 Nov 2010 10:56:38 -0200 > > Flavio Leitner wrote: > > > > > > > > Hello, > > > > > > The driver is calculating the amount of bytes transmitted assuming

Re: [E1000-devel] e1000/e1000e wrong tx bytes counting

2010-11-10 Thread Flavio Leitner
On Wed, Nov 10, 2010 at 07:58:55AM -0800, Stephen Hemminger wrote: > On Wed, 10 Nov 2010 10:56:38 -0200 > Flavio Leitner wrote: > > > > > Hello, > > > > The driver is calculating the amount of bytes transmitted assuming > > the way TCP builds GSO packets which are non-linear. Therefore, > > skb

Re: [E1000-devel] e1000/e1000e wrong tx bytes counting

2010-11-10 Thread Stephen Hemminger
On Wed, 10 Nov 2010 10:56:38 -0200 Flavio Leitner wrote: > > Hello, > > The driver is calculating the amount of bytes transmitted assuming > the way TCP builds GSO packets which are non-linear. Therefore, > skb_headlen() returns the correct size of the header and the > math is correct. > > How

[E1000-devel] e1000/e1000e wrong tx bytes counting

2010-11-10 Thread Flavio Leitner
Hello, The driver is calculating the amount of bytes transmitted assuming the way TCP builds GSO packets which are non-linear. Therefore, skb_headlen() returns the correct size of the header and the math is correct. However, the skb can be linearized if it is copied using skb_copy(), which leads