Re: [e4-dev] Locale changes at runtime - update

2013-12-18 Thread Dirk Fauth
I don't have strong feelings about that. Could you please comment in Gerrit so other reviewers see that too? There is also a discussion about which methods should be included or not. https://git.eclipse.org/r/#/c/19743/ On Wed, Dec 18, 2013 at 11:36 AM, Jonas Helming < jonas.helm...@googlemail.

Re: [e4-dev] Locale changes at runtime - update

2013-12-18 Thread Jonas Helming
I personally prefer either a prefix which expresses the context (e.g. "M" for application model elements or "E" for workbench services) or no prefix. I do not really like the "I" prefix, IMHO, it seems to be a left over from times, when an IDE was not able to visualize the difference between a clas

Re: [e4-dev] Locale changes at runtime - update

2013-12-16 Thread Tom Schindl
We've used E only i the workbench. I have no strong feelings about E/I (generally I have both of them!). Tom On 15.12.13 18:34, Jonas Helming wrote: > Hi, > > thank you Dirk for the great work and thank you Tom for warpping it up! > Might ELocaleSwitchService be a better name for the interface t

Re: [e4-dev] Locale changes at runtime - update

2013-12-15 Thread Jonas Helming
Hi, thank you Dirk for the great work and thank you Tom for warpping it up! Might ELocaleSwitchService be a better name for the interface to be consistent with the other e4 services? Best Regards Jonas Am 13.12.2013 11:46, schrieb Tom Schindl: > Hi, > > First of all a big thank to Dirk for work

Re: [e4-dev] Locale changes at runtime - update

2013-12-13 Thread Wim Jongman
Congratulations. Sounds really good. On Fri, Dec 13, 2013 at 11:46 AM, Tom Schindl wrote: > Hi, > > First of all a big thank to Dirk for working through this rather complex > topic which has been a lot of work! > > What makes me a bit proud is that the archtitecture we have in e4 allows > to imp

Re: [e4-dev] Locale changes at runtime - update

2013-12-13 Thread Tom Schindl
Hi, First of all a big thank to Dirk for working through this rather complex topic which has been a lot of work! What makes me a bit proud is that the archtitecture we have in e4 allows to implement something like this with justifiable cost - imagine doing this Now let me elaborate bit what the

Re: [e4-dev] Locale changes at runtime - update

2013-12-13 Thread Markus Alexander Kuppe
On 12/13/2013 10:21 AM, Dirk Fauth wrote: > yes, but the patches are for two different projects. So what else should > I do? Is there a better way to contribute such things? Unfortunately not that I'm aware of (I have been in the same situation recently and it shows one weakness of Gerrit/multiple

Re: [e4-dev] Locale changes at runtime - update

2013-12-13 Thread Dirk Fauth
Hi, yes, but the patches are for two different projects. So what else should I do? Is there a better way to contribute such things? Greez, Dirk On Fri, Dec 13, 2013 at 10:15 AM, Markus Alexander Kuppe < e4-dev_eclipse@lemmster.de> wrote: > On 12/13/2013 10:08 AM, Dirk Fauth wrote: > > > >

Re: [e4-dev] Locale changes at runtime - update

2013-12-13 Thread Markus Alexander Kuppe
On 12/13/2013 10:08 AM, Dirk Fauth wrote: > > These are the Gerrit changes containing my contribution: > https://git.eclipse.org/r/#/c/19743/ > https://git.eclipse.org/r/#/c/19746/ Hi Dirk, 19746 depends on 19743 via LocaleChangeServiceContextFunction and localechangeservice.xml. That's the reas