Re: [RFC 0/9] Updating lwip to 1.4.1

2013-06-27 Thread Will Wagner
This is now logged as bug http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001873 All the patches are attached. Please ffel free to test and give feedback. Thanks Will On 27/06/2013 20:26, Will Wagner wrote: Some of my patches are too big for the mailing list, guess I'll just log a bug in bug

Re: [RFC 0/9] Updating lwip to 1.4.1

2013-06-27 Thread Will Wagner
Some of my patches are too big for the mailing list, guess I'll just log a bug in bugzilla with the patches. Getting late now, will tackle tomorrow. On 27/06/2013 20:22, Will Wagner wrote: Hello, This patch series updates LWIP to 1.4.1. It seems to work well for us, but we have not run all th

[RFC 9/9] * Ensure udp stats counter correct when dropped packets

2013-06-27 Thread Will Wagner
There is a code path when udp packets are dropped due to lack of buffers where the stats object is not correctly updated. Signed-off-by: Andrew Parlane Signed-off-by: Will Wagner --- packages/net/lwip_tcpip/current/src/api/api_msg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/package

[RFC 8/9] * Fix LWIP compiler warnings

2013-06-27 Thread Will Wagner
Add some casts to prevent compiler warnings Signed-off-by: Andrew Parlane Signed-off-by: Will Wagner --- packages/net/lwip_tcpip/current/include/lwip/pbuf.h | 2 +- packages/net/lwip_tcpip/current/src/core/ipv4/igmp.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pa

[RFC 6/9] * Improve lwip cdl options

2013-06-27 Thread Will Wagner
There are a number of lwip cdl options which are only valid if another option is selected. Add the relevant active_if statements to the cdl file. Signed-off-by: Andrew Parlane Signed-off-by: Will Wagner --- packages/net/lwip_tcpip/current/cdl/lwip_net.cdl | 16 1 file changed,

[RFC 4/9] * Apply previous ecos modifications to lwip

2013-06-27 Thread Will Wagner
There had been a couple of changes to lwip source files, these changes need to be ported to the new version Signed-off-by: Andrew Parlane Signed-off-by: Will Wagner --- packages/net/lwip_tcpip/current/src/core/mem.c | 2 +- packages/net/lwip_tcpip/current/src/core/memp.c | 2 +- 2 files chang

[RFC 5/9] * Make changes to ecos wrapper code for lwip

2013-06-27 Thread Will Wagner
There were a number of lwip API changes in 1.4.1, this patch modifies the ecos wrapper around lwip so it works with new version Signed-off-by: Andrew Parlane Signed-off-by: Will Wagner --- .../enc424j600/current/tests/netconn_test_server.c | 7 +- packages/net/lwip_tcpip/current/cdl/lwip_net

[RFC 0/9] Updating lwip to 1.4.1

2013-06-27 Thread Will Wagner
Hello, This patch series updates LWIP to 1.4.1. It seems to work well for us, but we have not run all the tests or touched anything like all the different config possibilities. Please test and give feedback. This patch series is generated from git (whatever happened to moving away from cvs?)

FW: RFC: bsd_tcpip patch on synch.c

2013-06-27 Thread Bernd Edlinger
Jürgen, > After digging deep, I found that our problem was caused by something > else, so this fix is not needed, but we kept it because we did not like > that construct as you also point out. >> >> If you really expect cyg_mutex_lock to ever return false, >> then the right thing to do would be

Re: RFC: bsd_tcpip patch on synch.c

2013-06-27 Thread Lambrecht Jürgen
On 06/27/2013 02:51 PM, Bernd Edlinger wrote: > Hi Jürgen, > > > the variant with cyg_mutex_trylock is like busy waiting, and > should be reverted. But I agree that the > "while (!cyg_mutex_lock()) continue;" > construct is somehow really bad style. > > I do not think that cyg_mutex_lock can ever r

RE: RFC: bsd_tcp patch on in.c

2013-06-27 Thread Bernd Edlinger
Hi Jürgen, > The patch below we already use since 2006. > We had problems with the TCP/IP stack directly after booting because it > already received packets before being initialized completely. > Here our CVS log: > > move > splx(s); > from line 682 to line 739 > so that tcp/ip stack has started

RE: RFC: bsd_tcpip patch on synch.c

2013-06-27 Thread Bernd Edlinger
Hi Jürgen, the variant with cyg_mutex_trylock is like busy waiting, and should be reverted. But I agree that the "while (!cyg_mutex_lock()) continue;" construct is somehow really bad style. I do not think that cyg_mutex_lock can ever return false, unless the spl_mutex is completely invalid. If

RFC: bsd_tcp patch on in.c

2013-06-27 Thread Lambrecht Jürgen
Hello, The patch below we already use since 2006. We had problems with the TCP/IP stack directly after booting because it already received packets before being initialized completely. Here our CVS log: move splx(s); from line 682 to line 739 so that tcp/ip stack has started up before the et

RFC: bsd_tcpip patch on synch.c

2013-06-27 Thread Lambrecht Jürgen
Hello, The patch below we already use since 2009. But I did not code the patch, so I do not know what problem it solves. Here are our CVS logs about the patch: - To avoid deadlock on mutex 'splx_mutex', I changed 'cyg_mutex_lock' into 'cyg_mutex_trylock'. - Add 'trylock' and 'cyg_thread_delay'