Re: RFC: bsd_tcpip patch on synch.c

2013-06-27 Thread Lambrecht Jürgen
On 06/27/2013 02:51 PM, Bernd Edlinger wrote: > Hi Jürgen, > > > the variant with cyg_mutex_trylock is like busy waiting, and > should be reverted. But I agree that the > "while (!cyg_mutex_lock()) continue;" > construct is somehow really bad style. > > I do not think that cyg_mutex_lock can ever r

RE: RFC: bsd_tcpip patch on synch.c

2013-06-27 Thread Bernd Edlinger
Hi Jürgen, the variant with cyg_mutex_trylock is like busy waiting, and should be reverted. But I agree that the "while (!cyg_mutex_lock()) continue;" construct is somehow really bad style. I do not think that cyg_mutex_lock can ever return false, unless the spl_mutex is completely invalid. If